From: Jaewon Kim <jaewon31.kim@samsung.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: willy@infradead.org, walken@google.com, bp@suse.de,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
jaewon31.kim@gmail.com
Subject: Re: [PATCH v2 1/2] mmap: remove inline of vm_unmapped_area
Date: Fri, 13 Mar 2020 12:27:58 +0900 [thread overview]
Message-ID: <5E6AFDBE.4090808@samsung.com> (raw)
In-Reply-To: <20200312200259.7b79b38341bde97609fde99a@linux-foundation.org>
On 2020년 03월 13일 12:02, Andrew Morton wrote:
> On Fri, 13 Mar 2020 10:14:19 +0900 Jaewon Kim <jaewon31.kim@samsung.com> wrote:
>
>> In prepration for next patch remove inline of vm_unmapped_area and move
>> code to mmap.c. There is no logical change.
>>
>> Also remove unmapped_area[_topdown] out of mm.h, there is no code
>> calling to them.
>>
> Patches seem reasonable.
>
>> -extern unsigned long unmapped_area(struct vm_unmapped_area_info *info);
>> -extern unsigned long unmapped_area_topdown(struct vm_unmapped_area_info *info);
> I believe these can now be made static to mmap.c
Correct.
Let me wait for the 2/2 patch to be reviewed, and resubmit this 1/2 patch with having static if need.
Thank you for your comment.
>
>
>
>
next prev parent reply other threads:[~2020-03-13 3:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20200313011430epcas1p423b939dea080fda77a2e0fe3f6531489@epcas1p4.samsung.com>
2020-03-13 1:14 ` [PATCH v2 0/2] mm: mmap: add mmap trace point Jaewon Kim
[not found] ` <CGME20200313011430epcas1p129e4033f12b9c02f71443e0b359a26e5@epcas1p1.samsung.com>
2020-03-13 1:14 ` [PATCH v2 1/2] mmap: remove inline of vm_unmapped_area Jaewon Kim
2020-03-13 3:02 ` Andrew Morton
2020-03-13 3:27 ` Jaewon Kim [this message]
2020-03-13 10:36 ` Vlastimil Babka
[not found] ` <CGME20200313011430epcas1p436a6c02a262debcd755f3e1378331764@epcas1p4.samsung.com>
2020-03-13 1:14 ` [PATCH v2 2/2] mm: mmap: add trace point " Jaewon Kim
2020-03-13 11:25 ` Vlastimil Babka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5E6AFDBE.4090808@samsung.com \
--to=jaewon31.kim@samsung.com \
--cc=akpm@linux-foundation.org \
--cc=bp@suse.de \
--cc=jaewon31.kim@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=walken@google.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox