From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A18FC43603 for ; Tue, 17 Dec 2019 15:09:37 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C336E2146E for ; Tue, 17 Dec 2019 15:09:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lca.pw header.i=@lca.pw header.b="AqbMRymX" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C336E2146E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lca.pw Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 716598E0080; Tue, 17 Dec 2019 10:09:36 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6C7888E0079; Tue, 17 Dec 2019 10:09:36 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5DD258E0080; Tue, 17 Dec 2019 10:09:36 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0033.hostedemail.com [216.40.44.33]) by kanga.kvack.org (Postfix) with ESMTP id 49E748E0079 for ; Tue, 17 Dec 2019 10:09:36 -0500 (EST) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with SMTP id 069499418 for ; Tue, 17 Dec 2019 15:09:36 +0000 (UTC) X-FDA: 76274967552.08.wheel64_36a4b4a7e990b X-HE-Tag: wheel64_36a4b4a7e990b X-Filterd-Recvd-Size: 3572 Received: from mail-qv1-f68.google.com (mail-qv1-f68.google.com [209.85.219.68]) by imf17.hostedemail.com (Postfix) with ESMTP for ; Tue, 17 Dec 2019 15:09:35 +0000 (UTC) Received: by mail-qv1-f68.google.com with SMTP id t6so3863870qvs.5 for ; Tue, 17 Dec 2019 07:09:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lca.pw; s=google; h=content-transfer-encoding:from:mime-version:subject:date:message-id :references:cc:in-reply-to:to; bh=0OkMwroxaFTIfHX5v7BwxiXC57WOkvd1SruP9P6F2gQ=; b=AqbMRymX9CPH4mO3hD6Uyz9s6YZsLavTX4LxKYda/0ELAak4kzRE/RPLbedix3FfB0 iMU1mgu77Wqy0j6Psmm6DAK2UifEGoCWvQkAdq0VDBDHBCGfYG8T0kBkkTEsN0g17kV3 8EbFihrTBwEGteAhyplEHTnvjYsRUIDBoj5hS4K4q124bMhSAJotdOEjqgfDlUgFjOPF 23cIZboMOWo821f2gNCNtFM5cbbe/0QbiTU2VKtAItwRPgpSOLR44cx5UjESNPh+Q8Dv jbdD8EQ+hwNjT09z+o9vDTcAnTa1GdT4TGp05AaKX5pCPe8xB6IPgMYE5tZY9pBSJC8O eh+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:content-transfer-encoding:from:mime-version :subject:date:message-id:references:cc:in-reply-to:to; bh=0OkMwroxaFTIfHX5v7BwxiXC57WOkvd1SruP9P6F2gQ=; b=UeYSfFwmUbqNcy2BdrW9u6MrNt8Hzj1bFDl2mBivFwhnEaWaQWesrMuZwc4M5kDmWP FgX++LtKyf0r5Thj0LwVef9TSHLuDoXtSA7R550DsJQKjFIZ14E6mz39Odk4fe2OPK/M wWJcQhl/P1Dq9Hr4fc0amMHJEFuMUZIkEE70DT9PYJbYj/PQwSbMUGEzOGKtO1DM8UpK 6ICz5rMHCdQBph6E3DO6yOSM9wQlsMPZkRbd8NeZ+VRgzlBcdcTEzo1gbXR5UN7vqgzi GVCedeG9DmXO5Ip7qT45eq+A+knlX1CRd3NOHTYRmXnNyAzlw2YA29flPc0w2MzizxXz FgEA== X-Gm-Message-State: APjAAAWYkvI3rEkNRukDkpqi3E1ZgQv6iBYNnheqnGP8ferEzkX9xjXZ dQX/3EOWngdZ8C1pxe6DoKuCxQ== X-Google-Smtp-Source: APXvYqywK6ioDEXZv5myk3NMkzoATz7qETU5xLGU5chMhRL1F3ITK58LT6S9ttP9tEzds/UoMxL0nA== X-Received: by 2002:a0c:f703:: with SMTP id w3mr5069817qvn.6.1576595374810; Tue, 17 Dec 2019 07:09:34 -0800 (PST) Received: from [192.168.1.183] (pool-71-184-117-43.bstnma.fios.verizon.net. [71.184.117.43]) by smtp.gmail.com with ESMTPSA id 13sm7055010qke.85.2019.12.17.07.09.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 Dec 2019 07:09:34 -0800 (PST) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable From: Qian Cai Mime-Version: 1.0 (1.0) Subject: Re: [PATCH] mm: memcontrol.c: move mem_cgroup_id_get_many under CONFIG_MMU Date: Tue, 17 Dec 2019 10:09:33 -0500 Message-Id: <5D853968-99FD-4B66-9784-C1C540B23F92@lca.pw> References: <20191217143720.GB131030@chrisdown.name> Cc: Michal Hocko , Kuninori Morimoto , Johannes Weiner , Vladimir Davydov , Andrew Morton , cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org In-Reply-To: <20191217143720.GB131030@chrisdown.name> To: Chris Down X-Mailer: iPhone Mail (17C54) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000859, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > On Dec 17, 2019, at 9:37 AM, Chris Down wrote: >=20 > I struggle to imagine a real issue this would catch that wouldn't already b= e caught by other means. If it's just the risks of dead code, that seems equ= ally risky as taking time away from reviewers. Hate to say this but ignore unrealistic configs compiling test should not ta= ke that much time.=