From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83875C282DD for ; Wed, 8 Jan 2020 19:08:17 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 4D7BA206DB for ; Wed, 8 Jan 2020 19:08:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Qa1K1nXR" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4D7BA206DB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id DD4528E0006; Wed, 8 Jan 2020 14:08:16 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D83938E0001; Wed, 8 Jan 2020 14:08:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C4B678E0006; Wed, 8 Jan 2020 14:08:16 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id AC2528E0001 for ; Wed, 8 Jan 2020 14:08:16 -0500 (EST) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with SMTP id 6270B181AEF07 for ; Wed, 8 Jan 2020 19:08:16 +0000 (UTC) X-FDA: 76355402592.08.tail14_480818d5e561c X-HE-Tag: tail14_480818d5e561c X-Filterd-Recvd-Size: 5325 Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by imf18.hostedemail.com (Postfix) with ESMTP for ; Wed, 8 Jan 2020 19:08:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1578510494; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dF4FGW2H8qCPK5L+NqZ1nRPZo8yuJmWiHXHtrqRGZrM=; b=Qa1K1nXR0647ao/2eC0xU/3/q5/3bXN3z2iSKkCEoJlSaXK3Z1gG2mQZ0IOLvg6tA3vy8f HLqDEQBpByPTY1qa9Z/DOuTiGEJWzwLMAHtLE2C3Mxlmojijnidb1cnH51nncn5QCDh4ak 9FVwpyFnhdsbdUWSEuS2PAhVuCN7VtU= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-190-ct_edKHNOsyaCvcbIqABvQ-1; Wed, 08 Jan 2020 14:08:11 -0500 Received: by mail-wm1-f70.google.com with SMTP id y125so128549wmg.1 for ; Wed, 08 Jan 2020 11:08:11 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:content-transfer-encoding:from:mime-version :subject:date:message-id:references:cc:in-reply-to:to; bh=Amws6MWhDh9ExYW39LjH1zvpuHRVUUVI5bKPn/z5HTo=; b=Js/8goYJNI9j7d0ysPbT91VOWIExX9SAqHVTG/HxwtzhThcsppm+87AjglawxBNWeS Kpbbrt/9g9yGLNXO9xVYuxMCd/e66Dm7HsdaeXnLeHyyGW+4xlEZzeyI1ANzARfaBVxu 1Gxz7qGDvbNc9qmuxzeg1JatCZM8pRLl/+KwQGofyuJvqXcCYTmIBOieVmQz3M39zaxI vp9yDp+2U3PJ36GFeipZta7Ldvwz8SD5XrxB+GWnZvFpq7xZSznA9DPcUeRGWCb1VEUn yJSqKn3MiHB29f/6WzuOTHh0eLwAay3u6KmzWjJfpW+n6luNxf2PbB+Vv6lKsaojZETD q+BQ== X-Gm-Message-State: APjAAAUayg3j2OS8qDig2s4OUuYiyPSqN88TqVG8qGISOP0DxaDjom64 TQeeliWuaOKJnyv8cLxLyIAgSkqNELvodaHmkYrckMdjWRYZe9NuvXTaV/Bz9nZLPf5i0BdDxV2 2y7nPnqJNGGQ= X-Received: by 2002:a5d:534d:: with SMTP id t13mr6334273wrv.77.1578510490047; Wed, 08 Jan 2020 11:08:10 -0800 (PST) X-Google-Smtp-Source: APXvYqzwSf5xR5AuD7FXuI2qLWJMD45CtNqKofERmd6oZKYNzsaH7aKCx0AwVIr77ei63TWVvkuj2Q== X-Received: by 2002:a5d:534d:: with SMTP id t13mr6334244wrv.77.1578510489748; Wed, 08 Jan 2020 11:08:09 -0800 (PST) Received: from [192.168.3.122] (p5B0C6BAD.dip0.t-ipconnect.de. [91.12.107.173]) by smtp.gmail.com with ESMTPSA id f12sm49809wmf.28.2020.01.08.11.08.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Jan 2020 11:08:09 -0800 (PST) From: David Hildenbrand Mime-Version: 1.0 (1.0) Subject: Re: [PATCH v2 2/8] mm/memory_hotplug: Rename mhp_restrictions to mhp_modifiers Date: Wed, 8 Jan 2020 20:08:07 +0100 Message-Id: <5D5ED235-EB67-4072-8CCA-C046B7EC031C@redhat.com> References: Cc: Logan Gunthorpe , David Hildenbrand , Linux Kernel Mailing List , Linux ARM , linux-ia64@vger.kernel.org, linuxppc-dev , linux-s390 , Linux-sh , platform-driver-x86@vger.kernel.org, Linux MM , Michal Hocko , Andrew Morton , Christoph Hellwig , Catalin Marinas , Will Deacon , Benjamin Herrenschmidt , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Eric Badger In-Reply-To: To: Dan Williams X-Mailer: iPhone Mail (17C54) X-MC-Unique: ct_edKHNOsyaCvcbIqABvQ-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > Am 08.01.2020 um 20:00 schrieb Dan Williams : >=20 > =EF=BB=BFOn Wed, Jan 8, 2020 at 9:17 AM Logan Gunthorpe wrote: >>=20 >>=20 >>=20 >>> On 2020-01-08 5:28 a.m., David Hildenbrand wrote: >>> On 07.01.20 21:59, Logan Gunthorpe wrote: >>>> The mhp_restrictions struct really doesn't specify anything resembling >>>> a restriction anymore so rename it to be mhp_modifiers. >>>=20 >>> I wonder if something like "mhp_params" would be even better. It's >>> essentially just a way to avoid changing call chains rough-out all arch= s >>> whenever we want to add a new parameter. >>=20 >> Sure, that does sound a bit nicer to me. I can change it for v3. >=20 > Oh, I was just about to chime in to support "modifiers" because I > would expect all parameters to folded into a "params" struct. The > modifiers seem to be limited to the set of items that are only > considered in a non-default / expert memory hotplug use cases. >=20 It=E2=80=98s a set of extended parameters I=E2=80=98d say.