From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5EA83C531DF for ; Sat, 17 Aug 2024 23:58:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4616E6B0323; Sat, 17 Aug 2024 19:58:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 410E16B0324; Sat, 17 Aug 2024 19:58:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 28AB16B0325; Sat, 17 Aug 2024 19:58:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 0A0B86B0323 for ; Sat, 17 Aug 2024 19:58:18 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 71DBA1C2D77 for ; Sat, 17 Aug 2024 23:58:17 +0000 (UTC) X-FDA: 82463403834.20.5833653 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2074.outbound.protection.outlook.com [40.107.244.74]) by imf08.hostedemail.com (Postfix) with ESMTP id 9067C160002 for ; Sat, 17 Aug 2024 23:58:14 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b="F0/BHE1/"; spf=pass (imf08.hostedemail.com: domain of ziy@nvidia.com designates 40.107.244.74 as permitted sender) smtp.mailfrom=ziy@nvidia.com; dmarc=pass (policy=reject) header.from=nvidia.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723939035; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=axiIRTy/ToDCnhzIQbOXAsSwOEXJpr/EOlUmbBuh0b4=; b=TCR1dpcmvyg4/4VVXg7C5dKID8VIektZyAFYf++C4NJxheGxw8TopFCn7gWC56Zp5YeNtl z4oPmoNL5WmW4kW1qdO57cTJ5gxvI3pW6qksQRrc+CAG8HeNcK5j7aEe04C78dLKQfXEn0 vSv8FovU4nnM3Rg02+uF9gcybuzQIWA= ARC-Authentication-Results: i=2; imf08.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b="F0/BHE1/"; spf=pass (imf08.hostedemail.com: domain of ziy@nvidia.com designates 40.107.244.74 as permitted sender) smtp.mailfrom=ziy@nvidia.com; dmarc=pass (policy=reject) header.from=nvidia.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1723939035; a=rsa-sha256; cv=pass; b=HeF/sCI0ALQDDknSvZbO/Xlc5qNXSyeVRUUTA9dFBTruBGxTC1npnLszbMYR8HayHkzX0N BIkVaw4sm4hbXQzWbCpxvblJTo09DjBAE6QE4MLHle8POh5NV/bnEBd2uAMoFKfp3nbHoM rUA8Pom1YxdwGt/sfiqVYuR5fcEq5Cc= ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=iXeMrhZBBqoHlHpjcOscwcnaMty48nndf+/a0MkbqAAPhyoy0jUt3PIX6WV5zM0DuHbw38aR5o9BRSieAf72+f+CpMDCU/2zpiBGr0JK7ifX1qZjGQvCtd9D0bGD4skxwZ/WQDhf8d3m2wrfjkeCRJp78BXTdAfyT3Fk22HmbkYjqhXH5J335tLLEw3nH0kIAaZ5N6FrDfGdtL0AnXWHqZ8eRg4OTHKOgXSdGN/SN0KtdoO5SXiPWdSRs/hgaey50fHvRDSqcLLTU3dOHP/xAI8Og5gB2TFmPq9xana51YQkZbQ5pnmAMs5QVgD/3RAGjjn9otAk9wfMJLTObw/KGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=axiIRTy/ToDCnhzIQbOXAsSwOEXJpr/EOlUmbBuh0b4=; b=FIfu4P39yql1Lwljx/KwUIdvQGG75vQF+igJMKEYOB6oaNKTqN+mJWpfhb3VTXbMEQHCOnqje9UmZ9lcB6SBXhYwuuRPXKOhJ/fmeC9DFai9VA9nADWHGYoMkRiw10FdfyjCZykC10QozUC7yzUbGDfXICOVZ8OLTixlYe9JzqkvqFK/q6NO5TsRW1PC7/JqHwH9x9ZIMSC9rWiPnwRKcV7HfqP7eBiz1ltcXVHMKKkidfvfw8z8gwcWd7oBszmqln0Wh4zE9cYUmVxQdUVlhSs1AntvFLjcHzT+1qHquiRRWfkfZdncIsaNmlbs8xy2AvGJU7FgtioDup+1kVqddQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=axiIRTy/ToDCnhzIQbOXAsSwOEXJpr/EOlUmbBuh0b4=; b=F0/BHE1/C4Vy+iUkbM+88CsOnfNjYIGBf6+HWC7n96FqKtgRW2kIvMgGFfSXTTnHd4WDZ2Qz5s5gUfpn/Ux4keQmlEDza0XnbW4+apgQie0qy5qPT/IifRUveVLWr7QQ/0fCaP3VG0/0FQSE4ppVb2FWG3eio0sOHcgus/TIwnJy0geDqW7FeAbNA334DF6gkfr8dfrF0PgVfHp1u7hHa6yn3WOghgYNF7ykOgdND4IxISX2+eeudiYFPtiLMAhZGpEv8lIMjNXgJG84r8SFxZtjFxA+77zPmmpJF1qkBv23nyUt3VdVz9k8tE6It5e4YRWz76wR0+5czHbvt39ifQ== Received: from CYXPR12MB9320.namprd12.prod.outlook.com (2603:10b6:930:e6::9) by PH0PR12MB5647.namprd12.prod.outlook.com (2603:10b6:510:144::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7875.20; Sat, 17 Aug 2024 23:58:10 +0000 Received: from CYXPR12MB9320.namprd12.prod.outlook.com ([fe80::9347:9720:e1df:bb5f]) by CYXPR12MB9320.namprd12.prod.outlook.com ([fe80::9347:9720:e1df:bb5f%4]) with mapi id 15.20.7875.019; Sat, 17 Aug 2024 23:58:10 +0000 From: Zi Yan To: Kefeng Wang Cc: David Hildenbrand , Andrew Morton , Oscar Salvador , linux-mm@kvack.org, Matthew Wilcox Subject: Re: [PATCH] mm: remove migration for HugePage in isolate_single_pageblock() Date: Sat, 17 Aug 2024 19:58:07 -0400 X-Mailer: MailMate (1.14r6052) Message-ID: <5D57871E-0360-40F5-A3E3-B3DAD0B2F5BF@nvidia.com> In-Reply-To: References: <20240816040625.650053-1-wangkefeng.wang@huawei.com> Content-Type: multipart/signed; boundary="=_MailMate_E8E2AAF7-D7FD-447C-8832-DB19C7877FD9_="; micalg=pgp-sha512; protocol="application/pgp-signature" X-ClientProxiedBy: MN2PR03CA0003.namprd03.prod.outlook.com (2603:10b6:208:23a::8) To CYXPR12MB9320.namprd12.prod.outlook.com (2603:10b6:930:e6::9) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CYXPR12MB9320:EE_|PH0PR12MB5647:EE_ X-MS-Office365-Filtering-Correlation-Id: 68263b26-726e-4bb1-28c6-08dcbf187261 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?Qk16Ny94R1h6TVpaK3d5T29scjhxTDJxK3pyQStGRjhzek1XWVNFZ2cvS014?= =?utf-8?B?UVpUS2RveG9zTGhIQytYVzJjUkd5b3VjRFZnVU9MV3BRdkd4NDQyMFo4YTFu?= =?utf-8?B?REFVQXh2Rk01d1NvOGFwREk3K2hjTnhiNDFxd1p4TExJTXczUno3bHliSnJS?= =?utf-8?B?Nzk0MDJlaUo0TmxwVjZQdGh5UVM1dDRJM1FUa280N0Q5Q25nb3pmL2g4TU9a?= =?utf-8?B?MFNJTUtJb1dqU21xb1k2U1pBY3VMd1JXYjJVU0ExcXZiR0NGN3lxYTkwVGlD?= =?utf-8?B?YThCVlRTSUZiTVJ6eVd2dWxsYmF5YTdJQkhETkdKUkQrbC8rTk9Zc1Zibk01?= =?utf-8?B?L1JqMDJNNGFBMUNiUk14MkNKNDRaR0RQK0daMlpSWWVwZkQzUGlseExsRVVq?= =?utf-8?B?NlpWRzJaNk5vc0tQMUxUSTVDZ2FjSGtpWDEzQmhCbkd0eHRjMzFzUGdVczRz?= =?utf-8?B?Q3h6M0lma1R6TTE5VVdDRnZVTVEzNzh1RWYxdGN1djVEWUU3NXlUUnBmbFIr?= =?utf-8?B?OHh5dnMzUmIyY3BwSG1pYTZtWDA4ZzVrTjZrbTVZQWNoLzNMOTZWaVJOSEc3?= =?utf-8?B?NGZMTnBKNTYzK1F0eGpNYkprUHU0dU1IMEdLdStTRTN2d1YwTVZrU09UZHYv?= =?utf-8?B?NzRoWU15R0hScFpZVkc0bkJGOVU1Zkg1UXhSVm9BQnBYZm1WaEkrVEM4aXdp?= =?utf-8?B?QlNEYVA2QlZHV002Lzl0ZTZLUm1tR3d6eHNuc0IwZy9MYkxZd0RqZVA5OHJL?= =?utf-8?B?RTBWbjV0cTYrV1ZMTmpkL2VvT0xUZzhlekwxUG1ENDZGVU8wWGtYRUJIblZh?= =?utf-8?B?SDBhNFpCWG1mMXlGamZPUDdtMURhc0h4dnptM1ZqQ1Zjck52ZGdyMHAxT0tH?= =?utf-8?B?bmJQTTYvaUdyTk44Y1BVa3Z5OEQ1TE93OWdDS3kreE9QOVZmUWJWRkdtZFZ5?= =?utf-8?B?bThYdHJ1Z0RMakwybUdQejJBSDhZQzQ1WU9pTnpkR1YrVXh4bDN4YW1tM3hR?= =?utf-8?B?TllIWWtRMEJMd3IyeDdzcStHb1l3K2VSM05yaE9LYXdwR2duM2h3TTQyVDNo?= =?utf-8?B?a1laT3hDSUU0Qi9DTDFRTUIweFU5NDZtSm5JTzEzVzl6SW1McWxvbEtmc0JD?= =?utf-8?B?bXZZTHZnb2c5aE4yQ2hkSG5PSng2UktVeDFPT1VLTjVDa3p1TTlvak9mQlRD?= =?utf-8?B?cXorc2x4dXRPblBtZWQ3Y2sxMFZaVW5uVGJUVWw1NDMrSzBiMHVxVUxSb0p6?= =?utf-8?B?K2p2MnIybXFpelhpZEhvWDVDNlBHNTIwVzZzOUFZOEJWcmh0V29XMXRhZCtJ?= =?utf-8?B?aTZxNjNTY0RXZlRXQW85V3MrelY5R1ArTS8rbXRyOXJIQVQ3ZmNHWk9hTHAy?= =?utf-8?B?V2dEUXR1ODNKZGZYYnkrSFp3eWF1bHc3R3BILzc4NHl0MjZhalVnQVpzY2Rn?= =?utf-8?B?RUJ5SEF4ZTlXR3VSdTdDb2ZoVGcxU1hkUXA5U211MGlsaS9IaU1mMS84ajZM?= =?utf-8?B?RHRCU2dtN1d0NFFIdEdIS3pLTG1qcjRxNlhtR2MwWG1xL1RCaVdTcUQ5K3ZE?= =?utf-8?B?eDNsY043UjMvSUhEVGZoYnpwek9uWXJLZ0NvRm50MHg0TjVjMTB1Rkh4L0hz?= =?utf-8?B?YjZROHdObW5COXQ4bDM5a2RWRVlHelVNSFFaZ1B6dFF3WXRHK2FXUVpjVzI1?= =?utf-8?B?em84Q01GenRlVGxuSkxoSFprbG1wL05YMERPbE5qdFZ4T1puckNBM0ovcUFC?= =?utf-8?B?aXhic0lXZkdqL1oyQ2pSWU5aclA4Y3lrY2pDdit1dXVjMUpuRTdEQk9lYkpl?= =?utf-8?B?UjFaSnZ1RlRpQWRTeWtudz09?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CYXPR12MB9320.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(376014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YVFaTEJhRVJudXVpK1UzSGx6Rnd0TEM0YW1EaFE0S1Q3dTdtbWpISWpld0U5?= =?utf-8?B?WU1pTE1DRHBtOXI3TnBrYkk0SUNPeWJ0UlpoeGJxM2tZTXJrOHRWVGE5Wk9U?= =?utf-8?B?azlhemtpZzdtdDBDTU9QWDdOazZRaS8wQ0VVVmYwT1B2TkV3dit6OENtVVls?= =?utf-8?B?OEU1OHkySnVEWWErNWk4a3BnajlvVmdXOFl0K2N5b1dRcGhubHZ2am95dUxL?= =?utf-8?B?bmFTR3dWdThxazk0eno2ZE1qR1doNEFsWVE4RGFIZUMyckd6aXBUaExHUVVO?= =?utf-8?B?Rmd1RjZtMlV1S2p0dFVhajA1V3BCV01NWXBRMy93c3ZrUlBGNFphanNpYTFF?= =?utf-8?B?clVUMEdhT09DWTdRRmNRWTUweGg3TFUvN3BoeDE2RXFyQ0F3K3RwVkh2OG9Z?= =?utf-8?B?RzZzcVZzZHR3SnltNm5OSjFFOUd5YkJyWDFPMVhOaElIR3VrT3FWK1NKOHlh?= =?utf-8?B?N3pRWld1VDRvODYxdEc2aUdQdjVLUTZ5TDZYTGVJSDZ0UjhRQlJaUVVmRlJ6?= =?utf-8?B?aUpNbEF0c3hadzQyTXNVbTZmUEppNFU3UkxubGtaYVh6SllEdWxabTRPQ2RG?= =?utf-8?B?cFBTR2VibGdUNGIzcm5JbWtnT0VmTFFuU29ncTgwUU5oM3lhZ0NDKzZCVFFt?= =?utf-8?B?cFZZSEUxclc3YmJFS0Vua1ovbWU5Tys1eGRtcGVYMDhuZFNOcXJxWGJRK3Jv?= =?utf-8?B?R3hrOURlcElYemJDTTdoYk1xSUsyUW9iSHY4V0ZnL0JPVitNYklmaGZ3Nmc5?= =?utf-8?B?c0pVTUR4bU9qYXcxazRPVHFQMkhMR29pWXo1Uk84WTlEYmdHQytyMVo0dVZY?= =?utf-8?B?MTZ2YWJFUXhmamxGT2dPT0ZiOVduc2wyMnBQSW9vT3VKaWEyNkV5SHFBV1lU?= =?utf-8?B?SGlqd053WHh1YzNPYjY5dTJBaVVMQTR5RTZJejNXRmdoYTlpZVFCQmlwWUZY?= =?utf-8?B?bm1NY3IvR20xNDNqU28ybE0zVitCZ3g1WkVPNEEzT08zREdYc21zZGxtQm91?= =?utf-8?B?NFJER1VyWFVzQnl2Smk2K2JNWjFKcmtKTk5jbDYweHNWeDJCdkpjNjRpeUdY?= =?utf-8?B?Ry9LTkpNRm9xSlVhUnFVWDNHTTBCOE9lMWRTdHNJWWU0QkVyWnJJL3RHVllP?= =?utf-8?B?Z2hpd1l0Q1ljNkdOOGFIcHN5M1dJcFJjcTJrYWRNZVdVWEtiOUFLUVhBOWx2?= =?utf-8?B?MjBKcWdibHkzcWhOV2FWLzdac00vOGVweTFRWHh0K25URUVPRmFRZlZFVENG?= =?utf-8?B?UEcvRVJTWEdjSTkyYzliek81MzFvMjA1bUM2Sm5YdDVTUmJOQ3Q0anh2ZGto?= =?utf-8?B?cDU2UmtUaVhLQWxEN3pDcXdsNjJhZHBkbE5UdHpBRkxMSmVYM3QwaEc2NjZw?= =?utf-8?B?ZUp0MEtFRGlnaW52UVAwMkl0ZXNrbFdIL1hnTXZhOFBoVjNVRGdyOXc2YlRQ?= =?utf-8?B?YnZER1ppMWp3eENsS0hoZFhFSzdjcnVpWkxtekhpOGRuZHk2TTN3bGF5dHk3?= =?utf-8?B?MEpObjRiQUFKN1JPVmVJQ2VDVFdkdGhxN0VOL3RYcDlmcjRzK1RuT01rN3VR?= =?utf-8?B?TEd2dUQwQWpQUmNDSzdSOHU1d2JlWHJvQ2tHaVBpeldTVEF5SlRZNUduYUcw?= =?utf-8?B?L2xPSjZ5bVFiOVBqZ24wM3VSUGlYMVVRLzZQenFLWVN5MmpBc2FueTNXM1Vw?= =?utf-8?B?czBWa0F1K3k5bXA0SzRFTStkcGhmVzROeSthb0ZzVWtMS21lUk42cDZxcDU1?= =?utf-8?B?NUNCTVdaTzA5a28zUEx1MlpRaGZCeXBBaUx3Rzk0WXhaQnNudDExN29QRGtT?= =?utf-8?B?d1JpdWtWbm91ZFBISTdqWHRveENZb0FHdXZIc3J2VHFkZXBxQnZYL0wzeXBY?= =?utf-8?B?OFJhLzMveEU2RzFGTmJIeHNlRDk0ZEZTREFrQVFLNVJIR0tJQkpVMzdOSkZY?= =?utf-8?B?Mk00YkpNL1pOK1l2VFd1QytJWnZOZG5TcnkxOEEzbDhnb1AvUXNZQnBTS1BT?= =?utf-8?B?czNNNXBET0ZmNHFuSlBvVWR3a3J3QVY1Sm5DQVV0bndNeWsrbU95ZENFMDda?= =?utf-8?B?b1loQ1plN2w4ZndwZVQ5cmZJVDR4ejNkQmFSSlREMS95WDhHd3FxZFU2UTVy?= =?utf-8?Q?vT1o=3D?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 68263b26-726e-4bb1-28c6-08dcbf187261 X-MS-Exchange-CrossTenant-AuthSource: CYXPR12MB9320.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Aug 2024 23:58:10.0416 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: lSibR+pvf8RqsuIKF0BCG/ogZNp8N64NeXroy1MJN3BbrD3BZitckXW5QtYQOHMJ X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR12MB5647 X-Stat-Signature: 75w8mn4pf7kpstjgrnwo39jyomi7qobr X-Rspam-User: X-Rspamd-Queue-Id: 9067C160002 X-Rspamd-Server: rspam02 X-HE-Tag: 1723939094-765920 X-HE-Meta: U2FsdGVkX1+OO5mcOkPxVskaf4srwpeTpvKgFxZDNXJcLMNTm3f3c7ynnupyWtfcdKYNpJWaTzSJ1QXRnbLfsJcntnbfkbPOVEc23zffNucNm/Du8QbQUYzqlKyfNFvoFUqbp1nnA7eoW0+nilSa5mrMZtfv6s2RpwvmlmxCqPx6bIEplR1k4r/0EU6gCWLcDCWG/DWyA6lsjex8HQH1k3MfN6KyF3mFZWPUUt2Oh3rx+XW/xj3x6wL1MRNz75E5uA6OJPOlbWRtXDRusugIzHmOgFvqKuItsoz36LgA9KhIAhpthl/3hWdArLv0KjoWJQxlUiEeGwl6QzbRpKoHGEWInVRUvimvZlZz/JKM5XJN9RDryexoN2Hw3thV02QnTJVFdDuXRAg9TaVPKMyrm4wtsO82M0Uxc+5XP6oN2vjZ+Aph5DBpaLJRgWrEjyo0jekyIUklyc2lKTUqbrwGGQ+32AGB7His5DOAF/bEoR67xPmUFkzaHhURQc7jZuF+FMJJ54cVPHynsAAEM+i2jluXpVKeOSDIj3gbK5LZE6jzcYauhP+C8slZnQ/0cQacvYWMs9w83TX7BE66Fyy6aCzOqrEvDPwWcZb76rOcCLDmGZ9HWS6oJPHrWRzCgq2eGqeS7OtokuYLttkI7/wdQIvxGunZby5N2dcdnFjZqkpb55En3fMFw25eDM28yNWVv3f0DM2Cgslyw1zTiRGLVqst6TVlY/unRObIAYGbFIl7DEP95Znrj/eZpjGUgB/WgERBC3GQ/YKomVVAZ/MTB2+czCEmS94BOj1U/uN+bUsZfdax6P11so48VZSkpjyfU9loJ1Q8Q+JnEBSCe8vSRRwfTdoQJZnezYXQS/qc45wOQNbtB4iMxx1I3f58Ba1qlsD9k/E+QpT68fykfeYMyPE+Flz/nP5a0IwkzN6vC1oF2eMS7S4hVE81QBUKYJmsaXRoZhL1SQ0E5x8AGHl UhoNITn3 LJqGzMb6OPv4ZcKCRjDJv6RFnLFWcSRP7TO31cgw1JG1g/pYcshQ7QY2WRl/bkx5sGre839nPXGHrvTLyTBeXTSx84YxRcryni7ruoRoP9vhLsQo67q5dt4P/mkQagGxnx4FnJTnafQFgPz64xB9gHa+RvN9SmPVu+G0pBsmPNXj0sI3HeIrYPovga8gSEEOco7YO1Lnxk7R1hS4g6lXSq76puP7kLxJrgZz4P96NOFs+eC1gWhMdv9MnPCXTngJoRZcpnOuAdV0dayedabiIF3YdmOsR3q4nAR2vdWAuPPkubVim/fyTW43TAZLxhQZE0iQ0m3jhe9zrQb36uNF77aTGHyJ8IOejzWUZGizZyuBJVIMRUwFdg2jmTCD3T0LER2njrCMT8LlKLXWOObH6BUzyza1mWa3nTPdZ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: --=_MailMate_E8E2AAF7-D7FD-447C-8832-DB19C7877FD9_= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 17 Aug 2024, at 2:13, Kefeng Wang wrote: > On 2024/8/17 3:45, David Hildenbrand wrote: >> On 16.08.24 13:30, Kefeng Wang wrote: >>> >>> >>> On 2024/8/16 18:11, David Hildenbrand wrote: >>>> On 16.08.24 06:06, Kefeng Wang wrote: >>>>> The gigantic page size may larger than memory block size, so memory= >>>>> offline always fails in this case after commit b2c9e2fbba32 ("mm: m= ake >>>>> alloc_contig_range work at pageblock granularity"), >>>>> >>>>> offline_pages >>>>> =C2=A0=C2=A0=C2=A0 start_isolate_page_range >>>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 start_isolate_page_range(isolate_bef= ore=3Dtrue) >>>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 isolate [isolate_start, = isolate_start + pageblock_nr_pages) >>>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 start_isolate_page_range(isolate_bef= ore=3Dfalse) >>>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 isolate [isolate_end - p= ageblock_nr_pages, isolate_end) pageblock >>>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0 __alloc_contig_migrate_range >>>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 = isolate_migratepages_range >>>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0 isolate_migratepages_block >>>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0 isolate_or_dissolve_huge_page >>>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (hstate_is_gigantic(h)) >>>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return -ENOMEM;= >>>>> >>>>> In fact, we don't need to migrate page in page range isolation, for= >>>>> memory offline path, there is do_migrate_range() to move the pages.= >>>>> For contig allocation, there is another __alloc_contig_migrate_rang= e() >>>>> after isolation to migrate the pages. So fix issue by skipping the >>>>> __alloc_contig_migrate_range() in isolate_single_pageblock(). > > ... > >> >> Please distill some of that in the patch description. Right now you on= ly talk about memory offlining and don't cover why alloc_contig_range() i= s fine as well with this change. > > Borrowing some word from Zi, > > > PageHuge(gigantic) can bigger than a pageblock, the gigantic PageHuge i= s freed as order-0. This means MIGRATE_ISOLATE pageblocks will get to the= right free list after __alloc_contig_migrate_range(), the one after > start_isolate_page_range() for alloc_contig_range(), this is same as in= > memory offline, it has own path to isolate/migrate used page and dissol= ve the free hugepages, so the migration code in isolate_single_pageblock(= ) is not needed, let's cleanup it and which also fix the above the issue.= > > Please correct me or help to write better description, thanks. How about? Gigantic PageHuge is bigger than a pageblock, but since it is freed as or= der-0 pages, its pageblocks after being freed will get to the right free list. There i= s no need to have special handling code for them in start_isolate_page_range(). For= both alloc_contig_range() and memory offline cases, the migration code after start_isolate_page_range() will be able to migrate gigantic PageHuge when= possible. Let's clean up start_isolate_page_range() and fix the aforementioned memo= ry offline failure issue all together. -- Best Regards, Yan, Zi --=_MailMate_E8E2AAF7-D7FD-447C-8832-DB19C7877FD9_= Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQJDBAEBCgAtFiEE6rR4j8RuQ2XmaZol4n+egRQHKFQFAmbBOQ8PHHppeUBudmlk aWEuY29tAAoJEOJ/noEUByhUV/AP/ROsK+K91Jpw+LVgBQ1WUFoIF6DnaFz03oN6 P/Oc8VBsiNC9DCIe5B+6puc8zOrwi8spQA1zQatfqey0FKpBcZvtdnCsunSoRErp iHB2XFehh750D+JnPHf1C172LY+260kHXQ1/ypneAl4stCiL/qqcfYxn00jRLdXZ vtilQZaBD0HxsWXb+uvKMuV/GICnztN95U9ydhaY44gGEjV0bgauIIYvYq6zUy/K j0+0pXpGWW/rtYf82d+0EAyzKeYrHYKU19lvuQPrVO4CFaGoBxAouGo3kOK2tSCx Ycpzp1oT78tD/fRfB6Ns5B+2+CYv9i6YlvidqdlH6RmvdDdje7db3C5FrW/MBvxt /jDXasB1jb6wPDMcyKq85ITDFIyjp07GcLb5TFSgqF9c3/w4XMNnHxBNbYtbYRPs C5ENogjzwOEJ3cXHiFyYH7aXF1FLnpe8WxM0uJGhuKcqcFHBQTO4eRDpEbUH47a6 Ryr554S31VOcKjyN2WWIytkKU1V0JkZFBOMez8i5phe7G9IVQGFoaU/5t77hu0zl 03YjsMM+hbjyA9HsjPWD6ckCBGRwCE27IxtmmxJNFo+essMX0mLjKizAWxANUIdb KVVLPaTA7yohtExfdIrqKzc2UEmC5jAlcWRuumb6doTZGXt/t7/sMkSnIDHdubYb bWyI8bpB =CPfx -----END PGP SIGNATURE----- --=_MailMate_E8E2AAF7-D7FD-447C-8832-DB19C7877FD9_=--