From: William Kucharski <william.kucharski@oracle.com>
To: Song Liu <songliubraving@fb.com>
Cc: Rik van Riel <riel@fb.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"matthew.wilcox@oracle.com" <matthew.wilcox@oracle.com>,
"kirill.shutemov@linux.intel.com"
<kirill.shutemov@linux.intel.com>,
Kernel Team <Kernel-team@fb.com>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>
Subject: Re: [PATCH v3 6/6] mm,thp: handle writes to file with THP in pagecache
Date: Thu, 20 Jun 2019 07:55:15 -0600 [thread overview]
Message-ID: <5D2D066C-3E70-438B-9373-A65EB65D701D@oracle.com> (raw)
In-Reply-To: <B051CE4A-063B-4464-8193-93C9F1D0A0A7@fb.com>
> On Jun 19, 2019, at 8:10 PM, Song Liu <songliubraving@fb.com> wrote:
>
> This is not truncate the file. It only drops page cache.
> truncate_setsize() will still set correct size. I don't
> think this breaks anything.
>
> We can probably make it smarter and only drop the clean
> huge pages (dirty page should not exist).
It sounds like I will need this change for my THP work as well for the
same reason; once a RO THP text page is in the page cache, if the file is
marked writable strange things will occur.
next prev parent reply other threads:[~2019-06-20 13:55 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-19 6:24 [PATCH v3 0/6] Enable THP for text section of non-shmem files Song Liu
2019-06-19 6:24 ` [PATCH v3 1/6] filemap: check compound_head(page)->mapping in filemap_fault() Song Liu
2019-06-19 6:24 ` [PATCH v3 2/6] filemap: update offset check " Song Liu
2019-06-20 1:04 ` Rik van Riel
2019-06-19 6:24 ` [PATCH v3 3/6] mm,thp: stats for file backed THP Song Liu
2019-06-19 6:24 ` [PATCH v3 4/6] khugepaged: rename collapse_shmem() and khugepaged_scan_shmem() Song Liu
2019-06-20 1:05 ` Rik van Riel
2019-06-19 6:24 ` [PATCH v3 5/6] mm,thp: add read-only THP support for (non-shmem) FS Song Liu
2019-06-19 6:24 ` [PATCH v3 6/6] mm,thp: handle writes to file with THP in pagecache Song Liu
2019-06-20 1:39 ` Rik van Riel
2019-06-20 2:10 ` Song Liu
2019-06-20 13:00 ` Rik van Riel
2019-06-20 13:55 ` William Kucharski [this message]
2019-06-19 6:51 ` [PATCH v3 0/6] Enable THP for text section of non-shmem files Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5D2D066C-3E70-438B-9373-A65EB65D701D@oracle.com \
--to=william.kucharski@oracle.com \
--cc=Kernel-team@fb.com \
--cc=akpm@linux-foundation.org \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-mm@kvack.org \
--cc=matthew.wilcox@oracle.com \
--cc=riel@fb.com \
--cc=songliubraving@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox