Re: [Patch v2] mm/khugepaged: unify pmd folio installation with map_anon_folio_pmd()

[Zi Yan <ziy@nvidia.com>]

On 6 Oct 2025, at 20:50, Wei Yang wrote:

> Currently we install pmd folio with map_anon_folio_pmd() in
> __do_huge_pmd_anonymous_page() and do_huge_zero_wp_pmd(). While in
> collapse_huge_page(), it is done with identical code except statistics
> adjustment.
>
> Unify the process with map_anon_folio_pmd() to install pmd folio. Split
> it to map_anon_folio_pmd_pf() and map_anon_folio_pmd_nopf() to be used
> in page fault or not respectively.
>
> No functional change is intended.
>
> Signed-off-by: Wei Yang <richard.weiyang@gmail.com>
> Cc: David Hildenbrand <david@redhat.com>
> Cc: Lance Yang <lance.yang@linux.dev>
> Cc: Dev Jain <dev.jain@arm.com>
> Cc: Zi Yan <ziy@nvidia.com>
> Cc: Usama Arif <usamaarif642@gmail.com>
> Cc: Matthew Wilcox <willy@infradead.org>
>
> ---
> v2:
>   * split to map_anon_folio_pmd_[no]pf() suggested by Matthew
> ---
>  include/linux/huge_mm.h |  6 ++++++
>  mm/huge_memory.c        | 14 ++++++++++----
>  mm/khugepaged.c         |  9 +--------
>  3 files changed, 17 insertions(+), 12 deletions(-)

After addressing Lance’s and David’s comments, feel free to add:
Reviewed-by: Zi Yan <ziy@nvidia.com>

Best Regards,
Yan, Zi