From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 948F2C0218A for ; Thu, 30 Jan 2025 11:09:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D876D280287; Thu, 30 Jan 2025 06:09:56 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D3697280286; Thu, 30 Jan 2025 06:09:56 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BD78B280287; Thu, 30 Jan 2025 06:09:56 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id A1189280286 for ; Thu, 30 Jan 2025 06:09:56 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 1DD24C0D9B for ; Thu, 30 Jan 2025 11:08:51 +0000 (UTC) X-FDA: 83063845662.14.006F598 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf26.hostedemail.com (Postfix) with ESMTP id 8BBB114000D for ; Thu, 30 Jan 2025 11:08:48 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=bJr3M7nH; spf=pass (imf26.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738235328; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hRyAgd3cBvQHsVuEfrhD/VealxKoGbpl8JEiOYT4zok=; b=axM0vGQCMMD9uJHxa8SYLgj8XMCvSm9Fz60XJZPB5PssP06Q9S+tMdYgWlspXnbP0Q10Ux 1oA/kqijEqMNFte3khmDis5jQxthPEQDDKNuN8ff5XXWSVVNETbSURl6qDsWPkbjm5ZKwa JKdChU/qZm2wuEq3yZqo5Kgypn9teI0= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=bJr3M7nH; spf=pass (imf26.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738235328; a=rsa-sha256; cv=none; b=1jU1XFs0EvpdIVaQDS7mOEgK3nanFg+fEXXcLv0bdkd5ASvqvdctIhEutokxFgrafET79O jh3/jBJCnHSqFlhk8NNGdOngmFVllzg3vCFZDyhH3OmT6RDl0wiFYg40b4cKen8NT6VGUU le8UspTIkFdavIBv3cPKonB2Soy8glA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1738235327; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=hRyAgd3cBvQHsVuEfrhD/VealxKoGbpl8JEiOYT4zok=; b=bJr3M7nH9opKHZI/HI52rkkAAy/CuwH6po+BBewvAVmTHCnqA8tw/XA1jPAanbxNegxdXJ yOXeaSbIkyC55wgrgYc286qECtd/eGBX0f2nZCD7cPDnSMPNIhaTGLMSf5ddssAjDS1E2p WusX4COqWde1nVlbE3ADFYGF4opd7r0= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-187-ZeaofJo8MX6DBcQs_aYudg-1; Thu, 30 Jan 2025 06:08:46 -0500 X-MC-Unique: ZeaofJo8MX6DBcQs_aYudg-1 X-Mimecast-MFC-AGG-ID: ZeaofJo8MX6DBcQs_aYudg Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-3862c67763dso283520f8f.3 for ; Thu, 30 Jan 2025 03:08:46 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738235325; x=1738840125; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=hRyAgd3cBvQHsVuEfrhD/VealxKoGbpl8JEiOYT4zok=; b=vlWHcwUxxCMxv60SAsIcBRBlFlufycuBU0j4pw5/GXBa5Cfz4FQ5qicJYuoghKzTkT h8CWW279LMh3W7fiHtTwMrL19ZOSetfu7ATh9w08SQsSRxPNO6k4FOgF2LF1ewbASoq4 9icvDHubA00IwA62umFNCxdGGJs+QaCed53pgv33X8lZd3xD46Dk3Ala0oZF6uekaLin J60IUNrC/N8tIOMDCyz+UsBJjeCxEpfWY7rcv97flgW8otNxaU8tgchSc9Dzt2kamUq2 m9PDv0a8DuhYYw8E1aAkjC73fBfYJmgWBRqKGJRC/qxHyikZVyUvAXWxEk+t8PmwF0Wl mRsg== X-Forwarded-Encrypted: i=1; AJvYcCWtPSU6mqG/ZcrSkmCggy0qjRmomh3orWX/HmPJg7LrkPUS4XK6scrMN+ACjks+1bPZtXzmWVERuA==@kvack.org X-Gm-Message-State: AOJu0Yw7A0MKwdAss0Pr8nuCK7m4YvtWS2EQ2+WYjNSwPFjQUpf1wkSV Ng1AOzvciQpxxXYf3tqHt/67Od+iFA5dCgAf4GlTU1CYZmCbk4sDheCs3ugA+uXeE1sSRMvzBvB SFvWL6Yj2EPg5UxYqTByRzOJGqe/oIxnm7aPHUtmzmmQ+2svy X-Gm-Gg: ASbGncvjTnqnrGwwOFNce2/8kADMm3p2fDUgJb9T9yBHkAQ99H1QIZABvaPnO0y5KII rK+Dwp572jMow8aWRO1B9CEWmR/ejI1ZzYHQRCyKjx5xqy66LTUYSXk+U8sNWXRBI0aF6n+wFDD 3E7uK18jzrbegZITjDuTkBVHN+rH3j43L4kB7fEibie0QWUQgnItDi/Hs0yWaELP3z+Ts9YN69w kz/B42I0NdxPzANyMVxL1yq722YQf3Qjn2vNm/0G4WcNw0PwO2uhCfsNlwmMlw+HbQnM2ayHfJF wekxroj41RfETt+ozvmhPN1x9oQ5FX4GPzK16upK772HoVeqVaJETVN9LPm3Ya2aH7w/F85cFkF 4U4NdUsGKGyHwOZBAE+m/3GiN8rg8giw= X-Received: by 2002:a5d:6d86:0:b0:38b:ef22:d8c3 with SMTP id ffacd0b85a97d-38c5209395cmr7569840f8f.35.1738235325424; Thu, 30 Jan 2025 03:08:45 -0800 (PST) X-Google-Smtp-Source: AGHT+IF8Jaj7pR0+ZuRLv9i3VWlgl8F3HqPDaZn5mScaXDv//sxwlV18Dtu62XjbQ4yrxQNHvUAKBA== X-Received: by 2002:a5d:6d86:0:b0:38b:ef22:d8c3 with SMTP id ffacd0b85a97d-38c5209395cmr7569801f8f.35.1738235325088; Thu, 30 Jan 2025 03:08:45 -0800 (PST) Received: from ?IPV6:2003:cb:c713:3b00:16ce:8f1c:dd50:90fb? (p200300cbc7133b0016ce8f1cdd5090fb.dip0.t-ipconnect.de. [2003:cb:c713:3b00:16ce:8f1c:dd50:90fb]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38c5c1b4e99sm1645539f8f.74.2025.01.30.03.08.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 30 Jan 2025 03:08:44 -0800 (PST) Message-ID: <59feb709-dadc-4d19-857e-49320cca3d98@redhat.com> Date: Thu, 30 Jan 2025 12:08:42 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 08/12] mm/rmap: handle device-exclusive entries correctly in try_to_unmap_one() To: linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-mm@kvack.org, nouveau@lists.freedesktop.org, Andrew Morton , =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , Jonathan Corbet , Alex Shi , Yanteng Si , Karol Herbst , Lyude Paul , Danilo Krummrich , David Airlie , Simona Vetter , "Liam R. Howlett" , Lorenzo Stoakes , Vlastimil Babka , Jann Horn , Pasha Tatashin , Peter Xu , Alistair Popple , Jason Gunthorpe References: <20250129115411.2077152-1-david@redhat.com> <20250129115411.2077152-9-david@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: xImHHhrwjSiTQ1HHrcwt5B_-zUAugvW-8Spx0hvJabc_1738235325 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 8BBB114000D X-Stat-Signature: muf3runqmoo66bmcxxhxatniqqaejcpm X-Rspam-User: X-HE-Tag: 1738235328-154144 X-HE-Meta: U2FsdGVkX1+8P03HBostbiH9oDBwF44WtJ7MCDtRb4FeGvDsQYOw4ZGqTU9ZYEHug8tl2+kf22BLxxrEtbQ0eE2HdUGJERSexNs9b+RpwIaWMoBNt3a8/8vIM007qFrWzDR8eKiX5vyOIuRMskOJhneI6mZqVymJ60DXB0uGf3fEn5IWi9HbpGF7ODAVq6oP15bKQUxPH8pTVa6IHEqPPFBHdY0vj64qlVovpiS4QBXbjOSiNGatVzS3irpyE5SEDwvFomlqRvCJb+dnLXIaOHi9mF+V4341VU01/LnnjxjGx0suV+xx+Kkkddcqrx7XG5zKs81FiUfZdEY3ogKCDZEJY+ISv2hKxaxTYavB6GX7pp2tZUSo8+HGZE3zPaAf7U0iz5sAp7ssj+f/cIoH4Vr2jaa92OSmFmM8mSdbJyJqfKRIomGlEPg+mpyCG/mmuqPPOCnfPu1LslLeIe8jrDD9HiknYf/wpJ+UZ1K9PNW49n13v3tori3xONyCZD1fiFPJVeCfBYbvNb7WDNo6yJ6XEtlATP55+OQxvvhhVAE9sNaM4WO6/vva3C5Ln8p84K7oA9yQPrQoMSpCMXCk2GDKGwam8Amsm+bCj6K5R90jksLBHEt069ts1pbBwC4QMvHxbRZW9tBwp4540N6WF/9Srvxy4Ig3ouFy47K9LJmgwLWArItm+Zn55QbrWRc8/a/mqPG+jFu85/emVlo9eEIkVNDE6G3XCE/6wcC/+BMsDupz0jv2dbq0HRQp3bQBNodjUsi6o3Wm6JoyqBXJpsS8ooZJV3yt9Ax9AS3L42x2DtTPMBtPiXK7ygHLGX6u2MnlKbqwpM5OJdoi+CvSozjM2nuyuc0qjpdF2/hGQQ4bifUQDLsyuLxg2gCOR/DxzyAnjVnHxKjVx1LlL2h6MNRKNHdkpmWqTm7wKFB1ikvKslaJmEqnSR5IF1IrY5ncpFbfvtaOoBakBkendXj FXRyKW/m T6rJHYxqzak+qkSMJD4u9IGtMi0IXcgL5by1CuqN75svpl9+xd/weHjaZiH1hSfKOgSkxxBPZCMtW++hfrkqmenSOHULXU9frZ8jxF4TU+gvu8p9sJ0GPfGF/ldrCyIdhtenerd362deU8MRmfpXsgkA3FEPW8yFBcuuwYPXIBFr7v/oKK99wETiiyC5U00c9NifPXQ2ritrojj5ZpCpz2AQ8ndzrAN2OVnSAcPw0MI2HsUjkTtnKACqO5tZE+I/k2syeMKAhPgoZ3DJ1xMM7Danascbw/0i+hWDyBPvxZVIH8IsyXMyRd7UmDyMak5depmfuZ6FQyCvWqwvPUGYmPXYP3NVdidqhwAtoF5ydgD7t8Bn/l8cueK4Q6QzHcBNwZZtbvxzFPhKs1kH/+bi3YauJJcGJif808CWXWvosY9ABZtbeNW7YTUWwC/0BwPjN2Qlj X-Bogosity: Ham, tests=bogofilter, spamicity=0.000114, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 30.01.25 11:10, Simona Vetter wrote: > On Wed, Jan 29, 2025 at 12:54:06PM +0100, David Hildenbrand wrote: >> Ever since commit b756a3b5e7ea ("mm: device exclusive memory access") >> we can return with a device-exclusive entry from page_vma_mapped_walk(). >> >> try_to_unmap_one() is not prepared for that, so teach it about these >> non-present nonswap PTEs. >> >> Before that, could we also have triggered this case with device-private >> entries? Unlikely. > > Just quick comment on this, I'm still pondering all the other aspects. > > device-private memory is entirely owned by the driver, the core mm isn't > supposed to touch these beyond migrating it back to system memory in > do_swap_page. Plus using rmap when the driver asks for invalidating > mappings as needed. > > So no lru, thp, migration or anything initiated by core mm should ever > happen on these device private pages. If it does, it'd be a bug. I was not 100% sure about HWPoison handling, that's why I added that comment. In other regards I agree: reclaim etc. does not apply. -- Cheers, David / dhildenb