From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82C14C27C6E for ; Thu, 13 Jun 2024 13:29:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 15AB26B009F; Thu, 13 Jun 2024 09:29:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 109F26B00A0; Thu, 13 Jun 2024 09:29:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EECAA6B00A2; Thu, 13 Jun 2024 09:29:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id CE1076B009F for ; Thu, 13 Jun 2024 09:29:10 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 5ADF2121AC7 for ; Thu, 13 Jun 2024 13:29:10 +0000 (UTC) X-FDA: 82225946460.22.C507E26 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf25.hostedemail.com (Postfix) with ESMTP id 1EC3EA000F for ; Thu, 13 Jun 2024 13:29:06 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Nww6oB9w; spf=pass (imf25.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718285345; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9MpkKxwzq2w2aCJw7lO134Yt2Yq2mSP410Q+/QHmPLI=; b=wLYsyaHGac9nAdXgk7vPcp68qa0Kelf9aIyBQYE4S382LAPTV8Fuw6vtgN5+7ICp5E/MRA vtBgVtbZ1xo1+AgMdCd/X5jxACdZYVW/4nffoaPX9eNdISpBORE9rzQENQLy/Ls+rzD7nZ NoLYnHib9Y+Yj8sCVIg0Xe8PYUl6sxY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718285345; a=rsa-sha256; cv=none; b=TIfUAubS1+Ok9/Vb+YYKQ0j507NgJnRuG1j07uhyHoprnsr4yfw++dn9wg11gOYKnZVmdb m0tT/kBNjIh6Grz9W+RpHEWtRp5ttdSYtlhqsqjkerqTXLWxw6id55Wftw77YyDZDA89/N eCNxhFXJ7Ff/Lxsj1IZ/r68IveD5FMQ= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Nww6oB9w; spf=pass (imf25.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1718285346; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=9MpkKxwzq2w2aCJw7lO134Yt2Yq2mSP410Q+/QHmPLI=; b=Nww6oB9wQzyADABjQDXRVPhDWoMzBOyQG2MFHct9uxE2Eox2Wx4XqjWmffZlEDiCkOuGwC fU6W1R8KHnhuivARjVFDNqSMUfIRBeCwJxQ4cMFmmrbsDKPtUkRI35TB6Xbmw8TrMb8gOl Vam4oOweiOgsI69kt0Kc+WlOiGjR7UY= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-632-gc-hYW29OOmWeNvclb-QzA-1; Thu, 13 Jun 2024 09:29:04 -0400 X-MC-Unique: gc-hYW29OOmWeNvclb-QzA-1 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-422a0f21366so7891475e9.1 for ; Thu, 13 Jun 2024 06:29:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718285343; x=1718890143; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=9MpkKxwzq2w2aCJw7lO134Yt2Yq2mSP410Q+/QHmPLI=; b=R/0H0rNvxK4KJHedlUhSiGrtGuGFavE/6iYxpHmkzJLhtdlh/T9rBYBNIFljw2LtsE ohBOKpztuEe9GNXLss4UsiWzrhuSMkmgvFdz/XAVqomNNjU2GFDHB/HqbcugQODPNfMS xbZQiTlloeVsue6KbObiVn1vdpeDBXfY4Bl2FUGI4JWi3hqyyTqU7nJ6DYcN5d4KeGTH g0NeWKRMrLYlnR5ak31OBuWHCMJJH/FwqVG8wha74pCvMKtFKTRr59vNTK/AY+sVw3R1 PzaAjzXKxJXADIOYWSyhWD8JmJjPsna1b7tvwEPyd6rcnHr8nq6xHuAwBMxWVUcOf/Vv sjiQ== X-Forwarded-Encrypted: i=1; AJvYcCU0nL2dD5QdTRw67raSCynajm1Z+9Ryv74D5H7dbp/4JRLlELkeFj+wxu2ILVhPwpXUeLU8HnYeica4EPoSLsQiY30= X-Gm-Message-State: AOJu0YwfgwUt5N5k4Q9P5dpwGX0Jnmk1bWoO7StygkC56Sp8rN0cyZaJ /o+OcK5OAw8cop+3gMEk0AQQh7ZM4z3m4+Q3DjezwGtKgCIS5hfradyJBahrndvDZGyo2vOnkqQ X4S3d2epNij4EndkgLiAZs7lTYYJLtbxtW4pNlMtjxEmtRors X-Received: by 2002:a05:600c:4f88:b0:420:177f:c2a6 with SMTP id 5b1f17b1804b1-422c2c64dbfmr25325665e9.10.1718285343098; Thu, 13 Jun 2024 06:29:03 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEcbh3n93XeUmI5nh9ei6KF78qtSGnP9NCToujLpbKUppOIbe8XIp7XjVkJIG2reWqARepP/A== X-Received: by 2002:a05:600c:4f88:b0:420:177f:c2a6 with SMTP id 5b1f17b1804b1-422c2c64dbfmr25325425e9.10.1718285342586; Thu, 13 Jun 2024 06:29:02 -0700 (PDT) Received: from ?IPV6:2003:cb:c703:fe00:10fe:298:6bf1:d163? (p200300cbc703fe0010fe02986bf1d163.dip0.t-ipconnect.de. [2003:cb:c703:fe00:10fe:298:6bf1:d163]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42286eefa07sm62689845e9.8.2024.06.13.06.29.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 13 Jun 2024 06:29:02 -0700 (PDT) Message-ID: <59d82010-c24b-4e83-a9a8-0add8ba1bc82@redhat.com> Date: Thu, 13 Jun 2024 15:29:00 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 1/4] mm/rmap: remove duplicated exit code in pagewalk loop To: Lance Yang Cc: Barry Song <21cnbao@gmail.com>, akpm@linux-foundation.org, willy@infradead.org, sj@kernel.org, baolin.wang@linux.alibaba.com, maskray@google.com, ziy@nvidia.com, ryan.roberts@arm.com, mhocko@suse.com, fengwei.yin@intel.com, zokeefe@google.com, shy828301@gmail.com, xiehuan09@gmail.com, libang.li@antgroup.com, wangkefeng.wang@huawei.com, songmuchun@bytedance.com, peterx@redhat.com, minchan@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20240610120209.66311-1-ioworker0@gmail.com> <20240610120209.66311-2-ioworker0@gmail.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Stat-Signature: mo359a7uffdsdo4xcindrp9rxfjdm1tg X-Rspamd-Queue-Id: 1EC3EA000F X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1718285346-569128 X-HE-Meta: U2FsdGVkX1+6hXq+7iGhHcA/PKFKto7p5q2MMoBSqMUHIrM2VH8/ZO1YFKXvfKIOdme2gO+M33EHgtRRM4gG4ar37FMUpTTE2UGVnrk+geyB2jzgCChtZGT3pmPiZpwKF12BfQ+unPmfFtSod1H/CNFUGDrG1Fo3+QHYniiNsr8vzNji6BKVhDpValOPaTB+yzOJSeZ2+wmZ/3Ger/zxSCmDh+k2vF4OeVubsxBEZkoHrNPk4+fIAFP30McTX34nlQtnNxQnKh2EgGKprCgiT8BST8HKPKjvgYuNm0Sv8vHUs8SMWpuPSPAlK6R6maceT3dBKfLejAPc1VXe4hzZz37+0LBv2/blJsk+nbXyheydc3QobvExEIEbrQZ/cPvp84P/Y/tOOpXA22BLJ+8Vvcuge/baaDNErPpWDw0heGceKnbKXbvUfvsjkpc8K/4QBFMOcrO9lYYqs+YcNWXrhTdGEdof9UxXAqnJEjJmMPtfTUnKdh1jkLVJSicAy8TwhqwqDmoFmTMryy8TowyvTOa+h/EqLcStWIg1uNpQ4PcZ7QlmTdykNyT2CY4E+zoQ1Er+wgxJtf8sUHAGzlaYpvcAoQO1oLEiHRglvIUnypSPY6XJ5lmx5dVuish7kMlJZNLYQV60uyGocSOe/N6tTM8jDeSxyAXp6FmQy4Ne+7T145vpBg7SbeFVE0CUb0LCdyeqFlzQhnc5F9ShrhwSI/AnQIqU3obXqvRorbFmg+hsnS42Q3/DnPvHNztCW17cP2OYpxJ/VTBcRxhFoOip6odK/Dob23tHAq6kwDdMnnEQ9GevA7wmXnAfdbqleXxMVx+EnASK/bOA0v9pBS3cDuoL3+jt1VVXNJKv7vEnEsAs9LYHyMmLKoG+eLvWzzsHRvTGdw7mbnvwbrXtlX9zaHczkF/kHDi7t3EDqhHgqlv15lKYubb5DxtKx+pfnYA8F2dBgNwTUVT90lXvjD2 30/DVcJ4 2iUHa0aMOR6TvBI8cWXVfjnfwF+uN5akP73R68247jCnoE83LZndT9D0ALQb76E7ueZ+RwgztMsdPcKmSdRZL1NVRCrFscK9olon2asEEMhSdoT4UFd1x4nov1dZNlcMEk1SZD0XtQCFA5KRQgSb9bfnH+1Tpwvc/t+ZELsZxM9hkKL9L+D70WSMG6Nm0ca8BX49WVqz4xRwiASi3+Hud1FyfWk2efV6hhf7BLOPrd7KzwlEG20xFIjNa8DJoxsPJxDLDwQWMcs4jGil50rW3wSyT9DXHOPjPvMlquBs+xAhms6e8m89WIRFsdlFfYHPqj6VzkVTvuqfeOArw74sw5/NHs9Tepc0N/jQjCmCboT6ryfVxPMKrHY/xNfkKJiLDJhOhZvUY7Tvqoa/0xv/ptNIBLXVpXv/etjcuH+mQIpERSQIXVKWwuKs7w6IU7k8JmG3B/le5kg7hPU1XBC9Ju+/GSWKpxkN6uO3kRBGpYatatdUYGaWt9jhcNGkQ89ktSQ8+FRDUgCFf6kIYX/RFCyD9ib1/gYLRm+0T X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 13.06.24 14:43, Lance Yang wrote: > On Thu, Jun 13, 2024 at 4:49 PM Lance Yang wrote: >> >> On Thu, Jun 13, 2024 at 4:27 PM David Hildenbrand wrote: >>> >>> On 13.06.24 09:52, Barry Song wrote: >>>> On Tue, Jun 11, 2024 at 12:02 AM Lance Yang wrote: >>>>> >>>>> Introduce the labels walk_done and walk_done_err as exit points to >>>>> eliminate duplicated exit code in the pagewalk loop. >>>>> >>>>> Reviewed-by: Zi Yan >>>>> Reviewed-by: Baolin Wang >>>>> Reviewed-by: David Hildenbrand >>>>> Signed-off-by: Lance Yang >>>> >> >> Hi Barry and David, >> >> Thanks for taking time to review! >> >>>> I don't think "return false" necessarily indicates an error, so >>>> "walk_done_err" doesn't seem like an appropriate name. >>>> However, this is a minor issue. >>> >>> Agreed. As we only have a single walk_done user, should we instead >>> remove "walk_done", keep the "page_vma_mapped_walk_done" for that single >>> user, and rename "walk_done_err" to "abort_walk" ? >> >> Yeah, I agree that 'abort_walk' is better than 'walk_done_err', and let's >> keep 'page_vma_mapped_walk_done' for that single user ;) > > I just realized that there is another walk_done user, which is > unmap_huge_pmd_locked(). > > Could I keep "walk_done" but rename it to "done_walk"? Sure. "walk_done"/"walk_abort" might sound better. -- Cheers, David / dhildenb