From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50826C02180 for ; Mon, 13 Jan 2025 18:52:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B5DD56B009C; Mon, 13 Jan 2025 13:52:12 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B0E976B009F; Mon, 13 Jan 2025 13:52:12 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9605F6B00A0; Mon, 13 Jan 2025 13:52:12 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 758326B009C for ; Mon, 13 Jan 2025 13:52:12 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 3D484AE562 for ; Mon, 13 Jan 2025 18:52:12 +0000 (UTC) X-FDA: 83003323704.20.688C751 Received: from BYAPR05CU005.outbound.protection.outlook.com (mail-westusazon11020126.outbound.protection.outlook.com [52.101.85.126]) by imf01.hostedemail.com (Postfix) with ESMTP id 5006A4000F for ; Mon, 13 Jan 2025 18:52:09 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=os.amperecomputing.com header.s=selector2 header.b=LqTcEYBf; dmarc=pass (policy=quarantine) header.from=amperecomputing.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf01.hostedemail.com: domain of yang@os.amperecomputing.com designates 52.101.85.126 as permitted sender) smtp.mailfrom=yang@os.amperecomputing.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1736794329; a=rsa-sha256; cv=pass; b=6ekm+Bi88yTIrVPKx8ueghK8wPdJQvjsaAHeeAIJbbYlhyZ/aqsAvqFg3wkq6W6AMhC+aH AWPQiUgTIYidONfetUmUa4b/EQSG/YrmbLUMPFeMNnVQ9HEBRS8MTZKs++xg23dpyb3c0g HvFbNHKls7QKwsbX8f9SZheGjI2XVwA= ARC-Authentication-Results: i=2; imf01.hostedemail.com; dkim=pass header.d=os.amperecomputing.com header.s=selector2 header.b=LqTcEYBf; dmarc=pass (policy=quarantine) header.from=amperecomputing.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf01.hostedemail.com: domain of yang@os.amperecomputing.com designates 52.101.85.126 as permitted sender) smtp.mailfrom=yang@os.amperecomputing.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736794329; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1oDrj/t0dvjPwHGkl7ooRyyk/ZL27qDdRkjtYmXGXS8=; b=mQZkTa0asLC/rZ5/3x8zgLPKAvfE0MVADdhp2ryuSUpZgaBIM6BeTanNyK6ICR5W+3yRu0 dnxADlNO+URzmC3yW/mOQ2R6SgPlnq3Z6b7+xZWA8wCM5SApxL15pyCUOjvxYKvESP6oYx 8Er7ntJoqLkza+5hBEnQzKDzIAKhr4Q= ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Yofsvs4JTYjGY20rLSP90IvHDhIkBdTxfezpnfoTPv391uOuVgqRIAKeb+eseNYGfDaEnYCO8Oy3/R7fB28vZWtMukiw/Tdif9DrKiMGK4SfTlso+RIqN0ZldGltjxnmuFGBjxj6Yoy9isYhguxjd7JtMypOcBgihM73nb2755h8GtVXVaiIId7wB8bSgovkwAbvprTaX9jv2OlLIEAWDuuHnvLTDZ/tNKbrw7jlarBAwf8wEt9xJ8i9id/YNwhs8l9WoGTyE+UKDIZEI19q4rvX3c6uueOZ1kULdyNDQgNBILyEPgy1qmmEBU8paWUHbdT7oQa98KnSeorluDo8pg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1oDrj/t0dvjPwHGkl7ooRyyk/ZL27qDdRkjtYmXGXS8=; b=sB0i9S6vRYTBvviFvo5l7XafU7TZgCOmcqdtDuS3PnmLNsu+ctdgWJrysmjh9YB/8sxDgilCj3152hlgpTFOWFRjMbn/VtP1DDOwP+vgg9GH8RrWKHYVE7dRpTJziKlUQY+JcCuNC8x7/iUWZo4I/Lb2BJ76DIh2BnlbllaYWUddHJoIGw1654txrDntVATZ6foGm2ednhDreA8L1h7dDUatK5/dAudQQtW9+Bn75obxGrF6KQWGMpJ7N5LTnapLrRsR59jbFJsb7/Vn2I1VgasEurPW4RvUL8R6nuBPvPxgpQ0XGGevlgw2ZA6k7zNwugxMTLUyDdo/JUyPd87LQA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=os.amperecomputing.com; dkim=pass header.d=os.amperecomputing.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=os.amperecomputing.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1oDrj/t0dvjPwHGkl7ooRyyk/ZL27qDdRkjtYmXGXS8=; b=LqTcEYBfm8Ee+ICfPRS/z6t4A1Ik6POPNqroUmiRa2yRHIer9kEDvpppcrtV+qBwU6ICFOgP8Q1WSa/uxshnN9vcOgwbHl4fR7AklhaSRC/lzuiysZDpO4baZXaD4nAWrhPgSI0hmnbVTUkwEZD4bU8eM9jd0tKRY/j9j76tbDc= Received: from CH0PR01MB6873.prod.exchangelabs.com (2603:10b6:610:112::22) by CO1PR01MB6645.prod.exchangelabs.com (2603:10b6:303:f8::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8356.11; Mon, 13 Jan 2025 18:52:06 +0000 Received: from CH0PR01MB6873.prod.exchangelabs.com ([fe80::3850:9112:f3bf:6460]) by CH0PR01MB6873.prod.exchangelabs.com ([fe80::3850:9112:f3bf:6460%6]) with mapi id 15.20.8356.010; Mon, 13 Jan 2025 18:52:04 +0000 Message-ID: <59d1c878-0a05-45d8-a357-c8172e05c754@os.amperecomputing.com> Date: Mon, 13 Jan 2025 10:52:00 -0800 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] mm: khugepaged: fix call hpage_collapse_scan_file() for anonymous vma To: Liu Shixin , Andrew Morton , Chengming Zhou , Matthew Wilcox , Kefeng Wang , Nanyong Sun , Muchun Song , Qi Zheng , Johannes Weiner Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20250111034511.2223353-1-liushixin2@huawei.com> Content-Language: en-US From: Yang Shi In-Reply-To: <20250111034511.2223353-1-liushixin2@huawei.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: BY3PR04CA0022.namprd04.prod.outlook.com (2603:10b6:a03:217::27) To CH0PR01MB6873.prod.exchangelabs.com (2603:10b6:610:112::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH0PR01MB6873:EE_|CO1PR01MB6645:EE_ X-MS-Office365-Filtering-Correlation-Id: 0afc85d7-d051-41ef-dd8a-08dd34035f08 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|7416014|376014|7053199007; X-Microsoft-Antispam-Message-Info: =?utf-8?B?N2kzNWV6MnR6Yi9tcS8vd0g4T2RjZ09CZUNudTliTC9kdy9NRkprM2V4L0hO?= =?utf-8?B?Ui9hYmJ1V1QyU3VjZmZpSjIrYU5EUm40MTRDM0VnYVhuOEtxT3NTLzBBUjFI?= =?utf-8?B?MzFPUVJnejBEN3NVaHRCTEE1TW9mQmVBNTZaMTZBOW9VZHR5WjdGUWVuZGIv?= =?utf-8?B?cjRyZDJEVzFCVStMM0NwZGY2eU9wUm52Z0xBY3NNUGc3SGFzalp6b0l5aVc0?= =?utf-8?B?eGVNTG5OL05halBQa3JpUUxQUWlJV0dEbmtjbGRLS3YyallJUHNVcThDa1BL?= =?utf-8?B?bG00aFU2WEwya0xnMWpYdnJHcmhxc2NoVXFwYXdNdUtFZUh0ZzFTSzdmUG9V?= =?utf-8?B?N0s3cStFWjc4dlFYOTBFeW8xWFdkR3FPUzFhZnQ1T2dqbnVuWCtub25EZ0Fw?= =?utf-8?B?ekwrekdTT24xUzJIa25NcytHWG1hTXdqLzQxcEJjNVdSa09ZZ1lKL0NtazJv?= =?utf-8?B?L1REejM3N1JlZnV2L29KUlFNY21BRUt5VWs1UmVxSmZVdU5IVFJZVU40eEhT?= =?utf-8?B?NzVEN2tKQXJOTmlEY3E3YVpHTGNkKzNQNFlFSEV0VWF0M0ZBZlQrYkZodUNt?= =?utf-8?B?V2JMV29Lem4vcFhyV1hWU1pVU3FKZzJpV0FpSWlTcUwyNitOL0pjS2Z4dFJ0?= =?utf-8?B?c2Z6dnpvQU1mNlRSSWtINUNYMjkwNmlYRjMxYloraE1hK21VclQ1UTRNUm85?= =?utf-8?B?elVSRHcvNmRVSERsSTliREFQdkNVZGhZK2REWjQwRWxTSWVJUW5obGxKdmhV?= =?utf-8?B?NnBxV20yVFI2SXYzemJFcjdFUWV4dTM5Y3lvZEJ4V1k0TEJsSEZRSjBwVk9N?= =?utf-8?B?T1NVYXJXVE84ZXQzNWprbkpSRDRQd0dLMk1pZXo4WVJKVDNjdDVJdFdLQ1FK?= =?utf-8?B?QU1FNVFlWVhIS1FmcGZjMzNoT1IvSDdZaitZcEluZFFCMy9iU0hKeW9FUTlo?= =?utf-8?B?blErWEhadHM2TnhRRWVYUWRiRk10bnl0RDR2cnhZMURnS2gyNVlIbzNoRUVZ?= =?utf-8?B?ZXh1aUswdFprdTNocmxWVjl6QTk2SzZQemxqcFoyNTlMZmNkRFhBYmhPaHhG?= =?utf-8?B?OVQzODlTdVBtQ2hlNUNudWI2c2FDazUxVTZoaFk1eFVoNE9NUDkxMTZ5N0Ix?= =?utf-8?B?K1BROHA5RkZEbGJuVGVGeHp3VlIzVzRkL1ZNV3k1WlZ0a0I4UHRLSDlCR05B?= =?utf-8?B?RHhvYXdMYTBPVDVVVHlaWFBDUzB5YTVTQWxsUUdjMDQzZWFQcXc0TDJJYndP?= =?utf-8?B?eDY0cENaYWxmamZnaldMSGgvdFgvMm1zWDRHSDlEYUY2WFZTYlBvWlVlc0hm?= =?utf-8?B?TEczQklMd0VvbXBvbTRBQlVwbHBVK0RTd0d4ODRhMlF6L2p2bUtkTFozSUdx?= =?utf-8?B?aE50aTNVS1U2UkRvK3NyQzFvUXNmODJ0cUlNUVFCWDVueDFmUENZcTZMZm9i?= =?utf-8?B?cy9WNEhBSjhvN3JOQmFLbVdXaU9mTkFuNmFFcDR2eVhGa3lxUzgwamZwazE5?= =?utf-8?B?SUJMUDZubjVtdm1GQzFPQ2V5K09JTTNjMytXaHQ5QlJyYjdXemdZUEtUenVa?= =?utf-8?B?Y25qRENWZU5TWXhBZDJwR3JTalI2V09tNjB0Vmdra2FOK2QwMU5LblBGMEhV?= =?utf-8?B?MWhMeTJ0ekpJNldPWm94OGd4amJvZjNNajFSbWVuWGF5aFgyMkpPdjdhby85?= =?utf-8?B?NjVPRk54eU9mQmlvbFM5d29LZmx0WjNpS2wwYlB0TWQreE1JMyt0OGRma0ps?= =?utf-8?B?QWhqZ2toWE83RklwdUp2MGlJbkNzSWdVUjF2dTQ1b3NIMkhZUXBMVGJzQzRI?= =?utf-8?B?TEtMenZQWWtRWVdKNEFNOXk1UVZWOElDdE5hYjRQMUZoZnpZSW5PUXRwdXNJ?= =?utf-8?Q?KOloKIH8W4Ptf?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH0PR01MB6873.prod.exchangelabs.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(7416014)(376014)(7053199007);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Umt0ZXBFc1FLbWkzZUR6Mit0ZmVCUHd4QXp3TzlBUHhhajdraElycjVOL2x2?= =?utf-8?B?d1VYQUFUdFBFUjkrbDg2SDkybjRuVDltZlVEb0ZiU1hlVG9MemNjVklzL2dU?= =?utf-8?B?a0EyUUxXTURFWGxGYjNVTkRQUUtZcGNld1JXUnE1eWpqREpsZnlTdUhuY0lz?= =?utf-8?B?Tmg3dXk3N0dMVy9IZjJoMllBbmFBMDN5TlZiWlRQTzBZeVkrakhMWUhnOHBp?= =?utf-8?B?THl0LzJyTUNpWmZNTk0rRXlscUx5OERoTU1FVFJnT3pyV3VqTmMzZ0VVbjN0?= =?utf-8?B?V0hUNjhVcWpkUlRTVEk1RVFreU9XbjArZ1drOGdiSDJhLzQ4TDlxNDhpamtz?= =?utf-8?B?OUs1b2dXeEJMTXMyTTA5eHRtcVBOODFicm0xTEk4L3dvRkExUlFjUlZYeEth?= =?utf-8?B?MmlORm5xZ00vTmFiLzdLSDQraUduRmtheUVPdS8yT3hFMDZpTlFUVlN5eURZ?= =?utf-8?B?VUx6Z1Z6aGpuVjEvNjR5UXJQekpuQ282YmhtRWpYT1g3RmdrZnhhcWExLzZN?= =?utf-8?B?R2t0eU1UdStEa2FpSTd2bDJidWx0STBucWpWS2syV2tBS25NTDVGajFEc3FC?= =?utf-8?B?SXVHYnNmZWdMa0c2R0F1eC9hd0lyRGw0OXdKeFc5WkV0Y1lFdmFXbHpaVTI2?= =?utf-8?B?RXUxUzBBYnNiN01LM2t2U2FVUGFWcHRSdGhpRGF0RTk5alo3TDBKeTlYU2hX?= =?utf-8?B?MWZSc2xGVytKYlRoS0pFTGNHL01Db050TjF4Q29ybFh1dkoxVWJRWTF2ekV0?= =?utf-8?B?QndQelIxSTdEeXM2LzJLNEFkc1hrSGk2M1RObTltTGllUkpYdWFHcWRYY1ZP?= =?utf-8?B?TjFhQzY5NzdUbVlrai9WaDNkbDM0ZlJBUWtmbG1pTzdIRE0xWkt2L2hlSTk0?= =?utf-8?B?Y1k0TVBNUXJpRFVHTDlXRDA0UWJOeFh3SUl3VTJ3N1Q3a3YwTGE4cEVPMXB6?= =?utf-8?B?YWk1K1BOanpEcUN1UE8zOVE0QitRdWprTVhVT2Z5eTh6RFFNaFlTRnEvTjBE?= =?utf-8?B?RG1aRzFsYUJoMkVhaGtJdTBTNThUYXZrazh1ZjlVTlF3OEZCeHpDUnA3TVRU?= =?utf-8?B?enltZDhyNGJYTjMxSHRwbWF5RTlCbEpsbXVNcmN0bVliQUhGRm55TzQ4bjRv?= =?utf-8?B?NHZOcTFoeGhXaW5keHgrKzB4SUdhdGE3RWRDU1VmRWdxYXl3MHg4WXhrems4?= =?utf-8?B?OXFPZDZpa2JCY0VPbmpJeVBDWFlPV09oaE1mZnhQbDhUdVhET0tJcVV5QlN2?= =?utf-8?B?UUVWejlpMHRGVHg4T0VPTVlRc3oyUlVJR0RjVHBqN0RDb3AyTDVvcEVjVXh3?= =?utf-8?B?S2pRYTNKUTZkZ3Z0bFhhN2RiZGZDaVpINXduSUdsTEt6QldJbnlGUFNjQndP?= =?utf-8?B?N2hGWUh2TTdoMkdLVitYN2dWRllKazhVZEprdUtwaFVVSkFDbWhvU0NSZ2N0?= =?utf-8?B?S2tkd0RIL0QyeGJUYlVCUEtHMzAra3piNjlPRDJrdllUcGYvM0s4Q1BRZmpO?= =?utf-8?B?cDJtTDNPeWRnbEw3ZEpoelVmZjB0a2NRRVVUWmxzQnlPc1VYbjRPNEF4b2R4?= =?utf-8?B?SGoxVFRraVR5aW82NEo1Y1ZGblpJWnlybm1Ya2JFY2ZuaXQzM2MzK0NsNTdP?= =?utf-8?B?Q0x4RTFrZGVMYzhEZkdWaWNVcm55ejlIaXBLaXpiNlpub1R1dFNDbGtoeitX?= =?utf-8?B?M0hOaWtmejVtdEpCU1l1MXM0eGw2azFWNk83SC9UYkgxcjFJdVBWZ2hyeHU1?= =?utf-8?B?bU55ZkljV2pOc3pJRVdZYTNvek9sZ041Y2FzWldXSXp0S2NGcWlRd0Fjckwx?= =?utf-8?B?NTdoUXpEV0Q3cWIzTDRheWxhNDN2cy9Cb3NKOXFTcStTbktxNFhPU0pIY0tY?= =?utf-8?B?ZzhucXk3T1lwL0pad0ZucTVMeHpIUmF2RmQ3dUkvMUFySGpYUW1WQVRucEtM?= =?utf-8?B?WWJIUndaYmF6UTJvMHVMK2VaeEd5b0s3ZS9xemh4RVN5bjcrditVY1JkWUVj?= =?utf-8?B?Q1IrWUFmL1JCaWRvUGU4WmxMdzJJcitWZDdOL0dLOVo3bnhzUGZWRjEyclYr?= =?utf-8?B?T3lUVkF2LzZFM0dDZXFGbEt6R1RwNnNPKzU5Wi9CbC9VNjRmekRtb3pzeHBa?= =?utf-8?B?b29DNlNQWG1DcWl1VXJ5TEJLdFA2bXpheStqMDZjWVVYVTRKTDgvMjlIRjh2?= =?utf-8?Q?qmdm7toVl9XjFw03Sc+7ll0=3D?= X-OriginatorOrg: os.amperecomputing.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0afc85d7-d051-41ef-dd8a-08dd34035f08 X-MS-Exchange-CrossTenant-AuthSource: CH0PR01MB6873.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jan 2025 18:52:04.1831 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: TjC6K0IZm+4lOSg4IZD4szG3371fNIEMPrcfp4lbmBUKV6n+4cJZCSAAV3XrIfZAwmzt28+I5mzjE8nVnYa3d5i1huYttkfsrBw78fSAH0M= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR01MB6645 X-Stat-Signature: mt7bsktmwzibrr4kqjr6rgbses9ux76t X-Rspam-User: X-Rspamd-Queue-Id: 5006A4000F X-Rspamd-Server: rspam08 X-HE-Tag: 1736794329-808014 X-HE-Meta: U2FsdGVkX18uEV0shbh4uYo5Us9zeV2XoXVUoUtoAwBfcXIKklpjHngqLL//s92LCbkkxPKOcN6OZfDzkqOMNjj28UylDd/By+zWi6WBaEbyDjbM50HkClSmBOxW+yl+u/gpZSBzoeqhafl6RYihvpEmsS7mxaXzZHq8Ea0yrC3liVX2afJct3L/FQLVT0BMuf/hZ4LErY8fNuBcIRQt1I3xHJXia1mEGa9JeeHzcjJBA2jzz7zNyxcECL7Iv8AlVyiD9UAt0JYbjMB1Z8pwI4uhJD1jRQw84UjpwOsSUBXVO7e09qLl1pQi2XSyP4qxs5Y+gfA1Cf2DNZU38s0wRjTraU8JTeDp/ylvV5Fj3eFjBaBf2k8NPufggEKnESSgh/nfF5lxeRLpGvc2XZidv5Ssq27BuVXPvxnPllwWzrLdkIRLIJXTBgxBr/DtFdh1vPmEn/+5NmxrzQAK8g9OqcbA5p2r1x4E0Cm/6XGCErAVb13BHa+F+RMRcx5OdP5BRif7z9vPSI/6VWDs9Mnzzc006FGKW+f1PkBgeiPe+f59hH/4+ZUY3mhIBYtrnfJL7pgzhZFUftMaYx2PvvR9PMwmjxb7LpHzJUCgHalps2NOzaxvO91UxfNI5/+OiAPRTtM43E7FiYLMEJjl/yzzKKjdfmAFLmB42WLCSlsEG79YaVLY2Qt9OGlS6UYI/Cgk1babhN9LorHHEPR3cZ2+LihKS687UGonM08kV/RkGx3PEcpse3P1H+TffmhXumuUBC0JHj1sNXl7fj8vAi9HOervwAKqpH8fSWiqjqZRMkbyIXu2A6vPjvoQbpW7Snr+Cjl/XyBjaxxKgHnvSXALLEGEFngm8IeG1bmF8mus7HBhTeH9Y/D53Nzh13kfK60dP5krhWNuQ5zT1BLJBB6SfX6qkBA8KGEYzrPZIKQ1smApbsM8HFsqjIEA8ZbWtPJRvpk5/LhkevB2+7RmM3d hL4CqAz5 ileDQN++PUQIFd/Sikb+WdZtJzZ38lGzejXgpk6Uwrn5YNGB+x6ny9nWRFIUcO/yFf7i3uFNKZwtHz1kayRvTbY1tZwrUqobwHPLNwdLtO9dMd7pFlRa5ywTnsqEnmVE3j8H2eKKGdzmJ8ZccsmeU4ThroVm6iInXRj/kgLsUAT4KiGbiXF8p8P/Opb3LyEDqspMSF9qSV2zljg4MGu3/TN1cn287NxOD0wuPeZzKOwa0x0mK5Jwbe9WkuTaHDS6BeFOhD68T258AbUlacr6DibgcH6gexR0urzYzkq+YcML0jgPXEt0nlPjNKD3/SiRIOJKtkJTyq0WMpARzBKXMigGVRBsqEAkCMPm0T1zRGrAh/xPPlxpFx9jnVXuqhX2P5Zx6TdU52FMCu5oSUHeGuevCqnBNzMjXs5VG7TkiY/I8fAPTrYxCqO64WYwYc6WzfNFHDPeX+yrlF/uNOh0Itrfwfpz6xCkTWr+Q53uG1mTS5D7+PAIIa3VLPo/dPEPJRSa5XKPMaqudFhs1egQcyjux1tqogFfSMF9T/G37f3UnqIXW0bzNtdmz/jo0PDTAbU6XyupSQpEtt7c= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 1/10/25 7:45 PM, Liu Shixin wrote: > syzkaller reported such a BUG_ON(): > > ------------[ cut here ]------------ > kernel BUG at mm/khugepaged.c:1835! > Internal error: Oops - BUG: 00000000f2000800 [#1] SMP > ... > CPU: 6 UID: 0 PID: 8009 Comm: syz.15.106 Kdump: loaded Tainted: G W 6.13.0-rc6 #22 > Tainted: [W]=WARN > Hardware name: QEMU KVM Virtual Machine, BIOS 0.0.0 02/06/2015 > pstate: 00400005 (nzcv daif +PAN -UAO -TCO -DIT -SSBS BTYPE=--) > pc : collapse_file+0xa44/0x1400 > lr : collapse_file+0x88/0x1400 > sp : ffff80008afe3a60 > ... > Call trace: > collapse_file+0xa44/0x1400 (P) > hpage_collapse_scan_file+0x278/0x400 > madvise_collapse+0x1bc/0x678 > madvise_vma_behavior+0x32c/0x448 > madvise_walk_vmas.constprop.0+0xbc/0x140 > do_madvise.part.0+0xdc/0x2c8 > __arm64_sys_madvise+0x68/0x88 > invoke_syscall+0x50/0x120 > el0_svc_common.constprop.0+0xc8/0xf0 > do_el0_svc+0x24/0x38 > el0_svc+0x34/0x128 > el0t_64_sync_handler+0xc8/0xd0 > el0t_64_sync+0x190/0x198 > > This indicates that the pgoff is unaligned. After analysis, I confirm > the vma is mapped to /dev/zero. Such a vma certainly has vm_file, but > it is set to anonymous by mmap_zero(). So even if it's mmapped by > 2m-unaligned, it can pass the check in thp_vma_allowable_order() as it > is an anonymous-mmap, but then be collapsed as a file-mmap. > > It seems the problem has existed for a long time, but actually, since > we have khugepaged_max_ptes_none check before, we will skip collapse it > as it is /dev/zero and so has no present page. But commit d8ea7cc8547c > limit the check for only khugepaged, so the BUG_ON() can be triggered > by madvise_collapse(). > > Add vma_is_anonymous() check to make such vma be processed by > hpage_collapse_scan_pmd(). > > Fixes: d8ea7cc8547c ("mm/khugepaged: add flag to predicate khugepaged-only behavior") > Signed-off-by: Liu Shixin > --- > v1->v2: Remove the redundant vm_file check, suggested by Matthew Wilcox. Reviewed-by: Yang Shi > > mm/khugepaged.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/khugepaged.c b/mm/khugepaged.c > index 653dbb1ff05c..bad1e130eda8 100644 > --- a/mm/khugepaged.c > +++ b/mm/khugepaged.c > @@ -2422,7 +2422,7 @@ static unsigned int khugepaged_scan_mm_slot(unsigned int pages, int *result, > VM_BUG_ON(khugepaged_scan.address < hstart || > khugepaged_scan.address + HPAGE_PMD_SIZE > > hend); > - if (IS_ENABLED(CONFIG_SHMEM) && vma->vm_file) { > + if (IS_ENABLED(CONFIG_SHMEM) && !vma_is_anonymous(vma)) { > struct file *file = get_file(vma->vm_file); > pgoff_t pgoff = linear_page_index(vma, > khugepaged_scan.address); > @@ -2768,7 +2768,7 @@ int madvise_collapse(struct vm_area_struct *vma, struct vm_area_struct **prev, > mmap_assert_locked(mm); > memset(cc->node_load, 0, sizeof(cc->node_load)); > nodes_clear(cc->alloc_nmask); > - if (IS_ENABLED(CONFIG_SHMEM) && vma->vm_file) { > + if (IS_ENABLED(CONFIG_SHMEM) && !vma_is_anonymous(vma)) { > struct file *file = get_file(vma->vm_file); > pgoff_t pgoff = linear_page_index(vma, addr); >