From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26D52C433E0 for ; Tue, 26 Jan 2021 02:03:32 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7D32322EBF for ; Tue, 26 Jan 2021 02:03:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7D32322EBF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 5C5068D0073; Mon, 25 Jan 2021 21:03:30 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 575558D0065; Mon, 25 Jan 2021 21:03:30 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 48BCD8D0073; Mon, 25 Jan 2021 21:03:30 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0022.hostedemail.com [216.40.44.22]) by kanga.kvack.org (Postfix) with ESMTP id 326168D0065 for ; Mon, 25 Jan 2021 21:03:30 -0500 (EST) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id E1E53181AEF3F for ; Tue, 26 Jan 2021 02:03:29 +0000 (UTC) X-FDA: 77746279338.10.rain92_03183732758a Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin10.hostedemail.com (Postfix) with ESMTP id BEBDE16A0DE for ; Tue, 26 Jan 2021 02:03:29 +0000 (UTC) X-HE-Tag: rain92_03183732758a X-Filterd-Recvd-Size: 2335 Received: from out30-43.freemail.mail.aliyun.com (out30-43.freemail.mail.aliyun.com [115.124.30.43]) by imf03.hostedemail.com (Postfix) with ESMTP for ; Tue, 26 Jan 2021 02:03:27 +0000 (UTC) X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R131e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04394;MF=baolin.wang@linux.alibaba.com;NM=1;PH=DS;RN=3;SR=0;TI=SMTPD_---0UMvltN6_1611626603; Received: from 30.21.164.77(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0UMvltN6_1611626603) by smtp.aliyun-inc.com(127.0.0.1); Tue, 26 Jan 2021 10:03:23 +0800 Subject: Re: [PATCH] mm/filemap: Remove redundant variable's assignment To: Andrew Morton Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <08dc7237b44b9455ab095b44dc6969a1607b08db.1611544316.git.baolin.wang@linux.alibaba.com> <20210125152237.d3cfebac78907fb50ae5cbbc@linux-foundation.org> From: Baolin Wang Message-ID: <59c68a70-4938-709c-77f4-2a2aea5e269d@linux.alibaba.com> Date: Tue, 26 Jan 2021 10:03:29 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 MIME-Version: 1.0 In-Reply-To: <20210125152237.d3cfebac78907fb50ae5cbbc@linux-foundation.org> Content-Type: text/plain; charset=gbk; format=flowed Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: =D4=DA 2021/1/26 7:22, Andrew Morton =D0=B4=B5=C0: > On Mon, 25 Jan 2021 11:20:02 +0800 Baolin Wang wrote: >=20 >> We've already set the variable 'i' 's initial value before using it, >> thus remove redundant previous assignment of variable 'i'. >> >> ... >> >> --- a/mm/filemap.c >> +++ b/mm/filemap.c >> @@ -2472,7 +2472,6 @@ ssize_t generic_file_buffered_read(struct kiocb = *iocb, >> if ((iocb->ki_flags & IOCB_WAITQ) && written) >> iocb->ki_flags |=3D IOCB_NOWAIT; >> =20 >> - i =3D 0; >> pg_nr =3D generic_file_buffered_read_get_pages(iocb, iter, >> pages, nr_pages); >> if (pg_nr < 0) { >=20 > Matthew's patch series "Refactor generic_file_buffered_read " > (https://lkml.kernel.org/r/20210122160140.223228-1-willy@infradead.org) > changes all this code - I dont think the patch is relevant after that, > so I'll skip it. Ah, right. Thanks for letting me know.