From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D322BC001E0 for ; Wed, 16 Aug 2023 17:11:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 68B188D004B; Wed, 16 Aug 2023 13:11:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 63ADE8D0001; Wed, 16 Aug 2023 13:11:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 503DA8D004B; Wed, 16 Aug 2023 13:11:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 3D8828D0001 for ; Wed, 16 Aug 2023 13:11:54 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 06CDEA0914 for ; Wed, 16 Aug 2023 17:11:54 +0000 (UTC) X-FDA: 81130610148.01.028EFF2 Received: from mail-il1-f173.google.com (mail-il1-f173.google.com [209.85.166.173]) by imf02.hostedemail.com (Postfix) with ESMTP id 1850480032 for ; Wed, 16 Aug 2023 17:11:51 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b=AMv+0pmz; dmarc=pass (policy=none) header.from=linuxfoundation.org; spf=pass (imf02.hostedemail.com: domain of skhan@linuxfoundation.org designates 209.85.166.173 as permitted sender) smtp.mailfrom=skhan@linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1692205912; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=nYoS3FzLsOAr5f0S1EEKnI/Ectdz8JgA5KQtKpQFDV4=; b=awWz9YqyDHg4pKHhQ2x4UXuSusyqaofpeVY0tUBlnubCrieAr+gKZve2bOLXdpM/2Hb24b oOjk/w146QEVyNNBtpRDRsjqxvPKQSM1IBnxg9tvHUya8kPaCvzTJxBnofzPtQWgN+yBjg /zS8VXmzP2nh9zv8sLBSnH6zat12OME= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b=AMv+0pmz; dmarc=pass (policy=none) header.from=linuxfoundation.org; spf=pass (imf02.hostedemail.com: domain of skhan@linuxfoundation.org designates 209.85.166.173 as permitted sender) smtp.mailfrom=skhan@linuxfoundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1692205912; a=rsa-sha256; cv=none; b=zltbVAu21wV0E8Ux2YJ2V3UxAtAs89HtRY8wuPC/qYUIUuenqwfc9M4XvLMAQSAx820Dd4 4N/67Slxiwwg5sSSoSNruuU0b2hKn75YQvPzR8RAu32gZIAaSv2a4/i8moqrPlo6Uv9O63 Y2iunSo1GA/fIzn8J/C6nZn/4oOCrKE= Received: by mail-il1-f173.google.com with SMTP id e9e14a558f8ab-34a91a25db9so2886505ab.1 for ; Wed, 16 Aug 2023 10:11:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1692205911; x=1692810711; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=nYoS3FzLsOAr5f0S1EEKnI/Ectdz8JgA5KQtKpQFDV4=; b=AMv+0pmzEtAON1kkKvAZgz0CRU9HzFF6eZbOn0MLgnGQI2zzR020WXGqXXHGUyebvU OvfOa98ihp+NtRXQMaOmmWe2NooUIxbBUFGG+e5MNM6ZvXWEbg8SjQMVZgI8350c7/Hg GU2kas2RbxyQ/Kppz74xwUHgUxzuGBOtsw0XA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692205911; x=1692810711; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=nYoS3FzLsOAr5f0S1EEKnI/Ectdz8JgA5KQtKpQFDV4=; b=LUyFmjymB8R/ZLcctMZket0gQAAF/WKg1jIQoV96x0XJTWzDuoVSb1BAx0AuETikoA 3gbqhjMu6wpd8PQ8kSGmMuOvh3ZlSOX+E1ZWgY7SUDIHJmkf0BWbyy37TAN652okzBoN mzpwbJGDnQxpOE+oLEFWiUnmhX6VV1WemX8WBEjRn2Va+cjPqFzvIPC38tfbcjpyyEpd VNjeVOFlLhWw2uXkhrju6GWDyjOBKtw78eJxq13A13iXz4aK3DtnuX2+ViaqmNa28pIz 4INKZ7Z3ObQkWaRgboM9h11bxI0JXCADJeRA7HwMMqaqNoq4UKy5IzqIy6P5CkDb3FX8 Ll4w== X-Gm-Message-State: AOJu0Yw3W+1hLblR4Ie0WfBbHw4iQmy/ofX6HSatTLMHNv5zYojx1Y+8 t7ukhl4MKBmQwboXytX3ODtiGA== X-Google-Smtp-Source: AGHT+IErv/EEWy15Sn057ZKbpCRgOvwG9jec2C11rkrbrBZ//FPdRLPpwEoeD7xt4vH/QgloY06scw== X-Received: by 2002:a92:c951:0:b0:349:1d60:7250 with SMTP id i17-20020a92c951000000b003491d607250mr3251426ilq.0.1692205911157; Wed, 16 Aug 2023 10:11:51 -0700 (PDT) Received: from [192.168.1.128] ([38.15.45.1]) by smtp.gmail.com with ESMTPSA id t17-20020a02ab91000000b00430a20ce88bsm4370963jan.174.2023.08.16.10.11.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 16 Aug 2023 10:11:50 -0700 (PDT) Message-ID: <59c0fcd1-a1f2-de37-c94d-76687934acd5@linuxfoundation.org> Date: Wed, 16 Aug 2023 11:11:49 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH 3/3] selftests: cachestat: test for cachestat availability Content-Language: en-US To: Andre Przywara , Shuah Khan , Nhat Pham , Johannes Weiner Cc: linux-kselftest@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Shuah Khan References: <20230815155612.2535947-1-andre.przywara@arm.com> <20230815155612.2535947-4-andre.przywara@arm.com> From: Shuah Khan In-Reply-To: <20230815155612.2535947-4-andre.przywara@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 1850480032 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: 46p5kcmpeyic9awihhqum8yyb98wmhwh X-HE-Tag: 1692205911-282198 X-HE-Meta: U2FsdGVkX1+8aI6+C6Ntep1Ig9f870+mTxNex5llF0LK6o0VKqTrIYPVgJBb1YI/qHiN06o5SSuZoylT8qLSnR/gwT8+r3i+XyNd0bjjORjM66H7RXOC5ujCetDdEzr3Fl6YmU0Aql2cjEvnDqE7WT1xjHbAASJ3+bAzp45SrUM+6mqP9z1DWbsoqW74WuEV70DlzfIqHunc0FdN9ga4TnmplILYJeAVm5FlM4IEQ6J+8IGAAFw+8bIGtNktRQ3dG0H74ileBLAiTcGDO715LG44hMTRXI4OOwETJD54jnVNY1VZZDP1JBDcpeMWQS+RdVJcfLpiYgyiSn0d7/QuP+c8BGyJCuRRzf6BChuyKmS//oXl5QuSzOJDI1n/FLb+GXhGY7+BACwYDf+kTy/a/QDUx20+EaceqBvrdHrKC14DSu/L+ZFCbL2mfZ+k9/TrCZbZjy+JjMveHgukAkKdhZ1Cn56SxlbEtXukUYW+yXLhjQtWGpEuccP6/hiC+VNBJVypYUuJxJErF8sh19OO6/m0Q0qEnz2f675oniIJHbh6q322PLiuHQJc+7vfBvZNvEoWj9IgtNbQw0klKj7uCV4fNjpmwHF4WDu0StGYoEA/DgjKmkVu5TGh4/qfSYxKQcs8VqdTw8RFJ8ZM4qbpz66HdXZlBA0qc3wSqL/ANPL3St3YiV4lKrTmaeGX7BSKlJbB0gG58KFlyNbUUYY62Wp4826LdmOCfjlblJm1rwrfzJX8eXOqCXeqFIJt9SRi4rxMmAGY9psPbvJh+w8zynzxTZ3sRw7AyaRZ5eSOWAnUz1cIR/MXwlOBd5uWXF13FkuECpEsKueVQEwDxfYlwQ6kQ5RK0AbNfivRm+w9vZ/iVMyP4pwHuZDMTdF223KcdVtCQzlVzL29Vum4FcthPagd57X3hBtMWq+0s8k/k2DgvjeN2zC0V5c1fDpmuegjB56RPLC+xVN4qi19XSS R+xdq4dL mclZFJwumHgQ3BBm5GZEDSgi0TiHEbgWwKk+1JUtkuiGwBciQ/nc/zMSZgBtxKaEeJYkeWP8gt5t/QspXKoZKXUk8iN8rIQbAURnhsjk3aNs5B5uPsDzSAuav+mRrt7fsoECCOqe2uJi/HzoS34O/q2kTnxFCaR2IaGXqkuGiCYc2Bt3q6gzMBLpqh6K7hoNMnV14mVVKxqdPXGod1+Hv9BV7puQyowIRc+XoJnHg60QoDXKgnkkRofbPe+Los63tUcQpXm3a4PDVlpKjmv/GRXEMv3GdIKMvnZu0Reyn7hjTyyrkeOqrg/hCfXXbJBlZFj7bXmvjZMGv6hsV9htqPUVS6SKWA3QMynZcXw7RujwudiYUfA0OCPsZBYNC/bRNBVQYk9f1FJgF+CuVkkxL41rFgYLypZe5VavxmzkC+ZVVTg+lVKvKGwhZFQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 8/15/23 09:56, Andre Przywara wrote: > As cachestat is a new syscall, it won't be available on older kernels, > for instance those running on a build machine. In this case, a run > reports all tests as "not ok" at the moment. > > Test for the cachestat syscall availability first, before doing further > tests, and bail out early with a TAP SKIP comment. > > This also uses the opportunity to add the proper TAP headers, and add > one check for the syscall error handling (illegal file descriptor). > > Signed-off-by: Andre Przywara > --- > .../selftests/cachestat/test_cachestat.c | 22 ++++++++++++++++++- > 1 file changed, 21 insertions(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/cachestat/test_cachestat.c b/tools/testing/selftests/cachestat/test_cachestat.c > index a5a4ac8dcb76c..77620e7ecf562 100644 > --- a/tools/testing/selftests/cachestat/test_cachestat.c > +++ b/tools/testing/selftests/cachestat/test_cachestat.c > @@ -15,6 +15,8 @@ > > #include "../kselftest.h" > > +#define NR_TESTS 8 > + > static const char * const dev_files[] = { > "/dev/zero", "/dev/null", "/dev/urandom", > "/proc/version", "/proc" > @@ -235,7 +237,25 @@ bool test_cachestat_shmem(void) > > int main(void) > { > - int ret = 0; > + int ret; > + > + ksft_print_header(); > + > + ret = syscall(__NR_cachestat, -1, NULL, NULL, 0); > + if (ret == -1 && errno == ENOSYS) { > + printf("1..0 # Skipped: cachestat syscall not available\n"); > + return KSFT_SKIP; What happens when other errors besides ENOSYS? The test shouldn't continue. > + } > + > + ksft_set_plan(NR_TESTS); > + > + if (ret == -1 && errno == EBADF) { > + ksft_test_result_pass("bad file descriptor recognized\n"); > + ret = 0; > + } else { > + ksft_test_result_fail("bad file descriptor ignored\n"); > + ret = 1; > + } > > for (int i = 0; i < 5; i++) { > const char *dev_filename = dev_files[i]; thanks, -- Shuah