From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 816B5C678D5 for ; Wed, 8 Mar 2023 15:28:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 15021280001; Wed, 8 Mar 2023 10:28:21 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 100536B0074; Wed, 8 Mar 2023 10:28:21 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EE2C5280001; Wed, 8 Mar 2023 10:28:20 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id DC4C86B0072 for ; Wed, 8 Mar 2023 10:28:20 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id C0317AAD39 for ; Wed, 8 Mar 2023 15:19:06 +0000 (UTC) X-FDA: 80546089092.11.B85E146 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf13.hostedemail.com (Postfix) with ESMTP id 82E5720020 for ; Wed, 8 Mar 2023 15:19:03 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=LGAyb4qK; spf=pass (imf13.hostedemail.com: domain of dakr@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dakr@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678288743; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RqMveydNu6XNejp+shWEpKdVrYy02V5i0PEhRKX7Rrc=; b=3j9IEGyICcr0vknkYIOTLkRVI2KmI2QOO1fh5Hy+oBdK8ZBsi/XxU9cmwanLM0YXK4Qw71 vSf0Xb+soMLdQ72AbGwLeG9RFul/EoKUJw68IegGrj3WgfMPLSZ3DZFfgcIALEg2KuYEg8 t4MXByqL7BCoeU6fVNbEYLSckC9M874= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=LGAyb4qK; spf=pass (imf13.hostedemail.com: domain of dakr@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dakr@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678288743; a=rsa-sha256; cv=none; b=xM80HLHIeEZhPoJ+ZmXC5odeV/PCmtrkpfA1PbmcIaBjMWZarIKO0jmLOsIaPiJwxE4Lt5 m8xATS/wUqvq3l6SKao73lHKzwq6zgpewLCYvtjRImugLCrh55ocx64jEJH6Dd+2Z4STS4 z8aVaXXRc4ci0OBRcnOcmQ/jnZOzsWc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1678288742; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RqMveydNu6XNejp+shWEpKdVrYy02V5i0PEhRKX7Rrc=; b=LGAyb4qKs/nlGfjQN0wQBK9lIVijIa+00x0tsi9OkS1YlLLhCnGLfeBVt56CR7DWt9T6mW 91xrQ6mZjwejrTOY/FbwJQ6NG6ppwVsTj46eO5m2jhjfqkU6Voj6ji6FXd+4zDF7qcbDJy HQ/DqJBSVKaPXGQNZjsn4hgsOMWRpQk= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-402-TeqXLuagPca6UFs7lUQQNg-1; Wed, 08 Mar 2023 10:18:58 -0500 X-MC-Unique: TeqXLuagPca6UFs7lUQQNg-1 Received: by mail-wr1-f71.google.com with SMTP id n6-20020a5d51c6000000b002ca3c48ba46so2949629wrv.4 for ; Wed, 08 Mar 2023 07:18:58 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678288737; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=RqMveydNu6XNejp+shWEpKdVrYy02V5i0PEhRKX7Rrc=; b=BIt/gUG13GhzjtegGk5QjvlWaHDbIezW+Z/9cr6zh5X4TrExKmpJ5fifZsX+fOj1Ug EqxRwSuIa8P7Xh8vfMwflSNXdew7FYSpwoYpLRalpZ7+Ov2WAzHmpmYBvIEawEGDd+W5 JSvadYCbFH+jbcCBOuMgRvFKKy+CwkyHDSFqT06/fvpaTsj+NH8U7K8cFCuEn7O18Baf fb19ZqHgp4gCGSn1/GWN+J8Rfn1qC/8yQi3RhjYytmCwJbvP5V56aP44dOEJx8GZCLRo fJxgj//CXOHpYboZB65XAHpt8xqOA5BTxkXf2sq89qv63QlEVHl3aFJ99093eS91fPap Qt+Q== X-Gm-Message-State: AO0yUKX/qBZ5s6nk71f+3yZzqq0mT9CTtXciPhw+PGiMpqNFM4AC/UE1 fBhSLjNmZhy3gi9bo8FDwDYfqflzjJ6Clm7jFFKtJEcfdSrYrm8eDxR2MNkBe3C0KIWOF16BPmS muDS3h2epZU8= X-Received: by 2002:a5d:4ac6:0:b0:2c5:4ca3:d56c with SMTP id y6-20020a5d4ac6000000b002c54ca3d56cmr16363767wrs.0.1678288737554; Wed, 08 Mar 2023 07:18:57 -0800 (PST) X-Google-Smtp-Source: AK7set+eeUD0ndDLPrfGROs+plKRbr9juDzI5L0SeuXOPDJn6wu4tn5amO/mlEW4MhS+El2M6NvXZw== X-Received: by 2002:a5d:4ac6:0:b0:2c5:4ca3:d56c with SMTP id y6-20020a5d4ac6000000b002c54ca3d56cmr16363758wrs.0.1678288737334; Wed, 08 Mar 2023 07:18:57 -0800 (PST) Received: from ?IPV6:2a02:810d:4b3f:de78:642:1aff:fe31:a15c? ([2a02:810d:4b3f:de78:642:1aff:fe31:a15c]) by smtp.gmail.com with ESMTPSA id p7-20020a5d4e07000000b002c5694aef92sm15528270wrt.21.2023.03.08.07.18.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Mar 2023 07:18:56 -0800 (PST) Message-ID: <59b703ac-9660-a0e5-09f7-c5b69d4f39cb@redhat.com> Date: Wed, 8 Mar 2023 16:18:55 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH] maple_tree: export symbol mas_preallocate() To: Christoph Hellwig Cc: Vlastimil Babka , "Liam R. Howlett" , linux-mm@kvack.org, linux-kernel@vger.kernel.org, maple-tree@lists.infradead.org References: <20230302011035.4928-1-dakr@redhat.com> <20230302015242.xi3y53okc4skmonn@revolver> <9abef101-3a9b-0bdd-7139-ced7d5e28ebe@suse.cz> <20230308144343.GA16259@lst.de> From: Danilo Krummrich Organization: RedHat In-Reply-To: <20230308144343.GA16259@lst.de> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: zswxjqhwns9yx9x8ksswrdj3tyuct17f X-Rspam-User: X-Rspamd-Queue-Id: 82E5720020 X-Rspamd-Server: rspam06 X-HE-Tag: 1678288743-135091 X-HE-Meta: U2FsdGVkX1+zFQ+0QsKthvdUg1pT0+4qA22kVB9ZijKj3+xvdp8TrDE7eMhPDggjHEocy6wVgz4CFDCDbsJOLvfpnaLLZogV85SQEEqvs35GS35TDdHENmR5+20r4pVuyN1L6nnFHGUyLsoE0Y5cCrf+yKNxdmH9aPUDUF+o+Vb655WnKbGdOmd+pZo2SjI6YDF0P6vDz7Xc6yfgeMPexO53oBJNnGp8ue6Yofkf5tHryl0JUUFlJ48mUTZSUm/F3aUUzr2OQq0y3l/6HRx4/eC9ScNt8VxmR9xXWBdW9MYTNndm46xs5BG9DBkRYi4y7lOE5Ba7detKMW/PbF5qj5iUiDy9Evo2r0DL/GMVPkcLt2ib22ELVeyr98GRgzeZm/GdfE05/Ap6Arq6Hhmk9SXMJAHV+4F4XHjJgxHAwJPeCwH4JTAAAsEmXX8i9hCNAcoAqqo9+XHfUpC1q2sOWBTKIbZtOdYA+Enq7eou7Srz6SvFY3fQfMS46mPaAHAfGSHJCTA+DaIQsUseNrlLOvwwVrcH1C4LYc5+vQ6vYS9eRp4sRe92vRCJnHbkCmXWTRxCIf/oXwmZpNbHxDRWjXJtL/n5mTAkm/eW/WtjmWJ2c9ZPKuzO7tQklhcHyBUCTQtpn8oIGMMi4mYoyJ9rTza1UOZQvbgU2FNiF/qsTmuT0DM9jS+UpRq0fmx8VjNmUDlVf65p30SLPoCpYrue9ypIclfop2xv1+dC8m6U2/rLhKt6kaVYzYEsPVIjEy2YOy9RnCU+4tb89GhbYekUypcPUWe6FUBVDc2qWP8acgHai3rlzzqupsRI5i5XIeQWXVqoRhqr98k+vGO4NauD3INpZnIwmKgnmFloiA7tPXK0p5SOD4HDbTdLDuwSvYiFsrYDZAbHk5LWHrDIZ/p7OSOvdOtPPQxMWpoX4pcxwiolLu/JCGeWFrgyTwOgCxinStAT+gkRs9u7B1mMf21 oi6nSADK kSzSeot7W1KXL/tUcEuSt1uLNptYGRVrd1W5lqpbpZCCXCc+9HIL/gwFJN2ExNyHPNhy0vKuP9JHgmewODxqOz6WPDw4s6mv6mju6S2lnr4TpJcLscxhGLmI+VSh7TrqkQlHdbJq8uLNpgWkop7mBbkUxmBw5rDHqmTVImjAMVEQkbX656rnJL7VEUhiYDhMdKp/MJ/gZEhmrS/8IZVnu6cdcsM7W9AY6AzcHwgqruyKMEmrx7ag6zJadRuSyF8BHijQAtsr/uKdpVDj3PJePYBiK4Rc4CBzWH4lxyZWuSqNeHby2vwIJZ+nmiWpXY/Fl9LFV9j3gvjvBRvmhPp0wjmzKG3GXC3xQZDa3qIBz9GKOQjzmVyvIIPeGOkz44ZtGoJ+oN1tlrKR0UQw1Qsl2yJV0jwFaLnpyKENBe917o6Qti6o= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 3/8/23 15:43, Christoph Hellwig wrote: > On Wed, Mar 08, 2023 at 03:34:29PM +0100, Danilo Krummrich wrote: >> On 3/8/23 11:59, Vlastimil Babka wrote: >>> On 3/2/23 02:52, Liam R. Howlett wrote: >>>> Thanks for the patch. This should indeed be exported. >>>> >>>> Reviewed-by: Liam R. Howlett >>> >>> What uses it? Don't we export only things used by in-kernel modules? >> >> mas_preallocate() is part of the maple tree's 'Advanced API'. All other >> functions of this API are exported already. >> >> More specifically, e.g. mas_store_prealloc() is exported which doesn't make >> a lot of sense without mas_preallocate() being available too. >> >> I don't think it is used outside of mm yet, but as a generic tree >> implementation maple tree is pretty likely to be used in code built as >> module, e.g. drivers. > > If anyone wants to use they can add the export as needed. > Valid perception, though personally I wouldn't share it in this specific case. Anyway, it's just that all other functions of the 'Advanced API' are exported already without them having other users than mm either, e.g. mas_store_prealloc() can't be used without mas_preallocate(), hence exporting one, but not the other doesn't really make sense. Consistency wise I think we should either also export mas_preallocate() or don't export the other ones either.