From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83187CF9C6C for ; Wed, 25 Sep 2024 05:29:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7901F6B007B; Wed, 25 Sep 2024 01:28:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 73F796B0082; Wed, 25 Sep 2024 01:28:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 62E1D6B0083; Wed, 25 Sep 2024 01:28:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 4554E6B007B for ; Wed, 25 Sep 2024 01:28:59 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id A1E384035B for ; Wed, 25 Sep 2024 05:28:58 +0000 (UTC) X-FDA: 82602131556.09.C8B8D0B Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf02.hostedemail.com (Postfix) with ESMTP id 88A138000E for ; Wed, 25 Sep 2024 05:28:56 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf02.hostedemail.com: domain of dev.jain@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=dev.jain@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727242039; a=rsa-sha256; cv=none; b=gGssy3VYnCM8x0dtI1VxAuf6ZDfM3sT61PWxK3be38uuMFW24s5gnhoBuSaHzjEkPoJHYH LI3+W2wmgpjKs3Qr9sek0f2VXbatvWhFA5IkGWg3Qfn5NLh1ouWbwTNcKFh4LqU1GWme9f aSdAlCHxb2DKoXrMsgKv/TNMrsYZmFA= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf02.hostedemail.com: domain of dev.jain@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=dev.jain@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727242039; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kH7+Xa0JKKWoue2p2XB/mbNL9v2L+jhDfsT3x/jLVhg=; b=erBBg1BnS9EuFIWGgq6RGAGOuUOtB4Ozsle5XvskOqdbP3ANWnahBZjNDNlYN2BsNk21lF s7Gvbf7Idf1IpdQMcnoGoPa9lkRmzVnxI35fF1+ZjMbYkY7ZWJ9pQ7gtBnOnWDn8AYhIJ3 gIKpVc1zoQEaKrubxCyX58wJ+nLDkk0= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0ABA1DA7; Tue, 24 Sep 2024 22:29:25 -0700 (PDT) Received: from [10.162.43.26] (e116581.arm.com [10.162.43.26]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id F3B753F528; Tue, 24 Sep 2024 22:28:46 -0700 (PDT) Message-ID: <59b38cc6-9491-40bf-a254-9c6c5f07c072@arm.com> Date: Wed, 25 Sep 2024 10:58:43 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 1/2] mm: Abstract THP allocation To: Kefeng Wang , akpm@linux-foundation.org, david@redhat.com, willy@infradead.org, kirill.shutemov@linux.intel.com Cc: ryan.roberts@arm.com, anshuman.khandual@arm.com, catalin.marinas@arm.com, cl@gentwo.org, vbabka@suse.cz, mhocko@suse.com, apopple@nvidia.com, dave.hansen@linux.intel.com, will@kernel.org, baohua@kernel.org, jack@suse.cz, mark.rutland@arm.com, hughd@google.com, aneesh.kumar@kernel.org, yang@os.amperecomputing.com, peterx@redhat.com, ioworker0@gmail.com, jglisse@google.com, ziy@nvidia.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <20240924101654.1777697-1-dev.jain@arm.com> <20240924101654.1777697-2-dev.jain@arm.com> <61b16640-49e0-4f84-8587-ae9b90a78887@huawei.com> <91892582-1063-4757-9cc6-664d57b9d828@arm.com> Content-Language: en-US From: Dev Jain In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 88A138000E X-Stat-Signature: gx1nrob4qipkwnuop37nx5uwus5j6xer X-Rspam-User: X-HE-Tag: 1727242136-403679 X-HE-Meta: U2FsdGVkX1+YVang1RZSi9utPy0LTWlU+vVSgGy7BPFBttaQk82QCQVd5/KNL6VWLPAtGlyLAY0YKY9LRp2Cp4BTuOAGAuJqLBXDqWqRJp2fisc6LhU6BYoSLhFnqx+c0iDehDTFhg7PfNBwUkwGJAPpF8b6+nod2MYBWgJ6VqwNmjMQmJXSaP3qFMeMQZG9tq5FFv+u11yPaJNCVkss3Phdghe8UN07MkGnp6735g5fYcvATM8xyMzS7ZRW2ZxyFuJAZLH5lyMkG+VGVtvO/92/9ARBRstxl7/Kr9+K5PEVmc4YfdixbZgexo8spy8psi6Vk/JExP3y0e/cb3Epw3ol+Zn7uqdU6qjQL3mczO54SHs2UaLKEL2hkcrj2Dq1VJ6ozk0A649F6X+yuLsDrJxKz7IcUz4w3t9eYFP8oGIub1ARQeWgkRCUjpyS/8sFqqW1eXOZ2jt5b6F75BEjfWqsEc3KbIFgwjxrndx4prDEy6g+RUKqGn5VT1T47SH75a9PTMUwwsg8RrerI0XmFJkiebOF2eKgMH+Q8OlIC0/HjYzftDVPH+Semt2PpGi27v8/gfossT23gq4mr6o+Zq0/4A+x0T+IpW6O5UF9n4hMFAkZGGecK6USFjLyeeDvMVOonrLXsqOZ4hK2D5WD31687n6GRHjhIjS9TKJS7P9xHtV+yrecswRJVf0Wb4k3u+0+1XWGmseeYU+oktsRQ03/4HtrXHkX9Tjz3B0MhOst3nGqRsNldkiE+fzLTRPHbg6qfQXJ+i86GuO4H3RXVSgsQOgA8VSXyDg7dhZmn9Dnhu//lvFLwgW6gmiSVpGac10XD+gkqEbv3rYVyFS77BziA8dO3XXelTQ88ioXMPOvAT+WMlxidaBT3qJJUPsjdVvQUzo933Q849FVhXnUjr3SlQPDpfh0fnQbneK978qCqaQHoGNc+rkYoNGAfYwH7pAiKnhCyPWUgcaw+CE jdhRrf/m BTcQ4KbeteotX7Uvsy0UBn/VRPuk1+x+6XSM5mq/55P3+nnvOQ3ubNeLONob4r4PDHC9zZTROlZufuOxowcsPGn780o+XJ8rJeAlrr/4C3fB/EpBs9/zbvDY/hPWtllq2nrwBiMhSh5BKqsb3FQw+Xoes2F/xnWcGnJu/i/fEDUfhmjBeMnBzA2yJRZpIcKDPDfkvX422r3cBhV+i5ZZD4bXI7XZwkqyJgEifAm3CRQq9sl9ZvJYullns3YaKhunF+M18UeJZs93vm+gm6Xo3Y+qaig== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 9/24/24 18:24, Kefeng Wang wrote: > > > On 2024/9/24 20:17, Dev Jain wrote: >> >> On 9/24/24 16:50, Kefeng Wang wrote: >>> >>> >>> On 2024/9/24 18:16, Dev Jain wrote: >>>> In preparation for the second patch, abstract away the THP allocation >>>> logic present in the create_huge_pmd() path, which corresponds to the >>>> faulting case when no page is present. >>>> >>>> There should be no functional change as a result of applying this >>>> patch, >>>> except that, as David notes at [1], a PMD-aligned address should >>>> be passed to update_mmu_cache_pmd(). >>>> >>>> [1]: https://lore.kernel.org/all/ddd3fcd2-48b3-4170- >>>> bcaa-2fe66e093f43@redhat.com/ >>>> >>>> Acked-by: David Hildenbrand >>>> Signed-off-by: Dev Jain >>>> --- >>>>   mm/huge_memory.c | 98 >>>> ++++++++++++++++++++++++++++-------------------- >>>>   1 file changed, 57 insertions(+), 41 deletions(-) >>>> >>>> diff --git a/mm/huge_memory.c b/mm/huge_memory.c >>>> index 4e34b7f89daf..bdbf67c18f6c 100644 >>>> --- a/mm/huge_memory.c >>>> +++ b/mm/huge_memory.c >>>> @@ -1148,47 +1148,81 @@ unsigned long thp_get_unmapped_area(struct >>>> file *filp, unsigned long addr, >>>>   } >>>>   EXPORT_SYMBOL_GPL(thp_get_unmapped_area); >>>>   -static vm_fault_t __do_huge_pmd_anonymous_page(struct vm_fault >>>> *vmf, >>>> -            struct page *page, gfp_t gfp) >>>> +static struct folio *vma_alloc_anon_folio_pmd(struct >>>> vm_area_struct *vma, >>>> +                          unsigned long addr) >>>>   { >>>> -    struct vm_area_struct *vma = vmf->vma; >>>> -    struct folio *folio = page_folio(page); >>>> -    pgtable_t pgtable; >>>> -    unsigned long haddr = vmf->address & HPAGE_PMD_MASK; >>>> -    vm_fault_t ret = 0; >>>> +    unsigned long haddr = addr & HPAGE_PMD_MASK; >>>> +    gfp_t gfp = vma_thp_gfp_mask(vma); >>>> +    const int order = HPAGE_PMD_ORDER; >>>> +    struct folio *folio = vma_alloc_folio(gfp, order, vma, haddr, >>>> true); >>> >>> There is a warning without NUMA, >>> >>> ../mm/huge_memory.c: In function ‘vma_alloc_anon_folio_pmd’: >>> ../mm/huge_memory.c:1154:16: warning: unused variable ‘haddr’ [- >>> Wunused-variable] >>>  1154 |  unsigned long haddr = addr & HPAGE_PMD_MASK; >>>       |                ^~~~~ >>> >> >> But why is this happening? > > If no CONFIG_NUMA, vma_alloc_folio(...) = folio_alloc_noprof(gfp, order), > it won't use haddr. Ah got it, thanks, I missed the ifdeffery in include/linux/gfp.h. > >