From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23967C5AE5A for ; Wed, 28 Aug 2024 15:17:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B1A626B0083; Wed, 28 Aug 2024 11:17:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id ACAE56B0085; Wed, 28 Aug 2024 11:17:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 944476B0088; Wed, 28 Aug 2024 11:17:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 74AF86B0083 for ; Wed, 28 Aug 2024 11:17:46 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 251F54028E for ; Wed, 28 Aug 2024 15:17:46 +0000 (UTC) X-FDA: 82502008932.07.ED8A28E Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf05.hostedemail.com (Postfix) with ESMTP id BD2BF10001F for ; Wed, 28 Aug 2024 15:17:43 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=taF32QZJ; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=e90qolF2; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=taF32QZJ; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=e90qolF2; dmarc=none; spf=pass (imf05.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724858199; a=rsa-sha256; cv=none; b=znshKJV/E+DihnKsGb3TuGK0gQ1b8adhp27gRYwzQLJRK3KbZU3JM3cyrjpoJ2wWALAHAG +HcIxtSvgEFnm3b44TKpOiT9LDuuWjSlaw6ZIvLlZ1mMe7nOq/v0BDA39VwF2nv/UXxUDZ cKw5deMK7sar8mbyws7iGklI4qivQhY= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=taF32QZJ; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=e90qolF2; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=taF32QZJ; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=e90qolF2; dmarc=none; spf=pass (imf05.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724858199; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=uJECRILoADIqJX7fv/yRkwv2GKSTM5VzaC2WYjJPNvc=; b=dl/uNOvRiwwd4Te7BBZA8j7oJjnwXECL9H+rX9/KVGK1zkZHie8NPs5+GTAK9xIU//FkOo gSzYGTglR7U8eQDPc1Dg50B1eiXvlseNOY8VfmoUX6jD460PqyTmAcd1hzVYV1gbPTJ31g LYU4atPhF355cFtGL1trUi+HT/aH3xc= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 61E7D1FC31; Wed, 28 Aug 2024 15:17:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1724858262; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=uJECRILoADIqJX7fv/yRkwv2GKSTM5VzaC2WYjJPNvc=; b=taF32QZJ2sWasKz4vEbP+x0Xfp/gwPd87P6racxG/ieokiBdrgCOCtEMA3HEzZznZtsmU2 rJT6xZtGCTrxit7ch96PodN2EKjDs1OlL2mdLA/cG0PyrfqQFdluSXfX8ZBZfYP7S4cmca BNG1+YDHlyTV8OxH2q137HPRX+taJn4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1724858262; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=uJECRILoADIqJX7fv/yRkwv2GKSTM5VzaC2WYjJPNvc=; b=e90qolF2+jh7Y6TTOAgyXOQ1u7527iVkPZP+wRdvXAkibwlb4atchFg7vBGulrLweOYtqx 60sDpBy7er8L+gAg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1724858262; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=uJECRILoADIqJX7fv/yRkwv2GKSTM5VzaC2WYjJPNvc=; b=taF32QZJ2sWasKz4vEbP+x0Xfp/gwPd87P6racxG/ieokiBdrgCOCtEMA3HEzZznZtsmU2 rJT6xZtGCTrxit7ch96PodN2EKjDs1OlL2mdLA/cG0PyrfqQFdluSXfX8ZBZfYP7S4cmca BNG1+YDHlyTV8OxH2q137HPRX+taJn4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1724858262; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=uJECRILoADIqJX7fv/yRkwv2GKSTM5VzaC2WYjJPNvc=; b=e90qolF2+jh7Y6TTOAgyXOQ1u7527iVkPZP+wRdvXAkibwlb4atchFg7vBGulrLweOYtqx 60sDpBy7er8L+gAg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 4C4ED138D2; Wed, 28 Aug 2024 15:17:42 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 9P1UEpY/z2YqTQAAD6G6ig (envelope-from ); Wed, 28 Aug 2024 15:17:42 +0000 Message-ID: <59a935ee-7507-4b94-aefb-f0e5a740e935@suse.cz> Date: Wed, 28 Aug 2024 17:17:42 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 3/3] fs: use kmem_cache_create_rcu() Content-Language: en-US To: Christian Brauner , Jens Axboe , "Paul E. McKenney" , Roman Gushchin , Jann Horn , Linus Torvalds , Mike Rapoport , linux-mm@kvack.org Cc: linux-fsdevel@vger.kernel.org References: <20240828-work-kmem_cache-rcu-v3-0-5460bc1f09f6@kernel.org> <20240828-work-kmem_cache-rcu-v3-3-5460bc1f09f6@kernel.org> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: <20240828-work-kmem_cache-rcu-v3-3-5460bc1f09f6@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: BD2BF10001F X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: ntqe5af3btbcwhnqto3xbsk9qoymm16m X-HE-Tag: 1724858263-984352 X-HE-Meta: U2FsdGVkX183NWrrgbzGq0OwvVuTUXb3IYWnNc7zX3e37JLv/AtT6A2tx8WM7lNUOGMgWgX443oRkpELlhd/aGBtdJxnDNyc96b+VYaIpqEGoOetn+zFfc8IMKXk2dK2jZOjTJ/Z9EpwB7bF/ajDiUYmv968siPU3g5YKW0S5j4G6zHR85bCIQlgcB70nbtU7Vcg1mjZlOzTDCCvDp3qvAm9pwShgedv3PkoBPLbpmGBjvkVdv5JiO/hhkyASPrdlPHWKZ35KQbMKxulJpmBY8TYVGM4BOlJW9AOWXpJ3Nieg9/KsasCnQbMbINXEdL3VmFgu1rDWqqa7koy7mIXIiZR+0qIMAqIZtmT3CKzGgJV/sCxL2q2WfqEoRj/CLH9+Te58c9orRMt3wAEbrzgteMl9CSFjG/94XAbr4NOFsxEk6dBj1a8ba0fsF+hpJU3D4odsYevViyfetCpSserIQsHf0nI/1kXq8PATrK6vDocwMtRdqtVNSGVluIHcfhcty/j/hfopEJoK2tIvNb9Uporfd1GJXTiyMPDMx7t/AOq3iZ9hAXyumY2UyUIwCWwEDSmcPbZZWk3DnhpFBX6PF6g5BUeNhhoT1kFIyr7Gjou6lQZZlidVbTFTqlkvnSvSp3dB/rFCOigQ/wczFBCPOWpn2f4vhDSm7hpHNHrltA7KYx5G0sum3ZEsGInBkmHK90WH3EdkiKdOISg4nAS7mnrgneS8LoK0OUx2GsoozJm6T6WwyaIOk+X7X0Agz+QqkXpn7iazsv9vjff4dVcB+gWMn2xDCBV6pXiDq+ZDAxMseSdtFkHa0yothRGY/leJpD6r1KzSvTeswCxVvNsP/u8Jq7q1LENwZtBQScGpan+6I46626A/TxCOiJ7FFKklWmJExm7WPoqlhcU+oXIQrKZ0wH/zfdOVlqNvh1j0dtaDesKHIxdtbTyk17pkIYcKulhlwWEEGVfo5E/emD OYTV4A5N Ph53mQ6NFM5YY76f+Ck6jzzTrkkkzkI/JV1nRlTatqz/YS1tXxpmEuwQQvZJP5vtjWbb+JKQArrj+erXOkwu3nLVtu3hwtoJXoDAEQbyORC8kY3PKeoWEuF2eDJ3PzNClZH51AEXw40/AGXsDyFT98G1ggo8BsHqv+4pqAtLqonITO6dcY+uffRN2bPafMYiJ+phnLAvInmnp1SS1Dj43u1oab6qLWtJJkk9AsxX/dSYm4fiBYvUVIv1EyTYsRT8uFxkupZsE53wjgEDrz3IGXIVFJ2K/xNZ0wnpKKX4DYclmdDv7PMBhnv5n/uXhzbjDDyjn/x9rBRWCBUgB/QcWhy0eAEXie4LBvuiPalInDA8sCtAmfMaTP9v7B3R/137xbDJmsndev+Iactw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 8/28/24 12:56, Christian Brauner wrote: > Switch to the new kmem_cache_create_rcu() helper which allows us to use > a custom free pointer offset avoiding the need to have an external free > pointer which would grow struct file behind our backs. > > Signed-off-by: Christian Brauner Reviewed-by: Vlastimil Babka > --- > fs/file_table.c | 6 +++--- > include/linux/fs.h | 2 ++ > 2 files changed, 5 insertions(+), 3 deletions(-) > > diff --git a/fs/file_table.c b/fs/file_table.c > index 694199a1a966..83d5ac1fadc0 100644 > --- a/fs/file_table.c > +++ b/fs/file_table.c > @@ -514,9 +514,9 @@ EXPORT_SYMBOL(__fput_sync); > > void __init files_init(void) > { > - filp_cachep = kmem_cache_create("filp", sizeof(struct file), 0, > - SLAB_TYPESAFE_BY_RCU | SLAB_HWCACHE_ALIGN | > - SLAB_PANIC | SLAB_ACCOUNT, NULL); > + filp_cachep = kmem_cache_create_rcu("filp", sizeof(struct file), > + offsetof(struct file, f_freeptr), > + SLAB_HWCACHE_ALIGN | SLAB_PANIC | SLAB_ACCOUNT); > percpu_counter_init(&nr_files, 0, GFP_KERNEL); > } > > diff --git a/include/linux/fs.h b/include/linux/fs.h > index 61097a9cf317..5ca83e87adef 100644 > --- a/include/linux/fs.h > +++ b/include/linux/fs.h > @@ -1026,6 +1026,7 @@ static inline int ra_has_index(struct file_ra_state *ra, pgoff_t index) > * @f_task_work: task work entry point > * @f_llist: work queue entrypoint > * @f_ra: file's readahead state > + * @f_freeptr: Pointer used by SLAB_TYPESAFE_BY_RCU file cache (don't touch.) > */ > struct file { > atomic_long_t f_count; > @@ -1057,6 +1058,7 @@ struct file { > struct callback_head f_task_work; > struct llist_node f_llist; > struct file_ra_state f_ra; > + freeptr_t f_freeptr; > }; > /* --- cacheline 3 boundary (192 bytes) --- */ > } __randomize_layout >