From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A730C433B4 for ; Tue, 6 Apr 2021 20:43:09 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D2678613D3 for ; Tue, 6 Apr 2021 20:43:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D2678613D3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 0EBAC6B007E; Tue, 6 Apr 2021 16:43:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 075376B0080; Tue, 6 Apr 2021 16:43:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E2FDC6B0081; Tue, 6 Apr 2021 16:43:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0046.hostedemail.com [216.40.44.46]) by kanga.kvack.org (Postfix) with ESMTP id C010A6B007E for ; Tue, 6 Apr 2021 16:43:07 -0400 (EDT) Received: from smtpin38.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 735F8181AF5CC for ; Tue, 6 Apr 2021 20:43:07 +0000 (UTC) X-FDA: 78003116814.38.20908D8 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by imf07.hostedemail.com (Postfix) with ESMTP id A77F0A000398 for ; Tue, 6 Apr 2021 20:43:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1617741786; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UnZQcXnGhFwRyzIpQwSatIVPlAQ2VJahZyUBcx6HwSs=; b=KPmd8k2lRLQLeYSZMdKHbcRHXU/8CDiHkBnx36iKGpfGj4/DIMFU32VKNtLn6D0tuvk1CU 6EsL568fzvJMomq386o8qYsstLgytGO8JKDeVWtzPZ3T2G2gzK5M4Zd/XWkrO2SWlxjeb/ xnbG5vzZHdh2S5n+wy32WoZ2b3Cy6fU= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-403-JDbTC_tPPeyyN7oN7qLDeg-1; Tue, 06 Apr 2021 16:43:04 -0400 X-MC-Unique: JDbTC_tPPeyyN7oN7qLDeg-1 Received: by mail-wr1-f70.google.com with SMTP id z6so10531056wrh.11 for ; Tue, 06 Apr 2021 13:43:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:content-transfer-encoding:from:mime-version :subject:date:message-id:references:cc:in-reply-to:to; bh=ABBXBhlUARaxNFBWCMnGkuMbTapmBL2uS8R+F500nIk=; b=lLhpmzbVUsC7xQT5wC1tXyn+kjEMv45HAAlS/NnyPqWlOcEEqiNnCKq7FutIpwiX0v CfTUnOBXkYDxPCcMiAJ2EMnqFB13Oq6TcFJzqnzc9by8CzLgVgllQeunEmQNp0uXaHAc sHfaEK4HVzfhhT3D2f6DAfsBGn6Vuegn38AAM6J1XD6+VzE5xaPW0/UIT2ySKUMBS9Je wm2DE/aBYbVRYJp8zd7EDOzvKribsszOqRS/WA4XOnAOjxp+uTvR1sPQqbZoBsg98wW+ qGYoq7037UGfZs9s70q92v+4huI12rQGCfWV/zvO6CLUrJO6rPzohb2z84DG/60xH0dy VEPg== X-Gm-Message-State: AOAM5337lRlS5qqxMwMC8SjoN5eIZr6otr/sP9J8brc3dQ2MBzvUVfpY X7DKFViT0n3yngR62mSJhZhVS0BKeaYiR6iRBfbN2l2nRYU0ank24EmrXkuB4c6ynivYd1QSjjj NzS87g8ROBQw= X-Received: by 2002:a1c:2781:: with SMTP id n123mr3351447wmn.64.1617741783532; Tue, 06 Apr 2021 13:43:03 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzi8P3V1Fc945skdd7Z39U7VGP6wyqLM61CVsa2i65JB/d0PTHRzVoE1kDrMQA3cxs62iQfMA== X-Received: by 2002:a1c:2781:: with SMTP id n123mr3351436wmn.64.1617741783308; Tue, 06 Apr 2021 13:43:03 -0700 (PDT) Received: from [192.168.3.108] (p5b0c64ee.dip0.t-ipconnect.de. [91.12.100.238]) by smtp.gmail.com with ESMTPSA id v189sm4609990wme.39.2021.04.06.13.43.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 06 Apr 2021 13:43:02 -0700 (PDT) From: David Hildenbrand Mime-Version: 1.0 (1.0) Subject: Re: [PATCH v6 2/8] mm,memory_hotplug: Relax fully spanned sections check Date: Tue, 6 Apr 2021 22:43:01 +0200 Message-Id: <59A04B1D-08D6-4E71-A382-F5503A6E0AF7@redhat.com> References: Cc: David Hildenbrand , Andrew Morton , Michal Hocko , Anshuman Khandual , Pavel Tatashin , Vlastimil Babka , linux-mm@kvack.org, linux-kernel@vger.kernel.org In-Reply-To: To: Oscar Salvador X-Mailer: iPhone Mail (18D70) Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=david@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: A77F0A000398 X-Stat-Signature: t9nkwukzydtrerdhwipdei9phhich6bs Received-SPF: none (redhat.com>: No applicable sender policy available) receiver=imf07; identity=mailfrom; envelope-from=""; helo=us-smtp-delivery-124.mimecast.com; client-ip=216.205.24.124 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1617741786-827923 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > Am 06.04.2021 um 18:34 schrieb Oscar Salvador : >=20 > =EF=BB=BFOn 2021-04-06 17:32, David Hildenbrand wrote: >> I'd only relax start_pfn. That way the function is pretty much >> impossible to abuse for sub-section onlining/offlining. >> if (WARN_ON_ONCE(!nr_pages || >> !IS_ALIGNED(start_pfn, pageblock_nr_pages)) >> !IS_ALIGNED(start_pfn + nr_pages, PAGES_PER_SECTION))) >=20 > But this is not going to work. > When using memmap_on_memory, the nr of pages that online_pages() and offl= ine_pages() get might be less than PAGES_PER_SECTION, so this check will al= ways blow us up. But not end_pfn as given in my version or what am I missing? > --=20 > Oscar Salvador > SUSE L3 >=20