From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B4D2C77B7F for ; Tue, 24 Jun 2025 15:17:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CDDCE6B009E; Tue, 24 Jun 2025 11:17:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CB5536B009F; Tue, 24 Jun 2025 11:17:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BCB816B00A2; Tue, 24 Jun 2025 11:17:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id ACA446B009E for ; Tue, 24 Jun 2025 11:17:11 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 23C941D825A for ; Tue, 24 Jun 2025 15:17:11 +0000 (UTC) X-FDA: 83590647462.08.A5883DF Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf13.hostedemail.com (Postfix) with ESMTP id 6B1B72000F for ; Tue, 24 Jun 2025 15:17:08 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=K5gFFZjk; spf=pass (imf13.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750778228; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VS7WT/Myda/TmCCBpV0MVboU7jS+MnjU+H4FMQ/YZGE=; b=pIGQWBSHqdMIp506scgLNNJm670eg+kq2lybNIVzEmzULv/hre6D9z52Ty7/b60XlwodVv OJ7h+n/QvmpsxaVRhe/pf1ZVxT+BnFoZvDOXb1x60U2VC04hk+a9ZfhuYld/ewoIjJg6Vh dD5RfFok3SW9Z1hczXOmOjTchRXJC3M= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750778228; a=rsa-sha256; cv=none; b=0/kAZVCKk1qI5ajxTZ4lSgmI28c9S+0KMENBdeAtjqizfAv7wnciAqFlyXPZ+vHh2G2a1l 1hOJF7blkda87S8GGwaPVo5EiXiUoQ8kWnq4nteMMBsozf+cE+EvTpHA5Vrs0lR3xMT+GK /Kd74BLW1BELMhAAyuEow0Di37UA1Uk= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=K5gFFZjk; spf=pass (imf13.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1750778227; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=VS7WT/Myda/TmCCBpV0MVboU7jS+MnjU+H4FMQ/YZGE=; b=K5gFFZjkQIDbIJfuiXA+EUt60Ql6DEcHbBuhxyb+9TaBvTL4ghqSZ80+emq2lzIXH8uGuz uWzco2fi0mkgfNT1AnSyp3tC41RbkK5g4b4/cpXslLHHSb6Rkqqa1I/8fYHwqU9ViypL1A l4JN4bKmrYYK0wPwYPpvY3jRMtjmyV8= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-693-OnTqK_4mMxa2OG6qsSeb1Q-1; Tue, 24 Jun 2025 11:17:06 -0400 X-MC-Unique: OnTqK_4mMxa2OG6qsSeb1Q-1 X-Mimecast-MFC-AGG-ID: OnTqK_4mMxa2OG6qsSeb1Q_1750778225 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-45311704d1fso35261155e9.1 for ; Tue, 24 Jun 2025 08:17:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750778225; x=1751383025; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=VS7WT/Myda/TmCCBpV0MVboU7jS+MnjU+H4FMQ/YZGE=; b=T032lJ7ne6d/SrC/75iwxLqDlC1BwmTmbdc241U7hwsZBuVpA/TAJ+eO8YENXhieoh Mau/+x30vjFR1CNuZqDjMaLZ1nVg9MyQ+2W/YsSkNTVmmAhfYYWvXBvqp0uq+IwDM35R kckGtSX5ivGQYzIQCSvQV6R5G05dvF774a01MS905EPHHynhjHmW9Kvy1sgyq9kq0Ozj tJG7A70uoyZDqNs5xCL8D4jyJ6IBov/WP5lOBrgaLgYEqulqVxw86/m6/VAAaT9QSGVu DmqLW1bBhj4JovsiSmNaQqTpoK06punJOkrG0EeieXIJxsuA4D+LxdWcAoJf5k4YKOxD sjjQ== X-Forwarded-Encrypted: i=1; AJvYcCUlLqWvf+WQZhKLKO4avzxC6ai5i2DXa3tVORtnfHByU4sLluFpmTYeE2ZoEHuxKCJ2bdhTtlbA+g==@kvack.org X-Gm-Message-State: AOJu0YxGoLKUZuT+O/BOs/xFisQ3lvjkr4naflXmYdZGVZViHNbpqeB4 ai7P60Okbg6sIJN9JmA8CN67Xcz6qBEmTQHoDbYVqCKWcJ5JCbVV1F99YnJYuYiznwPaDCArFYY Snusbtl3O9kdZzRdK4eIH2BIAOwU1M8v3oCYlnM+ax/CLRAVugd+J X-Gm-Gg: ASbGncvIOrnv9ixLb8nZt8vSL5uaaprtN8WdvJWLRqqm8con829mCqq4JF8o6Frx8Wd 3PW6N+5swrUH7n4yp1mICr45vIAGEsbf52iM0+OtTjRifpqrAcTR/VLR46sQNXcqb2qISQRDVw/ V/eflgLR3K59WByx9DpFWcK3jtQHsBFbxWYIgBbtNqJuV1R/jYnI0HT5L1epHjGsqQY8drkj9L+ b2TF14TSixAbbaAkWE8LQJ7jl/Y9qghAUq3gQPT622f4GFyAn6H+ObFcisGEoRfb2kx0bUEqvZ0 OPdz2kwVbtDzb7rxwBxf3RgqFXXBDgP6wFwFAk1aFVEcCXoJ8y1r5XE= X-Received: by 2002:a05:6000:658:b0:3a6:d967:380c with SMTP id ffacd0b85a97d-3a6d9673f9bmr9519388f8f.36.1750778224781; Tue, 24 Jun 2025 08:17:04 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGSv/IC3WnCIKLIezWORbCvAwDH9oA+fiyrjemvNBVXt77tG6qvLLNil4gzlrJ9PXRneuaYQQ== X-Received: by 2002:a05:6000:658:b0:3a6:d967:380c with SMTP id ffacd0b85a97d-3a6d9673f9bmr9519353f8f.36.1750778224422; Tue, 24 Jun 2025 08:17:04 -0700 (PDT) Received: from ?IPV6:2a09:80c0:192:0:5dac:bf3d:c41:c3e7? ([2a09:80c0:192:0:5dac:bf3d:c41:c3e7]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a6e8050fd6sm2232351f8f.17.2025.06.24.08.17.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 24 Jun 2025 08:17:03 -0700 (PDT) Message-ID: <59788375-4010-48f9-b783-2d4c51c8d546@redhat.com> Date: Tue, 24 Jun 2025 17:17:02 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] selftests/mm: Fix UFFDIO_API usage with proper two-step feature negotiation To: Peter Xu Cc: Nadav Amit , Axel Rasmussen , Li Wang , Andrew Morton , linux-kselftest@vger.kernel.org, "open list:MEMORY MANAGEMENT" , Aruna Ramakrishna , Bagas Sanjaya , Catalin Marinas , Dave Hansen , Joey Gouly , Johannes Weiner , Keith Lucas , Ryan Roberts , Shuah Khan , Mike Rapoport References: <20250622081035.378164-1-liwang@redhat.com> <20250624042411.395285-1-liwang@redhat.com> <4fd18a1c-aba2-468a-881f-0507953f2904@redhat.com> <611F9598-A1A4-47B6-B37E-09BF7B4D17D0@gmail.com> <239f75e4-1868-4ac9-882f-664a8863b781@redhat.com> <495dc88a-c0b2-4090-a89c-00f000b62a2f@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: e-eWLrFHnwmC8wJCC4aDhi_7LMAdmIvdIalmiAU56fU_1750778225 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 6B1B72000F X-Stat-Signature: dso93s8b6dcibjq39trpzkj5fh5e1qn1 X-Rspam-User: X-HE-Tag: 1750778228-591729 X-HE-Meta: U2FsdGVkX18aVA4ez8iI0YoE1xU3Tsk2cpKk5xb2nOKoc/SrERqaljzujtt6tMDBJdR+DXUxUe9Vjqsfk82PgJu/8+/9Aw8SBm++nASyDy3l9K0AF6ilTAE63dRKf9kWAuYyXE11vOcA/Hm9/AihgiFHZ1GAeoz99U2kpakaYp/qbvD5HDpXJBf9IeiKm+cxZlJ0JnvwYIUGzSxZgu6wbsAjcFzrKrk18cwNeuHJMfMV9510/x9lcHlpWINCJ9d8JB/LKbrEA5eQo73JHbT844BTYFjIppsL01GVvlC/8oH9+ZCT5NuKFkeTiDv8wp8mXm/Ao+DAbtGT/l548fzJNo7OM3RTqin4OTp3qNaU3kXZmO2HcrmNRR6bsbZ03gfeiCjtEabjXTlAX56cv2ichs2CpMleRwgcL0QMyvQ1gp32/lBnmqg8SUGqh+Iyo0ssdSB04S51uRghd53ir43PIHFLNip+fHp/0+x4rkj6NmBwCQbcgIyR4K2r5GyBT2PE9UJ+m33jLCov9LuXmpMga2vcetmw5NH5WWagURoW7Ie3yLHH8fF1xQfZee3U9nQKzmsWjKW19RnbVuWtkb9Iya0p3XzEQiUlur7/mPVhZ+kWZL+QsiRhTD0tBrTjcvfilKFk/z5OdtEHzIdGQmyvhF2Dymh9fHVL1OYRR//Lq2QK3qydB1v/9zJLXNGGROm76IvgLxcSx7Rjy1sMAyDroj4WcvACdYPEFcjmnpZvjj/p+B6TJ30UfJbKxPx7xXqFbhJNBhsG1SM23DQ0qENMv6cHNaSPp9b0jEZyfd2xxrfCkro6XTTdALGXINALl/oMh53J2EHVTlcPUfsJxg443/wbiQjmG3Fp4ooLKKlO8QkdMNmBXqQPkCgF+LE5vUliIjB+iGmX6Jgx5xOJpdu+6TAkpn21at6N4ka0fm/t92YJ0IjO5M8IBeuqzL6zrMBxpO0+1EXcmy3KD0rRQUj sKcO6GEP JAIVMj3hHhTFOjjIQ5m+WTBnDLoGjoSuMzjVmwZh1yilYyR9hhx7kzBS8DY5fIp5mEbjoUlDyXYh7AOOMXxKNJm5p2mKuu8SQkd5OrF95I42HvydzcayJUzzlgWXdDSgdbxiT7ujCRL1m7GmUy6SxTUPEwwN7fE7FjwDByBVtKvakFVuv/+HtsZkDpfm5rdPu2INlr7EAv7k8mBTvho4PQCTtpPzh2jBAqcJswYuRP1lsQqIvbt30ap6d3y5OF/Rlq/SK4ys1ViNLveqi9KWIyhq5Ky936SP/msfGJq7F0qlIZbHZfDzhpKv77xFlauDw6aoyExnI34dp0VanI097BQgQ8lNiOB9RVae76LIoGa7PnG2ZuWRyf6pbOdTIKO1lIuhcy/aHvqwCvOjuX12FvL3UDgAGHOhoH9jgWxUnEdY10z7ueOULIauoPAy+DIyIBOeL+ASDtGPo8zp5VZXne0UEVLe9ySLuU95Bex4PHOjPpDDFlVcTAb0rjklfx6VdNeIvaErwsIPnMmUm9RdMIvrRC+BNQHV+B158A7VMLjH3ewX11JOrvTwGksIvs/+y8nTh0/0XbiiACOJdMUE2sba/E2zULy6529HM X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 24.06.25 17:03, Peter Xu wrote: > On Tue, Jun 24, 2025 at 01:48:50PM +0200, David Hildenbrand wrote: >> The man page was updated with >> >> commit db3d5cc1a17b0ace008ebe1eaf0ac4d96b4b519a >> Author: Axel Rasmussen >> Date: Tue Oct 3 12:45:44 2023 -0700 >> >> ioctl_userfaultfd.2: Correct and update UFFDIO_API ioctl error codes >> First, it is not correct that repeated UFFDIO_API calls result in >> EINVAL. This is true *if both calls enable features*, but in the case >> where we're doing a two-step feature detection handshake, the kernel >> explicitly expects 2 calls (one with no features set). So, correct this >> description. >> Then, some new error cases have been added to the kernel recently, and >> the man page wasn't updated to note these. So, add in descriptions of >> these new error cases. >> >> @Axel, did you ignore the automatically-set UFFD_FEATURE_INITIALIZED and the >> repeated calls never worked, or was there actually a time where repeated >> UFFDIO_API calls would not result in EINVAL? > > The man-pages was inaccurate before. It got updated recently after Kyle > asking similar questions, see: Ah, great, thanks! -- Cheers, David / dhildenb