From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D13AC48297 for ; Mon, 12 Feb 2024 18:12:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 270B36B0078; Mon, 12 Feb 2024 13:12:34 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 220AE6B007B; Mon, 12 Feb 2024 13:12:34 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0E8F26B007D; Mon, 12 Feb 2024 13:12:34 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id F21E86B0078 for ; Mon, 12 Feb 2024 13:12:33 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 962771C0B5D for ; Mon, 12 Feb 2024 18:12:33 +0000 (UTC) X-FDA: 81783946986.19.EF37EAB Received: from mail-ej1-f51.google.com (mail-ej1-f51.google.com [209.85.218.51]) by imf02.hostedemail.com (Postfix) with ESMTP id 762CA80013 for ; Mon, 12 Feb 2024 18:12:31 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=c1onU+3H; spf=pass (imf02.hostedemail.com: domain of eddyz87@gmail.com designates 209.85.218.51 as permitted sender) smtp.mailfrom=eddyz87@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707761551; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=r++RqVTTRmgIAA96TrA9uBfy6z0w+8s1Y0IlIAISWKA=; b=BYtOb8fPcQA8MGXBrIRiZ55agp5IJqpSzZBIQF10OQU6HXX3Y4GZFYAwDbLSkPvEw1cS4T T5UZ8Kk0frmheedIHGDBFcTSgyXJ4+sYy3FHu8ZdXf09seXpA86IxCz9HdnJe+kuDIfOh6 2m7h2nKeqpxjWne/NDbxY3xrSz6Gfsc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707761551; a=rsa-sha256; cv=none; b=Vz7ILeenVYYzDmpkwl4blFVKZD29qjULYLpqWwrQiypKJlWZhZFOGley0AjB1yoDyMrewa 42jdh3notkFb9ZJ6kchIGhopyXGLtXfZzzymPwJVMlYPCx/3901vfXYkl3H6RfSXqgEghw bN4P6Cnr72JLAOTRhtHzbceRPhbDDBY= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=c1onU+3H; spf=pass (imf02.hostedemail.com: domain of eddyz87@gmail.com designates 209.85.218.51 as permitted sender) smtp.mailfrom=eddyz87@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-ej1-f51.google.com with SMTP id a640c23a62f3a-a3ca40db065so131415566b.2 for ; Mon, 12 Feb 2024 10:12:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1707761550; x=1708366350; darn=kvack.org; h=mime-version:user-agent:content-transfer-encoding:autocrypt :references:in-reply-to:date:cc:to:from:subject:message-id:from:to :cc:subject:date:message-id:reply-to; bh=r++RqVTTRmgIAA96TrA9uBfy6z0w+8s1Y0IlIAISWKA=; b=c1onU+3H1vFPTPjVS2ai3G1ADcdUaTQXnB74l8QWw6LWXHJJdTcPOvi/x6VusjINwf Nt4mwpm/BHwI9kVfwbEEJwQy4zE7tvosUxVBWZ9y649tbUZMpXVjYCkcIMrJnwiqYuMe aOBTPQcoO4TwIvjAYUZTCU9Zpdg12vQE2//jIMX9i4qIuskw027vV97sjk3qZHQiTuhZ N5G0RRGLmV4AKp4QgCjagDv/V4wY8p9cJ79xPd+U6ZGUfhSpOIhd13msgNWXvdE7yacL z+tJlOj9GxzjdVNwTW4G46jtCU7Lkcj7sBbZYAw3xCqkTxLmziMFiTbuSDnYaj79sPDa 6ORw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707761550; x=1708366350; h=mime-version:user-agent:content-transfer-encoding:autocrypt :references:in-reply-to:date:cc:to:from:subject:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=r++RqVTTRmgIAA96TrA9uBfy6z0w+8s1Y0IlIAISWKA=; b=hk/508ca9nXZwp0KlssZaL068fgmpi3qg2qyd75DqzOTHmfypnNbqkMXAPd1A1Ss01 6HsJXuamZFnADU3ZmE3VCF5PK0x6d/+iIBhwda12r94Ak5YS7YLcEXV8MxydaxDR9FJn OZfNFc2EmTUqC3J6zZnO0wkS0qiVHzDk6EbWWyOOz20HGBaFPYfq8vq9xCH0TK02mKz0 rJyQLKxrPHqZkc624aqRxgEp9opks0iMsZjgfQMNl2aseVcWNZUTA6i31eD5J5rtmsdb qIjrSFEhapQRLfv6Ak+U8Uchrx/8S5DXD4YSmgsKdItombTMXtGhlE4Y0hGEfrryUcDs IPcQ== X-Forwarded-Encrypted: i=1; AJvYcCVRBliORTclXB04rZ/tFzm+LDIBpFDGPeUzd1RE+/9uYlTB1JVQF8+SmdB/bB1Tos4BlNm8OtNeG4+SGS5+MM8D/Rs= X-Gm-Message-State: AOJu0YxPze/SLQsrfSNT19vMBM/dJWM/nQgHlLBMqNnYc7SHFACvCW4C JWh3f1Cdc96wR+CsMYVkQF1D1tmi2cPY3HXkdslcOYbDx1Mbi6dx X-Google-Smtp-Source: AGHT+IGsffcSjpQMeW19JrV2Xf+QsmR2my5S7mHLKH+jhdQoICPJ4mPnG7c7REPVTBy+DP1EkzGh6A== X-Received: by 2002:a17:906:a40b:b0:a3c:31d0:592b with SMTP id l11-20020a170906a40b00b00a3c31d0592bmr4848274ejz.11.1707761549652; Mon, 12 Feb 2024 10:12:29 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCWqeZpSIOi0t+tR86P4W5Aaq9YfJMHgfLA62n7DEPrgs6jVmdF+3F+919/KglI0xfooT/iw2/g8wfR+G4YXM2/cdfE+fJ5oA/+TVtJlejv0dIFsTo44e4QJeZk8sP6O4tRJHOam3XLjz0hdQWEnS4wKSImpF2min7RGe+a32zxNtt26iT6drcdnth5Zq5tg7orwSiEnS/gmdRywGqlkVUp/Nzf8JAyCGqCtkbhdXjhLeOtQIvRrY5mhBxgn2onP9NFeJviajG/bCvAjCbOEjNUq3pLPHnESATeOWO8EU/iBv/BVqXw1vizqyCKfoAMBv6WDbpsfyK3aoCPXRpjp1dnwWzFMps1o1d7MN00SVvUS0Cv7X9JmL/5+ Received: from [192.168.1.94] (host-176-36-0-241.b024.la.net.ua. [176.36.0.241]) by smtp.gmail.com with ESMTPSA id bq24-20020a170906d0d800b00a3bd84233b2sm437715ejb.85.2024.02.12.10.12.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Feb 2024 10:12:29 -0800 (PST) Message-ID: <59623808ebfd5ecd48cdb4c07a28326d777e7769.camel@gmail.com> Subject: Re: [PATCH v2 bpf-next 12/20] libbpf: Add support for bpf_arena. From: Eduard Zingerman To: Alexei Starovoitov , bpf@vger.kernel.org Cc: daniel@iogearbox.net, andrii@kernel.org, memxor@gmail.com, tj@kernel.org, brho@google.com, hannes@cmpxchg.org, lstoakes@gmail.com, akpm@linux-foundation.org, urezki@gmail.com, hch@infradead.org, linux-mm@kvack.org, kernel-team@fb.com Date: Mon, 12 Feb 2024 20:12:27 +0200 In-Reply-To: <20240209040608.98927-13-alexei.starovoitov@gmail.com> References: <20240209040608.98927-1-alexei.starovoitov@gmail.com> <20240209040608.98927-13-alexei.starovoitov@gmail.com> Autocrypt: addr=eddyz87@gmail.com; prefer-encrypt=mutual; keydata=mQGNBGKNNQEBDACwcUNXZOGTzn4rr7Sd18SA5Wv0Wna/ONE0ZwZEx+sIjyGrPOIhR14/DsOr3ZJer9UJ/WAJwbxOBj6E5Y2iF7grehljNbLr/jMjzPJ+hJpfOEAb5xjCB8xIqDoric1WRcCaRB+tDSk7jcsIIiMish0diTK3qTdu4MB6i/sh4aeFs2nifkNi3LdBuk8Xnk+RJHRoKFJ+C+EoSmQPuDQIRaF9N2m4yO0eG36N8jLwvUXnZzGvHkphoQ9ztbRJp58oh6xT7uH62m98OHbsVgzYKvHyBu/IU2ku5kVG9pLrFp25xfD4YdlMMkJH6l+jk+cpY0cvMTS1b6/g+1fyPM+uzD8Wy+9LtZ4PHwLZX+t4ONb/48i5AKq/jSsb5HWdciLuKEwlMyFAihZamZpEj+9n91NLPX4n7XeThXHaEvaeVVl4hfW/1Qsao7l1YjU/NCHuLaDeH4U1P59bagjwo9d1n5/PESeuD4QJFNqW+zkmE4tmyTZ6bPV6T5xdDRHeiITGc00AEQEAAbQkRWR1YXJkIFppbmdlcm1hbiA8ZWRkeXo4N0BnbWFpbC5jb20+iQHUBBMBCgA+FiEEx+6LrjApQyqnXCYELgxleklgRAkFAmKNNQECGwMFCQPCZwAFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AACgkQLgxleklgRAlWZAv/cJ5v3zlEyP0/jMKQBqbVCCHTirPEw+nqxbkeSO6r2FUds0NnGA9a6NPOpBH+qW7a6+n6q3sIbvH7jlss4pzLI7LYlDC6z+egTv7KR5X1xFrY1uR5UGs1beAjnzYeV2hK4yqRUfygsT0Wk5e4FiNBv4+DUZ8r0cNDkO6swJxU55DO21mcteC147+4aDoHZ40R0tsAu+brDGSSoOPpb0RWVsEf9XOBJqWW A+T7mluw nYzhLWGcczc6J71q1Dje0l5vIPaSFOgwmWD4DA+WvuxM/shH4rtWeodbv iCTce6yYIygHgUAtJcHozAlgRrL0jz44cggBTcoeXp/atckXK546OugZPnl00J3qmm5uWAznU6T5YDv2vCvAMEbz69ib+kHtnOSBvR0Jb86UZZqSb4ATfwMOWe9htGTjKMb0QQOLK0mTcrk/TtymaG+T4Fsos0kgrxqjgfrxxEhYcVNW8v8HISmFGFbqsJmFbVtgk68BcU0wgF8oFxo7u+XYQDdKbI1uQGNBGKNNQEBDADbQIdo8L3sdSWGQtu+LnFqCZoAbYurZCmUjLV3df1b+sg+GJZvVTmMZnzDP/ADufcbjopBBjGTRAY4L76T2niu2EpjclMMM3mtrOc738Kr3+RvPjUupdkZ1ZEZaWpf4cZm+4wH5GUfyu5pmD5WXX2i1r9XaUjeVtebvbuXWmWI1ZDTfOkiz/6Z0GDSeQeEqx2PXYBcepU7S9UNWttDtiZ0+IH4DZcvyKPUcK3tOj4u8GvO3RnOrglERzNCM/WhVdG1+vgU9fXO83TB/PcfAsvxYSie7u792s/I+yA4XKKh82PSTvTzg2/4vEDGpI9yubkfXRkQN28w+HKF5qoRB8/L1ZW/brlXkNzA6SveJhCnH7aOF0Yezl6TfX27w1CW5Xmvfi7X33V/SPvo0tY1THrO1c+bOjt5F+2/K3tvejmXMS/I6URwa8n1e767y5ErFKyXAYRweE9zarEgpNZTuSIGNNAqK+SiLLXt51G7P30TVavIeB6s2lCt1QKt62ccLqUAEQEAAYkBvAQYAQoAJhYhBMfui64wKUMqp1wmBC4MZXpJYEQJBQJijTUBAhsMBQkDwmcAAAoJEC4MZXpJYEQJkRAMAKNvWVwtXm/WxWoiLnXyF2WGXKoDe5+itTLvBmKcV/b1OKZF1s90V7WfSBz712eFAynEzyeezPbwU8QBiTpZcHXwQni3 IYKvsh7s t1iq+gsfnXbPz5AnS598ScZI1oP7OrPSFJkt/z4acEbOQDQs8aUqrd46PV jsdqGvKnXZxzylux29UTNby4jTlz9pNJM+wPrDRmGfchLDUmf6CffaUYCbu4FiId+9+dcTCDvxbABRy1C3OJ8QY7cxfJ+pEZW18fRJ0XCl/fiV/ecAOfB3HsqgTzAn555h0rkFgay0hAvMU/mAW/CFNSIxV397zm749ZNLA0L2dMy1AKuOqH+/B+/ImBfJMDjmdyJQ8WU/OFRuGLdqOd2oZrA1iuPIa+yUYyZkaZfz/emQwpIL1+Q4p1R/OplA4yc301AqruXXUcVDbEB+joHW3hy5FwK5t5OwTKatrSJBkydSF9zdXy98fYzGniRyRA65P0Ix/8J3BYB4edY2/w0Ip/mdYsYQljBY0A== Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.50.3 MIME-Version: 1.0 X-Stat-Signature: o5dfuen9cgy5z3yzt37baankxr48bxjx X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 762CA80013 X-Rspam-User: X-HE-Tag: 1707761551-143931 X-HE-Meta: U2FsdGVkX18+52upEZPyvbMyW8qhTPnZgseACPsJZ3PCnDmz04d9yOFpS99Ih1d5XaV+VKYsBlsNfifY0OGviMzQn3+0ogmaGqSGn1UBWMQyNw9Fz9xVsWP+DLjLySx0buJ/zPzdXeimu/OpVqJVvsefSrDCvMOgfW1IOeg0H/TL0ByWuladNbdZkYa1WvY4SqaNAl3EXFJED7LRusSZo3jK7DcCU9XT0ilx5am6Hm9mMSTylx0Jy1ugnNWhKbT6vhW6GxqvSa4mvLtXlGV5+A4jjyBgRx7V89mTFH3IQNxc4qcqQKeWehEzjNd+KshSEIuhYkOkQ+O4gj8R40QYq5F+OtIDeM6FOGPTnfZ2O6svj9BORkqNXLKXnBvoL+iOTJ3tHWUZRVvCZr8h3PLBZEiHwO4AVh/JnI/5xWjfRH+MJ7AUi/73X2LvTi4gPNo4JSm/Qe9fPnNoSOPw2H1LSECkBlCuwyHATqfFBbM3IUsD9+ae7EH/kt/Gz1JGAByASkEw11T7AUjERbKioA8YSgeo4Sj9r3/Vx3YPTbBGsQzSvZ+AEp9f3lrXNsXeaORLcyXGmGJ8mEacH6lb6FNcuCQN9u2LEtsiN8WWowLRuV4fS3iR04Ys4kDWQEe+EnIh05PjZEwolLByWjxS6j9D/uE2sj3Vil2VFBU2Rh8BQ9cTSgVS5c1F66NGBzWGWcpzLMIs9ZqQIbf4zh+tYWboLPV+/QeIvGia7TNTYiGb/NjtlPduBxBSf9m1Wxsf0YjMoy3WTwIP4mHvECsx3Vv05f+jNDZqsDMCJLNHf8OiyO+CU6rJPWxyAhyDGG/H7geo6UraK//Ry6+kEUR09CN5DcH6deQKnzuJtnK2zXLNxeDtRBH7vIvTKPZLp5jgRxF2J9PTfNvIxCTlkVTjslTDsSTS7p7BtmsXd2XP62DtslyC8ohMwI0jpagTExlMK0Vk+OzMJpaqMAh7IXmIVtH MaglsZCD rD14pUdV9dnis3cGTz4E3gy43+zK3gbwsCRyupBSqKgOHSVpVnCanfHqupGrG6O1Q2nBmznyeXcAvVhh0AiCh6CHdQo6J4G9gKFfRMKUB4s93M5lXaOPJUnvvgpVLO4BXJxKi/0PPGZP0DhzlmvUCmwtk5DdhYANTiNivuBs8WyqLq4zh11/YeGZQBsrwafv/MfI70lCWgSAgnhaTPZmfob4ygT+WP649JFPwNE4sM0AKsLLYG8JpIU6OasaxaUHgWlZeSkplfmJjVEUde4XuV+bmsPJOZ3gvoVdScsjnyfeKlleDMv3VHTBegKknz6gSqw8h9HwD8fD4DkIypaQHHMOrpeP2g9Jyfi0u8ieC4i+qI+NjwxR5bxKvNx/yQUuK2hL+6QehDnUJwa/M/ZYIQTNpVueDizSBYnWgdBGT26vgBb6fimTpvX8wriP0qcr8CpgvZ8sNGQq5O4jniWoHdIUU3vEIhwg/rX6eXeS8ktYiKga2auvWrfcvBRWsO9xz395bi/0ULwgS/eZVG/OI9ItlfI8Vxp4x3WnQ26hJ1KEXJ0A= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 2024-02-08 at 20:06 -0800, Alexei Starovoitov wrote: [...] > @@ -9830,8 +9861,8 @@ int bpf_map__set_value_size(struct bpf_map *map, __= u32 size) > int err; > size_t mmap_old_sz, mmap_new_sz; > =20 > - mmap_old_sz =3D bpf_map_mmap_sz(map->def.value_size, map->def.max_entr= ies); > - mmap_new_sz =3D bpf_map_mmap_sz(size, map->def.max_entries); > + mmap_old_sz =3D bpf_map_mmap_sz(map); > + mmap_new_sz =3D __bpf_map_mmap_sz(size, map->def.max_entries); > err =3D bpf_map_mmap_resize(map, mmap_old_sz, mmap_new_sz); > if (err) { > pr_warn("map '%s': failed to resize memory-mapped region: %d\n", I think that as is bpf_map__set_value_size() won't work for arenas. The bpf_map_mmap_resize() does the following: static int bpf_map_mmap_resize(struct bpf_map *map, size_t old_sz, size_t n= ew_sz) { ... mmaped =3D mmap(NULL, new_sz, PROT_READ | PROT_WRITE, MAP_SHARED | MAP_ANO= NYMOUS, -1, 0); ... memcpy(mmaped, map->mmaped, min(old_sz, new_sz)); munmap(map->mmaped, old_sz); map->mmaped =3D mmaped; ... } Which does not seem to tie the new mapping to arena, or am I missing someth= ing?