From: "Huang, Kai" <kai.huang@intel.com>
To: "tianwentong2000@gmail.com" <tianwentong2000@gmail.com>,
"jarkko@kernel.org" <jarkko@kernel.org>,
"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>
Cc: "linux-sgx@vger.kernel.org" <linux-sgx@vger.kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"mingo@redhat.com" <mingo@redhat.com>,
"tglx@kernel.org" <tglx@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"bp@alien8.de" <bp@alien8.de>, "x86@kernel.org" <x86@kernel.org>
Subject: Re: [PATCH v2] x86/sgx: use vm_flags_t for vm_prot_bits
Date: Thu, 22 Jan 2026 20:56:56 +0000 [thread overview]
Message-ID: <5961c2655b49a7d384140c33d6897e53f89cb5fe.camel@intel.com> (raw)
In-Reply-To: <20260122133633.79792-1-tianwentong2000@gmail.com>
On Thu, 2026-01-22 at 21:36 +0800, Wentong Tian wrote:
> The vm_flags_t type is the dedicated type for virtual memory flags.
> Architecture and driver code should use this type instead of assuming
> vm_flags is an unsigned long, as the underlying type may change in the
> future.
>
> This follows the cleanup in commit d75fa3c94750 ("mm: update
> architecture and driver code to use vm_flags_t") by converting the
> remaining vm_prot_bits usage in SGX code. Also, update the vm_max_prot_bits
> type in struct sgx_encl_page to vm_flags_t for consistency.
>
> No functional change intended.
>
> Signed-off-by: Wentong Tian <tianwentong2000@gmail.com>
> ---
> v2:
> - Also convert the type of vm_max_prot_bits in struct sgx_encl_page
> to vm_flags_t, as suggested.
Hmm I was actually just pointing out, but not suggesting, since I am not
sure (honestly).
Back to technical:
Gcc doc says:
A structure field declaration with an integer type can specify the
number of bits the field should occupy. We call that a bit field.
With vm_flags_t I think "theoretically" it could stop being integer type
someday. But I guess the advantage is when someone does that that can
trigger build error here (so that we can be aware) which perhaps isn't a
bad thing?
next prev parent reply other threads:[~2026-01-22 20:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-22 13:36 Wentong Tian
2026-01-22 20:56 ` Huang, Kai [this message]
2026-01-23 6:23 ` TwT pupupu
2026-01-23 7:58 ` Huang, Kai
2026-01-25 14:46 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5961c2655b49a7d384140c33d6897e53f89cb5fe.camel@intel.com \
--to=kai.huang@intel.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=jarkko@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-sgx@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@kernel.org \
--cc=tianwentong2000@gmail.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox