From: Rik van Riel <riel@surriel.com>
To: Baolin Wang <baolin.wang@linux.alibaba.com>,
akpm@linux-foundation.org, david@kernel.org
Cc: catalin.marinas@arm.com, will@kernel.org,
lorenzo.stoakes@oracle.com, ryan.roberts@arm.com,
Liam.Howlett@oracle.com, vbabka@suse.cz, rppt@kernel.org,
surenb@google.com, mhocko@suse.com, harry.yoo@oracle.com,
jannh@google.com, willy@infradead.org, baohua@kernel.org,
dev.jain@arm.com, axelrasmussen@google.com, yuanchu@google.com,
weixugc@google.com, hannes@cmpxchg.org,
zhengqi.arch@bytedance.com, shakeel.butt@linux.dev,
linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/5] mm: support batched checking of the young flag for MGLRU
Date: Tue, 24 Feb 2026 17:12:48 -0500 [thread overview]
Message-ID: <5957cdb584cad9007a58f43fb5a1c3b737fb0159.camel@surriel.com> (raw)
In-Reply-To: <84d2426c63c1eafeaa0cfbad7c5cc11e9c11b980.1771897150.git.baolin.wang@linux.alibaba.com>
On Tue, 2026-02-24 at 09:56 +0800, Baolin Wang wrote:
> Use the batched helper clear_young_ptes_notify() to check and clear
> the
> young flag to improve the performance during large folio reclamation
> when
> MGLRU is enabled.
>
> Meanwhile, we can also support batched checking the young and dirty
> flag
> when MGLRU walks the mm's pagetable to update the folios' generation
> counter. Since MGLRU also checks the PTE dirty bit, use
> folio_pte_batch_flags()
> with FPB_MERGE_YOUNG_DIRTY set to detect batches of PTEs for a large
> folio.
>
> Then we can remove the ptep_clear_young_notify() since it has no
> users now.
>
> Signed-off-by: Baolin Wang <baolin.wang@linux.alibaba.com>
>
I'm not entirely happy with how much code is duplicated
between MGLRU and classic LRU, but merging duplicate
functionality seems like a thing for a separate patch.
This one looks good to me.
Reviewed-by: Rik van Riel <riel@surriel.com>
--
All Rights Reversed.
next prev parent reply other threads:[~2026-02-24 22:13 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-24 1:56 [PATCH 0/5] " Baolin Wang
2026-02-24 1:56 ` [PATCH 1/5] mm: use inline helper functions instead of ugly macros Baolin Wang
2026-02-24 2:36 ` Rik van Riel
2026-02-24 7:09 ` Barry Song
2026-02-24 1:56 ` [PATCH 2/5] mm: rmap: add a ZONE_DEVICE folio warning in folio_referenced() Baolin Wang
2026-02-24 2:38 ` Rik van Riel
2026-02-24 5:49 ` Baolin Wang
2026-02-24 6:34 ` Alistair Popple
2026-02-24 1:56 ` [PATCH 3/5] mm: add a batched helper to clear the young flag for large folios Baolin Wang
2026-02-24 22:03 ` Rik van Riel
2026-02-25 2:05 ` Baolin Wang
2026-02-24 1:56 ` [PATCH 4/5] mm: support batched checking of the young flag for MGLRU Baolin Wang
2026-02-24 22:12 ` Rik van Riel [this message]
2026-02-24 1:56 ` [PATCH 5/5] arm64: mm: implement the architecture-specific test_and_clear_young_ptes() Baolin Wang
2026-02-25 0:23 ` Rik van Riel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5957cdb584cad9007a58f43fb5a1c3b737fb0159.camel@surriel.com \
--to=riel@surriel.com \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=axelrasmussen@google.com \
--cc=baohua@kernel.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=catalin.marinas@arm.com \
--cc=david@kernel.org \
--cc=dev.jain@arm.com \
--cc=hannes@cmpxchg.org \
--cc=harry.yoo@oracle.com \
--cc=jannh@google.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=mhocko@suse.com \
--cc=rppt@kernel.org \
--cc=ryan.roberts@arm.com \
--cc=shakeel.butt@linux.dev \
--cc=surenb@google.com \
--cc=vbabka@suse.cz \
--cc=weixugc@google.com \
--cc=will@kernel.org \
--cc=willy@infradead.org \
--cc=yuanchu@google.com \
--cc=zhengqi.arch@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox