From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4DA4ECD11C2 for ; Wed, 10 Apr 2024 12:34:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 686866B0083; Wed, 10 Apr 2024 08:34:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 635696B0085; Wed, 10 Apr 2024 08:34:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4AF6D6B0087; Wed, 10 Apr 2024 08:34:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 227366B0083 for ; Wed, 10 Apr 2024 08:34:45 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id D55AEC0639 for ; Wed, 10 Apr 2024 12:34:44 +0000 (UTC) X-FDA: 81993566088.17.84E47DA Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf07.hostedemail.com (Postfix) with ESMTP id 3313F40025 for ; Wed, 10 Apr 2024 12:34:41 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=HrOLe9+q; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf07.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712752482; a=rsa-sha256; cv=none; b=JMwfONSe9Vgx84kGpiZ82HQTplP9k9PV7IHCTaEoU5YCGGMfV23+vkvWOENtnEz92zh1dd ZUtr1HptlPf+P4K8qO9T7ulnbOj64S+jd8nsLpn1r+JHdDdXIGVIIDnb+Oa9PcERqBeVm+ NtJ6LMhmlPqJSPqYi/gE7qxk4e/yPgo= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=HrOLe9+q; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf07.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712752482; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SGeEQTYX/N6LJYhZCdDmcWoBaL25Lib85+jnSFUMr0o=; b=kKIXoGfd5jx4R2jkgOpVNYUYDvgor/NAvDUFtxtRzPRCpW0Pn49wVYq9vNTSQ0PC/b72bN HBzoH5Z4CrrwbQbqyaL76Z798w+ACeaT6GGWE5/kPG1kPCKvsg7Ruplp0R/5fZLmB1BLmC Z9K+QCVOi5Qz+tzh18XjhQzTQ1ZZzLE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1712752480; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=SGeEQTYX/N6LJYhZCdDmcWoBaL25Lib85+jnSFUMr0o=; b=HrOLe9+qy/uR0mN75ujQ7l1wb4A5HaMxamhn9dUwFwis+UFyUwFm+CSRWdGwXxXTajRkOW j29cVJnPkoc9FOr2RlPp6nnf1rxz6nVPcN+KJhVUUlt1VTZOJZ41KE6tIiRDN3FyyK7mgG BcslFmaCZzFwryla73OXtKn8swHyi2g= Received: from mail-lf1-f70.google.com (mail-lf1-f70.google.com [209.85.167.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-65-t7d6I5dHP-WK8tU9sA83rA-1; Wed, 10 Apr 2024 08:34:39 -0400 X-MC-Unique: t7d6I5dHP-WK8tU9sA83rA-1 Received: by mail-lf1-f70.google.com with SMTP id 2adb3069b0e04-516d6c879c5so2432376e87.3 for ; Wed, 10 Apr 2024 05:34:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712752477; x=1713357277; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=SGeEQTYX/N6LJYhZCdDmcWoBaL25Lib85+jnSFUMr0o=; b=E3nD1Eq78THvTKnIP2Ktuj0nvhHFNrdBM/1JAj9nKCzRdenwTeanL8xpv3vnR11zSZ OE+MWAKfA3DRkDZxEBkH2YmFhDQPYblX3ssIGDYwqjOhak4rKZ+eGhkBDP59SGyIq785 wOX8LTDl9kwjGJVYG8tkwZPKOfKevcuvcLVcEOy1kb3sREk44n1MZbCgC1Bd00BiqzzJ PSfoGk10OUIrCVHMBJtfoPTi8amlR2sMTNAPEpnhrq8xyIDFtXrXVkX+1u2IQeE3y+VD igsKqYPxXQrrfcJ3IyZ/ZjXOlpWwpkp5c4awFAFMvMQ9C/ygwJ07d11hf+k42op4YCpe 7hfA== X-Forwarded-Encrypted: i=1; AJvYcCW0tX8q5LBlvo/58xn6wBjtBSJKhJAOpLRAVMxY4eAoYEJsTbzHCKfvDADC51KTG1qkXPjbY4u/9rqPKEh8wMoq5Eo= X-Gm-Message-State: AOJu0YyZJsxErvE5HRMe+WMxW9HU5dTh09uRBShZDLbxBDPDqnhCr9nq Fz7oR1MtM95ybi78HG4K9iUiBtvlqiUHkpqV6veIQej2/E3UcZJgK5MknSjljGiLsMmUxiadOZO lkW44ZxvxmwTxzCj2gtcTdhx1ZIaVuGN9kdmzu6UdKzZGj+eC X-Received: by 2002:a05:6512:1249:b0:516:a302:f29c with SMTP id fb9-20020a056512124900b00516a302f29cmr2497238lfb.55.1712752477513; Wed, 10 Apr 2024 05:34:37 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGdIoQWgnS6VH8XnM/nKKzpVauhZ/seIZDhMORj8oKiPpegF33cCQt2WaXIAM0gbW4TLiGR9g== X-Received: by 2002:a05:6512:1249:b0:516:a302:f29c with SMTP id fb9-20020a056512124900b00516a302f29cmr2497221lfb.55.1712752477099; Wed, 10 Apr 2024 05:34:37 -0700 (PDT) Received: from ?IPV6:2003:cb:c712:fa00:38eb:93ad:be38:d469? (p200300cbc712fa0038eb93adbe38d469.dip0.t-ipconnect.de. [2003:cb:c712:fa00:38eb:93ad:be38:d469]) by smtp.gmail.com with ESMTPSA id d11-20020adff84b000000b0033e7a102cfesm13679872wrq.64.2024.04.10.05.34.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 10 Apr 2024 05:34:36 -0700 (PDT) Message-ID: <594dbec7-b560-44e5-a684-93dcb8ba85df@redhat.com> Date: Wed, 10 Apr 2024 14:34:35 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/shmem: Inline shmem_is_huge() for disabled transparent hugepages To: Sumanth Korikkar , akpm@linux-foundation.org, linux-mm@kvack.org Cc: hughd@google.com, hca@linux.ibm.com, gor@linux.ibm.com, agordeev@linux.ibm.com, iii@linux.ibm.com, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org References: <20240409155407.2322714-1-sumanthk@linux.ibm.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240409155407.2322714-1-sumanthk@linux.ibm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 3313F40025 X-Stat-Signature: 7xjnmqzbkx8dfbf7sdtagq8n8qihwstg X-HE-Tag: 1712752481-592969 X-HE-Meta: U2FsdGVkX19V6ajNeTAwUoGbr1b0fxg+WJmBP0cwxKNlHsapwdOySLVK9+rPag4DoBaTIYKLouJ5XydYzg8ruofll6qsNAHlAIYI+jewxVrGAG7YBXvTBVH1gAtON97Lj93FQLQSgwNUrzz0QqiXS+ce92r2uIVsDAcTZDVBB+2mi0tMZ/FwsOJ4/eyOqjhiS8MrYBK8crxrE+jKOWXz2+iDb01Nb3Zgndh5gkDvD4J1B0us4dRek9cf1BY56F/CnJgxEsALiS6MTdzkwoGo0Txa9Ec3NbVaduOKd7Y1o6FimF0X5WaZxc/AHEe/FyCgTe0UfkMsLf4J4HYeat6naeHWzxrXD/R0b68p6dhBd/S55RFiIB5KH5fdIoDauXZ8zHwi4JTnbajrpWBoLpeWwUjLq2O+R1awfQn9tyvp7cj/LHAK8EoDMEuaD0JuxiSzAeXU29lD536NjMwaU0GDf7kJ5/dEZwuafZo1Kg+UZ6UZPIxlgMlD92czBNezHm7IQk24ibqnTtUXytbR6beQx7SZ63GWrTIaToNHkYXcBDc6SN98l9WQz9evjUcgpTZKhC7NMvbcwrAGK/ZU2zS0Sh9phDZbOC4OAKpX8yVQzuHb+nP1cFuBv/m/h5w1KDsCo1k6osOLy/llQo+4s3Z261EEeMNdTgwt/pYStar5ZTodKJ3ZhNBTZBw3VnN3aYUW0eWwOCALfBFVyJaiGIC1lenZKjlDCVwltRGrEfXA0brtKRvH1FwF66cAtOJOeBkFg8uoskJ3bnoGoeTfgBOFyjUdsAkllutzoPo3lyEzBMPVYcu04btlNuSkZaEpJaUFmQw90pffkIXlcS1sUTAZyd0ap6MNt+0lULXYset2M8J3vuT6HCgmqJi4tVEiWPuPzAyAHV8aXAMrPhZIudB0hp7g9Qx7Rlz7/i0Hl5xiiwk7S8+CvjUnoKIlUR8lghcVKs8XOGdK+X46Tw95lwu t5dMIyY+ rPklYg5ez+omumxwhrYz7y60Fjdi4lz8H2uEmPdDp+LxVcm2MeJxaQYrYq/JPg/MfwBY9DJnhB2ue5mNzQMhjrVXb09YU8iUu/5OR/5sggbYGhFfTUB7tygeROfv0dMMbetjodOHd9cz+0C8ZgG2j2aGmZ0yLbb62hrlI9mSiFZ0oPzRc6nNkKg8DosBpSLnUMjEUsglUlW/hC5z22sLt/nXZDA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000056, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 09.04.24 17:54, Sumanth Korikkar wrote: > In order to minimize code size (CONFIG_CC_OPTIMIZE_FOR_SIZE=y), > compiler might choose to make a regular function call (out-of-line) for > shmem_is_huge() instead of inlining it. When transparent hugepages are > disabled (CONFIG_TRANSPARENT_HUGEPAGE=n), it can cause compilation > error. > > mm/shmem.c: In function ‘shmem_getattr’: > ./include/linux/huge_mm.h:383:27: note: in expansion of macro ‘BUILD_BUG’ > 383 | #define HPAGE_PMD_SIZE ({ BUILD_BUG(); 0; }) > | ^~~~~~~~~ > mm/shmem.c:1148:33: note: in expansion of macro ‘HPAGE_PMD_SIZE’ > 1148 | stat->blksize = HPAGE_PMD_SIZE; > > To prevent the possible error, always inline shmem_is_huge() when > transparent hugepages are disabled. > Do you know which commit introduced that? -- Cheers, David / dhildenb