From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70488C77B7A for ; Wed, 31 May 2023 01:21:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D0322900004; Tue, 30 May 2023 21:21:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CB2C2900002; Tue, 30 May 2023 21:21:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BC8FF900004; Tue, 30 May 2023 21:21:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id AC74F900002 for ; Tue, 30 May 2023 21:21:38 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 690D41A0360 for ; Wed, 31 May 2023 01:21:38 +0000 (UTC) X-FDA: 80848797876.29.458A913 Received: from smtpbgau1.qq.com (smtpbgau1.qq.com [54.206.16.166]) by imf30.hostedemail.com (Postfix) with ESMTP id 2315480017 for ; Wed, 31 May 2023 01:21:34 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf30.hostedemail.com: domain of gouhao@uniontech.com designates 54.206.16.166 as permitted sender) smtp.mailfrom=gouhao@uniontech.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1685496096; a=rsa-sha256; cv=none; b=ic+wVqB+3hJk4xeT0/7QZj5pMcN5+b+FlGGvbSztXNkCadJGyt6oSd8ZTgTKNx/VNEd3jN A7aYmEaNIn7TepT5X0nHGpChh3A3Xi/R51qSYJ23DVxoWb92FAgtEYG8iDTDHDZ1rx7Z8v Y8Riw9DFklLXPB/Il4hsnpYYziGifsY= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf30.hostedemail.com: domain of gouhao@uniontech.com designates 54.206.16.166 as permitted sender) smtp.mailfrom=gouhao@uniontech.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1685496096; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=A01mJZWigLgezUnV+6dXqqpEC4ipjaiko+YjTTqLPGc=; b=bFGiaePi7bwb0ND7Pkms9C0MFKJffLBJkS4E/35FKXCX74XruC1D/nwnq4B42YjmmxgTjI SrXIW3h6W66Cu0P80W94dGnmNo2UApeDjCj/lNuZZQ9d0fFLqC369q2LJ9XY5a9pGCFsW7 Jhsvju3CSBnkPbddQijWmYXRauBw2UI= X-QQ-mid: bizesmtp81t1685496025tw3oxnvp Received: from [10.7.13.54] ( [113.200.76.118]) by bizesmtp.qq.com (ESMTP) with id ; Wed, 31 May 2023 09:20:22 +0800 (CST) X-QQ-SSF: 01400000000000C0G000000A0000000 X-QQ-FEAT: W+onFc5Tw4MXg9NmrArDYuEAjJHK4eL16p2bcGANAmu997qLZ+ujaV0s8Z1f/ Nzmi8pNaWsKZP3Jmi5RKnu6nb+dCbNyrwOCVF3RhlVA1YBbFzgt8Coml9Vf2MloZUnDRpkl ADpUgJE8XNtjVow/bv7ZzhCNWk6I9WYmKFl0SSM5YLTrc8oT51rizMWMAPqdm1XDAhtCWWX DTqIUQa3efIfkNOAZX6/Yw4UnTUT6YoTYppGEuFOveHR6P5KZuNwCsuXN+Ey1bBhqyCVvPN eC3evk9wk+U3FfRn1CeZLX4tO4xCLND+a2cq7UCdAoJE6IMuJmrs5xNI56H1bmPeS+O61qR RBvgLchUjYteu3Ao0qfjQZGWJn29WS3hcVcO44C5o7MX+jf/j0= X-QQ-GoodBg: 1 X-BIZMAIL-ID: 16526261309428552688 Message-ID: <594B3D441ED28D0D+301afc15-d56d-4b9b-dc94-c97c658df05c@uniontech.com> Date: Wed, 31 May 2023 09:20:22 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v6 04/20] fs: buffer: use __bio_add_page to add single page to bio Content-Language: en-US To: Johannes Thumshirn , Jens Axboe Cc: Christoph Hellwig , Hannes Reinecke , Chaitanya Kulkarni , Damien Le Moal , Ming Lei , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, dm-devel@redhat.com, Song Liu , linux-raid@vger.kernel.org, Mike Snitzer , Matthew Wilcox , Dave Kleikamp , jfs-discussion@lists.sourceforge.net, cluster-devel@redhat.com, Bob Peterson , Andreas Gruenbacher , Mikulas Patocka , Damien Le Moal References: Reply-To: f67cc9c310bed1e3c3302ea1c206da7d5ebc14cb.1685461490.git.johannes.thumshirn@wdc.com From: Gou Hao In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-QQ-SENDSIZE: 520 Feedback-ID: bizesmtp:uniontech.com:qybglogicsvrgz:qybglogicsvrgz7a-0 X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 2315480017 X-Stat-Signature: sg4apux6st3gd8jy497r91qumxurrzcj X-Rspam-User: X-HE-Tag: 1685496094-508300 X-HE-Meta: U2FsdGVkX19f2aSbTobEsm25dbHPifrQ7bAslUPfsR1sorl/4CH1MB/aKvOgFrVMQAgosCgx+nUIg6F2S7U+Rc6/RiewspQWOxHJKuxRih6j56rNwdok+8bHSAkpPvHTpO9q9WR/lxEYvQdULDpt0h2RqRPpmSU/P1gKhLMdRqeSkYmbjt2ij7m7iIGhAS1KIALoTthu0Hqs4rLRAXpsfxk/PnacEKFgjWD6L1bp/KgPSyROHO1v6ZMrMM5oOal5WPNwVQvFBwb5adTSfQrePcxL4ornL8pv1ERZ3+r2I0ZnB9bb+uAAor0FRyY9UkF33IdzjonwzGEUuon3BiqwockaVesj+xubq7eH6jhdY4k2monAOLM9yEG9U7XgNi7jzJozEwOgVyPrfU5Wgl+j1TChkkrWf51GYezf0lU/uGNsF2/7R9ltD0mi1n0RJlBVenfNCqVMbAwOwrJenTYyw/hoVNefBEy2ct+jb/0fBV0SODf7JcHquNLczn/HAVXeZkOSruB5Rtfo7DnyJMzeO1CjaFYlc6OIyOErd2wHCaWqPpngSwg0/qVpW1KYjMD7n0cMH9sTN3gelGYAhlcN9AcT5fx30LKPiQSZikc32SLh4xqjs5xgtRF7qZI09D3lhIPZ3cSbHGQLbx+DmOqhulYd7yAao3jLCyP0kzFxqihtkW8xjHX8eeK+C7812jB+A2cZDHR1H0WyoYzokBPBo3Rle8vX5AJFROnmEnaVKS1gLCJTim7IVzWkCWm+IL4mux03qdzsZ7ukWyxRJSOXqdea2MmXPRPFcM4bB2TygRde7uUFz1iOWpywlkE9lKIjwHDpOJiitYqms5TOcr9ebHueJq+ljqQbN9Kc6ZycnfH68fJKoOxzx7qCc9eLqFGub23BvuFuj3UD39Uewmn+vPh0gIB8o+efoD7KaZ+GrOVNcPGKyxNhWb7Ta46fAY5Po4SpNlqizGbj0Fe8XpK BKKgC972 A6+uWLystb7PPqNBB5hNiljbMsk0EbV7sfcQ+M/QNN5kR5brCvUtBmyuX6YMAS6vG4+wdQWKOIqA4vgpCGh3ChCimoT4QKPIvHnwZkNjMgMet6Vvk7qlPj+BOP0GSEkoTkUDDi9IYjZMpaKvksRB34+Ophv1AIOAfx7Y52423mWnYLXzBF0e6rFivP4reV51HuYQsf9WD6jvl8aX9H1EtLW7wAQ8jSCRb5PMdeI7wGoYmzgu1dfaMZtf7yF7RhJWt9lKIO8EC4o2X9XtZyxDcmZAdjdn2gaPs4oxEmQ7C1JT8GyJuO03z5EYlBnSu315SLWBQBrSTdoQYUmTD92XYhrX9ApeDo81853JucG2mTpYVl24qZpogVywP2Te3AumGHEk48j/DK1fvcgzwNahIYhFy1k0j2gLN8bTwuSNH72sNU6Qzr6BG550zwwf6hAShoFqnbYIYPmkpC0xZK74RNrMrhJqOtEpJqiyspCIlPyFj8yKS9ZAPh46o56NmApmrkZLMjrWyL1Jcc38Ibk0nVgT0JfDjS997DvO8qpyXcyC3eWmNUhKG6Jwi+g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 5/30/23 23:49, Johannes Thumshirn wrote: > The buffer_head submission code uses bio_add_page() to add a page to a > newly created bio. bio_add_page() can fail, but the return value is never > checked. > > Use __bio_add_page() as adding a single page to a newly created bio is > guaranteed to succeed. > > This brings us a step closer to marking bio_add_page() as __must_check. > > Reviewed-by: Damien Le Moal > Signed-off-by: Johannes Thumshirn Reviewed-by: Gou Hao > --- > fs/buffer.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/fs/buffer.c b/fs/buffer.c > index a7fc561758b1..63da30ce946a 100644 > --- a/fs/buffer.c > +++ b/fs/buffer.c > @@ -2760,8 +2760,7 @@ static void submit_bh_wbc(blk_opf_t opf, struct buffer_head *bh, > > bio->bi_iter.bi_sector = bh->b_blocknr * (bh->b_size >> 9); > > - bio_add_page(bio, bh->b_page, bh->b_size, bh_offset(bh)); > - BUG_ON(bio->bi_iter.bi_size != bh->b_size); > + __bio_add_page(bio, bh->b_page, bh->b_size, bh_offset(bh)); > > bio->bi_end_io = end_bio_bh_io_sync; > bio->bi_private = bh;