From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9CCD5C001B0 for ; Tue, 11 Jul 2023 17:57:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 10BC86B0072; Tue, 11 Jul 2023 13:57:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0BD746B0074; Tue, 11 Jul 2023 13:57:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E9FC76B0075; Tue, 11 Jul 2023 13:57:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id D9F706B0072 for ; Tue, 11 Jul 2023 13:57:47 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 73DD21C7A3D for ; Tue, 11 Jul 2023 17:57:47 +0000 (UTC) X-FDA: 81000088974.24.9BB0490 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf15.hostedemail.com (Postfix) with ESMTP id 96B13A0016 for ; Tue, 11 Jul 2023 17:57:45 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=cYCZdiKV; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf15.hostedemail.com: domain of broonie@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=broonie@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689098265; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=O9c4IFj+zXzYCi0odRI1qyxw4exoSSSZjYbUbKE7UFg=; b=R9In8fdwqsFYaKoWKAYsOO29ZyGfN7ZdpfLu5sUc0vec590Akr84wT6j6sUUufrQIbN6sH +auiZ3BGbT2mPUHCO6YTxfFq5xW6QfamAKS7/ktPWXcX/BwMhKQ0Qh7TxTOPfzdcKNSwwm EDptPi3lQt1MAFJQl2nSERGaCOIJc/o= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=cYCZdiKV; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf15.hostedemail.com: domain of broonie@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=broonie@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689098265; a=rsa-sha256; cv=none; b=JqAV1AGP1zByKeccMgccQh2fH0zLoLevORAJoGenuaIKQBjdH31GgX1ab+86T28QIBz68f EePxgu7joTrS7XIREEarhp7xylRb7zE+r8M/a1uygia9LmNTN60QRb0S7ht/DdF7Xjw2Jo 5dfVPG+ftHOBcZXNdkpvaRHHOBczmZI= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8C093615AA; Tue, 11 Jul 2023 17:57:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B4920C433C8; Tue, 11 Jul 2023 17:57:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1689098264; bh=zXrDCJKFB8vVgSszrJcLCbm92nu+l5wGbuT30UhMTg4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cYCZdiKV0Z6gq96y9jRLhGD1Qk1WV7w8KD+8x73yWOf/wsLNRk3FTLMgT/oFdDuIb F15DWWUh2lBghW1DPM78x0xZAAhBQiRavfiUo8Ntkw8f8aWFGflU8VUjpYnEsQlpMN oD3Bw5AvNGqfjUGEuybCBHTTlE+67XUUE1V/vXb+G3Sf0qf56ycF5q55UL1lZWJtb8 8y1jCk+jM8SzyO1bpAWNc/CGxUolr0PJGhrBt+Y1sI3Q5l039VDI4NevXSAqrzPjHc bY+F6xxPrdUZ6QCR+B7rtt9Bi5A/CYD+TNhVfb9oyfDRTD0PTtIc/m/pwihDGxN4rm vkaJbzAf3JzeQ== Date: Tue, 11 Jul 2023 18:57:33 +0100 From: Mark Brown To: Hugh Dickins Cc: Lorenzo Stoakes , Andrew Morton , Mike Kravetz , Mike Rapoport , "Kirill A. Shutemov" , Matthew Wilcox , David Hildenbrand , Suren Baghdasaryan , Qi Zheng , Yang Shi , Mel Gorman , Peter Xu , Peter Zijlstra , Will Deacon , Yu Zhao , Alistair Popple , Ralph Campbell , Ira Weiny , Steven Price , SeongJae Park , Huang Ying , Naoya Horiguchi , Christophe Leroy , Zack Rusin , Jason Gunthorpe , Axel Rasmussen , Anshuman Khandual , Pasha Tatashin , Miaohe Lin , Minchan Kim , Christoph Hellwig , Song Liu , Thomas Hellstrom , Ryan Roberts , linux-kernel@vger.kernel.org, linux-mm@kvack.org, regressions@leemhuis.info, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 12/32] mm/vmalloc: vmalloc_to_page() use pte_offset_kernel() Message-ID: <591b5253-47f0-440c-84b6-7786ff59667d@sirena.org.uk> References: <696386a-84f8-b33c-82e5-f865ed6eb39@google.com> <42279f1f-7b82-40dc-8546-86171018729c@sirena.org.uk> <901ae88d-ad0c-4e9d-b199-f1566cc62a00@lucifer.local> <977ddee4-35f0-fcd1-2fd-1c3057e7ea2a@google.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="FgXD3/YC1RpaGmET" Content-Disposition: inline In-Reply-To: X-Cookie: marriage, n.: X-Rspamd-Queue-Id: 96B13A0016 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: koi16u8grqiwheqgmgp16w7eosuzgr1a X-HE-Tag: 1689098265-470940 X-HE-Meta: U2FsdGVkX1/O/G+6gJCiIgq3/+Rrg1V6q84JLL1jSfCw4ia1LNHNuWqbQRBwSS8nG+gJEttR782ApWa/6TGzCUAWlleGMSPbjkFtRUpZJwWk2HAJV+Djupwx04eFwW9VwU0jLn0rSyKRvZgLMz+B8Lyd3wnaT0HL/2vKRAQj3RqvejgnxZozHkbclwRe83Gm+WpryrazeNgAOAVuBS4fjgw0o6IsiT7tiiNckEkLT6PkXGH0yaD0QOQy56Irx9N4LGrJLUUuInAgA0lcD41rsIAH0+112k0jxdJoh3HeZcGVpUyTejarfb57lt+AlqArBxvbOk5jAJTCxilRWfceQCrEjrKYwOdEYAnovp9yWtjzbr6ffoqMS+nTLbizpPoBBLXdcgTvQ9ZrVbZDKLWx6bgAY1grmrnnMDZDojXV3Z6lwNlo+Cb4Y+7yRW9c8b9vMRUgFJjb4oQTHvO4EsF7RwjO7yjuFOTfNX1GS7vNyN5J6Hs2bxPEZ1Z2UdtE7CFbJgeaS0qNL4q7g6NRYXAPSvINM/nvISs5B2b3pEfUqGbGAYy3KLYbNDPr/oHD3HhzX5RGuSasPtgucr5+s635EsfEwIujdrL2CH4L2+Rvuvja0JLwjffRHTh8KhVThjQ0xCqCiX4i7eP2wWYio1A/y3GR/+tHUTj0oUXVWriD+3gfZJGI2TyfyjUh3gMLGcJQhOFsQJK2BsbeXVSPbo4RrnBye0rcL2xX6LrxRwZpy47meiVhFRRM7bkrqZqJVIK0sVOcifKS57UuOUhVPoRi7pZ4sLrS66jPlGAE7B1capEYznZILEK6mAjNJSlc/qHzbNkhJwUng+jDAWtKNgBe49+2tjkkPHIgVVOsULDEm/dgB8XVWUupbyGVwEs/XS4dItRy5xUm+KP01xQR4YrBwSeN4DpD5z3vAFd8NdE97Dy4OwzdblLzx/ZjP7Pxfv3y0x3YFMgFBF2/DPOL1jl bdATcHq0 WMfahacxrq/WssNEA6pFaN3lRhvHfCr6rncDZRFXZEfrRT5+OZMScF0aot3hn8BqDMQW1a2ZaeippgJ3VzhTC9szVAfhxQgmQYOAV+PYqcZX5VU62i6uTIViUFky7HrfHryRTqHNeCiuSWN98qI/8i/p8VhUgGOIz0Xe3/b3ej8U6beh6qJt+G+vD/5Ukur2G0vxw42Bmi0W3E4BmoDoJuzlvCfxuizGkLL20gZnfZowCvMFMant77L+QWYjo3GckICRsxxR0fssSRDBNqU7w1QNX6MhNcTvmZlJYyQdGw27FmdPrwbN+ZW6Nv4S/YahLR+VduZq41ZMUxqvPddMB4+7Uf5/YzttRhqd+n41uaisTPTkZwFeUv7YCXiJl/iSmTYC7obmtRNzZ+IU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --FgXD3/YC1RpaGmET Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jul 11, 2023 at 09:13:18AM -0700, Hugh Dickins wrote: > On Tue, 11 Jul 2023, Mark Brown wrote: > > On Mon, Jul 10, 2023 at 09:34:42PM -0700, Hugh Dickins wrote: > >=20 > > > I suppose I should ask you to try reverting this 0d1c81edc61e alone > > > from 6.5-rc1: the consistency of your bisection implies that it will > > > "fix" the issues, and it is a commit which we could drop. It makes > > > me a little nervous, applying userspace-pagetable validation to kernel > > > pagetables, so I don't want to drop it; and it would really be cargo- > > > culting to drop it without understanding. But we could drop it. > >=20 > > I did look at that, it doesn't revert cleanly by itself. ... >=20 > Right, that ptep_get() wrapper on the next line came in on top. > The patch to revert just 0d1c81edc61e is this: Still investigating but I'm pretty convinced this is nothing to do with your commit/series and is just common or garden memory corruption that just happens to get tickled by your changes. Sorry for the noise. --FgXD3/YC1RpaGmET Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmStmAwACgkQJNaLcl1U h9BVSQf+KnL1hqqyERin3gYRRghB0Kz2nNsNK2qNHnl40av8BTvNeGpjPtp5ZV9G Z5kjhS0QSEvpCd6Y048HnE4qy1wx7B7sF74cvUJttSVUs9BAoWMqXHFF0zlVnRjr xI/KPWc+ZyqBppF7zKZaFdXv/PDgVCVkbAFcmMH5ZEgi2hmrQRnG91SN0r9xvX94 oyg9EtrLhbdEQ3f1FqCU7XpFjJ4fI3qBQF4CHnuGzNo7q/2fJpdDDFw3T3xclcQJ eSeY4Kzlijv1OaSMq/To4Ky85/OhmROM96el2vPC5/B+TmhWy5McNhMFfFZBInXW tBICpj9RAybRnJsJ0agR/53kkvi2GA== =Dh39 -----END PGP SIGNATURE----- --FgXD3/YC1RpaGmET--