From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E3E5C001DF for ; Thu, 3 Aug 2023 13:09:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 107A0280254; Thu, 3 Aug 2023 09:09:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0B85928022C; Thu, 3 Aug 2023 09:09:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EC24D280254; Thu, 3 Aug 2023 09:09:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id DC52028022C for ; Thu, 3 Aug 2023 09:09:01 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 8FFC381137 for ; Thu, 3 Aug 2023 13:09:01 +0000 (UTC) X-FDA: 81082823682.15.7231C14 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf02.hostedemail.com (Postfix) with ESMTP id 0E36A80027 for ; Thu, 3 Aug 2023 13:08:58 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="LIBSN/NQ"; spf=pass (imf02.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691068139; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=25q2f4QIBXlN+KgpNe5k3Wb9XdvdW+h/LzkEpoNRomc=; b=fTyqF0uo9pi0t3sj5fL0c5NYDAy1Y9nhgbmjD7lTPTsnEbxC65+OWjsVhw/QuIkzuqrD6I Pu26Mku+yxfDvZyiJNypMC7ev72aGHd1NQiHw2k12hV+XVj9oBgV75fJyMNQusgsscSc9W o0n30JJE7ZPSYxf8oqgRSHuxbUVolk0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691068139; a=rsa-sha256; cv=none; b=pNgqXqa83MSIlVHTZt0c4uZ6BYxkn0xYenqmdKaNFNOiEHH8Ib4KF/SrNhlg0AMzxdu6xA 0959NeSz2DiDE3vrpO5rHOSrB78LdA19d6rR7/LeWhFgOCEz9wJ7dqLZNxRf7q8QIoNep7 RACEmlTupwnlmDmy0SDPycO5PRiPsAM= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="LIBSN/NQ"; spf=pass (imf02.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1691068138; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=25q2f4QIBXlN+KgpNe5k3Wb9XdvdW+h/LzkEpoNRomc=; b=LIBSN/NQcjMAf0Jabheiuy1dfUKiaLTPGVkE8WQNPQfJZBfsoNzGc9gC+iI+ewAELeR38V +TDofEtO9ii6qyPSg9gRjQ8WBtM/jBIB6lr5Oi/OifAwirMsB82Fhht5cXj95i27bg92ke A6Kx/1g9P5dZQ8dOdSXn01cdChCyonE= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-104-_3JSOhgqMO23lYmxMvOnfw-1; Thu, 03 Aug 2023 09:08:56 -0400 X-MC-Unique: _3JSOhgqMO23lYmxMvOnfw-1 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-3178532c6c8so509463f8f.1 for ; Thu, 03 Aug 2023 06:08:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691068135; x=1691672935; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=25q2f4QIBXlN+KgpNe5k3Wb9XdvdW+h/LzkEpoNRomc=; b=N5/FtN2bkgG3Z+XwYa70kbZmZDU09skr3X4D9FB/jDOf/r5eIx/1nikSgIvAOFZQ5z wIgTdtno9/VMcjDMyWlvyfDAiMUN0VM06E9zNl9rELKG9oW2KJah5j1b19w+ZUs5XANT MypYlIDxzH1s1cRr9Pkt9rw+Tdblj9vfdEbccQuAFF0RSVvU48Hfcw+0fSSfB1sa8aRS uNb9b/jY55V2J5Pc4IiDQML5XHzw+WYuBbsd0G0BXsfQwiwVG7lKwEohG0EqSZ+C9s4Y FxIUvzRFDhkTj3MPbfJV28z+D+YmINPjqCMsEv6u5guyWDX3NK95uNVAaIjrZirNorpt 4RWA== X-Gm-Message-State: ABy/qLYNXWsEIeGubxQw60ejdeYrQF5LVRpIoMz0zFp4lFNN0xvFdkOv Z1epgchkvIan6HGF1nMe7JXiD0kpOd8G6GEohFo6LnIkA2yIoddqrT9T2ejzmdbGRcK3b3xYFr8 nUYIMVRVvlC4= X-Received: by 2002:adf:f6c6:0:b0:317:5cfb:714c with SMTP id y6-20020adff6c6000000b003175cfb714cmr6691076wrp.25.1691068135676; Thu, 03 Aug 2023 06:08:55 -0700 (PDT) X-Google-Smtp-Source: APBJJlGwjr+buTj2yxFI0ur1IJMZMUMb4lAUtmU+Klmbq0qiadSvcx+oDaX7+hTjcsSCWJz0m+tMzw== X-Received: by 2002:adf:f6c6:0:b0:317:5cfb:714c with SMTP id y6-20020adff6c6000000b003175cfb714cmr6691065wrp.25.1691068135291; Thu, 03 Aug 2023 06:08:55 -0700 (PDT) Received: from ?IPV6:2003:cb:c718:9a00:a5f5:5315:b9fa:64df? (p200300cbc7189a00a5f55315b9fa64df.dip0.t-ipconnect.de. [2003:cb:c718:9a00:a5f5:5315:b9fa:64df]) by smtp.gmail.com with ESMTPSA id d4-20020adfe884000000b003144b95e1ecsm21876256wrm.93.2023.08.03.06.08.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Aug 2023 06:08:54 -0700 (PDT) Message-ID: <590d3fd8-54a8-e2c8-33ae-5e2f6d03abe4@redhat.com> Date: Thu, 3 Aug 2023 15:08:54 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH] mm/mm_init: use helper macro BITS_PER_LONG To: Miaohe Lin , akpm@linux-foundation.org, rppt@kernel.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20230803114051.637709-1-linmiaohe@huawei.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230803114051.637709-1-linmiaohe@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 0E36A80027 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: isn3wte16b535ipkhcmtyx4qm53josph X-HE-Tag: 1691068138-347820 X-HE-Meta: U2FsdGVkX1+oXfpI5wmj/Tqr8g0XTPuJpFec44olAUZnvFlEBheZW8R2XcMPWuXQt17CxfBNLqFmegt50dOlCEflWlaITg+bGhI5zQY2M9hap7oluiwORseJj+gks/S1savtr8nsrpkOwI+NBtWdCH+UhUgu+G+RpQUA80KCxrNYwX+S3MG1p2laDCNtCwrDKwiQJEVL+D1tU6kVY+dLn5ss3oQbMi8x6b2C1InAWVLn0y1enpGAX57V2px2VSxVuoBGlvtzszHH6f/Kx9kJrxh+vpGfkPoEBlfWX2wXMuQzKjTjSmGORAPr3huOSBg6kragCESIiVsEuZSoPjjPRp2VkJ9JmiwKHXUa4LtcdWDwXefizynC/ZCaVKBa0f7xYmF68Wtqxv2zsussPZVxn3Bn5ywuZO49lisBR9ToYcxbKRPV2jg3dp46bR0JxAJHvRxNSJQB19fFxEYMSisJlyI3LfQ/pwnVQlS5dvkoZXSKYKBuqNYA+X+0F7uS8o8NR7kKuSxSyizuPx4Hkj4DMC+9I1A9li0FPbNQNAEUBTuCAwxmdJveenf2+I89e6nDzvTlaYJyZd/BWO9tmdK5rb77sfNu1jm2/kT7gITHdi8bcPpRKZKrAsUCJWna9wUyZP+Mg9uKiuF9hgtDlQQwSr+p6qx2iQNLhgous83PSqvhS2PLg6tlwR/MvTPf71+mp8WGuOdnW28VpAuXSEYbbvaeKujlEkmV1LZ+TRDrIR9h+Y1AA5eID5N32Brof5Znm7umIPFtdmp0T2fCqL5RuWJSygTUNvvU9xiLqQjSJGdkmJn+w3Vo0X/Re12pIAlYHnGnP1IC/CuhU2Hsi5C3FZ/+PlZ2ySEaOaIMxEvDVc8Dsa89d5wg6qZLuDQO0usU0EX8w/3D8Nv+gJn8wyPt9zwFrMcLMURriGy98kJlbJmxN1kLyalAD2PtDdb/Nrtlh8uCP3VS5QPiVRG27N4 n1zCasYk B9g0WdCjpZ236siks5sIlRNy85MNJV4wsMU/iekveG8rg7LLD+aoj78jOlfehXib7ziXLwTsxhDuxNrVbrtBXHRimy+vhw4TeBN4to1OGGtMks5VgDC+i0uapotyfQdnjxmjog6glSvYMp1bkDDKDEKuAVI7RNCn6w3GXxhBtmUF+/kQA4zzgsvo9Y/u6q0NqH+jLRtpfLZnJ7/cYSVN6NbtrHZ6RLUjbsuxl7QgIm6t2R8lSOlR86fyZ/3AYsBDNR8ocGMPnhsajXK+Wcf7Quoz8eoy04ANdct7nCokEF91uhRbhBM3eWXl/5q7HbFKPNh35cowrRhqHFXQiM3dpRnNomX1xq7e9KunGg1H+70ptfKBt1oD1hroqasR2IsTpAUKq0i7IU3UW/WtIdnnK2c/AZNX1UJu7pc1O/HdezkiP/I30KVQf79mAN0KU5iHlmchD1TS+PImTjMwXG9mhMv6IsKX9l9BzS/OU X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 03.08.23 13:40, Miaohe Lin wrote: > It's more readable to use helper macro BITS_PER_LONG. No functional > change intended. > > Signed-off-by: Miaohe Lin > --- > mm/mm_init.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/mm_init.c b/mm/mm_init.c > index 66aca3f6accd..2f37dbb5ff9a 100644 > --- a/mm/mm_init.c > +++ b/mm/mm_init.c > @@ -79,7 +79,7 @@ void __init mminit_verify_pageflags_layout(void) > int shift, width; > unsigned long or_mask, add_mask; > > - shift = 8 * sizeof(unsigned long); > + shift = BITS_PER_LONG; > width = shift - SECTIONS_WIDTH - NODES_WIDTH - ZONES_WIDTH > - LAST_CPUPID_SHIFT - KASAN_TAG_WIDTH - LRU_GEN_WIDTH - LRU_REFS_WIDTH; > mminit_dprintk(MMINIT_TRACE, "pageflags_layout_widths", > @@ -1431,7 +1431,7 @@ static unsigned long __init usemap_size(unsigned long zone_start_pfn, unsigned l > usemapsize = roundup(zonesize, pageblock_nr_pages); > usemapsize = usemapsize >> pageblock_order; > usemapsize *= NR_PAGEBLOCK_BITS; > - usemapsize = roundup(usemapsize, 8 * sizeof(unsigned long)); > + usemapsize = roundup(usemapsize, BITS_PER_LONG); > > return usemapsize / 8; > } Reviewed-by: David Hildenbrand -- Cheers, David / dhildenb