From: roger <honghe@amd.com>
To: Michal Hocko <mhocko@kernel.org>, "He, Roger" <Hongbo.He@amd.com>
Cc: "Grodzovsky, Andrey" <Andrey.Grodzovsky@amd.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"amd-gfx@lists.freedesktop.org" <amd-gfx@lists.freedesktop.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"Koenig, Christian" <Christian.Koenig@amd.com>
Subject: Re: [RFC] Per file OOM badness
Date: Fri, 19 Jan 2018 18:02:12 +0800 [thread overview]
Message-ID: <59079b24-ce47-1ddd-6b22-7b5f97408fad@amd.com> (raw)
In-Reply-To: <20180119082517.GM6584@dhcp22.suse.cz>
[-- Attachment #1: Type: text/plain, Size: 991 bytes --]
On 2018a1'01ae??19ae?JPY 16:25, Michal Hocko wrote:
> [removed the broken quoting - please try to use an email client which
> doesn't mess up the qouted text]
>
> On Fri 19-01-18 06:01:26, He, Roger wrote:
> [...]
>> I think you are misunderstanding here.
>> Actually for now, the memory in TTM Pools already has mm_shrink which is implemented in ttm_pool_mm_shrink_init.
>> And here the memory we want to make it contribute to OOM badness is not in TTM Pools.
>> Because when TTM buffer allocation success, the memory already is removed from TTM Pools.
>
> I have no idea what TTM buffers are. But this smells like something
> rather specific to the particular subsytem. And my main objection here
> is that struct file is not a proper vehicle to carry such an
> information. So whatever the TTM subsystem does it should contribute to
> generic counters rather than abuse fd because it happens to use it to
> communicate with userspace.
>
A A got it. thanks.
>
[-- Attachment #2: Type: text/html, Size: 1627 bytes --]
next prev parent reply other threads:[~2018-01-19 10:02 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-18 16:47 Andrey Grodzovsky
2018-01-18 16:47 ` [PATCH 1/4] fs: add OOM badness callback in file_operatrations struct Andrey Grodzovsky
2018-01-18 16:47 ` [PATCH 2/4] oom: take per file badness into account Andrey Grodzovsky
2018-01-18 16:47 ` [PATCH 3/4] drm/gem: adjust per file OOM badness on handling buffers Andrey Grodzovsky
2018-01-19 6:01 ` Chunming Zhou
2018-01-18 16:47 ` [PATCH 4/4] drm/amdgpu: Use drm_oom_badness for amdgpu Andrey Grodzovsky
2018-01-30 9:24 ` Daniel Vetter
2018-01-30 12:42 ` Andrey Grodzovsky
2018-01-18 17:00 ` [RFC] Per file OOM badness Michal Hocko
2018-01-18 17:13 ` Michal Hocko
2018-01-18 20:01 ` Eric Anholt
2018-01-19 8:20 ` Michal Hocko
2018-01-19 8:39 ` Christian König
2018-01-19 9:32 ` Michel Dänzer
2018-01-19 9:58 ` Christian König
2018-01-19 10:02 ` Michel Dänzer
2018-01-19 15:07 ` Michel Dänzer
2018-01-21 6:50 ` Eric Anholt
2018-01-19 10:40 ` Michal Hocko
2018-01-19 11:37 ` Christian König
2018-01-19 12:13 ` Michal Hocko
2018-01-19 12:20 ` Michal Hocko
2018-01-19 16:54 ` Christian König
2018-01-23 11:39 ` Michal Hocko
2018-01-19 16:48 ` Michel Dänzer
2018-01-19 8:35 ` Christian König
2018-01-19 6:01 ` He, Roger
2018-01-19 8:25 ` Michal Hocko
2018-01-19 10:02 ` roger [this message]
2018-01-23 15:27 ` Roman Gushchin
2018-01-23 15:36 ` Michal Hocko
2018-01-23 16:39 ` Michel Dänzer
2018-01-24 9:28 ` Michal Hocko
2018-01-24 10:27 ` Michel Dänzer
2018-01-24 11:01 ` Michal Hocko
2018-01-24 11:23 ` Michel Dänzer
2018-01-24 11:50 ` Michal Hocko
2018-01-24 12:11 ` Christian König
2018-01-30 9:31 ` Daniel Vetter
2018-01-30 9:43 ` Michel Dänzer
2018-01-30 10:40 ` Christian König
2018-01-30 11:02 ` Michel Dänzer
2018-01-30 11:28 ` Christian König
2018-01-30 11:34 ` Michel Dänzer
2018-01-30 11:36 ` Nicolai Hähnle
2018-01-30 11:42 ` Michel Dänzer
2018-01-30 11:56 ` Christian König
2018-01-30 15:52 ` Michel Dänzer
2018-01-30 10:42 ` Daniel Vetter
2018-01-30 10:48 ` Michel Dänzer
2018-01-30 11:35 ` Nicolai Hähnle
2018-01-24 14:31 ` Michel Dänzer
2018-01-30 9:29 ` Michel Dänzer
2018-01-30 10:28 ` Michal Hocko
2018-03-26 14:36 ` Lucas Stach
2018-04-04 9:09 ` Michel Dänzer
2018-04-04 9:36 ` Lucas Stach
2018-04-04 9:46 ` Michel Dänzer
2018-01-19 5:39 ` He, Roger
2018-01-19 8:17 ` Christian König
2018-01-22 23:23 ` Andrew Morton
2018-01-23 1:59 ` Andrey Grodzovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59079b24-ce47-1ddd-6b22-7b5f97408fad@amd.com \
--to=honghe@amd.com \
--cc=Andrey.Grodzovsky@amd.com \
--cc=Christian.Koenig@amd.com \
--cc=Hongbo.He@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox