From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A536C5AE59 for ; Thu, 5 Jun 2025 07:45:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4E3C46B0125; Thu, 5 Jun 2025 03:45:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4BA7C6B0126; Thu, 5 Jun 2025 03:45:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3A8CA6B0127; Thu, 5 Jun 2025 03:45:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 1C4096B0125 for ; Thu, 5 Jun 2025 03:45:56 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id BA0C681D20 for ; Thu, 5 Jun 2025 07:45:55 +0000 (UTC) X-FDA: 83520563070.01.0205081 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf29.hostedemail.com (Postfix) with ESMTP id 5C3C212000A for ; Thu, 5 Jun 2025 07:45:53 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=LBwQiw5a; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf29.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749109553; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=O6H1ftBO6CEKGJOKs9g86ajvG5fS+ZjCtKrVQh3o6Cw=; b=Yzk1ssNaUTMWRMUwYDOjKXL0omwZqEhnfm3LfSordu37TPCxKMMUjF1/SCvA0oeZa0pJX0 83G8dSYkrszR2wrEtlhAL5vqGNVJFqCtvk3v+o+HMSMEmxDVY6rc15ivcYL0HdPwbljG6z YU0N+7eyBLmasGH/P0J0rwrh4PpJ7uA= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=LBwQiw5a; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf29.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749109553; a=rsa-sha256; cv=none; b=jCkVtZqLQocnGmlDyPzr9XN3FyboZNbCvL4N3+/6c6aemvMdK+hK5YTFn8/pQ8BgeHl+Wf Xj+qRAHcq5/Wy7GCmT72lKpQoRH5avjmS1DhJRCKdRCXGT6azS1vyx9Pyg5CaiV3RY2HDv rSQAxBiWWBVNtTpMQfcI5aLP3xBFHg0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1749109552; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=O6H1ftBO6CEKGJOKs9g86ajvG5fS+ZjCtKrVQh3o6Cw=; b=LBwQiw5a2cVbnLo59eSlisfixEyH06HFxLditsyYQkxl4elL2W657tYTkAdKg6CR+sJ41k mp+dAHz6Hz0pqjHAxsCH5xyd4bcLNwvCvdUSjUdNEZAxnXnxK9T+aGVHcb+OrKGaRWKrCR ZTxzUflBY3v7RdBG09kMgJBKmzWzanY= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-583-nr-gmLJVNtSjoSGG-WKFRQ-1; Thu, 05 Jun 2025 03:45:51 -0400 X-MC-Unique: nr-gmLJVNtSjoSGG-WKFRQ-1 X-Mimecast-MFC-AGG-ID: nr-gmLJVNtSjoSGG-WKFRQ_1749109550 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-451ac1b43c4so3686425e9.0 for ; Thu, 05 Jun 2025 00:45:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749109550; x=1749714350; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=O6H1ftBO6CEKGJOKs9g86ajvG5fS+ZjCtKrVQh3o6Cw=; b=jLbA/6YzRK5kIWYUTE32dacd7ankjz+/GgWg0gia2W7BZCzHlErKcXWeV3S6s8aFp3 TVTBJW4E22HoEFDAHECZklgfBIX4IavALn8m1O/O0x4SiWNHb69Y4rDaiI1eG64CrDNv aGYiEGOiB3zHBpspU5Ek+BL8GFXrx6aUNsvc9rXg8tZgJzWZM/nC81C8tSKyjrEVt3oR FqZiS0/kZZt+CIb+RRfuZ/fsQZS2EzorEQMyWRT7h7E3aP4IHOWERZK6YS6HlETztPfP S5UBhM8MVtENWTL9ibeqCH8FirRQLCQSLUnjTTSKjpSlsY9iUz42CSvtrxWB0FAVTqf5 KcfA== X-Forwarded-Encrypted: i=1; AJvYcCVMdRZhYQsb7Npfaam1XbKnf75ZSaDH23l4xod68sCdMrReAGapIvTmJ8neYz0yeYnqwvF0uNfx+w==@kvack.org X-Gm-Message-State: AOJu0YzmSEfEshZ1BW8dr1fCbOWThhpLtEQIYW/dQyC6XTwoUyrzlxK1 T5kGijjSTTzAhkdxfCyzZ1DKP/rWKYW2DWh+D4fuanAvwuv2QFL6EzLlXl+vyU+PsdalLRoA3Tw XcCW7qKGR6CHCpR/zcya/vzEWkEMSXHVrkWA4uOsOVn0NxNxFK4bQ X-Gm-Gg: ASbGnct4U/HIwoidhUnHo45zMYTIrEuxUo03BalYcD91KqiHdXWPsqHQST7GWw+Jcqp 14FVxXtA7JrfyLWT5gESuA376HshX19i/Q+1MTSqIYBRLWtTBHXgVI+ql8tNglRbOCAUIEOT1o8 RVh7Efd5cOw36VWY7+n3eypffM7pO/MJell4CY7WNd5ZaM2qmR0OWzXrPVdhnIvu/hVoiCFBCbq VpAh+uf8e6ADtA+Z2fpTHrci6rv4imKinwV6FRB7/MpLxluDShR6xcpn4sNPd/DwWT7k3arjJkL ZphgS4uRw/fxNobPy9GCCRKc1UFuKHDNbcFv7nkKnR635uD3yhWNu/uvJiflL+R5Kdqs1hqK6YZ DOpGe0LuCI1i2fIlw5gxtcyyHZIfbH74rs3j1 X-Received: by 2002:a05:600c:4e01:b0:442:f4a3:b5ec with SMTP id 5b1f17b1804b1-451f0a64f08mr56930925e9.4.1749109550292; Thu, 05 Jun 2025 00:45:50 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHROMgPjj+pP0emg4VKEoyCSGEnHYlNibukVyaEg4rn+/3yPGA5yK/itaMc1AE1G562Zflv1g== X-Received: by 2002:a05:600c:4e01:b0:442:f4a3:b5ec with SMTP id 5b1f17b1804b1-451f0a64f08mr56930315e9.4.1749109549833; Thu, 05 Jun 2025 00:45:49 -0700 (PDT) Received: from ?IPV6:2003:d8:2f27:ec00:4f4d:d38:ba97:9aa2? (p200300d82f27ec004f4d0d38ba979aa2.dip0.t-ipconnect.de. [2003:d8:2f27:ec00:4f4d:d38:ba97:9aa2]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-451fb208ad0sm9163115e9.24.2025.06.05.00.45.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 05 Jun 2025 00:45:49 -0700 (PDT) Message-ID: <590641e8-35f0-43e5-985a-3912c126b4aa@redhat.com> Date: Thu, 5 Jun 2025 09:45:47 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] mm/pagewalk: split walk_page_range_novma() into kernel/user parts To: Lorenzo Stoakes , Andrew Morton Cc: Barry Song , "Liam R . Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Muchun Song , Oscar Salvador , Huacai Chen , WANG Xuerui , Jonas Bonn , Stefan Kristiansson , Stafford Horne , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Jann Horn , loongarch@lists.linux.dev, linux-kernel@vger.kernel.org, linux-openrisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-mm@kvack.org References: <20250604141958.111300-1-lorenzo.stoakes@oracle.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250604141958.111300-1-lorenzo.stoakes@oracle.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: gtv6YdMs7BHunNdNkuILVDbk8plVl1u2F30T2br3nWk_1749109550 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 5C3C212000A X-Stat-Signature: dem8hhu5trcrc6wmwpphprrd5g7rma4f X-Rspam-User: X-HE-Tag: 1749109553-708371 X-HE-Meta: U2FsdGVkX1/IkaYquRiHxf/7XZl1G+OhDU4uYzViH4z0x+MB4QE8Kbi/NvhoMY7NfpMwAjS9Y3Abcx7X99WPDxnLjHuPIpi1OwBV1e9solryIqnT+jyZPhoREoDeTHxsnY7ouVbwqnnEuEK0wRtjTDK7KbrpDmX+yhwNmiYD2Tacd9PLfGKTjhWea1FwOrhIPMx+C5cgeuulFW90QtCRf/5hvSD/sp4dOiC2vauZpDiW6Yq+OJvypCjkNfUx6lQYuqLxPZ4O7LefPV9Oo13D6zSmsnw/hO7BIw6BN+IzDt5K2aph8lXf9CAT8IOu7W3jXDf8ISNy90gWT6CWFHVRtKzfVa/v7orI3eKaHWPUTlRf8ZTA9F1KZlG3f4il/aKANLdprq4E09Cmh6V34iPh/VzAw1/RZE9Q7jNdxTW9e9v81cOQ9eCeQbH/vGlAOXmVrSb1zC76eRrlNxT/SEJvBTJEEX4QJlVsDLHbw8BWjL+PbD1CU4efRwQiT0Bcv5ZdjkekBB16XsVRvECWy/B709jilWoPbVTomY0A3Jkh7tSQiDxiDijUZBDB7jhwpCB1r19rBX5pQUAyrVVb1I7zvGj/pJfYz0ZNaK7/9+Yyad44+frHa9NkrUct4TpXrZVR5vwdQ9ghrXOIRAEmMRZBcDJuJODi8iq9TpptackUvb1KuAt7hO4PqVuoUFZH4OP7C5W/XmXVl2+3SZQSktlTpDTgabEJRkevlL6YQY6LZ+OC/0V2tDErVPqBX3OpDdY6BwAQrY48N1z+rG+eYE3K1Xcv18tOv+NFtY7mBnwVOMPPsnt1hhUJLYDKgCN9kCpUcCgOzIprUkHrzvSS3u2HOs9wx9BP+5y1MPJQNYIv0QKbhw44TB/OO9x7/VQH/tjHXqSUPO+l+oc7Ly6GinVDCQfqNZ2uXSEx6fOJTgbYeqcodJgsb+lusdEeJ+r5NzppBzfpVpECfUngzdipTXb VmL2I00K VjW0Iddmc6tlhM0vPqUOdA7qBwjvbIP2a4OKUG95CMWeF2dE2/hDs7hwdFRWCWJQvQ6gRLGGwppeSAgK9lxmJg77TNIKMNkzj+SW27sbR88kY0PW3dcgq1d3elWna2xcyRWb0uA2qCYp+wZceReqyW/fgUvtSnRdIEFI8XTEZUtU9t2PuyAjPPQIbkH4cBBDp/rJd3MFUFjlqMbV6X6sluBaXBXMkfb9bQIPXLmq+XOyiP/DBVm+AzxT+UEqmaPA62sMfelpyu2DweIgiFkt+I99IJGB7Q4XTjljEn+TBknWi347IwOkvD0ozisgG01X9OaXGOB+KwaHhZs6rXBogz5SAZvxaeoGYHo+xIlZxK7q8pnoR4JYWveNw/2GBsmYQgQ2OUDmUBLzMF/iy+F94FWDUJHyUlfVALc6vofGRTdWhy7ryWgiw8XMxDi8jCeTYj2hGaWuJtHVOeJpQ2piVGY4Z/Pz5nblkxmvTIAlVtfbG4jgRAmNt+SW9hw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 04.06.25 16:19, Lorenzo Stoakes wrote: > The walk_page_range_novma() function is rather confusing - it supports two > modes, one used often, the other used only for debugging. > > The first mode is the common case of traversal of kernel page tables, which > is what nearly all callers use this for. > > Secondly it provides an unusual debugging interface that allows for the > traversal of page tables in a userland range of memory even for that memory > which is not described by a VMA. > > It is far from certain that such page tables should even exist, but perhaps > this is precisely why it is useful as a debugging mechanism. > > As a result, this is utilised by ptdump only. Historically, things were > reversed - ptdump was the only user, and other parts of the kernel evolved > to use the kernel page table walking here. > > Since we have some complicated and confusing locking rules for the novma > case, it makes sense to separate the two usages into their own functions. > > Doing this also provide self-documentation as to the intent of the caller - > are they doing something rather unusual or are they simply doing a standard > kernel page table walk? > > We therefore establish two separate functions - walk_page_range_debug() for > this single usage, and walk_kernel_page_table_range() for general kernel > page table walking. > > We additionally make walk_page_range_debug() internal to mm. > > Note that ptdump uses the precise same function for kernel walking as a > convenience, so we permit this but make it very explicit by having > walk_page_range_novma() invoke walk_kernel_page_table_range() in this case. > > Signed-off-by: Lorenzo Stoakes > Acked-by: Mike Rapoport (Microsoft) > --- [...] > bool try_get_and_clear_pmd(struct mm_struct *mm, pmd_t *pmd, pmd_t *pmdval); > diff --git a/mm/pagewalk.c b/mm/pagewalk.c > index e478777c86e1..057a125c3bc0 100644 > --- a/mm/pagewalk.c > +++ b/mm/pagewalk.c > @@ -584,9 +584,28 @@ int walk_page_range(struct mm_struct *mm, unsigned long start, > return walk_page_range_mm(mm, start, end, ops, private); > } > > +static int __walk_page_range_novma(struct mm_struct *mm, unsigned long start, > + unsigned long end, const struct mm_walk_ops *ops, > + pgd_t *pgd, void *private) > +{ > + struct mm_walk walk = { > + .ops = ops, > + .mm = mm, > + .pgd = pgd, > + .private = private, > + .no_vma = true > + }; > + > + if (start >= end || !walk.mm) > + return -EINVAL; > + if (!check_ops_valid(ops)) > + return -EINVAL; I'm wondering if that could be moved into walk_pgd_range(). > + > + return walk_pgd_range(start, end, &walk); > +} > + I would inline that into both functions and finally get rid of that "novma" ... beauty of a function. Well, we still have the "no_vma" parameter, but that's a different thing. E.g.,, there is no need to check for walk.mm in the walk_kernel_page_table_range() case. -- Cheers, David / dhildenb