From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29001CE8E6E for ; Thu, 24 Oct 2024 12:45:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 745126B0088; Thu, 24 Oct 2024 08:45:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6CE1E6B0089; Thu, 24 Oct 2024 08:45:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 56E986B008A; Thu, 24 Oct 2024 08:45:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 3CCFE6B0088 for ; Thu, 24 Oct 2024 08:45:38 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 786A0ACEC3 for ; Thu, 24 Oct 2024 12:45:01 +0000 (UTC) X-FDA: 82708466568.23.E5A1990 Received: from szxga04-in.huawei.com (szxga04-in.huawei.com [45.249.212.190]) by imf18.hostedemail.com (Postfix) with ESMTP id 91C3F1C000F for ; Thu, 24 Oct 2024 12:45:26 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=none; spf=pass (imf18.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.190 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729773782; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WGJJA1A1bwqfuysQ+5q6xOL2XoYantvci9OYYJp2dAM=; b=8h87xUvkWolYUk8zKvJebYALW79I4kTiD2swcHc9cxj6/KXYEUqfb4RdS9iw6HxHsRV9RH AImh9Ft5/atOawuOkHLV9NUDIdfYkszj7NFTpo8WArUhRUEJT7657AUHyRQtcqfWC59SpX D3gkZ+noQTmdGMq58owCjykh+1gMRAg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729773782; a=rsa-sha256; cv=none; b=kSxQPdNJKkVamhH9bDCJry0XeEPiXVWo1l2iQv9pp3t1r4enA5eZ6WfkNRKZAmx9GDndiX uh5AAUW/RbK1s4xR61VQR7CDMxVNVKGWJpT5q+xwDpC5MBYcG5HtNbM6U3SbdUkrjsv+/P cQbhkCTsNhoE+Dx5CyydHqz8gUmR2xg= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=none; spf=pass (imf18.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.190 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com Received: from mail.maildlp.com (unknown [172.19.163.44]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4XZ5Fd1bmHz2Fb37; Thu, 24 Oct 2024 20:44:05 +0800 (CST) Received: from dggpemf100008.china.huawei.com (unknown [7.185.36.138]) by mail.maildlp.com (Postfix) with ESMTPS id C45781400CA; Thu, 24 Oct 2024 20:45:29 +0800 (CST) Received: from [10.174.177.243] (10.174.177.243) by dggpemf100008.china.huawei.com (7.185.36.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Thu, 24 Oct 2024 20:45:29 +0800 Message-ID: <58f6a052-8b0a-4c1b-88c5-d3a462acc0af@huawei.com> Date: Thu, 24 Oct 2024 20:45:28 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] mm: always use base address when clear gigantic page To: Andrew Morton CC: David Hildenbrand , Matthew Wilcox , Muchun Song , "Huang, Ying" , Linux MM References: <20241024124436.3419497-1-wangkefeng.wang@huawei.com> Content-Language: en-US From: Kefeng Wang In-Reply-To: <20241024124436.3419497-1-wangkefeng.wang@huawei.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To dggpemf100008.china.huawei.com (7.185.36.138) X-Stat-Signature: r4dr1xqht3gj6nehq6rxki7xz3p88hru X-Rspamd-Queue-Id: 91C3F1C000F X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1729773926-311417 X-HE-Meta: U2FsdGVkX1+sPC0ti06Lz3VM5hhxxSjo85bQJ1Gx28+Qs+otakbXykcgLpv4pzGToxVcjY7ZWiZVi4Ae/Ii7aqvX5trZzLcDHHyXKq/wBI2IyQgQRrGV2soXCk14lEaSandjBYfeL55UtMXvlE0TasvO+66v3sAmF1soLv9tC84esaL0OSx6lQMU5EBtVDFEFxrI5c9CFGU4udw/wYVqxIe4lTn0r33OG6rWciup4zUs5VveS9G1ZQQJzxBbRmYZ6wNXk12cGU0BIi2VETEmM0tGafUVRuoOia8LiJy6PCAFGUu6tRxq/VjEISo3H7yqnjzM4NSlH2fc5opyEEu0qAfKCfxZdkZ9EQ0BWUl09e5t9ezmwGvJ3kL4sQQGqK9gvkeOk+c0xNRQPKHXqJiMpMmIDeZxE5FKYBFyQWmhrbN6nd78ZMmfcrRyV/BdNRcYy9YSyR7NOyoJ9YymGmWIGWn4gkRaGW+v6NpFc2Nre1wVMR+GP1AMo95wWZIg+zIhVn+l0kbqRExW1zPqQkblpfH7P9JJgO2ZT4DvbeaU1VmAqtlJyKhHsTpLCNIg6driyztFE9YhWQ5RRG15lCFHYfed5W7wXspRiLAjXtlAylgf9+/vPM6tQ09sLpZkSPUHmRKgOZhpPqd5MflambHWgpdNzKtvbRoTBc/oGPBEFOAcqBqW6/a2D8lVGcWbFX/TfDxFaEGdz1u3P+WcEVA426PvP5ffEcobMhQZITRnqEx3A3vivXGAeU3Uz+jJ9beV7RXFZFhPxtFtj+ZUjg6BwoYcKx+vFJT+6XbjVz5MNZkh9JJLyM8LC4V65nvb5gT6aORj8SQVrXgOLOiBnLt0kvD4S3Axo87iOpVsofyGcgJS+htgtMmo8dTNeKJvSwu58I4n4xTM+81kC/4/dIf1+r73u8NLBP2/YB0G6h/2K2qX7deqvWk2lph54y55ZrOIx8VPzwOWBIHs5thrKT7 +o6Jfe8q pPPLg3Wlj0FSzLUGTTuQMgYVlx4bhhMGuYvGGXlGZJvokchVhMkx3wcOaAFyZuP4i3rL+6JJQyzWgVh3d2j14eZUUERsma1YXFWPeXPkPCJjcdHgTBsr5hwKfqAZ8NtZYWa/ol4kMICtHqWdtbHlPKvvz8jcTYV9/6q9mN67xPb10kTj1lJuhNmjN23a9EJsL9tWE X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: +cc maillist On 2024/10/24 20:44, Kefeng Wang wrote: > When clear gigantic page, it zeros page from the first subpage to > the last subpage, that is, aligned base address is needed in it, > and we don't need to aligned down the address in the caller as the > real address will be passed to process_huge_page(). > > Fixes: 78fefd04c123 ("mm: memory: convert clear_huge_page() to folio_zero_user()") > Signed-off-by: Kefeng Wang > --- > fs/hugetlbfs/inode.c | 2 +- > mm/memory.c | 1 + > 2 files changed, 2 insertions(+), 1 deletion(-) > > diff --git a/fs/hugetlbfs/inode.c b/fs/hugetlbfs/inode.c > index a4441fb77f7c..a5ea006f403e 100644 > --- a/fs/hugetlbfs/inode.c > +++ b/fs/hugetlbfs/inode.c > @@ -825,7 +825,7 @@ static long hugetlbfs_fallocate(struct file *file, int mode, loff_t offset, > error = PTR_ERR(folio); > goto out; > } > - folio_zero_user(folio, ALIGN_DOWN(addr, hpage_size)); > + folio_zero_user(folio, addr); > __folio_mark_uptodate(folio); > error = hugetlb_add_to_page_cache(folio, mapping, index); > if (unlikely(error)) { > diff --git a/mm/memory.c b/mm/memory.c > index 48e534aa939c..934ab5fff537 100644 > --- a/mm/memory.c > +++ b/mm/memory.c > @@ -6802,6 +6802,7 @@ static void clear_gigantic_page(struct folio *folio, unsigned long addr, > int i; > > might_sleep(); > + addr = ALIGN_DOWN(addr, folio_size(folio)); > for (i = 0; i < nr_pages; i++) { > cond_resched(); > clear_user_highpage(folio_page(folio, i), addr + i * PAGE_SIZE);