From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93279E7719A for ; Sat, 11 Jan 2025 06:47:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1D9176B0095; Sat, 11 Jan 2025 01:47:30 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 162136B0096; Sat, 11 Jan 2025 01:47:30 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F1D866B0098; Sat, 11 Jan 2025 01:47:29 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id D2D2D6B0095 for ; Sat, 11 Jan 2025 01:47:29 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id F1D54140CD6 for ; Sat, 11 Jan 2025 06:47:28 +0000 (UTC) X-FDA: 82994239776.29.8FFD8DB Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by imf29.hostedemail.com (Postfix) with ESMTP id B974212000A for ; Sat, 11 Jan 2025 06:47:26 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=TNnBynaA; spf=pass (imf29.hostedemail.com: domain of donettom@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=donettom@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736578046; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4kjNc3tCuILS0UOM47eOBjqqnd7S22erMZdnlM8JJW0=; b=cZrIUOxrRF3rg1GzUkSqf/xlEcY4iH+0wz40FgK4K7c0CQd1XbYb8kCyzORna7EWG1sX/v TkzWiP/x6Yf/7BW9HGqznRr6Nxid+APvDPCC7kc+t4Es8kol1kMV8/hElU/k3Hy4tKiapW zI5LNiw1BUI+Ea8tzqiygUWPyFArCM8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736578046; a=rsa-sha256; cv=none; b=Dyzeo20x/5rm8h7QTSaYbbiQ1pjqbmi/o5gJVCgyg+62kQP0Od2r+GrZCt/S2QeKoSXKMc +s1kqgdz/k/vTX1OobfE3hNJxz/7eyqfMvuIMvpwCrbKrwWhI5FLi4XNrg15uLof9aNMFU 7LkUSSVTw/nMISgOgwHiAzMS2JpRSyY= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=TNnBynaA; spf=pass (imf29.hostedemail.com: domain of donettom@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=donettom@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com Received: from pps.filterd (m0353725.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 50B4W4HA018939; Sat, 11 Jan 2025 06:47:22 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pp1; bh=4kjNc3 tCuILS0UOM47eOBjqqnd7S22erMZdnlM8JJW0=; b=TNnBynaA3KjjwmXPj6ZaTV G4vFiuJBBk9ig7NeSFbm9548wlIl6XQm38Ue5v/X7E5E9ONx90iA4dKifRWVLX+k 3Y8t6wAp2PGSUCCpfwZt/diRA8dTDhXiLYeNWDI2JwzRSq33rLLXgJFaicB5VS4V pIu+CZ4yV8jO/6rlCuufS2KqSkIUJQoo902wKe2/dVHcqelMV2PpWAmo6CXJ6wLK d1Hg51kOxShIzE1sUWNuvq7BB9ynytD8pRaESPZsNvEEzmAr1rdALvMlW2DHjyZk giV4k69D7SO5CcSg8+7GizzmDnlKvWe5kmQcOv9FHJ+Y9IGYHm8Aeq85g5m4v1Xg == Received: from ppma12.dal12v.mail.ibm.com (dc.9e.1632.ip4.static.sl-reverse.com [50.22.158.220]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 443f2hrqbc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 11 Jan 2025 06:47:22 +0000 (GMT) Received: from pps.filterd (ppma12.dal12v.mail.ibm.com [127.0.0.1]) by ppma12.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 50B5NKUU003572; Sat, 11 Jan 2025 06:47:21 GMT Received: from smtprelay02.dal12v.mail.ibm.com ([172.16.1.4]) by ppma12.dal12v.mail.ibm.com (PPS) with ESMTPS id 43yfatp665-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 11 Jan 2025 06:47:21 +0000 Received: from smtpav04.dal12v.mail.ibm.com (smtpav04.dal12v.mail.ibm.com [10.241.53.103]) by smtprelay02.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 50B6lLMb27984584 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 11 Jan 2025 06:47:21 GMT Received: from smtpav04.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 26D00580A4; Sat, 11 Jan 2025 06:47:21 +0000 (GMT) Received: from smtpav04.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 4DA63580A0; Sat, 11 Jan 2025 06:47:19 +0000 (GMT) Received: from [9.43.3.138] (unknown [9.43.3.138]) by smtpav04.dal12v.mail.ibm.com (Postfix) with ESMTP; Sat, 11 Jan 2025 06:47:19 +0000 (GMT) Message-ID: <58f51ab5-6048-4200-8a20-cf6a5c3f4dd9@linux.ibm.com> Date: Sat, 11 Jan 2025 12:17:17 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] mm/vmscan: Accumulate nr_demoted for accurate demotion statistics To: Li Zhijian , linux-mm@kvack.org Cc: Kaiyang Zhao , Andrew Morton , linux-kernel@vger.kernel.org References: <20250111015253.425693-1-lizhijian@fujitsu.com> Content-Language: en-US From: Donet Tom In-Reply-To: <20250111015253.425693-1-lizhijian@fujitsu.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: xBN5QtK5EDW-cQb4wkKxvUhPSOTbOHsH X-Proofpoint-ORIG-GUID: xBN5QtK5EDW-cQb4wkKxvUhPSOTbOHsH X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1051,Hydra:6.0.680,FMLib:17.12.62.30 definitions=2024-10-15_01,2024-10-11_01,2024-09-30_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 adultscore=0 mlxlogscore=991 phishscore=0 spamscore=0 priorityscore=1501 bulkscore=0 clxscore=1011 impostorscore=0 lowpriorityscore=0 mlxscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2411120000 definitions=main-2501110054 X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: B974212000A X-Stat-Signature: ym199fe8i7y66g1cj9g88ryn7hoqdukp X-Rspam-User: X-HE-Tag: 1736578046-656528 X-HE-Meta: U2FsdGVkX18AVb9qXalbVB+uELiEWaZgJvzGW815LuAi2DohYI5JyF8SZ9xzdOW0R8thFT0rIhJjDzr684jJHEmd5qJIdtZA6+ZMbTLWPUkcuRKnlmD/P+5XTIIT5yA/3G9yJSaUV1tJeFbXrv8VGdGNttH7JqqGKIyg5DzbUlmeDrE7o6LESWF8JHb6MpRQflji7wRmGW3ixY3vfpza013bYVCgfhQV/Y+tZWbw/JvTANp8hlmi5fP74hiC/qfcHqEPdKfFt+3q9huQoL2M2BRAGMEDt6Nakvlf0Kt/7/ODQERoP2Tfd+pavY8l+uDxYoetDgtGj+w5pPM3WIbC/mhQBzN9Uqk2QVkLM9wgThB2WD4DJb44lmJSdqoj2fNOpunpQ//lO0N9762JWTjSywDAX6Ppn+zWk43y+cYcx6uIG1u7mAhzCRSsI5PVTpmR+TVpI6BmerIAzMEAAgLWMHARGUYQb5gAGXuV0+cNjquChZ1WIvjTL4X173eECD70G/3aLl9gv7K5bJSnUFAU+b1jkotvvr8t5FrizdoCYVObMmIfnjUYrXTweyuszRp92tP+WWQ/Md6qPCyiQcL/qLvu2xxJ3klmsMummMOYKBeUjNvKpZbLynbOtg8fh55jk/vF/3gdshcWQIEl5qf70CX6RP7q/IGYH1UtyNGDFlJyUDZ7C/U650qAVUGP2cX3aV+P0y+FI9isD3ts0o9Kbp337B8kPBYYDD9mpS9P7sM7u03nTeE1mAvoitWR5fnM5cQfMfZtkxXK0ZDdvNOIjBoj4+Cf4AnGkzcFj05N+wM44GaEO+2Hl7kmMua5vtYD9n6jBnFaTRXZvpxKRodL9O8yYgX24ZEbXQqsnZISUQOg6AfPmwWP3khmFB8Eedf2akCrbH4V5LDm0PtxRTd1OjInqrXb99wLcDT1ynbL2pnoFXcn090F1IMdRWV2dbHic3AE8JYbNqUXiVmt8vr 4M89Tpc0 8Ug3OCp2R6LqSsHgAel8U3Jcx2FmEo0VrrAK4l0Y4VthGZyhTgy/e4E07IAveI/mCUnyf8n8wtBUdHyyx6SavUFiRN37A8x8yac3R/nDRU5OWr4haOfMTEIZYvlb7BLbJo8a460VRE42V2jddw4XoeY5X+bcmUmnllM34UOaqzbQsR9hNhQhRSvh7OpQo+hG1xjabNgGgDLlAmxPlETCpKPKsbSDbB/YFN86CSNIaBXseTD5AJituJh7h2GbpZrPoqvkFcwefLNogVH7DkeqRwqbaktC8NZU5eLgCfBYjsJ7sFVrPIPgmfnbHmmLwGIRIIEBgfhfg9nnDiNHawFka56nyiFcdENu9q6Iup4sAqrJory6eAWdJ3oFlSMpDXpKiTeO8vqHfbgD7RogbQxcIyIVgcHby9UeQ8tIq4HWQX/1n0sqY33oBwV9MJKH0v8jTKnEDn4Ni4jOpO3fWNpJtJDElxyGfdnY+sQ6FQQopB0R/1PkGxDRjwrM0eKxJfOYgUuHezJy7dOdhIP0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000623, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 1/11/25 07:22, Li Zhijian wrote: > In the shrink_folio_list() function, demote_folio_list() can be called > 2 times. Currently stat->nr_demoted will only store the last nr_demoted( > the later nr_demoted is always zero, the former nr_demoted will get lost), > as a result number of demoted pages is not accurate. > > Accumulate the nr_demoted count across multiple calls to > demote_folio_list(), ensuring accurate reporting of demotion statistics. > > Fixes: f77f0c751478 ("mm,memcg: provide per-cgroup counters for NUMA balancing operations") > Signed-off-by: Li Zhijian > --- > > Cc: Kaiyang Zhao > Cc: Andrew Morton > > Kaiyang, I removed you ACKED tag for V1, please review again > Andrew, Please drop the v1 from the mm-hotfixs-unstable if V2 is > accepted. > > V2: > Introudce a local nr_demoted to fix it's counted 2 times by nr_reclaimed wrongly. > --- > mm/vmscan.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/mm/vmscan.c b/mm/vmscan.c > index 9a859b7d18d7..7f0624b98aa8 100644 > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -1053,7 +1053,7 @@ static unsigned int shrink_folio_list(struct list_head *folio_list, > struct folio_batch free_folios; > LIST_HEAD(ret_folios); > LIST_HEAD(demote_folios); > - unsigned int nr_reclaimed = 0; > + unsigned int nr_reclaimed = 0, nr_demoted = 0; > unsigned int pgactivate = 0; > bool do_demote_pass; > struct swap_iocb *plug = NULL; > @@ -1522,8 +1522,9 @@ static unsigned int shrink_folio_list(struct list_head *folio_list, > /* 'folio_list' is always empty here */ > > /* Migrate folios selected for demotion */ > - stat->nr_demoted = demote_folio_list(&demote_folios, pgdat); > - nr_reclaimed += stat->nr_demoted; > + nr_demoted = demote_folio_list(&demote_folios, pgdat); > + nr_reclaimed += nr_demoted; > + stat->nr_demoted += nr_demoted; > /* Folios that could not be demoted are still in @demote_folios */ > if (!list_empty(&demote_folios)) { > /* Folios which weren't demoted go back on @folio_list */ This patch looks good to me. I tested this patch with the stat fix [1] I could see the demotion counts are coming correctly. pgdemote_kswapd 60517 pgdemote_direct 6737 pgdemote_khugepaged 0 [1] https://lore.kernel.org/linux-mm/20250109060540.451261-1-donettom@linux.ibm.com/ Feel free to add Tested-by: Donet Tom Reviewed-by: Donet Tom