From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39C16D1CA0E for ; Tue, 5 Nov 2024 00:36:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AC7336B0093; Mon, 4 Nov 2024 19:36:16 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A50386B0095; Mon, 4 Nov 2024 19:36:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8C9686B0096; Mon, 4 Nov 2024 19:36:16 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 6DC986B0093 for ; Mon, 4 Nov 2024 19:36:16 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 1FCEDC0CD7 for ; Tue, 5 Nov 2024 00:36:16 +0000 (UTC) X-FDA: 82750173114.13.42EACB7 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by imf05.hostedemail.com (Postfix) with ESMTP id 89370100002 for ; Tue, 5 Nov 2024 00:35:12 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=quicinc.com header.s=qcppdkim1 header.b=l8i09vbe; dmarc=pass (policy=none) header.from=quicinc.com; spf=pass (imf05.hostedemail.com: domain of quic_yingangl@quicinc.com designates 205.220.180.131 as permitted sender) smtp.mailfrom=quic_yingangl@quicinc.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730766890; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=b3Auwp04dOEVHSooU2i3aQsCGVpTXCoUUCvBQEYUf18=; b=YO3vTmExbof4mTfeM98nqDfq/SJbPg+IOCQNHwqrFrFMX8dUYEXGFbxFA5MrguHD3I3P4m zA9rLJlX9I3jfjqdZShgVhmO49UaHzSwdqcfnUkW3buuTP3F9VlUu3K+lozBez0I9HpRpI jLDoUOAE1GXKdG00xdvfLYwzvYpuEIQ= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=quicinc.com header.s=qcppdkim1 header.b=l8i09vbe; dmarc=pass (policy=none) header.from=quicinc.com; spf=pass (imf05.hostedemail.com: domain of quic_yingangl@quicinc.com designates 205.220.180.131 as permitted sender) smtp.mailfrom=quic_yingangl@quicinc.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730766890; a=rsa-sha256; cv=none; b=EwsWKz0fQr0MspsV5TyhhtoBLZa4nVZbXUkvlu94lLkTm/AClhqsP3IUJUn9vI3PsejhwQ tg9hTIVVRutJzGTPh8aY2erl62dN5b8kP4NAmO7HXu72o3q2NgyUbOa1FzywnO2AAVTHY8 cOK1Xss/H2AHxkk5b4AoQiOb8P8qpzI= Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4A4LIoKv009217; Tue, 5 Nov 2024 00:36:06 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= b3Auwp04dOEVHSooU2i3aQsCGVpTXCoUUCvBQEYUf18=; b=l8i09vbegixJ6k0V UkuQq0Gx7YDy5uRusMpSdMfC9wEqOpRhyqW6Fc/fUHc/ioR7dLYxQxk3Ts6rFyhw n8W9kKS2hHH0CC2VzeFzfbtMSUK0ydp8aiiLUl4vaJre79UY5Esoe7K+nEU5Yiwf j7guVonRSON/ywoaSk6D87EblXCwg30ZSH/fl0Rjo+BooxkExg9/fn1J4qLP+zbQ 4HcTL44ozF/0QggD0rq034v9NJ+CEOqsySweOk/l/yNBJ8Ee9Zarq/wN8yc3USla 0mF+l+cZM8fjwMu9Yu/1ZgBHlBjs1F4AvxujULcBh5TDnrLkm4XDkirk9ATUNaiV Lt99oQ== Received: from nalasppmta05.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 42nd4unv50-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 05 Nov 2024 00:36:06 +0000 (GMT) Received: from nalasex01b.na.qualcomm.com (nalasex01b.na.qualcomm.com [10.47.209.197]) by NALASPPMTA05.qualcomm.com (8.18.1.2/8.18.1.2) with ESMTPS id 4A50a57g017943 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 5 Nov 2024 00:36:05 GMT Received: from [10.232.65.248] (10.80.80.8) by nalasex01b.na.qualcomm.com (10.47.209.197) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Mon, 4 Nov 2024 16:36:02 -0800 Message-ID: <58f01375-37db-4720-98bf-eb2d8ed5cc1f@quicinc.com> Date: Tue, 5 Nov 2024 08:35:59 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] trace/events/page_ref: add page info to page_ref trace event To: Matthew Wilcox CC: "Vlastimil Babka (SUSE)" , , , , , , References: <20241031024222.505844-1-quic_yingangl@quicinc.com> <8418b91e-04bb-4b74-96dd-a9489fbf9ba6@kernel.org> <55f6332d-3b4c-4478-93f9-514a906e348d@quicinc.com> Content-Language: en-US From: Kassey Li quic In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01b.na.qualcomm.com (10.47.209.197) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: jjRYV1ssAcyIMliQ9v2cTcu4fkgverH4 X-Proofpoint-ORIG-GUID: jjRYV1ssAcyIMliQ9v2cTcu4fkgverH4 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-06_09,2024-09-06_01,2024-09-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 malwarescore=0 lowpriorityscore=0 bulkscore=0 phishscore=0 priorityscore=1501 mlxlogscore=496 impostorscore=0 suspectscore=0 spamscore=0 mlxscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2409260000 definitions=main-2411050002 X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 89370100002 X-Stat-Signature: rb1x6sgrtczmt8marpyd449axhnb5yfj X-HE-Tag: 1730766912-800002 X-HE-Meta: U2FsdGVkX18TLZP5/9hnWGF8HdePtq3erpOYzAShVKoqmcHPMhy2lOnLhc+5Xvw4D7dy3uGdxpWLdNzrZseXpOuYpYMANVx1XiP21zEj2PAL4DRILXkUTwvr4xwauzQuVU7FNH8+S34gl9INs9hM46WqztqiF8WCRYwu041cvt/UXyvDbfcZY7FN5utjqFvc6pzta5o3vq0kUvJyaW2tBfU3Ao5Y0eEJ7wIvL6Jhj+VutVW2E1zf595M8C+kPtKcLr998iemwNIxJtxTao/ZJ3SQ+leB2ZpN6jF1/KI1UwEDVTZH8jSfSdcgcjsS5TParjqrO60VGc2CfH72OdkfEQyfvf6LA7O0aC2PiPQQP0EgfwUowRcDGSv0j/IWtYLGj2kGQPtD/S28VvImkfOh2N5yYkneqBen6EG1IJTgLTKA6D3H7pWxUL2CYHxVcbUzWlsy5Bl09AOfajhDH+1iNxhYq5CO2XohQGkks/f9HLLcLZfoQ756QAmibQINbK0NdsDxVVKccjabRrmcP7AE1j380yqLSPkEVO+gNxphXAb3gYDdZoklQ6Yf+xfnSVEzvlMzjTB7DiZV+vfHJYrqsd+dwBLdpnoYyKct7GENNA3UpaDq3n28eqgA3SsaeziK3xmBY+FrhP0xW8xXOY3AQxvOmM6kOlpbKsqzFff0M341eycFJNcUTcZqwxQFc7rUg0n8w5Q4ypZcRwVf1Ssh5EjjLxXHpGHiC+6kzpizcb7axYPxRJLbXfoiyhK/YiJAtujVA4u3Q5KvV0QkXL/5mcs2++6JLtzlt1cSAw3X+akH9r8HXFXwksYohfcNlAR3ai3bvaO6T7N8ATb+8u0ZTqL5LSWTv1HEswpfSMr7LdD6/f4gLBj5Ny6LV82GwlRfNL0/ivG9MSDKLpro0fEPawOYy8CJvOn+MnJPSQYOvTJNOEI6HMOCz+roT/qeZT51eLCOhDrC0A5l1FMOwEi R85kgQ1q QnjrZyfk8UdCnHOAH2nsg8jTLAE6IycUqc1wPJ9TxzhuJnGNfWfyqP5g+HKIUTEvggrb11pjpZQhtZea/fJ3pYEzcXHZPjlMBfDM5WBooQDaTJMSpPUvVYkAEspT7UOgN1/wYdNFBD4Aj5jVByjOsh21sz6mB/3gqWZSBrGl/H9WqkBh1NIQhU4X5QjOE75yVwadRmh5nPh0wkzC+lXCS06ABb5xxHesbyHwhugJMfjdzokcW+gujbqvTWuyuZT27M0TbfrqqSJ/Fe4/kApcS1NCGVC0YcNoyqYfLSnSd2g3vPvnb/07m6KNHHOMgdoNi8wtULgGMZpI8HE5N8B3pwoheg51/hVyxHHtT X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/11/4 21:39, Matthew Wilcox wrote: > On Mon, Nov 04, 2024 at 03:35:37PM +0800, Kassey Li quic wrote: >>>> In many kernel code we are talking with page other than pfn, >>>> here we added page algin with pfn. >>> How exactly would this help you, what are you doing with the trace? >> >> we met some problem where filesystem held the page. >> >> we can show the page pointer other than pfn in filesystem code. > > Don't do that. Change the filesystem code to show the pfn, and send > *that* patch instead. thanks for the suggest from Matthew and Vlastimil. On 2024/11/4 21:39, Matthew Wilcox wrote: