* Re: [PATCH] mm: Remove unused has_isolate_pageblock
2024-10-18 9:22 [PATCH] mm: Remove unused has_isolate_pageblock Luoxi Li
@ 2024-10-18 9:24 ` David Hildenbrand
2024-10-18 15:35 ` Muhammad Usama Anjum
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: David Hildenbrand @ 2024-10-18 9:24 UTC (permalink / raw)
To: Luoxi Li, linux-mm
Cc: linux-kernel, Andrew Morton, Johannes Weiner, Vlastimil Babka,
Baolin Wang
On 18.10.24 11:22, Luoxi Li wrote:
> has_isolate_pageblock() has been unused since commit 55612e80e722
> ("mm: page_alloc: close migratetype race between freeing and stealing")
>
> Remove it.
Acked-by: David Hildenbrand <david@redhat.com>
--
Cheers,
David / dhildenb
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] mm: Remove unused has_isolate_pageblock
2024-10-18 9:22 [PATCH] mm: Remove unused has_isolate_pageblock Luoxi Li
2024-10-18 9:24 ` David Hildenbrand
@ 2024-10-18 15:35 ` Muhammad Usama Anjum
2024-10-18 18:59 ` Johannes Weiner
2024-10-22 5:32 ` Anshuman Khandual
3 siblings, 0 replies; 5+ messages in thread
From: Muhammad Usama Anjum @ 2024-10-18 15:35 UTC (permalink / raw)
To: Luoxi Li, linux-mm
Cc: Usama.Anjum, linux-kernel, Andrew Morton, Johannes Weiner,
Vlastimil Babka, Baolin Wang
On 10/18/24 2:22 PM, Luoxi Li wrote:
> has_isolate_pageblock() has been unused since commit 55612e80e722
> ("mm: page_alloc: close migratetype race between freeing and stealing")
>
> Remove it.
>
> Signed-off-by: Luoxi Li <kaixa@kiloview.com>
Reviewed-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
> ---
> include/linux/page-isolation.h | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/include/linux/page-isolation.h b/include/linux/page-isolation.h
> index c16db0067090..73dc2c1841ec 100644
> --- a/include/linux/page-isolation.h
> +++ b/include/linux/page-isolation.h
> @@ -3,10 +3,6 @@
> #define __LINUX_PAGEISOLATION_H
>
> #ifdef CONFIG_MEMORY_ISOLATION
> -static inline bool has_isolate_pageblock(struct zone *zone)
> -{
> - return zone->nr_isolate_pageblock;
> -}
> static inline bool is_migrate_isolate_page(struct page *page)
> {
> return get_pageblock_migratetype(page) == MIGRATE_ISOLATE;
> @@ -16,10 +12,6 @@ static inline bool is_migrate_isolate(int migratetype)
> return migratetype == MIGRATE_ISOLATE;
> }
> #else
> -static inline bool has_isolate_pageblock(struct zone *zone)
> -{
> - return false;
> -}
> static inline bool is_migrate_isolate_page(struct page *page)
> {
> return false;
--
BR,
Muhammad Usama Anjum
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] mm: Remove unused has_isolate_pageblock
2024-10-18 9:22 [PATCH] mm: Remove unused has_isolate_pageblock Luoxi Li
2024-10-18 9:24 ` David Hildenbrand
2024-10-18 15:35 ` Muhammad Usama Anjum
@ 2024-10-18 18:59 ` Johannes Weiner
2024-10-22 5:32 ` Anshuman Khandual
3 siblings, 0 replies; 5+ messages in thread
From: Johannes Weiner @ 2024-10-18 18:59 UTC (permalink / raw)
To: Luoxi Li
Cc: linux-mm, linux-kernel, Andrew Morton, Vlastimil Babka, Baolin Wang
On Fri, Oct 18, 2024 at 05:22:35PM +0800, Luoxi Li wrote:
> has_isolate_pageblock() has been unused since commit 55612e80e722
> ("mm: page_alloc: close migratetype race between freeing and stealing")
>
> Remove it.
>
> Signed-off-by: Luoxi Li <kaixa@kiloview.com>
Thanks!
Acked-by: Johannes Weiner <hannes@cmpxchg.org>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] mm: Remove unused has_isolate_pageblock
2024-10-18 9:22 [PATCH] mm: Remove unused has_isolate_pageblock Luoxi Li
` (2 preceding siblings ...)
2024-10-18 18:59 ` Johannes Weiner
@ 2024-10-22 5:32 ` Anshuman Khandual
3 siblings, 0 replies; 5+ messages in thread
From: Anshuman Khandual @ 2024-10-22 5:32 UTC (permalink / raw)
To: Luoxi Li, linux-mm
Cc: linux-kernel, Andrew Morton, Johannes Weiner, Vlastimil Babka,
Baolin Wang
On 10/18/24 14:52, Luoxi Li wrote:
> has_isolate_pageblock() has been unused since commit 55612e80e722
> ("mm: page_alloc: close migratetype race between freeing and stealing")
>
> Remove it.
>
> Signed-off-by: Luoxi Li <kaixa@kiloview.com>
> ---
> include/linux/page-isolation.h | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/include/linux/page-isolation.h b/include/linux/page-isolation.h
> index c16db0067090..73dc2c1841ec 100644
> --- a/include/linux/page-isolation.h
> +++ b/include/linux/page-isolation.h
> @@ -3,10 +3,6 @@
> #define __LINUX_PAGEISOLATION_H
>
> #ifdef CONFIG_MEMORY_ISOLATION
> -static inline bool has_isolate_pageblock(struct zone *zone)
> -{
> - return zone->nr_isolate_pageblock;
> -}
> static inline bool is_migrate_isolate_page(struct page *page)
> {
> return get_pageblock_migratetype(page) == MIGRATE_ISOLATE;
> @@ -16,10 +12,6 @@ static inline bool is_migrate_isolate(int migratetype)
> return migratetype == MIGRATE_ISOLATE;
> }
> #else
> -static inline bool has_isolate_pageblock(struct zone *zone)
> -{
> - return false;
> -}
> static inline bool is_migrate_isolate_page(struct page *page)
> {
> return false;
Reviewed-by: Anshuman Khandual <anshuman.khandual@arm.com>
^ permalink raw reply [flat|nested] 5+ messages in thread