From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A2ADC83F0F for ; Thu, 29 Aug 2024 12:10:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5C5B86B007B; Thu, 29 Aug 2024 08:10:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 59C966B0083; Thu, 29 Aug 2024 08:10:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3EF416B0085; Thu, 29 Aug 2024 08:10:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 1EB366B007B for ; Thu, 29 Aug 2024 08:10:06 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id B48591C2B92 for ; Thu, 29 Aug 2024 12:10:05 +0000 (UTC) X-FDA: 82505164770.09.5576988 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by imf04.hostedemail.com (Postfix) with ESMTP id 5E90A40006 for ; Thu, 29 Aug 2024 12:10:01 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=TJ86xS3a; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=SflvtTAw; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf04.hostedemail.com: domain of lorenzo.stoakes@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=lorenzo.stoakes@oracle.com; dmarc=pass (policy=reject) header.from=oracle.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724933312; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SxkGLs0ISRqMpgwQcmzC/6cIPpFbS6k1TclKte2+nNM=; b=2NZIEigKygNmkd3XeJ0u3vdRNLCKOKK87L6jmDopIdH16DuGbXvBvANyLlNeFdIW5lfIcP +bqtZMgq0yidcXm0hf2u8C/ux4ZvqEtCkLAZMMHg556UJXA7Z/2+incavjXshDgD1mNe0f HOOoNsVFaw8qjlCK2gNy4rDu/4zvmGk= ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1724933312; a=rsa-sha256; cv=pass; b=ZkWhe7riK/wMGEFiCooQaVRSyopz6AqZGQdTb8uSnAfLZHi5BwiQmpyfQ8q3Tossz58TJt ZGR3H29wpJVpTJ40tezZypQF+DmmGI5uH4O/BR6itmbQ+5n8+li21XPGHkDuo5lRXIO5ER xUkN5jeoPYcg3wEpNCAHcRaOHXFVxWE= ARC-Authentication-Results: i=2; imf04.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=TJ86xS3a; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=SflvtTAw; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf04.hostedemail.com: domain of lorenzo.stoakes@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=lorenzo.stoakes@oracle.com; dmarc=pass (policy=reject) header.from=oracle.com Received: from pps.filterd (m0246627.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 47TBi1tJ023801; Thu, 29 Aug 2024 12:09:57 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h= date:from:to:cc:subject:message-id:references:content-type :in-reply-to:mime-version; s=corp-2023-11-20; bh=SxkGLs0ISRqMpgw QcmzC/6cIPpFbS6k1TclKte2+nNM=; b=TJ86xS3aPtjfZIG92MtvQk/ZTc6VlQx Vdozrps08FJf2ChNfm64tgKshEd7g0LvQQv6rfd2H+44qWBKHnAhKKBEpoYp8/PD w0B7/bmPzH3SC+eFojdijEFgiOrJSFrB5QQ5xeIw0hOSbAUq4RH7e3cD/Q1gBN50 t9DyDcXWkjZfMPn+8ybdq5xlmiv+pgA6MgfVgK1cZpYmc0oR6b1qhriPUGfnzV3E Aa12S8PMibBP0qZs8R+5zOB6dlWpoFCMp8BEbGOTK3ymD9lJusnxdn8nI93rSdNJ i1S0qwjpwz2X7xOQjNvYGCFJNq7GDVhd1kReWV+n5507VBRSHyJs7EQ== Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta01.appoci.oracle.com [138.1.114.2]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 41arbt01h5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 29 Aug 2024 12:09:57 +0000 (GMT) Received: from pps.filterd (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 47TBdj9D017602; Thu, 29 Aug 2024 12:09:47 GMT Received: from nam11-co1-obe.outbound.protection.outlook.com (mail-co1nam11lp2175.outbound.protection.outlook.com [104.47.56.175]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 418a5v1grp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 29 Aug 2024 12:09:47 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=W0N6WxGTlJIFZmb7vJoQI4xOB+scVgu6cqsGHpOFWbT/NteWkE79vJD9UVKkize8rjH7b6IJ/GGfTGEkUYgyA0bX6W3phBVCI4R4SIurnRjdVzzNRjZcDfnDmtzW0MzIDzA7hD5Ns0+Ct1toRbtX2FQNV8WOSrcZxbisZ+l4ETRqjSYLJY6YwvADOkH00s7AGYH+5UPEBaGKeoGRvAegTthJbi2zR4qGswlwePSPEzCL6z0+Xnwp7yWVQa02F86okJAFMxUWsNi/9JbAoG1yZxANl+f+Lb5/bBd9OWkv8umdA2FYIpoAv6WtsRGrFZnPy6x60etO7mEV9JiExhN+2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SxkGLs0ISRqMpgwQcmzC/6cIPpFbS6k1TclKte2+nNM=; b=ayvqoa+L68PaArYdGUCQOTUOg75RpDc7JMPAAaGAl9xOresLGUPKOXtaaIDz50GF/DUfxWEYn5w6nN3mxknexJ+Kf8YWXgc74kK+njxhA1yFV856bRQAt/d2yYdItKMq1sKd9b8a5mK23lqj3H0z5lolUHzcme3yheCHUb7EO9apYQerz8aC20b/BO9F0eUo5fAOvvO6foGZQnjR1tEQHksMbuZxbv6RIJP51PU8juZics/BzMdXKqYc/qugqJ9CEH5Vof4le1um7L4d8Yxdya6OueSGB1bA8tZDAv/C8ccLjH4hFfkEuX9fu52mtfYCuwfBlWL6H47HN5MHRZsvcQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SxkGLs0ISRqMpgwQcmzC/6cIPpFbS6k1TclKte2+nNM=; b=SflvtTAwcmyH6iEf1CvEHEwvRbAXTXkmmRpSZYExUAy2UcOAI4FRvhRLEgVjU4wQgQsA7ddtHuPIhI1wytx1PLPGXRdjjTFdo/AVKbtGwNyH5pS2usM6tmID/beF4CDidjTvEQP6sAgkKMdBzV4+LYDWcWWxWhECWxynMpnUmPI= Received: from SJ0PR10MB5613.namprd10.prod.outlook.com (2603:10b6:a03:3d0::5) by SN7PR10MB6620.namprd10.prod.outlook.com (2603:10b6:806:2af::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7918.19; Thu, 29 Aug 2024 12:09:44 +0000 Received: from SJ0PR10MB5613.namprd10.prod.outlook.com ([fe80::4239:cf6f:9caa:940e]) by SJ0PR10MB5613.namprd10.prod.outlook.com ([fe80::4239:cf6f:9caa:940e%5]) with mapi id 15.20.7918.017; Thu, 29 Aug 2024 12:09:44 +0000 Date: Thu, 29 Aug 2024 13:09:41 +0100 From: Lorenzo Stoakes To: jeffxu@chromium.org Cc: akpm@linux-foundation.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, linux-hardening@vger.kernel.org, pedro.falcato@gmail.com, rientjes@google.com, keescook@chromium.org, Liam Howlett , vbabka@suse.cz Subject: Re: [PATCH v1 1/2] mseal: fix mmap(FIXED) error code. Message-ID: <58e47a2e-6556-4a41-9fe5-1378f5257534@lucifer.local> References: <20240828225522.684774-1-jeffxu@chromium.org> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240828225522.684774-1-jeffxu@chromium.org> X-ClientProxiedBy: LO4P265CA0286.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:38f::13) To SJ0PR10MB5613.namprd10.prod.outlook.com (2603:10b6:a03:3d0::5) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR10MB5613:EE_|SN7PR10MB6620:EE_ X-MS-Office365-Filtering-Correlation-Id: 82d9da77-abf3-4eb9-7c79-08dcc8237847 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?NYowgGbuJLQuRWVOWYT+7Gvi5fut8Z9DbFggMuhxSto62/eWuhtKoyqYbaV1?= =?us-ascii?Q?bcpIBKHAeqfsbsjloS3v3wg5/4CIQXISuxSouiG20TG5D5W2bqWo0jG/ruo4?= =?us-ascii?Q?3aLyQjgnBVXawFNkkbS0z54ozlnrV10KQ6Kp9ikVnbMXsfovy4OkoQhWB1hX?= =?us-ascii?Q?OgPkdZtZ2e1LLKDKLakZtHzrY4f5JDE5R0zPKu0RchnIaj8fJ7ztZrqQ32rG?= =?us-ascii?Q?FxbrzeSZ7Q3JaRfG3HM59Dd24Dce8j4SW5Q9fYwsKYuOQTurus5n588VDneu?= =?us-ascii?Q?nRZhLLvaP41L7t2QLA6zWBGLh4asyHS19g6iJx4kLyHZSo0s3L4tJ5CsHUOk?= =?us-ascii?Q?gz/e9jXcJnNAtQpOKlZWCgn1J8qwzpMVaDhMP+RO663zy4w2GvafHLiTsIQ4?= =?us-ascii?Q?mZ5gBjHKzaiwBbY/Z3ZQ/1ZtCl81PQRWtdIj9+U/OmbtwXh0heKmfLo43u63?= =?us-ascii?Q?HElTebMtBKXeM6n3SMJVcSoZMFdwSSmlpRdX88BnSrohn6kThBW0gAnBm5km?= =?us-ascii?Q?7Fbq77RFHILq/hE+sKPli97xwwChugPYIqt6k7WjO5gHpw9QhXYIJbqNljYo?= =?us-ascii?Q?QKnXq3HUetVrnyA9MEWG6qVH3eF4T/7/lgIbqMs2bokJVUsZEWK64QlVOlFd?= =?us-ascii?Q?PdgbjZxIJJYGamYaeldZwX/CsrRzbTb7C9XvOqCz2zS18H1econSq3QD9esZ?= =?us-ascii?Q?a1id3vbU4rDfUFl22Fabi11PeJeilYkrRag/UiBczmaeaMUxOhsWXfhqr/gF?= =?us-ascii?Q?WsF5B613F6oxifA8zHpWF6qMaMrmBl8peRya6wrPxxEf5tPVTtE0g2fv7gmF?= =?us-ascii?Q?rDryHQH8iiebXlkQzQt9YCLJfxyPxdF9+myuPGcNlP448Jj08Xp7r3xVmsBE?= =?us-ascii?Q?4yr2WZQMbBQL6C28EC9jrcAx75UfGsUrPbSoZAPwlYDA6oB3xOI4WKLYQhA9?= =?us-ascii?Q?9JoGhfw5H6uNByP5K/oizqj+pxbAkov7ZAc7SmPiFtAacvt6fN/BDIMUjj1e?= =?us-ascii?Q?qxiVsf99WVA3M1tHAUCJIg8jvFqQqKLd7uuWYiEI4T/qcv2kwXRXN6IdLV+c?= =?us-ascii?Q?eMJT4Cd0nIWMUeL1YIJp+nQ0ArHkcIQU3VM4MCfOwkSh0xOuc6pX3zq3oNwN?= =?us-ascii?Q?jtY5QMPS8Q8MyS2XQ6RFuCcn2SF+4KMe0+3f/isIXGnu+YgNa6Yln4iLHKqJ?= =?us-ascii?Q?I5kW+PWvF+ADtrCRYnZMZ5DDMwuXFREYhTF0dxaQ53IMM8pfznthNTmxRx1D?= =?us-ascii?Q?FUxG4trplXEgUXHU45sH2A2721R1HRRTlF2NLEqOb0uNIsv+mBNDfKpTNOvJ?= =?us-ascii?Q?reg=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR10MB5613.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(1800799024);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?CU3KL/nJY97QdzHa5PHS1Cgwxm95sNR38SXLb/QHKrtHT6moYgwSDjr67NNt?= =?us-ascii?Q?jNoAcB+Ivp8GBOQ+INIdQPmMnmLvjojyVky29cG9YfKToxJ/pY61vr4LOkVI?= =?us-ascii?Q?+nApsCcxlYYsWTigkIOd0bgOo6ioLHlLeC57wxlpTqUOKnLB/F/LweVbTGqC?= =?us-ascii?Q?we4xDaKwRyT26AJEiqs4O7QeMdWmxtNpodfZEwJxtwSZPZGW1Yhvd/4jvRiZ?= =?us-ascii?Q?4q29o8RxF5w7USgZ9Ncj6b7y/LhRaF2x1Mz0RZfW3ig4bZEaGEok5vpl9kYA?= =?us-ascii?Q?zNIkAp8m/eP/BIKs/NONfQ9rGC/C8+XUgwxtIk5Hrm+L7bgSpfxvZLluxnIa?= =?us-ascii?Q?HScnTqpy5uSlCulYvkYoW6cJcaRIkoou624B4arWJqHbD+wgjEGoFt78njbm?= =?us-ascii?Q?X9yug2ksaS+nRMFnmbgcHonSuSFobT5PVW29CjvdBjSRbxOoPEw+B3bNBLSR?= =?us-ascii?Q?vCXCJmQOFB7WRQUKsvbvDvLhDuSSKI8XWGaBPMEZU10NHizCay9QPq0HuhLd?= =?us-ascii?Q?TiPa9rizqKYjoARATsCeQXKIJq83DT4hSRNvmOw8K29k+a7gLc/UuYCkMGkM?= =?us-ascii?Q?c0pd9FIKS5TOCs7PcBU4Nnj2Zk9+9NneH0B7V35kOVFSSisnDdHQby7Db9JK?= =?us-ascii?Q?+cXJK8TBnDAvk+eG8G2PzBTqWOcmKlO7W0RWlFLFC/wodju6sMTEUDQxy0jn?= =?us-ascii?Q?9rZtJGzgfBfWfsWO1IJZaMOO4TmfsLW3BT+/zbpmgGdyUCDtXTFWXFaPG44M?= =?us-ascii?Q?B0F1DUkUzZwlrJDZ/XvUozukSDi9RTekgwhCEz0PIPdDcjJVuGahyN6WY1C0?= =?us-ascii?Q?v2hVr3Pm+eYUOaoqiGxcwTP0+pI2RSNdGiNnc54t8itzFfNzKiVYjVl1QNC1?= =?us-ascii?Q?lMbwmc9Ni2wTpzw/ntcwvz1uRRdm7MiO8Jp2QxXJ6EtE9w4+4avE3+nXMpxP?= =?us-ascii?Q?g+FeY64/EEG6s1fQWFikKT+e4b7wSMTHVvqO/tXrDOYXaHScQMfNSWZXLeEy?= =?us-ascii?Q?a5ZLpFCr8DSpDWzIsnWNdUhFdzLpRxkV1Lume9Cslxc6v6G4/TZQdaVhasfV?= =?us-ascii?Q?R3gv7168j5e7ltC92tYUuc0IJQ8nnCdO/hfyP4FcZgeEdhNE1l/2UpBzkPd6?= =?us-ascii?Q?h8jDq1enLEKrx4UD70zpVzFu9tVM2Th5mXARO9UO8N+CKkUHr5QPxsG/3Apg?= =?us-ascii?Q?fRlGJAmt+lXu8Zoe+kYFrbvFwNp+3nghQejuYoNRjmWgleo/m31skxq6ETiG?= =?us-ascii?Q?Nhj0Q/8UqGl6HDokXoqn/+74so92vnk05nvO3mLwUNsbodFzjU9lseGplSBr?= =?us-ascii?Q?qITOgd9pKt/xmEEtwFzRqbDFIRcO7gDyHpvOqr4eRyNxKbsMwI+6z99xmmCc?= =?us-ascii?Q?/+kNOEE/YOo+bK57JIjUqJ9XBcZDYF/GyPiex6dnVkRkrboctbGN5EgIE8iz?= =?us-ascii?Q?5MkgG4Wr4aTQIxilRhGD1l/rMa20ZXHtnBn2WA+iRODpvYyGQuW8E3blPrxX?= =?us-ascii?Q?Ht0YHaK522kDEMvVfuPfP4ur1nCruzRjP3ws3KFgB6TnkXjm7ou6alCsZP+M?= =?us-ascii?Q?QPTDJF8GoHJLzVnjVifAZrbOtA/Uf9KEfCgjn2H1h0uEK5VJVG+CoS7UpqUZ?= =?us-ascii?Q?sQ=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: nwUXsBy+UVVIprIzgfgSTNa6/m+cL5GrsxsuDk3j1SvKeoREg9b52I75RSd2+67kLUiOHAqiKdJAQxY37qU91Ub0x84dc9d0dFrwoHsSjEE8/yuIaRDo7fG30FY1Kvs7H8oBz7a3PPq9Lrd9Kwa7YVNfuUHm7oiwbTpleHXFIYEkArereafLjk41w4ZlfX3IZK3tlk/l1MobiObW6ReIUwii7EYSv+VCVzAB/Rw2hV+2/GdNv0t8zmZP13q9BVJmiT9+bGARq8dnE8908UPQh4tLWnhkZtbmNg1foZariHvpEt3hQMRPJYxpahsKG4/XSjAKiHr90RfDtldUXkB17FG241yndwb8ghVchQdPpilzZIDA3VLsoUwIJS70IQnVl0RU8egNAguWi12jGWc13BGL2BqMMLiFL10e3K4g4J9N8M1qGuaRcyOVYUtNmM2U+X4yivbVGkwrWVIPwvwcR6XT0wuNUV8ETIddcIvTJC4AIs9xpwBOzWhVu9S7jxdy9BiN3zSNkqPNholM831tDNzhlsEMs1wx1Fi0VCCZBWNOMAj4IqPtUTKjZMy9Y3pXWpqOZBwpwVKmZBjpvhSOT/Cec6jSl7yQuXn6xDGucuI= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 82d9da77-abf3-4eb9-7c79-08dcc8237847 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR10MB5613.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Aug 2024 12:09:44.8280 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: pj7bEj5T22v6Cujxjsq/goQ7qqF7RYQQVht6yhpWDjoF00vKdGGNmETbbMV2ger89h03jNM8k6rzA5NoqHRFJXWREKq8MFs3Ly9BNtbp8/8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR10MB6620 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16 definitions=2024-08-29_02,2024-08-29_02,2024-05-17_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 mlxscore=0 mlxlogscore=999 phishscore=0 bulkscore=0 malwarescore=0 suspectscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2407110000 definitions=main-2408290086 X-Proofpoint-ORIG-GUID: WB-Yqv6KzkBGz79yjjZRVWC43n59on8G X-Proofpoint-GUID: WB-Yqv6KzkBGz79yjjZRVWC43n59on8G X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 5E90A40006 X-Stat-Signature: jytttbn5h3d8gqw67roc38jhfuabz7iq X-HE-Tag: 1724933401-889464 X-HE-Meta: U2FsdGVkX18YILIAvUMjWCAMptPGn0A95D5jaQGhc5xCVSkwDFhP5usp0FHpo3sc93c/Uzti7Owios73H3P/CagNq2EQsyUbaD59y14hU+q8Vm+TQF+poC+CbdZKemWvVA//7GSy2scU6EjQiiOIcFYLUXf9/wUneoL6V7h/Rra9SnAwwBvWqPyNgIav6U23ckLwJiJYGg3tgJPXbaF9dUtxjHldP1x8ZrS6W3yMv/0ZlrArR5qREZsnoM4LEzLZIXg3H/kyTTSFCpNwhCoT73RUe4seW8xWyxVZGxozyn7w+SSa3K/pEd3FhNNX9H8UIbIbE3F60gjsAi0FJkYSFdzg2zZdHNxxnJrTsGAZKUqyrlJqwDhgtD9CskHlVBQF+Iamd1hdILOOTuE3+Uf79BFSmQA5wpfII/OZdSm4qbAp6VhSnkv221F1ggHldkGkB4kCu0pt/twSpQE5KVgq7mM2LgHbk0Y1UPZ99ZEv2G8piXUpBI//6BGSY6vw9BxJVTJV0vpXXErdGFzzl61UaAxOFLG55dnrW3lMYfBFD2L6kKLTJqHJam56iHmZ4OJQHde1XpqDUHcSJp3SvOQMHYZWRAbqPucCwDBW+0mPshjtFr6zaHvtWi5e15GY+zD0PeA+bE93mbRG/aRRp3YXD29Y+R/NVwCR6IggATyfH/r6wnSPCYttCgz4fLUdv7gB0RtiAVSSZmFk1D4HBA7F452I2drQ6Q/3t8OJZrMxL/NvG4zBYOX6vpoUbrR+y4MqxspONSAg+ypQHdDX6xXbynMqdHVALH64/lwpv1s9K52jmfxON0lTvuT7ODPBV/zwbvxJweBSG8j6C+s0p/TtryxFkrTVi3lFMBVjnSI49wcEB+eD0wTIB/SQPo+1PCoQ6bzXxzJRi9U3WUS/Q9D77H9dt/+krRD8b8eOGUTTlo5sIgx2zw/LOkeOixVRBJB3gwMllxLtaAoe3jOoJ9e 1SyBbtJr uHoIF/JRdb+N4LEYY9E1wus41+F0REbEN72nyp69h5RdJDyKWCLlytvWicjygVIgfIYn91K/LUWMlqdIl/IH9u1PA4m9Zv0r6S3QxRA9I6RYX20OkjCdap2aomQBzeok6ujVPQTbLYKY1GjFoO4oc1H2iE22cRa28kQFMqo4EdfMTl3xxVBz6kCXNL8ngoXnaVIx9RIuIHPbiTFjsp7liC2ETGBZJQONDepHCyKqp+R/gD2xKXAzBvvsg67lDvxueg4NOrC1yyBrLk0eqSomHBNshOVMa9U6QC/JaCNns2cI73wejHasZUKVbEy61RJSZnyNBClMK8hT/r4JMGY3qku/yQorfi8R0M0Ynw9+J7y8QFi1lx/Df4m8nCWfaEz9WHSmeXb2JZ8qNVEFDoG0xJbr9xRXVOZZG4gOyX/DrqJPVYiAiUuBasIvLUynqtHMZkL7F1nArm4fUqr9whqAHMzfHsGOcNhCTuxfLSPGx6+U0VlVrcItOQ6IUgC1eMVg7YNVFU6WMwGbPFh9NUu2CsE6BQrFUZt+reIwtSuDyAc5qBV4o7RrgOsaLz6YBztgQQs0gJUp5h3iBxXLvZfhKrYmtYdsjr998buYWYAsbYnG2Hd7OvP4J2sNgDdVjORnn4c4vFGb2G1Y5hUXPA0go+egON2B1LDzsLlJrf7KmqoVgJ0eKBN6OyrUeigqQck1tOqBfR5bS0MagxGUvB95YevOKeWZsETh0lFSY1O/u40L3QG9NxzbUzzVoUu1eAeh39i0KnUxALM6OJ333oerRXnDYnwzEGfSIrW25 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Jeff... come on now. Please cc- the reviewers of mm/mmap.c on these patches - that's me, Vlastimil and Liam. Same for mm/vma.c, mm/vma.h, mm/vma_internal.h. And it seems like it should be pretty obvious you should cc- Liam when it's quite literally his code you're changing! Relevant section from MAINTAINERS: MEMORY MAPPING M: Andrew Morton R: Liam R. Howlett R: Vlastimil Babka R: Lorenzo Stoakes L: linux-mm@kvack.org S: Maintained W: http://www.linux-mm.org T: git git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm F: mm/mmap.c On Wed, Aug 28, 2024 at 10:55:21PM GMT, jeffxu@chromium.org wrote: > From: Jeff Xu > > mmap(MAP_FIXED) should return EPERM when memory is sealed. > > Fixes: 4205a39e06da ("mm/munmap: replace can_modify_mm with can_modify_vma") > Signed-off-by: Jeff Xu > --- > mm/mmap.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/mm/mmap.c b/mm/mmap.c > index 80d70ed099cf..0cd0c0ef03c7 100644 > --- a/mm/mmap.c > +++ b/mm/mmap.c > @@ -1386,7 +1386,10 @@ unsigned long mmap_region(struct file *file, unsigned long addr, > mt_on_stack(mt_detach); > mas_init(&mas_detach, &mt_detach, /* addr = */ 0); > /* Prepare to unmap any existing mapping in the area */ > - if (vms_gather_munmap_vmas(&vms, &mas_detach)) > + error = vms_gather_munmap_vmas(&vms, &mas_detach); > + if (error == -EPERM) > + return -EPERM; > + if (error) > return -ENOMEM; Can't we just return the error here? This is one for Liam, but I'm ostensibly in favour, this does seem valid! > > vmg.next = vms.next; > -- > 2.46.0.295.g3b9ea8a38a-goog >