From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BDCA6EB64D7 for ; Wed, 21 Jun 2023 09:11:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 58E5E8D0002; Wed, 21 Jun 2023 05:11:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 517A38D0001; Wed, 21 Jun 2023 05:11:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3B8898D0002; Wed, 21 Jun 2023 05:11:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 26E418D0001 for ; Wed, 21 Jun 2023 05:11:08 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id EBE6D160855 for ; Wed, 21 Jun 2023 09:11:07 +0000 (UTC) X-FDA: 80926185774.30.B4B987A Received: from out30-119.freemail.mail.aliyun.com (out30-119.freemail.mail.aliyun.com [115.124.30.119]) by imf05.hostedemail.com (Postfix) with ESMTP id 22999100018 for ; Wed, 21 Jun 2023 09:11:01 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=alibaba.com; spf=pass (imf05.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.119 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687338666; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ig4Ip3xFURcna0FEPQNJfflXkAYnSJJ2VrU80FOqccU=; b=doQauTtb8CrmYzt16TXCYj5RcLI7rd5x6w+dU4iI2oRfCyIckidBnwFL3rT4MS/Yt8HzuZ FlvK1YDhttQJ2Odwi/fwGS7rLeowv9aa4rUBH6Za8bjuCL/lNIlg4vWQ5xTBQQRzjxRNB7 rX9646vhGvRxLP6WtVCI/7krrCN8lQ0= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=alibaba.com; spf=pass (imf05.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.119 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687338666; a=rsa-sha256; cv=none; b=gTGTRM4KgoLrTlBSdRVl5kFtGaPEp+7o/83jUyvPgTbJFCwyKSOEqRoHKRixK3V9/TykCO h9xoscoJny12vixUNYqNbSRgEHC3IkbZ+aQhETUJC80smk9KOUhVTHNNUvkM1gaELIxVEG m+avgsUXcEpMocjyu9BqkwjWhMw+iV8= X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R821e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018045192;MF=baolin.wang@linux.alibaba.com;NM=1;PH=DS;RN=7;SR=0;TI=SMTPD_---0VlfKbH7_1687338654; Received: from 30.97.48.59(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0VlfKbH7_1687338654) by smtp.aliyun-inc.com; Wed, 21 Jun 2023 17:10:55 +0800 Message-ID: <58d0d829-da04-0f77-eedf-8bfa519b52f0@linux.alibaba.com> Date: Wed, 21 Jun 2023 17:11:15 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Subject: Re: [PATCH -next v2 1/2] mm: compaction: convert to use a folio in isolate_migratepages_block() To: Kefeng Wang , akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, willy@infradead.org, jgowans@amazon.com, yuzhao@google.com References: <20230619110718.65679-1-wangkefeng.wang@huawei.com> From: Baolin Wang In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 22999100018 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: h1f4b8sbfqjko8bddaren9fyc8ms8krt X-HE-Tag: 1687338661-133290 X-HE-Meta: U2FsdGVkX18G80xlLdhNIxkhn4PhFeI7p2o/zhODXArQZMyXW02ze5fYUjZsIZwruYUNzNmH/gYdbBUWTZvU8JyhcUcSLIgnTAStDFGS/dYg0QHoUhwy4S+LF6Npq5I54G2ipysQzVuxQvjiMpoyT9EOH0zpZACrAeaNQvvq8cCwK8RUj5oNoyor7iB6+tjosXaV7RuNb+4gf6SJGnwdpLlXFziFSUj/FZ1Gq9xrj9l5kwbhYQafiSScfNWFJljCfSNOZxvT2VLTzCJkmgT30jO0kuwIy/aKNTInHHR6wL5f3cU8ZtlTdGjzVbPogMFzOxuJhMnCKk8IAhS+llVGMH29eykw38rAI1XGJ+BdUAAADXTmM/cbfRH8krFF3oUDxBSuhOSNCLXI9TW7l6vqOJVixmNrIyhTogXVA8mUw12ZH2HZ+bgabdW0THEZ9djRsBPTkSramoy8Muxsmuke4VYlyozuUzIyZceGMJ7OIX/QYDv6Qs+V61CYNQIkkIE78lKyuXz4KzpSYPvaWEpSymRVXV1swmehUb3do1JQtQ3iENMzQqX6a7l0LmPb3uJNu3D2YbWyqmO0UzHreMouQgQ2XYE3IWRnn9dodGoWOq0z8Q/pFHcab5V5S5BjDxBo9ai2kvI1rmJsQKX9wtOMcv/2iY8d7IXgd0XkFWk0oYxE2zzbODoNzKbNKT2wWN78Q1Oih0OSSRas1kTXc7+Agwb/OXC/LjfjdDYC7IsRkypTHIEk23x90Tsr/BqlIhKTdmLyDl+G8HPDF0FiM/+Ony8STyhDbpUQ7whlfP+OVBgOcvXgjZdvFUyIeJGoNmDfmOAQD8sO4FUtEE4AHy5LxNrxHsu+s51Dj9vm3YUQGK1AWVo/L7nSYwhI4FRDIrWHetN/QQzGOrwL7B4uwmRhEcD9Ep13wjAYSXREgrhFyF1hJ72EygxWE5CWQtBfGOucidZwbvxdeYXe7pfIhxw VA9jI+IF 6RULg8dsY8ZDpphqfyfVkdQwMdROLFx4WCpn+NqNo6GGM7dtyu8BYHG8C7swrHRoZsFqHlTNse4WC0f2bh5CII703eHgcgBkZBw1psMBAnZ0sn6fvXQ9y7cO9JC5x8EUY495ZY4ileWlWXul05YLQfHyR9u00sNfxw4F8Su5XV27WSphVltRZqdv7zFYk2ZSfy6718y0joxb9lJTj/XJ74dpwvfWpfOHZ7NK+JsFLZjuq/VqbTTHSPENHCOFTLAgZn7PxPsAE0WpHzmncMhSDbjNc7zwal8MmqBH2yuAZ2Ml1qVo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 6/21/2023 4:36 PM, Kefeng Wang wrote: > > > On 2023/6/21 14:20, Baolin Wang wrote: >> Hi >> >> On 6/19/2023 7:07 PM, Kefeng Wang wrote: >>> Directly use a folio instead of page_folio() when page successfully >>> isolated (hugepage and movable page) and after folio_get_nontail_page(), >>> which removes several calls to compound_head(). >>> >>> Signed-off-by: Kefeng Wang >>> --- >>> v2: >>> - update comments and use node_stat_mod_folio, per Matthew Wilcox >>> - add missed PageLRU conversion and rebase on next-20230619 >>> >>>   mm/compaction.c | 84 ++++++++++++++++++++++++++----------------------- >>>   1 file changed, 44 insertions(+), 40 deletions(-) >>> >>> diff --git a/mm/compaction.c b/mm/compaction.c >>> index 6149a2d324be..0334eefe4bfa 100644 >>> --- a/mm/compaction.c >>> +++ b/mm/compaction.c >>> @@ -795,6 +795,7 @@ isolate_migratepages_block(struct compact_control >>> *cc, unsigned long low_pfn, >>>       struct lruvec *lruvec; >>>       unsigned long flags = 0; >>>       struct lruvec *locked = NULL; >>> +    struct folio *folio = NULL; >>>       struct page *page = NULL, *valid_page = NULL; >>>       struct address_space *mapping; >>>       unsigned long start_pfn = low_pfn; >>> @@ -891,7 +892,7 @@ isolate_migratepages_block(struct compact_control >>> *cc, unsigned long low_pfn, >>>           if (!valid_page && pageblock_aligned(low_pfn)) { >>>               if (!isolation_suitable(cc, page)) { >>>                   low_pfn = end_pfn; >>> -                page = NULL; >>> +                folio = NULL; >>>                   goto isolate_abort; >>>               } >>>               valid_page = page; >>> @@ -923,7 +924,8 @@ isolate_migratepages_block(struct compact_control >>> *cc, unsigned long low_pfn, >>>                    * Hugepage was successfully isolated and placed >>>                    * on the cc->migratepages list. >>>                    */ >>> -                low_pfn += compound_nr(page) - 1; >>> +                folio = page_folio(page); >>> +                low_pfn += folio_nr_pages(folio) - 1; >>>                   goto isolate_success_no_list; >>>               } >>> @@ -991,8 +993,10 @@ isolate_migratepages_block(struct >>> compact_control *cc, unsigned long low_pfn, >>>                       locked = NULL; >>>                   } >>> -                if (isolate_movable_page(page, mode)) >>> +                if (isolate_movable_page(page, mode)) { >>> +                    folio = page_folio(page); >>>                       goto isolate_success; >>> +                } >>>               } >>>               goto isolate_fail; >>> @@ -1003,7 +1007,8 @@ isolate_migratepages_block(struct >>> compact_control *cc, unsigned long low_pfn, >>>            * sure the page is not being freed elsewhere -- the >>>            * page release code relies on it. >>>            */ >>> -        if (unlikely(!get_page_unless_zero(page))) >>> +        folio = folio_get_nontail_page(page); >> >> I'm just curious, how can you make sure the 'page' is not a tail page? >> Since the validation is lockless. > > folio_get_nontail_page is added by commit "3c1ea2c729ef (mm: add > folio_get_nontail_page())", see more comments [1] > > [1] https://lore.kernel.org/lkml/Y86sRiKAAOz2myNe@casper.infradead.org/ I see. Thanks for sharing. The changes look good to me at least. Please feel free to add: Reviewed-by: Baolin Wang