From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67F57C4332F for ; Thu, 9 Nov 2023 15:34:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ED661440149; Thu, 9 Nov 2023 10:34:33 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E86168D0073; Thu, 9 Nov 2023 10:34:33 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D9CC0440149; Thu, 9 Nov 2023 10:34:33 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id C83E48D0073 for ; Thu, 9 Nov 2023 10:34:33 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 22AA940E4B for ; Thu, 9 Nov 2023 15:34:33 +0000 (UTC) X-FDA: 81438812826.03.DF37015 Received: from out-188.mta1.migadu.com (out-188.mta1.migadu.com [95.215.58.188]) by imf20.hostedemail.com (Postfix) with ESMTP id 12E701C0006 for ; Thu, 9 Nov 2023 15:34:29 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=I+7dxyoh; spf=pass (imf20.hostedemail.com: domain of jeff.xie@linux.dev designates 95.215.58.188 as permitted sender) smtp.mailfrom=jeff.xie@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1699544070; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=fh5FxdhqxyPMFvq7DwpOb62I2S3xPmOM/5undUGaLs8=; b=Bw9NRg6UVC8plR3IwDyuESQ9MyARFuUNl0gNrMBttogkrwyExrCR6wMe/o8SJYv9qfFa30 RvmRaziQ8Y/TqNXZQ1RNhiZ+1XPMiOQXXPyxdv+bto/bATs0Jenvycz5vCil2rZa+0VL9Y 2grBu5qnPa+T4PHD8+NVo31X5AKMMbQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1699544070; a=rsa-sha256; cv=none; b=66yTuPm27pEZt5LRbZ1X6oPLYNM+vLXuTKvjT+za8YPYCT4FtYQNuSfirZY+evoHMQoUY9 myClYjEmBdvFB7jFGMUGJDFNwHm40WlDeltfcCPTZA2xKYKq7+guaP/jvsud/zHmgYfhp8 0UyNmkc4z/ZZj3MlBs6wtDSG6MRkj+s= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=I+7dxyoh; spf=pass (imf20.hostedemail.com: domain of jeff.xie@linux.dev designates 95.215.58.188 as permitted sender) smtp.mailfrom=jeff.xie@linux.dev; dmarc=pass (policy=none) header.from=linux.dev MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1699544067; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fh5FxdhqxyPMFvq7DwpOb62I2S3xPmOM/5undUGaLs8=; b=I+7dxyohR20zDvsdodZRebLKR6MvQj2wWNnaWNN2hCEoIGx9P+RBWSSqNJhXagEizarlYt SABIRD5ZWbmiZL5h5Dg6c65s7yNoaa//gElgYzkpQmu36bT73cAsC2bjZ7ZF2eEnB6cfU4 Io5I2qjGy4YR/De6h5wz7vEU8y8CgV8= Date: Thu, 09 Nov 2023 15:34:25 +0000 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: jeff.xie@linux.dev Message-ID: <58b99c29425dd61130f04b41be14e3609daf5a91@linux.dev> TLS-Required: No Subject: Re: [RFC][PATCH 2/4] mm, slub: implement slub allocate post callback for page_owner To: "Matthew Wilcox" Cc: akpm@linux-foundation.org, iamjoonsoo.kim@lge.com, vbabka@suse.cz, cl@linux.com, penberg@kernel.org, rientjes@google.com, roman.gushchin@linux.dev, 42.hyeyoo@gmail.com, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, chensong_2000@189.cn, xiehuan09@gmail.com In-Reply-To: References: <20231109032521.392217-1-jeff.xie@linux.dev> <20231109032521.392217-3-jeff.xie@linux.dev> X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: 12E701C0006 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: yzbwkbjdqswsmh869r9xnjjfnu3fmt84 X-HE-Tag: 1699544069-90764 X-HE-Meta: U2FsdGVkX1/JGfmkxC1g67tr1tUO/wm0ySe6Z/26bX/juuqXERmfNHAS0/a7k0lWZqBdJUSohrzzyj9TrKHKz4b+K+sJJ2tYcJEn0KXOU1HptUIYIW9OwOGjGX2A+rHcFM9PhE4ipYmnj2YB5P9kPu7ntGARvngV+nOrT5Z//6cZvHiVqG1/IaB3rtCVDmvKUAqKYZE+GdLj2nw+uqbM0vci9jdHny0GOWkOg7QZ1WyV7Ms9GQmmJV9s3EU33SAI3AsRRR3vt14Jr0AlmQDCj4nzKBb+q1gy2dnKLh+VvUXeAB70XaOFFYtXfttBzgPQOTuKOBLP8vGTGAkLJ7Fv0vQ59miofewOz1zWHWqLHSPwZfPyb+uE3myIWAVT+NghNG5zJsUeKKy6LJKF7NgeIxAFZrgyEPpuY3+Zv/yo/dLSu8f+7O7L4nZzo2edw21xRt9Uayqyb8j2z3z1ZDolnMT3xymNS+B+ztnoWRmoyHjpFKoYsfAaFw2U7TmcrPSpqqi+GnICqy37oPeIDaDjvGu3+QO+4WMkACetL5J3d5fjJE4C3tyf0bu40rXPislGxH1h6feQ7oDgcudhsAbohR3El/LurUY2lqix2Fa38bXBJnqtW+yoVCzEkUDADg4ohcs3RrY2nKrxHmkHO+PzpzXLfi7wErzJVfHnixsHK6+mRlwHFsxUt7diTppZiH643dOm9CQwFh1n9gnb5+pabOunCfhLWSKxB82C65dqgbHkkph1s0h+Rz4GEofnwaNShbQj9wA7ahZDre/QIg6KFSPYuyNp60C5K3zzselXgThICu7btPznlaxo4sptgXVMloOYEN6ZypITLSeym2aRs2AVDcpaGP0BXXEMGWSo9LKJicSVDyduX+9lyzquvCQaJxq0c0GRZBCb4Vd0jMRDTshHdZcYegUjdZVLKpxv0wpofoJFO1aoNbucyTtua4TLzOosHJ2SB7fWFZwD5xp g48Wr97O 2JLFHkDdVf2UkhS7Z1xtf+9ehNMWdYcLQex7faZ+dF9dvnAlvELAtHcmEMtI8olpu4R0uDGFJfQkDqvzPcijzEzXMTxDX+POH6eMjibIDu3ZYac85oNcfVbvqnqBziGty/ZFr/w6s8zWY3OMKeQB04lvTmXVQGrR2PUdvPcvd8v1hteLN19RsYrMi6bPzs2dLCuMzcJO2eIKI7DjXHQVo1U9EhBnLkOM5EOlzrCUMzLYSIO0cGMsjK5qRMI7sQedqOlEFJMbRvU5NuJ9LiPhFn1OpzMNg4wRQjoQIiFGCp8ArqbAk6Tuc42UWSWnjHFQcBBGGjD0wFN1gSzexaQmCRTHWLTFuwXpcBV/3PDH6xXEjBFDdVxo9Ec4RdPQ1JpgzQuyG X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: November 9, 2023 at 10:05 PM, "Matthew Wilcox" wrot= e: >=20 >=20On Thu, Nov 09, 2023 at 11:25:19AM +0800, Jeff Xie wrote: >=20 >=20>=20 >=20> +#ifdef CONFIG_PAGE_OWNER > > +static int slab_alloc_post_page_owner(struct folio *folio, struct t= ask_struct *tsk, > > + void *data, char *kbuf, size_t count) > > +{ > > + int ret; > > + struct kmem_cache *kmem_cache =3D data; > > + > > + ret =3D scnprintf(kbuf, count, "SLAB_PAGE slab_name:%s\n", kmem_ca= che->name); > > + > > + return ret; > > +} > > +#endif > >=20 >=20 > Or we could do this typesafely ... >=20 >=20 struct slab *slab =3D folio_slab(folio); > struct kmem_cache *kmem_cache =3D slab->slab_cache; >=20 >=20... and then there's no need to pass in a 'data' to the function. > I accidentally replied using my other email (xiehuan09@gmail.com) just no= w.=20 Thank=20you for your advice. Indeed, the "data" didn't serve any purpose = here. -- Jeff Xie