From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C8F0C46CA3 for ; Tue, 28 Nov 2023 12:15:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D15896B0246; Tue, 28 Nov 2023 07:15:42 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CC3AA6B024B; Tue, 28 Nov 2023 07:15:42 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B8BB36B02F4; Tue, 28 Nov 2023 07:15:42 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id A503C6B0246 for ; Tue, 28 Nov 2023 07:15:42 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 5D9EAC01B5 for ; Tue, 28 Nov 2023 12:15:42 +0000 (UTC) X-FDA: 81507258924.29.E678447 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf30.hostedemail.com (Postfix) with ESMTP id 708FC8000E for ; Tue, 28 Nov 2023 12:15:39 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=none; spf=pass (imf30.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701173740; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ifikt70MRDjBpGz3EujBK91avUGGg9+a9Kmp3OIe4Cg=; b=ZPBeY8mElpoo2lWDPUAHeZ3Sf6qwEu7i6txoM5PpEsupLfYgIqG3a47cQZEWP1IGd5p1Jv buzAjr1DvNEjvxK/7LNszTKnvKVuyd6c9/yZhgj99OKtHk6SJyo65gxlbOu7qEHX6urKMy D3amv6ZfeteVHESFmAW/ALZI+fjPEW8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701173740; a=rsa-sha256; cv=none; b=6HKfHhw7yqHFz2ULbqcZvhwLiSstYzNkrmXoq7fybw1tsUGFDb0HKVmN1C18BEf5ZEUHc5 nmdIxESVogWYMK/mPBlPzAqGHyJZ89wk0RP+xseBZKZnqXTJwkrMNjSZBArHT9Jw/jzvOF xcWxptomjMjKsAhCDscoPxl4Rz1HoCs= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=none; spf=pass (imf30.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com; dmarc=pass (policy=none) header.from=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E44DCC15; Tue, 28 Nov 2023 04:16:25 -0800 (PST) Received: from [10.1.33.188] (XHFQ2J9959.cambridge.arm.com [10.1.33.188]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E69273F73F; Tue, 28 Nov 2023 04:15:32 -0800 (PST) Message-ID: <58af512c-3d7d-4774-88f7-6336c9384b61@arm.com> Date: Tue, 28 Nov 2023 12:15:30 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RESEND PATCH v7 00/10] Small-sized THP for anonymous memory Content-Language: en-GB To: David Hildenbrand , John Hubbard , Alistair Popple Cc: Matthew Wilcox , Andrew Morton , Yin Fengwei , Yu Zhao , Catalin Marinas , Anshuman Khandual , Yang Shi , "Huang, Ying" , Zi Yan , Luis Chamberlain , Itaru Kitayama , "Kirill A. Shutemov" , David Rientjes , Vlastimil Babka , Hugh Dickins , Kefeng Wang , linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20231122162950.3854897-1-ryan.roberts@arm.com> <9c8f6d2a-7ed8-45d2-9684-d77489bd99b8@redhat.com> <26c361bc-6d87-4a57-9fae-ef635c9039c7@redhat.com> <87sf4rppuc.fsf@nvdebian.thelocal> <51e6c9f1-e863-464b-b5f3-d7f60a7ebed6@arm.com> From: Ryan Roberts In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 708FC8000E X-Rspam-User: X-Stat-Signature: ajuazk1a84ffqma68wfgrxzod13a4xjo X-Rspamd-Server: rspam03 X-HE-Tag: 1701173739-293203 X-HE-Meta: U2FsdGVkX1+Vbnm2vrAO/+a8ywoMOKPFyGpDIwdJzmyIs+7BsS5ay5Upuszi61LTdJIsxaM+21D4+mINNywHmSG5I4hPQB4Yz6emk1BGapXUJ6RFeW5y5q6tvjjJdUUztEbT8LnPQe5SLzOgI4jTpR2SRrTn7VBU7FxJxBrctdsFVRIK+neI0BiXsS347ul/Miwk6oqj0TR2mUf2ejqT/CKCOuxeegm06kj0e7wlqt8kgqBT3qynhdWUVFLZAZRnqUegK5iOUs2WlCoufEJZnuz6wn8VuJ9Bxk8dCitX1pGE6FL5eYkhluiRClLp5Brth0X/MktTcbQ6yZ2a76U8X6aCIBhgbMdjvihVfskGoTnIBUGIsHQsvH473EugEqPACtppYjzDOVNoCwKTwEDQ0gi4PfVJq66LsUsuZJrHxdxRiO/PKiNWSnowByRqyMhMo5a0N7yyuqUwdFeKejqy6AqKybLSnNLXLOHicFZ9sB8YuQGShYLJDlJxF06hWyjgrV79rpGvlsasEblfex/q/VY5kfrRSQQprhgWxb0wGI9GMlxnRl0eVwB8/3RW8a2NKTOWbzRlVBvQtcGb+fgu2ik2hOYBcqyH/mXlz3ttEKacAcUdiUT+K/1M74XuZS/4h8lOAVCzvby/JZvRAkPw4L2whksJtYd/k1qopSWJkA4hJpR0o21RUDrlOClNoEk3vKa7cdz27rI9aDNeD/s2lxqtHB+qJ/iTWv5N3FnL25L6iDTeNx8F5+L5xcU8L/2l2Hu1Mc7Bo6t4YsCGVYXZl0g8Cow2J4OzHElD29eAL0u18IWwY/FjEScz3Pep9vTXA4qdSQGOyVOpMNJQqL1WwRhfxsdi6tDMJtW35b+vEjrfTe8N5SDuhcEl7O9Jzr0jook1iSpPe3vzTCKCIsitEeRMP50SHQb0ffCwxeMACA+ekfrlDLUhNlZMPRbPLMkXdXorwlSxfRN4m9tSg7a We0SSpb5 kOPBbZSOUCv/1g7jNOMBPUrafjSSZeDlZnmue4MLuOXl9pm5sxs3FI+HLrPz+NB+IlG2ZD9yLIuVxwCZjISr8V8b/eCHoU5dCBPOfSIc7HopaXNdAYrQun+3qqF++Lwbxm2Dmf6jvgXeWXSfbWQZGHK5LY0C2KSJ76r/f0r9CdDJJnc+xTBVTP8gJTISduM77cyzTi0YUM+9VAdpGPc+Tik9b2g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 28/11/2023 08:48, David Hildenbrand wrote: > >>> >>> Agreed. We are bikeshedding here. But if we really can't swallow "small-sized >>> THP" then perhaps the most efficient way to move this forwards is to review the >>> documentation (where "small-sized THP" appears twice in order to differentiate >>> from PMD-sized THP) - its in patch 3. Perhaps it will be easier to come up with >>> a good description in the context of those prose? Then once we have that, >>> hopefully a term will fall out that I'll update the commit logs with. >>> >> >> I will see you over in patch 3, then. I've already looked at it and am going >> to suggest a long and a short name. The long name is for use in comments and >> documentation, and the short name is for variable fragments: >> >>       Long name:  "pte-mapped THPs" >>       Short names: pte_thp, or pte-thp > > The issue is that any THP can be pte-mapped, even a PMD-sized THP. However, the > "natural" way to map a PMD-sized THP is using a PMD. > How about we just stop trying to come up with a term for the "small-sized THP" vs "PMD-sized THP" and instead invent a name that covers ALL THP: "multi-size THP" vs "PMD-sized THP". Then in the docs we can talk about how multi-size THP introduces the ability to allocate memory in blocks that are bigger than a base page but smaller than traditional PMD-size, in increments of a power-of-2 number of pages.