From: Song Liu <songliubraving@fb.com>
To: Oleg Nesterov <oleg@redhat.com>
Cc: lkml <linux-kernel@vger.kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"matthew.wilcox@oracle.com" <matthew.wilcox@oracle.com>,
"kirill.shutemov@linux.intel.com"
<kirill.shutemov@linux.intel.com>,
"peterz@infradead.org" <peterz@infradead.org>,
"rostedt@goodmis.org" <rostedt@goodmis.org>,
"Kernel Team" <Kernel-team@fb.com>,
"william.kucharski@oracle.com" <william.kucharski@oracle.com>
Subject: Re: [PATCH v8 2/4] uprobe: use original page when all uprobes are removed
Date: Wed, 24 Jul 2019 09:20:22 +0000 [thread overview]
Message-ID: <58E13FCB-FE49-454F-995F-832870D314F1@fb.com> (raw)
In-Reply-To: <20190724091725.GC21599@redhat.com>
> On Jul 24, 2019, at 2:17 AM, Oleg Nesterov <oleg@redhat.com> wrote:
>
> On 07/24, Oleg Nesterov wrote:
>>
>> On 07/24, Song Liu wrote:
>>>
>>> This patch allows uprobe to use original page when possible (all uprobes
>>> on the page are already removed).
>>
>> and only if the original page is already in the page cache and uptodate,
>> right?
>>
>> another reason why I think unmap makes more sense... but I won't argue.
>
> but somehow I forgot we need to read the original page anyway to check
> pages_identical(), so unmap is not really better, please forget.
>
Yeah, I was trying to explain this. :)
Thanks for your feedbacks.
Song
next prev parent reply other threads:[~2019-07-24 9:21 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-24 8:35 [PATCH v8 0/4] THP aware uprobe Song Liu
2019-07-24 8:35 ` [PATCH v8 1/4] mm: move memcmp_pages() and pages_identical() Song Liu
2019-07-24 8:35 ` [PATCH v8 2/4] uprobe: use original page when all uprobes are removed Song Liu
2019-07-24 9:07 ` Oleg Nesterov
2019-07-24 9:17 ` Oleg Nesterov
2019-07-24 9:20 ` Song Liu [this message]
2019-07-24 11:37 ` Oleg Nesterov
2019-07-24 18:52 ` Song Liu
2019-07-25 8:14 ` Oleg Nesterov
2019-07-25 18:17 ` Song Liu
2019-07-26 6:07 ` Song Liu
2019-07-26 8:44 ` Oleg Nesterov
2019-07-26 21:19 ` Song Liu
2019-07-24 8:35 ` [PATCH v8 3/4] mm, thp: introduce FOLL_SPLIT_PMD Song Liu
2019-07-24 8:36 ` [PATCH v8 4/4] uprobe: use FOLL_SPLIT_PMD instead of FOLL_SPLIT Song Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58E13FCB-FE49-454F-995F-832870D314F1@fb.com \
--to=songliubraving@fb.com \
--cc=Kernel-team@fb.com \
--cc=akpm@linux-foundation.org \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=matthew.wilcox@oracle.com \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=william.kucharski@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox