linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: yalin wang <yalin.wang2010@gmail.com>
To: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
	Mel Gorman <mgorman@suse.de>,
	Johannes Weiner <hannes@cmpxchg.org>,
	riel@redhat.com, raindel@mellanox.com, willy@linux.intel.com,
	boaz@plexistor.com, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: change tlb_finish_mmu() to be more simple
Date: Wed, 4 Nov 2015 16:46:25 +0800	[thread overview]
Message-ID: <58D5B463-D8C3-40E2-A0B0-458DB1117338@gmail.com> (raw)
In-Reply-To: <20151104083610.GA403@swordfish>


> On Nov 4, 2015, at 16:36, Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> wrote:
> 
> On (11/04/15 15:35), yalin wang wrote:
> [..]
>> 
>> -	for (batch = tlb->local.next; batch; batch = next) {
>> -		next = batch->next;
>> +	for (batch = tlb->local.next; batch; batch = batch->next)
>> 		free_pages((unsigned long)batch, 0);
> 
> accessing `batch->next' after calling free_pages() on `batch'?
> 
> 		-ss
oh,  my mistake, my code is buggy here .

Thanks
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

      reply	other threads:[~2015-11-04  8:46 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-04  7:35 yalin wang
2015-11-04  8:33 ` Kirill A. Shutemov
2015-11-04  8:36 ` Sergey Senozhatsky
2015-11-04  8:46   ` yalin wang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=58D5B463-D8C3-40E2-A0B0-458DB1117338@gmail.com \
    --to=yalin.wang2010@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=boaz@plexistor.com \
    --cc=hannes@cmpxchg.org \
    --cc=kirill.shutemov@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mgorman@suse.de \
    --cc=raindel@mellanox.com \
    --cc=riel@redhat.com \
    --cc=sergey.senozhatsky.work@gmail.com \
    --cc=willy@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox