From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F149D5E154 for ; Fri, 8 Nov 2024 10:38:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BBC296B00A0; Fri, 8 Nov 2024 05:38:07 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B45166B00A1; Fri, 8 Nov 2024 05:38:07 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A0C1D6B00A2; Fri, 8 Nov 2024 05:38:07 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 7FDC06B00A0 for ; Fri, 8 Nov 2024 05:38:07 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 2F00CA0B6A for ; Fri, 8 Nov 2024 10:38:07 +0000 (UTC) X-FDA: 82762576764.12.D5ACE75 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by imf26.hostedemail.com (Postfix) with ESMTP id 10362140017 for ; Fri, 8 Nov 2024 10:37:36 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=qkoCKyxZ; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf26.hostedemail.com: domain of donettom@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=donettom@linux.ibm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731062224; a=rsa-sha256; cv=none; b=MbKa1DcK/u3gSmp21givP5X9IXU3E/sUOT9OIbq1iO41nIjWNWDuzqQVUJrUCpQy20Lxe1 BVNV7RHtfod6B90XyTxAe5Sx55uC8zbdk7xZHanOF9Ho+icfYgLQWXwYjP5/mlawbzNBkG AWXpnFV7hKs6OBJo7htnVyxyQvzwhNc= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=qkoCKyxZ; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf26.hostedemail.com: domain of donettom@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=donettom@linux.ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731062224; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YV7dqm1guhPXEd+Ayv5dY9WkStJcSAGbALacM9gpk/I=; b=yoRBG8rgrVARLPjgbC8kKanJGabz013uUSp2Oyba15orfVjhg7eYS9Ot4kJ0fmP6k5G0eu 0FcJZENz0i0FW65/kWmM+Z/RvJiJz/yMjGxQUSWwUVTiGGfSyR+pvdEWOuFWgq8YeiDSz3 eL+siV3WVYjnyK05lCbwc2io/UScu4U= Received: from pps.filterd (m0360083.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4A8A9oSL023429; Fri, 8 Nov 2024 10:38:01 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pp1; bh=YV7dqm 1guhPXEd+Ayv5dY9WkStJcSAGbALacM9gpk/I=; b=qkoCKyxZGO8s0i1DthAwRO rDJbviz+tumYreCe8m1xkt08JYEyprlQjPRVEbhpRDdgyBzLTe3nyzxfOzAWXOOl +e0HhaF42qtlEr1DZZvrNzPMMTuCmXex1mzRkgEt4rEBIHo4iwq1aW1pPOAqyoFm 3eODm+BlofKzeGhDbHuGO8dOXKxyoe9Gq1MbbI1TLmM+K1v8lWhdwg9UDLHQTy0c 3XrelxSEaTm8Mfl3/QbE64tI/xHdpoHEBtp4y7Z++H2l3vnIsUx/qABj8P3xY17V C7jH/hxpIDWUyCV05ELVPFvNDEfJMcyrECwNgCD20AWNXmUsR5FvydRwBPBS4dFQ == Received: from ppma11.dal12v.mail.ibm.com (db.9e.1632.ip4.static.sl-reverse.com [50.22.158.219]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 42sgn7835n-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 08 Nov 2024 10:38:00 +0000 (GMT) Received: from pps.filterd (ppma11.dal12v.mail.ibm.com [127.0.0.1]) by ppma11.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 4A83XgUR023412; Fri, 8 Nov 2024 10:35:13 GMT Received: from smtprelay02.wdc07v.mail.ibm.com ([172.16.1.69]) by ppma11.dal12v.mail.ibm.com (PPS) with ESMTPS id 42p1411ysp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 08 Nov 2024 10:35:13 +0000 Received: from smtpav04.dal12v.mail.ibm.com (smtpav04.dal12v.mail.ibm.com [10.241.53.103]) by smtprelay02.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 4A8AZClr21758536 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 8 Nov 2024 10:35:13 GMT Received: from smtpav04.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 8EC6758067; Fri, 8 Nov 2024 10:35:12 +0000 (GMT) Received: from smtpav04.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 2844858065; Fri, 8 Nov 2024 10:35:10 +0000 (GMT) Received: from [9.179.28.136] (unknown [9.179.28.136]) by smtpav04.dal12v.mail.ibm.com (Postfix) with ESMTP; Fri, 8 Nov 2024 10:35:09 +0000 (GMT) Message-ID: <5883b1c0-13c6-4593-9dd5-17f34c1319fe@linux.ibm.com> Date: Fri, 8 Nov 2024 16:05:08 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] selftests: hugetlb_dio: Check for initial conditions to skip in the start To: Muhammad Usama Anjum , Andrew Morton , Shuah Khan Cc: kernel@collabora.com, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org References: <20241101141557.3159432-1-usama.anjum@collabora.com> Content-Language: en-US From: Donet Tom In-Reply-To: <20241101141557.3159432-1-usama.anjum@collabora.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: J3MZ_ATCNLJm_HHz-P-dL4bmOnro8wQp X-Proofpoint-ORIG-GUID: J3MZ_ATCNLJm_HHz-P-dL4bmOnro8wQp X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1051,Hydra:6.0.680,FMLib:17.12.62.30 definitions=2024-10-15_01,2024-10-11_01,2024-09-30_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 adultscore=0 malwarescore=0 priorityscore=1501 mlxlogscore=945 phishscore=0 suspectscore=0 impostorscore=0 spamscore=0 lowpriorityscore=0 clxscore=1011 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2409260000 definitions=main-2411080086 X-Rspam-User: X-Rspamd-Queue-Id: 10362140017 X-Rspamd-Server: rspam01 X-Stat-Signature: xmfx5xqdxs4oef656dheab7gh9nrfzmd X-HE-Tag: 1731062256-510709 X-HE-Meta: U2FsdGVkX1/d7hb152gca9bZmbEK5HQXGjpiITxticu2QrQHqjCTNcSP4znyHMKmuqt5liBe/g24zSe8nZ+ZFDdui9I8KW76j+bKNQbTzYF7DB+RXcdkpqAfO2Umez+o118HFb8Mg3nbd/OzIrKqnSZzd22nyXyd5unYU6k4wDu5AEgVNmCgY7jDxN72M5VxdEWtWxuHmvSWZHbSk2SEDYE6hEWPA7N7bB42f/Psc2uvQAh3m84dcJ0owf/pabxe2VTERFZvHvVwtkrl0oefNjZ8xEJU4XVQS6JcFC0G+eghJLWuNGpRL2AQEECtzBU/6TptU15L3621MeebpIFWI7cY9p1DBZOEjtIYK72QM+rsEMHHpGBZBnFwXkTHv+oIbfkH+F5uJ/2WBRFP25VFCq6cioxnY51ttkQWcbHPG0uWNJfG8MPSC3alVadlLJOo3yM41e+Knk9NYWrM57nxfuSY3/DQr/ZAsJPS9YXnPd2fBopJHLHKY8E/TTo5q3oGiZnt04BuA/+Ucvv0mhOixoTiB0z+9oL8GPoUQO2Iajc19wQXD4nMC5glTXH0KW2xsOlaIFABmJLM4A7qWeOIMh0bWH+nrvE8j93EFTENuSyYf7YmwJTKowSr3EV/Qy2eceVpuksTr+INCqoleFck8R36ulsI1O4aiB7I/6FikTr8CLNWYck+BxaaGmLIzwzF/MoyiR1z5GVWOoAO3LsfSxxg7XKoYkWjBvegJr+slSdvRoZSKZ78Z3/5clTdVoEEnL+l5+DETS6mSnQMElrRcZU/AIEJHeS++O90DFxxuWU4O96qZfuZmjzKpxsR1+hHH/etHwPkOfwHTn0HZX5b2Jr3yaB+Xf/4pEEKUiyWp8dZ3QRPOJKsTYRAN9Y44SVOF1XE6kXhsLAFAWVGn2ul4ztaEo4zgJWQ0f2eO4ich0OZ+LwYH3px/sQx9RAh52EIhWL0JNtu216zFuXsYLn gROq3rph tPtCcbaSKhCLPoGEuuIGYZHr4Xik7/V2Pq9ePKlePLuaulC3NJZX8EqveirkwaPapxduBD+4Oc3S/zOqfOC5sx9UA+acazABuEZe3wZhT7h+axvdM+9AJm3anj9B89B+6LjH4J4OcfeEl/FzUA7nG506BKFs+W8vpi1ygeDQOIioXBuvSgI6POz0XMg3VbGuAq6NKPLBQJjBFHemxprdQ+5cWoer/bosBg2kDaUxW74gPdCyUg0aTXZyJDSxZYi6an/A6/N3O+UNyCwalHbf4i2LcZ9d/e838mEGNG8Qg3kel9d9Z/R2+3wBde/9NBxfklA5iMkDs3rPwrsG5cMpaibxrxLwRkwrLQKv19asaxP6cytT8NAwef6zpc8HDZeUNeZJ1LJ+Xs0cOVd7cHgv8zAdDXiN3iYYy+RW24hoMLQ9dL6lv8/ZJbXx5VI+AAy1Mf85OdtLwEFmqY/Y= X-Bogosity: Ham, tests=bogofilter, spamicity=0.002049, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 11/1/24 19:45, Muhammad Usama Anjum wrote: > The test should be skipped if initial conditions aren't fulfilled in > the start instead of failing and outputting non-compliant TAP logs. This > kind of failure pollutes the results. The initial conditions are: > - The test should only execute if /tmp file can be allocated. > - The test should only execute if huge pages are free. > > Signed-off-by: Muhammad Usama Anjum > --- > Before: > TAP version 13 > 1..4 > Bail out! Error opening file > : Read-only file system (30) > # Planned tests != run tests (4 != 0) > # Totals: pass:0 fail:0 xfail:0 xpass:0 skip:0 error:0 > > After: > TAP version 13 > 1..0 # SKIP Unable to allocate file: Read-only file system > --- > tools/testing/selftests/mm/hugetlb_dio.c | 19 ++++++++++++------- > 1 file changed, 12 insertions(+), 7 deletions(-) > > diff --git a/tools/testing/selftests/mm/hugetlb_dio.c b/tools/testing/selftests/mm/hugetlb_dio.c > index f9ac20c657ec6..60001c142ce99 100644 > --- a/tools/testing/selftests/mm/hugetlb_dio.c > +++ b/tools/testing/selftests/mm/hugetlb_dio.c > @@ -44,13 +44,6 @@ void run_dio_using_hugetlb(unsigned int start_off, unsigned int end_off) > if (fd < 0) > ksft_exit_fail_perror("Error opening file\n"); > > - /* Get the free huge pages before allocation */ > - free_hpage_b = get_free_hugepages(); Hi Muhammed Usman Anjum Reading the free pages is required before starting the test. This value will be compared to the free pages after the test. If they are not the same, the test will be considered a failure. Since reading the free pages before the test was removed,|free_hpage_b| is always 0, causing the test to fail. ./tools/testing/selftests/mm/hugetlb_dio TAP version 13 1..4 # No. Free pages before allocation : 0 # No. Free pages after munmap : 100 not ok 1 : Huge pages not freed! # No. Free pages before allocation : 0 # No. Free pages after munmap : 100 not ok 2 : Huge pages not freed! # No. Free pages before allocation : 0 # No. Free pages after munmap : 100 not ok 3 : Huge pages not freed! # No. Free pages before allocation : 0 # No. Free pages after munmap : 100 not ok 4 : Huge pages not freed! # Totals: pass:0 fail:4 xfail:0 xpass:0 skip:0 error:0 I think below changes are required. --- a/tools/testing/selftests/mm/hugetlb_dio.c +++ b/tools/testing/selftests/mm/hugetlb_dio.c @@ -44,6 +44,9 @@ void run_dio_using_hugetlb(unsigned int start_off, unsigned int end_off) if (fd < 0) ksft_exit_fail_perror("Error opening file\n"); + /* Get the free huge pages before allocation */ + free_hpage_b = get_free_hugepages(); + /* Allocate a hugetlb page */ orig_buffer = mmap(NULL, h_pagesize, mmap_prot, mmap_flags, -1, 0); if (orig_buffer == MAP_FAILED) { With this change the tests are passing. ./tools/testing/selftests/mm/hugetlb_dio TAP version 13 1..4 # No. Free pages before allocation : 100 # No. Free pages after munmap : 100 ok 1 : Huge pages freed successfully ! # No. Free pages before allocation : 100 # No. Free pages after munmap : 100 ok 2 : Huge pages freed successfully ! # No. Free pages before allocation : 100 # No. Free pages after munmap : 100 ok 3 : Huge pages freed successfully ! # No. Free pages before allocation : 100 # No. Free pages after munmap : 100 ok 4 : Huge pages freed successfully ! # Totals: pass:4 fail:0 xfail:0 xpass:0 skip:0 error:0 Thank Donet > - if (free_hpage_b == 0) { > - close(fd); > - ksft_exit_skip("No free hugepage, exiting!\n"); > - } > - > /* Allocate a hugetlb page */ > orig_buffer = mmap(NULL, h_pagesize, mmap_prot, mmap_flags, -1, 0); > if (orig_buffer == MAP_FAILED) { > @@ -94,8 +87,20 @@ void run_dio_using_hugetlb(unsigned int start_off, unsigned int end_off) > int main(void) > { > size_t pagesize = 0; > + int fd; > > ksft_print_header(); > + > + /* Open the file to DIO */ > + fd = open("/tmp", O_TMPFILE | O_RDWR | O_DIRECT, 0664); > + if (fd < 0) > + ksft_exit_skip("Unable to allocate file: %s\n", strerror(errno)); > + close(fd); > + > + /* Check if huge pages are free */ > + if (!get_free_hugepages()) > + ksft_exit_skip("No free hugepage, exiting\n"); > + > ksft_set_plan(4); > > /* Get base page size */