From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE112C54798 for ; Tue, 5 Mar 2024 16:22:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6D3CF6B0088; Tue, 5 Mar 2024 11:22:20 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 684CD6B0089; Tue, 5 Mar 2024 11:22:20 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 525EE6B008A; Tue, 5 Mar 2024 11:22:20 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 420F86B0088 for ; Tue, 5 Mar 2024 11:22:20 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id EF804140ADA for ; Tue, 5 Mar 2024 16:22:19 +0000 (UTC) X-FDA: 81863502798.24.7A54056 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf08.hostedemail.com (Postfix) with ESMTP id BA9BD16001D for ; Tue, 5 Mar 2024 16:22:17 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=OsIAF6CZ; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf08.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709655737; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HP9C+rdgr4fOwFC+fJYUv+fItgUKFD8btPOgXvimh54=; b=vAkjIyyjRQRrfxpk/P6BccNMA6vhXoKzms5lVifb2ZTTg5cqdgrauWJHi6RydN1xBVLwH4 fBd+B+1OIdf8jDq0ii2RQxeOU1QgGTyphw7+f0UrhiR9NDJkAQtWlBDpzgK/ZymF60xLk9 XyWE3TKx11/9+ra7kGBtcPlKF2nS6m8= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=OsIAF6CZ; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf08.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709655737; a=rsa-sha256; cv=none; b=h20nq/SdG9AF39POdsRdgHt50jIzBAwcicn7OJfPo63PRgX4fmwBst9gVs+jYMCFAX4Ex1 wTNa4My9aBNTslB69CUO6d3P+9NyofFRbrUdsPajGD5w+M5k8qq8O6LW6GGImW4JSnh55m PpnAnPqfi1PFKa4ezzp/5om3nKD1CXg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1709655737; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=HP9C+rdgr4fOwFC+fJYUv+fItgUKFD8btPOgXvimh54=; b=OsIAF6CZo16rHgzZX7yejCs3KaPHDj1QY6xakS3czKj1vbfrTQnNV7PHw1K13pFk1efu6/ gwgFcXnmQHgwqhjTKpT3JgUUpHh5hR5WO6FNFKAP3Q4eMNk2L7TVuGVkLzAqqlVdP5cAt0 HtblsyepkJ5mrwSwlJ0ud7DUFhSPzH8= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-328-pRQYdVKIMRSPnAgWxWHF5w-1; Tue, 05 Mar 2024 11:22:10 -0500 X-MC-Unique: pRQYdVKIMRSPnAgWxWHF5w-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-412db897ef8so14396135e9.1 for ; Tue, 05 Mar 2024 08:22:09 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709655729; x=1710260529; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=HP9C+rdgr4fOwFC+fJYUv+fItgUKFD8btPOgXvimh54=; b=FDRDpDbBcloD8suzPFROCBfWfu5cRj3mHojuDbHkPiTqQ7qA+7AEKDxhkv4ecM6bEq CgsU/1N0FiSGaNVttN3XVTL7f/Par7roNd8tC3b+BSHF9vBbG2sqc6ZWw91wtbH4hw1F /E39JCKhLt9/NM91IZ/g29gVJIaDtxW0Zwta3f8D6jIxfpJ8OsxyIesIIpgxkoOmkhWm pdbT4jJtN+YRDnDXDxF5VkTITg3FU3Khy+w+RooTZ0jAxef4f27NunDtIoO1h2y6NlEx /GRcpD2HrIRmDILGkjqMTubjPO96tyQURR75xZI4dy9CbKnqVWKdvJjTY0ExMAILk5gs 2DfA== X-Gm-Message-State: AOJu0YxDHDztX4VGQbnp0hrzLipAV5/PhFZ8fnYss7jlWfBqQ5pIddM1 aAhJqYB7oeMBgf7hrDiWjupCWIhxBiYY6U4vYI5G7lxvNYKp7CXkB3TU43UlEbvbJB5ev9NZDYK xMq4ImzyT0Lob1rpCq/BsZQuHnNtuYvcSnAEQmbiOKRI3mnA4 X-Received: by 2002:a05:600c:3846:b0:412:e568:a123 with SMTP id s6-20020a05600c384600b00412e568a123mr2788383wmr.10.1709655729029; Tue, 05 Mar 2024 08:22:09 -0800 (PST) X-Google-Smtp-Source: AGHT+IE4rmScddkOzoQRTAWscoHiHRAJMlx5bhlP/Gy3d1Zo0RCrRIlqJ0Texua0xTBLdiCnIOX/5w== X-Received: by 2002:a05:600c:3846:b0:412:e568:a123 with SMTP id s6-20020a05600c384600b00412e568a123mr2788357wmr.10.1709655728647; Tue, 05 Mar 2024 08:22:08 -0800 (PST) Received: from ?IPV6:2003:cb:c73c:8100:600:a1e5:da94:a13a? (p200300cbc73c81000600a1e5da94a13a.dip0.t-ipconnect.de. [2003:cb:c73c:8100:600:a1e5:da94:a13a]) by smtp.gmail.com with ESMTPSA id p15-20020a05600c468f00b00412b0e51ef9sm18506547wmo.31.2024.03.05.08.22.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 05 Mar 2024 08:22:08 -0800 (PST) Message-ID: <58812e2d-8f81-4760-aa6a-7a0fbe42170e@redhat.com> Date: Tue, 5 Mar 2024 17:22:07 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH STABLE v6.1.y] mm/migrate: set swap entry values of THP tail pages properly. To: Zi Yan , gregkh@linuxfoundation.org, stable@vger.kernel.org Cc: linux-mm@kvack.org, Charan Teja Kalla , "Matthew Wilcox (Oracle)" , Andrew Morton , Huang Ying , Naoya Horiguchi References: <20240305161313.90954-1-zi.yan@sent.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240305161313.90954-1-zi.yan@sent.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: BA9BD16001D X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: xhmtewk7yj619wt7dzxw6z5qgceuzf3r X-HE-Tag: 1709655737-635646 X-HE-Meta: U2FsdGVkX1/q/U+eb7uFxluhX3Rm22Et+voYReQVfkozNNi3EbWRBB19jvzLgOFfglP16mAVuDuC9sTRxna9sKEx8n7LkJQtB5BinGhwRpT6wjpfrSczwKGtWK3MrvHON2WZITmRiwMx6jNtb0YxYktc1IrzxTGogkquSkOX/5JiQqAZ5KyPb8nWSXAPn137VjQPtab0Zc/jmIgx0sYD9XzMD6SVBhOab4MOlYKeXZ4taqYqVoinqdPgYSbzqdp4tqRgsi9dewEEqPBbR5i174g562UVqPvYOiU7Z7mA+QJZ6uymtl8LQa3AB2iy1Adu+JFjGvsC5gzb1MV9wt0YGFhf9dQIA6FpxDUeIoXrJS+zym0T2+j9bYEqp2LJ24hrOokuUgFzMugCdtw4SnxEyyf1dHJnKSs5W7B5mnEo5iNPo7Bo6Snp7nzHS5/K+wd3XorBVrdTYKs+PXUef977ZNXXYDfgN1KNqCEc6EMcI4/0nM+AITSPqqYkcOMnBq1fo1iwheiwsbUn7GrQHQ0Kcv6kgceiy5zOFAB70vYyZAcgLY1XYWddrnG3LxRgZQK/MmARd24Spvweavpi3TvwfLPd5PQaB5P/PEQCxqAm/JIiIgiVzTsZxX9q0j1zhhbviZ6TBCjH/4EXzBxFvRKmb+2XkeaK/FP0tLUiqQsV4qsTiMb+afUQ9IQLKGytiUehbz8K/bEif0PABFSOtFIaLp95F9+JGProLUcSvJ+YbhlNfXWBl2IwvNzf+Oavlz3q9lu2Ihte/+sS+R6mAJsdc/HVfy5kMH2eJBuNoAW0y5pvPfCeZTzKDD9y4INnc3QWfZijD3t6dvu58QCxM6N2bnoGpL73L/TyQAZwYS5Wb3jwCr6/TiQg7ymXLw4vfGFnu1xeVL4HzT/YX0nq4XwWWS5kGYFabC/SvCwKoWpgNB2lxdY92UKnWjaPBSY/VMsBHaKp/Pdyw2JThsqAZyC OmaD9r83 A5SCpeS2lP8ywhKDFtmo9aLx6sBnIdLcYUmAmik0LVJbcJw9AJ1yJNf8NmoZuccFEjoIyPU5QVFodnIHCXX2EV/WA01kmRMT0Pjd6d7lX3rIIQ7k90pgBfZlvmx8CSeB5Y/6bB43F5OkqgMz+TibxP8Yyh7ioejNbaEgl X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 05.03.24 17:13, Zi Yan wrote: > From: Zi Yan > > The tail pages in a THP can have swap entry information stored in their > private field. When migrating to a new page, all tail pages of the new > page need to update ->private to avoid future data corruption. > > Signed-off-by: Zi Yan > --- > mm/migrate.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/mm/migrate.c b/mm/migrate.c > index c93dd6a31c31..c5968021fde0 100644 > --- a/mm/migrate.c > +++ b/mm/migrate.c > @@ -423,8 +423,12 @@ int folio_migrate_mapping(struct address_space *mapping, > if (folio_test_swapbacked(folio)) { > __folio_set_swapbacked(newfolio); > if (folio_test_swapcache(folio)) { > + int i; > + > folio_set_swapcache(newfolio); > - newfolio->private = folio_get_private(folio); > + for (i = 0; i < nr; i++) > + set_page_private(folio_page(newfolio, i), > + page_private(folio_page(folio, i))); > } > entries = nr; > } else { Hopefully Charan can run the reproducer against this. Acked-by: David Hildenbrand -- Cheers, David / dhildenb