From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54E87C27C6E for ; Fri, 14 Jun 2024 05:07:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6ECF06B00B0; Fri, 14 Jun 2024 01:03:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6748C6B00EE; Fri, 14 Jun 2024 01:03:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 49FB56B00B1; Fri, 14 Jun 2024 01:03:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 3AAAE6B00F5 for ; Fri, 14 Jun 2024 01:03:37 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id DD4D31A049F for ; Fri, 14 Jun 2024 05:03:36 +0000 (UTC) X-FDA: 82228301232.20.E312682 Received: from out30-97.freemail.mail.aliyun.com (out30-97.freemail.mail.aliyun.com [115.124.30.97]) by imf11.hostedemail.com (Postfix) with ESMTP id 9B7F94000A for ; Fri, 14 Jun 2024 05:03:33 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=JlpOopHK; dmarc=pass (policy=none) header.from=linux.alibaba.com; spf=pass (imf11.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.97 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718341413; a=rsa-sha256; cv=none; b=MebWzMmlWk2FwnWpWyw8A20PrRwRAeOcpJsm7NJmoi2vVvaVcq97i8C9NfSVJsgz5pZavy 0oylx88a3L1RvjvexeXjCQKA6Ia2CHU61y15k779P3sdJQClz3WVfpS1fzVyXWafnqd8ma PN9DiC+/EQLLWh8TlryzLJQ7lwKl2xU= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=JlpOopHK; dmarc=pass (policy=none) header.from=linux.alibaba.com; spf=pass (imf11.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.97 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718341413; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mQK9TcRk5CAg8ht/5H2KpfQR0Jq0zPNlh/9xoAZV1ak=; b=jf/4Hg+1oaUyo38UF3Lj60UbhO2do/yTk1tzAB+SQuDFzNYHgPyts0krcbc6CyRQIKIK95 33lHhR1IR1CXcFc72OrogS7vYiaZmKelOpsXjOaLQ7MxGyTJaY5y0cO5OQmPIJCoSDT6SY Xs4tO3xwWaiWX5wh9h8ZhD3z0pOJDrQ= DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1718341410; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=mQK9TcRk5CAg8ht/5H2KpfQR0Jq0zPNlh/9xoAZV1ak=; b=JlpOopHKZ/RXRTp2lAaH/b+SPjlEkxqtNKi/9AxUTmfrK4me/T6umtPqakrd6cXf5kl3dRR06LOZe6coUCvOFnbHHOnpLB9aS2emNKeIEFiSAwTBpDHqS2HmoHDsAZlMcr4LU/Ajx9MqwXc+w2amb9E7Lnr0ghYtasyAmESmAwU= X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R111e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=maildocker-contentspam033037067109;MF=baolin.wang@linux.alibaba.com;NM=1;PH=DS;RN=12;SR=0;TI=SMTPD_---0W8Q.rcN_1718341408; Received: from 30.97.56.56(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0W8Q.rcN_1718341408) by smtp.aliyun-inc.com; Fri, 14 Jun 2024 13:03:29 +0800 Message-ID: <58681eb0-cf36-4aa2-906e-a1a8daa2b969@linux.alibaba.com> Date: Fri, 14 Jun 2024 13:03:27 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] mm: shmem: fix getting incorrect lruvec when replacing a shmem folio To: Matthew Wilcox Cc: akpm@linux-foundation.org, hughd@google.com, mhocko@kernel.org, roman.gushchin@linux.dev, shakeel.butt@linux.dev, muchun.song@linux.dev, hannes@cmpxchg.org, nphamcs@gmail.com, yosryahmed@google.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <5ab860d8ee987955e917748f9d6da525d3b52690.1718326003.git.baolin.wang@linux.alibaba.com> From: Baolin Wang In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 9B7F94000A X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: gxegumdp8sxgsrssj8jf7ajkso7yfpof X-HE-Tag: 1718341413-593031 X-HE-Meta: U2FsdGVkX18L5h3f+JU1i/n2tZ3KCQ/sHhoCyeLcIct9mLHpfsJpZWOHc6meJIZMCC7afNMA23cyDSJoZUD1zpN3bZ2N+gzh/w30N0HynG3Vr3UTy+Q2zMYz2Hi4Hts6fNxwJCdbv15rkIckdrHV/2ALSW5XmNx7n610Jaar2LJ0OLZH1agWVjXhGIvlcaXUiO/f6m4XI/1QQmIhKEkKZTslNxG3DmNMLr5AU3mdX1kwzuBqm6pgfzySdEmOHTbW5RFvF37UQt2ttvgh1yJk2404DKtL+MlGdvLbgR3abnUQnS7rTgwUVDPtVGHhYBXCqftlYD1vCxH5rpFQvkpV6dQKjDbXEpiOBEIZUTd74wR/u0lqBZjxX9Loua/gFGTj3X6r1yfKuAJSAR8O7eCNHbFTh8112Sq+IstskezHv2MzWJtcFgIXf84DsNynBM+4PI5t1eAdxFXyHyZUFU8XOPKDwZD8zRuf8o6Q6GPDM9s24V8FcI06rcTEjlzCeV/s5hYb4nyTISMWgbWd0ungyTp2aXbfoZG5VGf6GaH1+3JRCm1SPibHQaFytu9+tpST0ObRspGW5k34Sg7D1e5/bj7eEysljobz4N8b4T08moVYk42+AO9kDb6SULmKlsVwBKUhAwdWWXzqV1wKV02avrXKh5dVdTdt2xt9cKxYr/XewgNWiYLnNtfoQ3bav7eMR+hW2zQxeK3DQvCOeRbNQNVQRKVXnvIs8rkghwwusrgL/RIO71CJNDmoXALwpwB6F957Jz5QORNV0+ldYlFblDRHftaDZCww8pBJgF8iwmZ6+tR37m1msAo+j4M+2vv/u2YiuW1iv3jhPPoQYlwwBasjQQT47CbxJGYj2qlyjELn+1T9wbGn74h3RbPwUsrMIOpSVw5vult5CO03COGtjAdk3VBsCz41f4+KStVJ2Exa/QtKjJB926SKwVG3EExVQutWAPkO7xJwmafjcjK D+YyfGoi 4YEY0qyubXgTBf/nB5uz+B2B3tKQW3vXCW7P4quE9sHuwMa2K7lEiMqqzFCVDhA9s5s/qhNOL4OqOBZ4KWWnQZuCZfo5AzlkxzIjDfJ1PSBqKqGN8gYzApuSAJGdLjhMnGNzcXhywl2lty3hna/UTxFfKFAM5ySkJOfFBZFDwDk+50EgxLQQwdKSCFFwX7lroZpScB4XbRHPgjVWZQAf7woKIcyX32uxiGx5vUYPmm+sEUck0rDovtCmHhT/OMmuR2rbagHa/vgNYLcXqnBKDHBhoQawKTCr3AWP+CPgF3+kzT3M= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000023, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/6/14 11:22, Matthew Wilcox wrote: > On Fri, Jun 14, 2024 at 08:49:13AM +0800, Baolin Wang wrote: >> * Charge @new as a replacement folio for @old. @old will >> - * be uncharged upon free. This is only used by the page cache >> - * (in replace_page_cache_folio()). >> + * be uncharged upon free. This is used by the page cache >> + * and shmem (in replace_page_cache_folio() and >> + * shmem_replace_folio()). > > Please just delete this sentence. Functions do not keep track of who > their callers are. Sure. This sentence seems less helpful. Will do in v3.