From: Baolin Wang <baolin.wang@linux.alibaba.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: akpm@linux-foundation.org, hughd@google.com, mhocko@kernel.org,
roman.gushchin@linux.dev, shakeel.butt@linux.dev,
muchun.song@linux.dev, hannes@cmpxchg.org, nphamcs@gmail.com,
yosryahmed@google.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] mm: shmem: fix getting incorrect lruvec when replacing a shmem folio
Date: Fri, 14 Jun 2024 13:03:27 +0800 [thread overview]
Message-ID: <58681eb0-cf36-4aa2-906e-a1a8daa2b969@linux.alibaba.com> (raw)
In-Reply-To: <Zmu3YVFfUA6_uToA@casper.infradead.org>
On 2024/6/14 11:22, Matthew Wilcox wrote:
> On Fri, Jun 14, 2024 at 08:49:13AM +0800, Baolin Wang wrote:
>> * Charge @new as a replacement folio for @old. @old will
>> - * be uncharged upon free. This is only used by the page cache
>> - * (in replace_page_cache_folio()).
>> + * be uncharged upon free. This is used by the page cache
>> + * and shmem (in replace_page_cache_folio() and
>> + * shmem_replace_folio()).
>
> Please just delete this sentence. Functions do not keep track of who
> their callers are.
Sure. This sentence seems less helpful. Will do in v3.
prev parent reply other threads:[~2024-06-14 5:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-14 0:49 Baolin Wang
2024-06-14 3:22 ` Matthew Wilcox
2024-06-14 5:03 ` Baolin Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58681eb0-cf36-4aa2-906e-a1a8daa2b969@linux.alibaba.com \
--to=baolin.wang@linux.alibaba.com \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=muchun.song@linux.dev \
--cc=nphamcs@gmail.com \
--cc=roman.gushchin@linux.dev \
--cc=shakeel.butt@linux.dev \
--cc=willy@infradead.org \
--cc=yosryahmed@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox