From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DBAC6C433EF for ; Sun, 6 Mar 2022 22:15:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5C31B8D0002; Sun, 6 Mar 2022 17:15:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 573898D0001; Sun, 6 Mar 2022 17:15:38 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 43AED8D0002; Sun, 6 Mar 2022 17:15:38 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0041.hostedemail.com [216.40.44.41]) by kanga.kvack.org (Postfix) with ESMTP id 344A98D0001 for ; Sun, 6 Mar 2022 17:15:38 -0500 (EST) Received: from smtpin21.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id E3DFE9EB34 for ; Sun, 6 Mar 2022 22:15:37 +0000 (UTC) X-FDA: 79215369114.21.20A7A25 Received: from mail-pg1-f174.google.com (mail-pg1-f174.google.com [209.85.215.174]) by imf15.hostedemail.com (Postfix) with ESMTP id 236E1A0002 for ; Sun, 6 Mar 2022 22:15:36 +0000 (UTC) Received: by mail-pg1-f174.google.com with SMTP id 195so12050325pgc.6 for ; Sun, 06 Mar 2022 14:15:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:in-reply-to:message-id:references :mime-version; bh=391huVYq5DAxhEYcIPd+Z6lK4Gud3fqq7TgEeUR+WWI=; b=tXH49C8/vqs+ygCTzo5gP4nqHiqf0//z9rAWQ3TD+9PZuNPidOX/ZS1vxWIoFuREqs WcrIp1iJL5qTXQG1TGsDXXXhnXWK6J/WuMKVQ/YN4EEaKW4mYCFjnTZDBoZB8kiSYn4q gp+XMKpzFJOdiiejLnn+lG11vEwFwoGRup5SHgJXjxBs0B24C7pCZ/Gy2dusyG9LYgPm L5sOz8iXExBhKRmF0YnPLcOOF3FfMm1ypr35T/55arFRS1zVuVToSeFOdctvH0LZp5st io3B4Sg3DLipbdzZ+ROgmvU0GrfkNkFjYoWDnxd5LsUCK7m78sqCb91LOa6Fu++FMXeb q8Zw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:mime-version; bh=391huVYq5DAxhEYcIPd+Z6lK4Gud3fqq7TgEeUR+WWI=; b=zv6NZ6nS7ci+SJWAK4JhBqNazpQcHHR9rtdjzlMuittPdtSicI//QPPjkz7PEwL9OZ 3pHyThG5md0jZki/cZQAmw2iNWYe2W8bHunwvvWYMa79Hi0UctU0H9xnLztrgCpwCdN7 7fAthTqTF35CcwUWMtTjBXkV0rt5Pqmcssyu52kNOjD8+zs2aLl5V3VG8J8V0Na7M8At HRQt4sIkbNTgnOHTSTCTEjho9nOKrpCZ3OhMKpVOsX/GzKAdRLB7Vokm5bcv/zrsXoND WGdhzXfrqKR9zf/RNhXVp/dSdyEfZ/G6Y8o1YY7dZEsPBYL/KllPwgAsTm3IBZUJWkc/ Y3jA== X-Gm-Message-State: AOAM531/Fa4p3RF8IcyKrayDmJZcJ1GU78Ao08hP32HxfHkL1odY4hxM chIg5MchwcK10vE8uo2Vari0dw== X-Google-Smtp-Source: ABdhPJwzKRwjJxCBJDMG8IhPCM3CI0pHUwMA/K8n/SXqp3bCN/ofaAeYsUKldmofLQ5O23BfCUuCiA== X-Received: by 2002:a63:7b49:0:b0:37f:ed43:4fc4 with SMTP id k9-20020a637b49000000b0037fed434fc4mr7481916pgn.387.1646604935931; Sun, 06 Mar 2022 14:15:35 -0800 (PST) Received: from [2620:15c:29:204:5f87:a605:2b59:e392] ([2620:15c:29:204:5f87:a605:2b59:e392]) by smtp.gmail.com with ESMTPSA id l5-20020a056a0016c500b004f140564a00sm13682590pfc.203.2022.03.06.14.15.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 06 Mar 2022 14:15:35 -0800 (PST) Date: Sun, 6 Mar 2022 14:15:35 -0800 (PST) From: David Rientjes To: Eric Dumazet cc: Andrew Morton , linux-kernel , linux-mm , Eric Dumazet , Mel Gorman , Vlastimil Babka , Michal Hocko , Shakeel Butt , Wei Xu , Greg Thelen , Hugh Dickins Subject: Re: [PATCH v2] mm/page_alloc: call check_new_pages() while zone spinlock is not held In-Reply-To: <20220304170215.1868106-1-eric.dumazet@gmail.com> Message-ID: <5867e22f-43cc-ca21-bc60-ec67554e66@google.com> References: <20220304170215.1868106-1-eric.dumazet@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 236E1A0002 X-Stat-Signature: ptjaakdb5jr7gm4fx5tubkz5jk8sh5qx Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b="tXH49C8/"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf15.hostedemail.com: domain of rientjes@google.com designates 209.85.215.174 as permitted sender) smtp.mailfrom=rientjes@google.com X-HE-Tag: 1646604936-674886 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 4 Mar 2022, Eric Dumazet wrote: > From: Eric Dumazet > > For high order pages not using pcp, rmqueue() is currently calling > the costly check_new_pages() while zone spinlock is held, > and hard irqs masked. > > This is not needed, we can release the spinlock sooner to reduce > zone spinlock contention. > > Note that after this patch, we call __mod_zone_freepage_state() > before deciding to leak the page because it is in bad state. > > v2: We need to keep interrupts disabled to call __mod_zone_freepage_state() > > Signed-off-by: Eric Dumazet > Cc: Mel Gorman > Cc: Vlastimil Babka > Cc: Michal Hocko > Cc: Shakeel Butt > Cc: Wei Xu > Cc: Greg Thelen > Cc: Hugh Dickins > Cc: David Rientjes Acked-by: David Rientjes