From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-f71.google.com (mail-pg0-f71.google.com [74.125.83.71]) by kanga.kvack.org (Postfix) with ESMTP id CEB0C6B0069 for ; Tue, 27 Dec 2016 23:40:46 -0500 (EST) Received: by mail-pg0-f71.google.com with SMTP id g1so822516129pgn.3 for ; Tue, 27 Dec 2016 20:40:46 -0800 (PST) Received: from mailout4.samsung.com (mailout4.samsung.com. [203.254.224.34]) by mx.google.com with ESMTPS id h16si48688363pli.122.2016.12.27.20.40.45 for (version=TLS1 cipher=AES128-SHA bits=128/128); Tue, 27 Dec 2016 20:40:45 -0800 (PST) MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 Received: from epcas1p4.samsung.com (unknown [182.195.41.48]) by mailout4.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0OIV00V57OZWTR40@mailout4.samsung.com> for linux-mm@kvack.org; Wed, 28 Dec 2016 13:40:44 +0900 (KST) Content-transfer-encoding: 8BIT Subject: Re: [PATCH] lib: bitmap: introduce bitmap_find_next_zero_area_and_size From: Jaewon Kim Message-id: <58634274.5060205@samsung.com> Date: Wed, 28 Dec 2016 13:41:24 +0900 In-reply-to: <20161227100535.GB7662@dhcp22.suse.cz> References: <1482725891-10866-1-git-send-email-jaewon31.kim@samsung.com> <20161227100535.GB7662@dhcp22.suse.cz> Sender: owner-linux-mm@kvack.org List-ID: To: Michal Hocko Cc: gregkh@linuxfoundation.org, akpm@linux-foundation.org, labbott@redhat.com, mina86@mina86.com, m.szyprowski@samsung.com, gregory.0xf0@gmail.com, laurent.pinchart@ideasonboard.com, akinobu.mita@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, jaewon31.kim@gmail.com On 2016e?? 12i?? 27i? 1/4 19:05, Michal Hocko wrote: > On Mon 26-12-16 13:18:11, Jaewon Kim wrote: >> There was no bitmap API which returns both next zero index and size of zeros >> from that index. >> >> This is helpful to look fragmentation. This is an test code to look size of zeros. >> Test result is '10+9+994=>1013 found of total: 1024' >> >> unsigned long search_idx, found_idx, nr_found_tot; >> unsigned long bitmap_max; >> unsigned int nr_found; >> unsigned long *bitmap; >> >> search_idx = nr_found_tot = 0; >> bitmap_max = 1024; >> bitmap = kzalloc(BITS_TO_LONGS(bitmap_max) * sizeof(long), >> GFP_KERNEL); >> >> /* test bitmap_set offset, count */ >> bitmap_set(bitmap, 10, 1); >> bitmap_set(bitmap, 20, 10); >> >> for (;;) { >> found_idx = bitmap_find_next_zero_area_and_size(bitmap, >> bitmap_max, search_idx, &nr_found); >> if (found_idx >= bitmap_max) >> break; >> if (nr_found_tot == 0) >> printk("%u", nr_found); >> else >> printk("+%u", nr_found); >> nr_found_tot += nr_found; >> search_idx = found_idx + nr_found; >> } >> printk("=>%lu found of total: %lu\n", nr_found_tot, bitmap_max); > Who is going to use this function? I do not see any caller introduced by > this patch. Hi I did not add caller in this patch. I am using the patch in cma_alloc function like below to show available page status. + printk("number of available pages: "); + start = 0; + for (;;) { + bitmap_no = bitmap_find_next_zero_area_and_size(cma->bitmap, + cma->count, start, &nr); + if (bitmap_no >= cma->count) + break; + if (nr_total == 0) + printk("%u", nr); + else + printk("+%u", nr); + nr_total += nr; + start = bitmap_no + nr; + } + printk("=>%u pages, total: %lu pages\n", nr_total, cma->count); > >> Signed-off-by: Jaewon Kim >> --- >> include/linux/bitmap.h | 6 ++++++ >> lib/bitmap.c | 25 +++++++++++++++++++++++++ >> 2 files changed, 31 insertions(+) >> >> diff --git a/include/linux/bitmap.h b/include/linux/bitmap.h >> index 3b77588..b724a6c 100644 >> --- a/include/linux/bitmap.h >> +++ b/include/linux/bitmap.h >> @@ -46,6 +46,7 @@ >> * bitmap_clear(dst, pos, nbits) Clear specified bit area >> * bitmap_find_next_zero_area(buf, len, pos, n, mask) Find bit free area >> * bitmap_find_next_zero_area_off(buf, len, pos, n, mask) as above >> + * bitmap_find_next_zero_area_and_size(buf, len, pos, n, mask) Find bit free area and its size >> * bitmap_shift_right(dst, src, n, nbits) *dst = *src >> n >> * bitmap_shift_left(dst, src, n, nbits) *dst = *src << n >> * bitmap_remap(dst, src, old, new, nbits) *dst = map(old, new)(src) >> @@ -123,6 +124,11 @@ extern unsigned long bitmap_find_next_zero_area_off(unsigned long *map, >> unsigned long align_mask, >> unsigned long align_offset); >> >> +extern unsigned long bitmap_find_next_zero_area_and_size(unsigned long *map, >> + unsigned long size, >> + unsigned long start, >> + unsigned int *nr); >> + >> /** >> * bitmap_find_next_zero_area - find a contiguous aligned zero area >> * @map: The address to base the search on >> diff --git a/lib/bitmap.c b/lib/bitmap.c >> index 0b66f0e..d02817c 100644 >> --- a/lib/bitmap.c >> +++ b/lib/bitmap.c >> @@ -332,6 +332,31 @@ unsigned long bitmap_find_next_zero_area_off(unsigned long *map, >> } >> EXPORT_SYMBOL(bitmap_find_next_zero_area_off); >> >> +/** >> + * bitmap_find_next_zero_area_and_size - find a contiguous aligned zero area >> + * @map: The address to base the search on >> + * @size: The bitmap size in bits >> + * @start: The bitnumber to start searching at >> + * @nr: The number of zeroed bits we've found >> + */ >> +unsigned long bitmap_find_next_zero_area_and_size(unsigned long *map, >> + unsigned long size, >> + unsigned long start, >> + unsigned int *nr) >> +{ >> + unsigned long index, i; >> + >> + *nr = 0; >> + index = find_next_zero_bit(map, size, start); >> + >> + if (index >= size) >> + return index; >> + i = find_next_bit(map, size, index); >> + *nr = i - index; >> + return index; >> +} >> +EXPORT_SYMBOL(bitmap_find_next_zero_area_and_size); >> + >> /* >> * Bitmap printing & parsing functions: first version by Nadia Yvette Chambers, >> * second version by Paul Jackson, third by Joe Korty. >> -- >> 1.9.1 >> >> -- >> To unsubscribe, send a message with 'unsubscribe linux-mm' in >> the body to majordomo@kvack.org. For more info on Linux MM, >> see: http://www.linux-mm.org/ . >> Don't email: email@kvack.org -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org