From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D376CC02192 for ; Mon, 3 Feb 2025 19:17:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4E7AC280002; Mon, 3 Feb 2025 14:17:47 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4964B280001; Mon, 3 Feb 2025 14:17:47 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 385BE280002; Mon, 3 Feb 2025 14:17:47 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 1A886280001 for ; Mon, 3 Feb 2025 14:17:47 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id C9008A040D for ; Mon, 3 Feb 2025 19:17:46 +0000 (UTC) X-FDA: 83079592932.12.7DD2DAF Received: from mail.marcansoft.com (marcansoft.com [212.63.210.85]) by imf16.hostedemail.com (Postfix) with ESMTP id AA3FE180017 for ; Mon, 3 Feb 2025 19:17:44 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=asahilina.net header.s=default header.b=uOa6ofKd; spf=pass (imf16.hostedemail.com: domain of lina@asahilina.net designates 212.63.210.85 as permitted sender) smtp.mailfrom=lina@asahilina.net; dmarc=pass (policy=quarantine) header.from=asahilina.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738610265; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Dh7PdNNpCsggnOuJY5vfjwHQ/XIO1t4CRELbT3HIBlc=; b=bjqqnR7LIWF98XvQT6Fowf5ixMQPeOteuHJ1ze1qIVpjtrqb792OonTsBfUjMevZr8PMb+ yJ65Hp5OdGT0yyKmdKnmscjwy90mCTjrnoCCz1/qjRxGN1I/BzXwItxgNsgtz7m8mDACpW EjFVo7WxdiMVWxCKVQkmn7LmJUurUxM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738610265; a=rsa-sha256; cv=none; b=1U73S2mQEDTG9N00L75ugIuFsRuaKWTmVz8fZjrVNWolIO9uRqc9zpewpdgZX//9WUyJzI wtAYyHYu5wqaSv9ZVg8STCAFZThIdCHXVoQ8SxuitCe+TMwMoTT3NJeGjoQWocYS+Tmmc9 s/yOCIiudgLHZmF4gBq6MZrAJaGL9wU= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=asahilina.net header.s=default header.b=uOa6ofKd; spf=pass (imf16.hostedemail.com: domain of lina@asahilina.net designates 212.63.210.85 as permitted sender) smtp.mailfrom=lina@asahilina.net; dmarc=pass (policy=quarantine) header.from=asahilina.net Received: from [127.0.0.1] (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: lina@asahilina.net) by mail.marcansoft.com (Postfix) with ESMTPSA id EC6FC41F5F; Mon, 3 Feb 2025 19:17:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=asahilina.net; s=default; t=1738610260; bh=LT2/Yf1z+TNQiO+U9g+rhfC5zMEZaRWAdxzwNtxlZUo=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=uOa6ofKd9OXGhMAmfr+cL5LXLbYuCNtr7M/fb0HciWv+6du9svov8+Q/4q0PxH1FA 732VjRIbeyWXzD3oNEY32AbpHvgG3NlIZtARoJ/ZB23cV05717kBH4UDAVnYokFPnm gHbjsFhX9nlPpESZdzz3uGuTNcT08YHTkioU0Ew7h14FyJQ5ovjAQKoQK9+9LygWBO G0JEhSH930JJYiaMbSHtxiiY6uJIuqY954KQ/+XRw3AeHGVcjZaUsfX62VoDYYU8ga im1iw7VBD3GrzQPXJ+5HjM2k216I6JLtbWLxEveCAeIEAC5WXWXAbUVQaR05QqJ7UW 4DxHyV1RE63pA== Message-ID: <585deb4e-3d05-488b-80dd-df64a6983d85@asahilina.net> Date: Tue, 4 Feb 2025 04:17:38 +0900 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/6] rust: types: Add Ownable/Owned types To: Alice Ryhl Cc: Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?UTF-8?Q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Trevor Gross , Jann Horn , Matthew Wilcox , Paolo Bonzini , Danilo Krummrich , Wedson Almeida Filho , Valentin Obst , Andrew Morton , linux-mm@kvack.org, airlied@redhat.com, Abdiel Janulgue , rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, asahi@lists.linux.dev References: <20250202-rust-page-v1-0-e3170d7fe55e@asahilina.net> <20250202-rust-page-v1-1-e3170d7fe55e@asahilina.net> Content-Language: en-US From: Asahi Lina In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Stat-Signature: tfnuf3s4ri7t6wzp5mos35wydncd5t38 X-Rspamd-Queue-Id: AA3FE180017 X-Rspam-User: X-Rspamd-Server: rspam06 X-HE-Tag: 1738610264-302731 X-HE-Meta: U2FsdGVkX18AVU1fJeNWEwLO0lFTLztmE8/uaxxQyQJO2UAxg1VpjGjWvo2moR0S0Txw8DDig/l3z7E+ZIQYRo4k9KCH/8+COU5U38JoIbRiIknPuBf38YDXfw5jS4FPJad83hI8c6sxl3z7BoUoC+MHghxPwg1OEs8yXPTNG2TN+wMLYPn1tA/9z/syJpFVjh3o49KczsKK9qCB/84AiIDCRgP/kKRp38ZWTi7Gk7IU+VrYIhN20nchmCAjGgTGhm2uye6H+lpqf0VimK1ID4vqJCyfrnBaadEDKCwMlDabeP+KcGW/kOwEbWXr88HjyOq9eMZkqNq6sz5BhCpqIKUvjl3Zxh7Rf3rwdkdFz0Hb+zsFrlmcwQYSn0mpa2PuShqb4lXUZwAfmAfn/q94COACG+Qum+FPO2PHvUF8oheQDSSXItvSrdepaPf5vNQWRn+Mko4JzozsUNVpv1bzgEM9dY3/ieMAZJJJRYKqQMqM1g/gVLnacWp4VHptS82vgxer13Cf9wYBAm3k8yUFjRwAXBsiyQhY10KXP5QDqbmn0YzhUQVTcrPjMSyvlbQS26HspFLBR+JS2ycDxLC4wmO1xc3zpOaQisUiLYTCQSwZWD0+9PWdo5o8ogwn/9uC5hVWzUX+YsVhaS4tHd3bUhjxu7xx4SjUVLDuvcxxQm/FfASCBWuDnndzTN24B49MsuN5+1E1uWtSPlUi7D2BLbFERygP94rRE0I3l7D22M8UfuzjzAGRgpDloiPfl48W6Qvof/25LEM677q1jfvMYINWxjLXS+38HEudjF1NE+AxbmZYy+qCoAbPzm9jHPUTr5ZRYtRcnlk9wXg6/UiTWH+Zd6EZWfZnzXLFjxR2VRXmfk6yS1X1hvSvfs/U6Hs8WUbwaBsN6/Dg3zXOhC2HBA2QwLzi9l6wwE7h1OSjycR5apzG6mZeueE94X+NJ4ChfcvbkQResQ9Gp4xVYd7 oDNh5Zrg eJD0eelgBTHPEhCf+IzcfWZddJzRN6Yt1cS5N9BH3fJnC2T/jV4Ll0JZ6l8le+TSzmKSWGnL/2eEHDRUt8b0jQtM6k1soZAJUWCO5YfIG4i+fbjF+WgQbR0FU8eJhiISSxQobELIYXiXrntOgjIUzuI/HRaFmji+ByYgewwD5onNSqX0QWWjxghg/sFuTw/0RGPqMmeKzQda7EyV2SknJd0Y/ooKlF+W/DLwbwemnlpADFV5Bgau50pCd7JugSfgw29hLiqpu1cJW4blNEBgYHmL19bS9gLT81rXL2YUUVrItPNTcdVcROeH7nfKZjIYEziqTtGmMe7z6aUfnal1/j8l7I4CZq8BlLhuXzsYpeIp3g45ih2WTbfBGkjeRYXT7YEB/13ffvSifs5Jea9otj9IlJeNerd0LWdrj7giVwCwDX91d7gUaCegYgrtj2Syyxn5qIciIiqTS3/vWoreaudC4B0gh/bTmgmXU1U6GGT+pEeA= X-Bogosity: Unsure, tests=bogofilter, spamicity=0.500000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2/4/25 3:17 AM, Alice Ryhl wrote: > On Mon, Feb 3, 2025 at 3:17 PM Asahi Lina wrote: >> >> >> >> On 2/3/25 6:13 PM, Alice Ryhl wrote: >>> On Sun, Feb 2, 2025 at 2:06 PM Asahi Lina wrote: >>>> + /// Consumes the `Owned`, returning a raw pointer. >>>> + /// >>>> + /// This function does not actually relinquish ownership of the object. >>>> + /// After calling this function, the caller is responsible for ownership previously managed >>>> + /// by the `Owned`. >>>> + #[allow(dead_code)] >>>> + pub(crate) fn into_raw(me: Self) -> NonNull { >>> >>> I would just make these methods public, like the ARef ones. Then you >>> can drop the #[allow(dead_code)] annotation. >> >> Does it make sense to ever have drivers doing this? I feel like these >> methods should be limited to the kernel crate. > > Not having drivers use this is the ideal, but I don't think we should > always expect it to be possible. The Binder driver has a C component > for the binderfs component, and it also has some code that's > essentially an abstraction inside the driver that I was asked to move > into Binder because it's so specific to Binder that it's not useful > for anyone else. That's fair, I'll make it pub. ~~ Lina