From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0947ECAAD3 for ; Thu, 1 Sep 2022 08:00:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 265EC8D0001; Thu, 1 Sep 2022 04:00:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2146A6B0073; Thu, 1 Sep 2022 04:00:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 104608D0001; Thu, 1 Sep 2022 04:00:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 003A86B0072 for ; Thu, 1 Sep 2022 04:00:32 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id C9828ABCC0 for ; Thu, 1 Sep 2022 08:00:32 +0000 (UTC) X-FDA: 79862769504.11.4C0F970 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by imf17.hostedemail.com (Postfix) with ESMTP id 095D94003B for ; Thu, 1 Sep 2022 08:00:30 +0000 (UTC) Received: from dggpemm500022.china.huawei.com (unknown [172.30.72.57]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4MJCz65KDgzYcyj; Thu, 1 Sep 2022 15:56:02 +0800 (CST) Received: from dggpemm500001.china.huawei.com (7.185.36.107) by dggpemm500022.china.huawei.com (7.185.36.162) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Thu, 1 Sep 2022 16:00:27 +0800 Received: from [10.174.177.243] (10.174.177.243) by dggpemm500001.china.huawei.com (7.185.36.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Thu, 1 Sep 2022 16:00:26 +0800 Message-ID: <584e63c2-2574-ea2b-55c4-da5e2cd08868@huawei.com> Date: Thu, 1 Sep 2022 16:00:26 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH] mm: remove BUG_ON() in __isolate_free_page() Content-Language: en-US To: David Hildenbrand , Andrew Morton , CC: References: <20220901015043.189276-1-wangkefeng.wang@huawei.com> From: Kefeng Wang In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To dggpemm500001.china.huawei.com (7.185.36.107) X-CFilter-Loop: Reflected ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1662019231; a=rsa-sha256; cv=none; b=7SfeFtckekUY/2ClMZRh2R+EM46+UynhCQnJtivSTVW6DhIJ2ul0l8R4Pph+k4HURolDBK whOxs7CdIhErb3ufRyMFHcUzjaFb0v+wxfscVztkBCkE8vzJsY+zOlryFtpnd53wH0uNdW 542eV5cTQH9l3szeXShgqsEoEJEb5SY= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=none; spf=pass (imf17.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1662019231; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iXmlJre99+c8LwVN4CMddygc9CwO2+Mn75pvp3yEQac=; b=fdmH65mvCCFSKXjKJZGi0egGtfAFQrXar3CDkuc+sRa6jvxg24+V1HM8jHPa7CDfJYK5Py HhcVXAOE7vtC7hDe+oIYz+5RdDZasnmZqPgK3Ml3LLfvLDzmRcdixl+ocEShp07MUA/Cvm CXQfSIzHFU5Mr/d1tciNOI3Cj1Dl1MA= X-Rspamd-Queue-Id: 095D94003B X-Rspam-User: Authentication-Results: imf17.hostedemail.com; dkim=none; spf=pass (imf17.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com X-Rspamd-Server: rspam03 X-Stat-Signature: trzdkhsr9mso653nzy6rghx85dw36jt3 X-HE-Tag: 1662019230-816365 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2022/9/1 15:37, David Hildenbrand wrote: > On 01.09.22 03:50, Kefeng Wang wrote: >> Drop unneed comment and blank, adjust the variable, and the most >> important is to delete BUG_ON(). The page passed is always buddy >> page into __isolate_free_page() from compaction, page_isolation >> and page_reporting, and the caller also check the return, BUG_ON() >> is a too drastic measure, remove it. > Why not WARN_ON_ONCE then? But yeah, maybe this really isn't of any > value anymore. or VM_WARN_ON()， but I think this bug_on is useless after check all calllers, so let's drop it if no objection.