From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42213C4828D for ; Mon, 5 Feb 2024 17:54:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CA22A6B008C; Mon, 5 Feb 2024 12:54:37 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C52586B0092; Mon, 5 Feb 2024 12:54:37 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B1A616B0093; Mon, 5 Feb 2024 12:54:37 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id A0E3A6B008C for ; Mon, 5 Feb 2024 12:54:37 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 7528240AE6 for ; Mon, 5 Feb 2024 17:54:37 +0000 (UTC) X-FDA: 81758500194.02.E66C79F Received: from gentwo.org (gentwo.org [62.72.0.81]) by imf06.hostedemail.com (Postfix) with ESMTP id BE36A18001C for ; Mon, 5 Feb 2024 17:54:35 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=none; dmarc=fail reason="No valid SPF, No valid DKIM" header.from=linux.com (policy=none); spf=softfail (imf06.hostedemail.com: 62.72.0.81 is neither permitted nor denied by domain of cl@linux.com) smtp.mailfrom=cl@linux.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707155675; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MbqZG62eBIzpFM6l/f+Co7VU/S5K7qiyQDPdGZ/iriA=; b=jhV0J3TJJwYp+Sk/hi0YVADS7grr+vP/aOYc6UBymwbkQJCbqj5bWNWZfSTt0+/6JJs2ef +tAwaUpqe76rbDgWA9ooFX26quJxWape5RLM0c6Bq1d4Vh2LjR3U/s6GQkaaTECVoLQbWc fv1z5tv/krfva3dL54zdLGzuf59348Y= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=none; dmarc=fail reason="No valid SPF, No valid DKIM" header.from=linux.com (policy=none); spf=softfail (imf06.hostedemail.com: 62.72.0.81 is neither permitted nor denied by domain of cl@linux.com) smtp.mailfrom=cl@linux.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707155675; a=rsa-sha256; cv=none; b=gqBAGZnuqVnN7CNpkylDdAwdvfNyuELONnbozsxVkfgTX8h90ucn+yBvjxvgzDDXAcqgFt Ln9VK0OOFkUDIJvT6wLLCCTirFi+D1IhO2d3L6RuRRT3fA13T7V/ExA5hx3wQysRxIR4zO YB28Jtf1vvQjsCjtVRdYbW4xz8OzKpI= Received: by gentwo.org (Postfix, from userid 1003) id 6BF1941CB0; Mon, 5 Feb 2024 09:54:34 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by gentwo.org (Postfix) with ESMTP id 6B6E940789; Mon, 5 Feb 2024 09:54:34 -0800 (PST) Date: Mon, 5 Feb 2024 09:54:34 -0800 (PST) From: "Christoph Lameter (Ampere)" To: Vlastimil Babka cc: Greg KH , Fangzheng Zhang , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Fangzheng Zhang , Yuming Han , Chunyan Zhang Subject: Re: [PATCH] mm/slab: Add slabreclaim flag to slabinfo In-Reply-To: <2f43774a-16cf-412e-b4b7-840889bb796b@suse.cz> Message-ID: <58191e1b-7ebc-16ff-1df0-16ddcaa2e7b9@linux.com> References: <20240131094442.28834-1-fangzheng.zhang@unisoc.com> <2024020441-version-chihuahua-1067@gregkh> <2f43774a-16cf-412e-b4b7-840889bb796b@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed X-Rspamd-Queue-Id: BE36A18001C X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: ookb5ob3nf4x1yi8tobqq9ionc47qw3u X-HE-Tag: 1707155675-583065 X-HE-Meta: U2FsdGVkX1/pA74SwjVBsH17BeYRVY6CSBxzRcheOyeIbZSgw95WvQnE/Fk7zvvGYWvYph9r9vkSmHPxs4nyme5CTKM8IctLzc9ad7fO3DizUHosB50BKgUPlfyxyle3qmHIDCWZknjnW7wm1V2JE9qTFcaxc0+Af4Sf5TCCDkSyEPUN9sM7rlkbe1oj3HWycoiD7DGnOvrmsgsSgG1Q1gUehh6ZbMC5rHvr5bxtrj3+3rlsH/kDEpwtomj4lWheiF8qUQ7jLu3ICVIC9oDtEVqvpdH5Y5LHv1F5aKXacm8Va6i45Z6CgX2kum3NzoSt0/Dlr43ye98ewQN/9zqbwxtBDuGMEBRHm2xq63UXN/PdpJj2WDjOeh9V6yQadTva4NhDFqQ6QUWOqXGJPXNed9iZztTQw/e54Q8ldNdX1bRrqAUHwtwQrmLkfOSR0/TkFpj+hJodIvdrmWLY5x014NzD38r9diHyJyiquAdGzn9HdE1MXX0SUwbOoulNlbD5ExVV92keilqfrFZdZM6P6khnwGCXgbhZUFdkjc0rYd9f4DnlTZjP7JN0FWO4aAkqaR8/hwVwh7uzcCG+zZKu0MSXPWgXYve4rmtZ3tgqI0cHFP0bVBrbPJ+XYPRoxY9wuXPuW9BXqb8L6U7PinqRjPss66Zi7UAkKL0TwDvjTfjpspwjNiZinOVyIznYmcDGcmKROt8n6V7O8O46B26hCGFa7nJW44I1B6o+LyeIzmV1C/7LYe/FSO8wYS7HEIQrZz6CgEHmfGRlvAVd9XVKTFL3L5EycFBa+M9vhuy85ChhFe1ln1K9HFlZDpSbMymIAxdaJPnsPcSl/pgwyHMoCODIk44XdXLaaaE3P7R9PdJ5cQOdlmXDrFq0f0PvzRMxHrTL7PyUWbnDrCHL34+FrNE/6g0HmTPQV+fxbF1xWYIJaDunfDXRY3srFtOGsrrPI61tGwdKQheHK7H7dTj oW6OVQwZ YW7zEenl27xg/waDu16yEOHxcBSRLL61dMA1cui7Ne54EA3ra2+XaDgEaz1SI42/jdoYhlLaVYZbfpfnG0mlUvd7go5c2CS/tvM4lXx4Qh3iWEzDGA4FNNo3+9/wj30PMRUocqT8R4UBTpkNTyKf0s3o7cnRjLXbRh7QyMbglVJFn4yJ7FcbblKTTrGM7ois1AhvMHPgspc3lb6vnMmaZJBWrvPuIHvN0QRzi6p0TJL7VmfVfstHZPOrVbv2Y7uJd7bBxqM9i6KPnRcqDce9u8lyv1a/C3P6FbIwggn1bO54WNPL/8DzC2Rxbeg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 5 Feb 2024, Vlastimil Babka wrote: > On 2/4/24 14:09, Greg KH wrote: >> On Wed, Jan 31, 2024 at 05:44:42PM +0800, Fangzheng Zhang wrote: >>> In order to enhance slab debugging, we add slabreclaim flag to >>> slabinfo. Slab type is also an important analysis point in slabinfo >>> for per slab, when various problems such as memory leaks or memory >>> statistics occur. >>> >>> Signed-off-by: Fangzheng Zhang >>> --- >>> mm/slab_common.c | 7 ++++--- >>> 1 file changed, 4 insertions(+), 3 deletions(-) >>> >>> diff --git a/mm/slab_common.c b/mm/slab_common.c >>> index 238293b1dbe1..aeeb2bfe6dda 100644 >>> --- a/mm/slab_common.c >>> +++ b/mm/slab_common.c >>> @@ -1038,7 +1038,7 @@ static void print_slabinfo_header(struct seq_file *m) >>> seq_puts(m, "slabinfo - version: 2.1\n"); >>> seq_puts(m, "# name "); >>> seq_puts(m, " : tunables "); >>> - seq_puts(m, " : slabdata "); >>> + seq_puts(m, " : slabdata "); >> >> Doesn't this change the slabinfo version number above? Where is this >> change documented so that userspace knows about it? I have never seen such a document. I would suggest incrementing the version to 2.2 since there is a minor extension of the format. I tried to remove /proc/slabinfo in the past and have people use the more versatile /sys/kernel/slab interface. But /proc/slabinfo has a long legacy. Could we mark /proc/slabinfo as deprecated and recommend the use of either sysfs directly or use of the "slabinfo" tool that we have been providing in linux/tools/mm for a long time?