linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: "Liam R. Howlett" <Liam.Howlett@oracle.com>
To: JaeJoon Jung <rgbi3307@gmail.com>
Cc: maple-tree@lists.infradead.org, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] maple_tree: add mas_node_count() before going to slow_path in mas_wr_modify()
Date: Mon, 3 Jun 2024 08:29:41 -0400	[thread overview]
Message-ID: <57xfda6fbz6m4sig4kdyi5jinibcqycobwrpaih45cykfqyr5a@fstc2xjyw2x5> (raw)
In-Reply-To: <CAHOvCC6vZQkotPCvOafGxXWb5GygMSUiYUaYZu3RwFA9cCY2nw@mail.gmail.com>

* JaeJoon Jung <rgbi3307@gmail.com> [240602 05:06]:
> Hello, Liam.
> Thank you very much for the detailed answer and explanation.
> 
> I tested this patch in userspace.
> In user space, this phenomenon always occurs when kmem_cache_alloc()
> is executed to allocate a new node.

This is expected in the userspace test program.  We test the error path
most frequently, with only a bypass for those who wish to test an
initial success - such as preallocations.  I was concerned about the
testing since your first patch had a syntax error with a correction
quickly after.  It is good news that you were able to find and use the
maple tree testing framework, though.

> I will try to test it in more detail in kernel space.

If you test in kernel space, you will have to hit a low memory scenario
to see a difference.  stress-ng would probably help.

> I will also refer to the notes from the email list you shared
> and send results once a more clear analysis has been made.

I don't think you need to continue with this work as you will find that
the low memory situation is going to be rare and in a very slow path
already.

Thanks,
Liam


  reply	other threads:[~2024-06-03 12:29 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-01  2:55 Jung-JaeJoon
2024-06-02  2:41 ` Liam R. Howlett
2024-06-02  9:05   ` JaeJoon Jung
2024-06-03 12:29     ` Liam R. Howlett [this message]
2024-06-04 12:03       ` JaeJoon Jung
  -- strict thread matches above, loose matches on Subject: below --
2024-06-01  2:37 Jung-JaeJoon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57xfda6fbz6m4sig4kdyi5jinibcqycobwrpaih45cykfqyr5a@fstc2xjyw2x5 \
    --to=liam.howlett@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=maple-tree@lists.infradead.org \
    --cc=rgbi3307@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox