From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3FF7CC04FFE for ; Fri, 17 May 2024 05:19:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 51BFD6B007B; Fri, 17 May 2024 01:19:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4CC3C6B0083; Fri, 17 May 2024 01:19:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3BB216B0085; Fri, 17 May 2024 01:19:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 211E36B007B for ; Fri, 17 May 2024 01:19:08 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id A1675A4189 for ; Fri, 17 May 2024 05:19:07 +0000 (UTC) X-FDA: 82126733934.28.AB95C49 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by imf23.hostedemail.com (Postfix) with ESMTP id D2984140002 for ; Fri, 17 May 2024 05:19:04 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf23.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715923145; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IV7r/wo4YyiyHM/ly0ZIJPNCtJkrikJZK1w9p7Rzryg=; b=8i8IUGFP/xERhQzqyCjNvZVzRMnLEFVN4OUt9sbBen2md08lbU6VOdokADUaIAwPYqQSqz 0+M+qJK+OvYMPhr1VjeB2miYVBNJeRAo4qry1Zm78jG9yRvEshxFylwfq+HADOR3cfNVed 4c623+2a3dLOVKvmQm5voz9u/CGTrn8= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf23.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715923145; a=rsa-sha256; cv=none; b=B2EnzA64XDvSQ5J5c/pbfj68eEAhi45NBcmiR9Fkg3+/n4bxqpO+VsUAgho9WzPMpQ1klc 17n0LptaZjnFihnfKwHTKbhe8PY39Yx5sRwUGN4lt6f8E1KkCt4ZoI7bq0MbTZpbKpE6+9 dF7wedZz51wapIOtbj74xW3fDN3bAbo= Received: from mail.maildlp.com (unknown [172.19.163.252]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4VgZwR51rnzcf1c; Fri, 17 May 2024 13:17:43 +0800 (CST) Received: from dggpemm100001.china.huawei.com (unknown [7.185.36.93]) by mail.maildlp.com (Postfix) with ESMTPS id D44B118006E; Fri, 17 May 2024 13:18:58 +0800 (CST) Received: from [10.174.177.243] (10.174.177.243) by dggpemm100001.china.huawei.com (7.185.36.93) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Fri, 17 May 2024 13:18:58 +0800 Message-ID: <57fbf9c2-10ec-4972-946a-7864932d4281@huawei.com> Date: Fri, 17 May 2024 13:18:57 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: refactor folio_undo_large_rmappable() Content-Language: en-US To: Vishal Moola CC: Matthew Wilcox , David Hildenbrand , Johannes Weiner , Michal Hocko , Roman Gushchin , Shakeel Butt , References: <20240515064506.72253-1-wangkefeng.wang@huawei.com> From: Kefeng Wang In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To dggpemm100001.china.huawei.com (7.185.36.93) X-Rspamd-Queue-Id: D2984140002 X-Stat-Signature: rbjfkb9mwdf8ufyk8x3c5sqcwu7pxk63 X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1715923144-817783 X-HE-Meta: U2FsdGVkX19w/jlIjyyCtAXDu9Qn9OuRjN0HhvaAiSjoYiuoQcef3IZLL3y9Qgf0sUFCU430uoUazSWIfvSToghr74c5pK772NHC7EQRTNCPV12guXRo2Z6t43jt/nEpHG11EHg/OLfv9iBgMQXuw80kd+Fu/TYbdYe3MisEZbHj15ZJrRzcz0leIoFv5zsTRFoKYaJrPx06Vp14rvhYrq6o712S9jxDkTTaADlUM3qXS5MImchLIF1nTr5A7+T3k1RTE0tEIHKXo2fRr4inynvK2b1OVf4yll2HKDHpa9SR5M2XTWy44AkloEXmSSAujEZwFFZMspabHTR8MzSOKym/ZtNFkEAynEoRKY+AGMmVVxOaV/vQxFiFN+bV417UX8/6sCF0b6HiS5fT40B8lD49n6OK9hGMkYKOes70VALoewsn6oI0xy2GPQk8ICAzmNmidrQ7/6dKYxRXFbNdMIEtCvOx8pthv2NrC1MA5IXL2PJr2WniX9KG5YPbC1WkGIaAvlhmMj04fDGFM3DbDOrWSSyuS2GJh3c2wNClKT7Tq31l8F7nWdAwMicQ/D3URcqA+D2l5hmhQMWYlYYTL+3gqAcKlfXatwJQZUGpDHpDFs22/MaMMpZ+xe6rJtH80fZw7a0lgNuI3iLQI4NUiTiolUAjsEnjN/RWUW8ZTTylf5mFBlCdqCtM8keviKj7y6/agKodHHqaGzOr6P+/5n2ouHLfCoBV9yldbsrcdM2bdevOyG81meOXcS2Act37rgJK/jWZmWDtMZIq5IM784Po5FSjDefg/4GPq/L3Zr30dShs+WaJK3YrA7Bg6EHuY2lLq7N87s77SYMSH6QO2m1pej66JW/DQ9V7RQf+sbBM0z3ZP2sEnl/SyKamgD3MPSDwuOyvF7aSte4YXGF2OCi3b5GXnUhb980VhuliwtZ4mz4gZ1jOsoeERav0U1l44Zt1eqgKXaIb/XYEyYq GUZGT3o0 EUozBSMKeHvaoAQwWLr/vB7lBc3tARyTqbLZIAjq4mZiHlSkRwx1B528Ampf0MgJaGyp58CXkDKnLYDI/UKkLgP9d0WRjZISNDfeLcWXGf6JW9/kWQIKL3FTGGGLAHJVC6fGs8usxSS0eyyEzr8UscBAYQy31mgZHWCAkxS0Ge+Z9bU652YkPdqbjljm6PiKJ0zI5KnyBuNJxhUL+5OA+usIEWMIPdxgM5CNGLIzpJi79CJB4GCXSqLHcBPhaY2mKE/+6JNEQlQa7J8w+0jPBAtnzQ1TwdNya9fsL X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/5/16 23:54, Vishal Moola wrote: > On Wed, May 15, 2024 at 02:45:06PM +0800, Kefeng Wang wrote: >> All folio_undo_large_rmappable() callers will check folio_test_large() >> which already checked by folio_order(), so only add the check > > This commit message is a little misleading. The folio_order() check in > folio_undo_large_rmappable() is primarily for catching order-1 folios, > not to check folio_test_large(). You can read more about it in > commit: 8897277acfef7f70fdecc. folio_order <=1 cover the small folio and order=1 cases, maybe I could update message to try to make it clearer, > > Aside from that, I like the patch. It should make this code easier to > maintain. Thanks.