From: Kefeng Wang <wangkefeng.wang@huawei.com>
To: Vishal Moola <vishal.moola@gmail.com>
Cc: Matthew Wilcox <willy@infradead.org>,
David Hildenbrand <david@redhat.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Michal Hocko <mhocko@kernel.org>,
Roman Gushchin <roman.gushchin@linux.dev>,
Shakeel Butt <shakeel.butt@linux.dev>, <linux-mm@kvack.org>
Subject: Re: [PATCH] mm: refactor folio_undo_large_rmappable()
Date: Fri, 17 May 2024 13:18:57 +0800 [thread overview]
Message-ID: <57fbf9c2-10ec-4972-946a-7864932d4281@huawei.com> (raw)
In-Reply-To: <ZkYsIHAII6gUQg4w@fedora>
On 2024/5/16 23:54, Vishal Moola wrote:
> On Wed, May 15, 2024 at 02:45:06PM +0800, Kefeng Wang wrote:
>> All folio_undo_large_rmappable() callers will check folio_test_large()
>> which already checked by folio_order(), so only add the check
>
> This commit message is a little misleading. The folio_order() check in
> folio_undo_large_rmappable() is primarily for catching order-1 folios,
> not to check folio_test_large(). You can read more about it in
> commit: 8897277acfef7f70fdecc.
folio_order <=1 cover the small folio and order=1 cases, maybe I could
update message to try to make it clearer,
>
> Aside from that, I like the patch. It should make this code easier to
> maintain.
Thanks.
prev parent reply other threads:[~2024-05-17 5:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-15 6:45 Kefeng Wang
2024-05-15 6:53 ` Lance Yang
2024-05-16 4:43 ` Kefeng Wang
2024-05-16 15:54 ` Vishal Moola
2024-05-17 5:18 ` Kefeng Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57fbf9c2-10ec-4972-946a-7864932d4281@huawei.com \
--to=wangkefeng.wang@huawei.com \
--cc=david@redhat.com \
--cc=hannes@cmpxchg.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=roman.gushchin@linux.dev \
--cc=shakeel.butt@linux.dev \
--cc=vishal.moola@gmail.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox