From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C50EC02192 for ; Fri, 7 Feb 2025 09:28:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3587D6B0088; Fri, 7 Feb 2025 04:28:28 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 307486B008A; Fri, 7 Feb 2025 04:28:28 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 181536B0095; Fri, 7 Feb 2025 04:28:28 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id EE6836B0088 for ; Fri, 7 Feb 2025 04:28:27 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id A53671C7C22 for ; Fri, 7 Feb 2025 09:28:27 +0000 (UTC) X-FDA: 83092623054.29.F244C47 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by imf11.hostedemail.com (Postfix) with ESMTP id 4BC8D40006 for ; Fri, 7 Feb 2025 09:28:24 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=dmDZnUn0; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=SuPhoWkn; spf=pass (imf11.hostedemail.com: domain of lorenzo.stoakes@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=lorenzo.stoakes@oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); dmarc=pass (policy=reject) header.from=oracle.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738920504; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=iphE8HHigEN9f0WR0+i6ZBpGRgcKimbUCjELmRjiTmw=; b=v1L8oGePioDzixfxyjDFi9idtV7E/rOQTuvJKW5vQdl/7+PpRB7MM1H2zy9MM1hWgO1K0k R4rlaKe7NK5+FLMTBXgueb8PLi7OS3FSfvdmHvScqiM662SwS47VRHxXn8MVKNJZsIjOE3 frEMnej2co3MiCKO33+h4cF5pKrrkjE= ARC-Authentication-Results: i=2; imf11.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=dmDZnUn0; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=SuPhoWkn; spf=pass (imf11.hostedemail.com: domain of lorenzo.stoakes@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=lorenzo.stoakes@oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); dmarc=pass (policy=reject) header.from=oracle.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1738920504; a=rsa-sha256; cv=pass; b=hi9SkpEPY5lm970fg85pGbEhVCXmgmHGfDSvPy4zg5KvP3tzVejkP6/xjDa+bb7YDbR+Xl Zq67FVGvS7C1e1tsbiP35vJoLWZxUAgzNBOSfvxUjpHv2Q+8GsP9K1HRrEBsZtl8xDmrUT 1QXfltsYO4SrMPID/M68fsjbw17nzOE= Received: from pps.filterd (m0246629.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 5171ttkP016765; Fri, 7 Feb 2025 09:28:20 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=corp-2023-11-20; bh=iphE8HHigEN9f0WR0+ i6ZBpGRgcKimbUCjELmRjiTmw=; b=dmDZnUn0Ja8hrxwKJK/PQLrEgdodcfi56a 70Pu1lUcmb5AKzrTWf1cUHwsaUFl9PMiM5/aF1f5oUVnVP6H90cnCfo+RkMFppIV v/oryQTkTlwqaJgcTVvKXAIQ5uZBTSSetZndD8krenbUrw1GdDhg3rhZbUXBDAIA igz68B1EoRqxWIjLFrKXL/StJxyCBZF2PNJCgEE5W7Fj2cBbnXG5tMS8n31XoDFN mPvxbC6WE+EqhMz05QECSjkgkFU2lnchuaRjiy2XvM4CJxZr+acvDTz/lmNVSJTq N1OYTRqNnkr1tm7Y02VT65xtsUHAT8DnYyR8WI0n7UE8fyVqn0SQ== Received: from phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta02.appoci.oracle.com [147.154.114.232]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 44n0fshbjb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 07 Feb 2025 09:28:19 +0000 (GMT) Received: from pps.filterd (phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 5177SVq1023618; Fri, 7 Feb 2025 09:28:19 GMT Received: from nam11-co1-obe.outbound.protection.outlook.com (mail-co1nam11lp2168.outbound.protection.outlook.com [104.47.56.168]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 44j8gmw5xw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 07 Feb 2025 09:28:19 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Hl69Yup57irGDM6n9wf948QJfcHA2E1s9aqgnzj6HoqSHp3+eFErQeG6aMMYmb1blnojl2Ntyk7A3/TqeyXqLr8zZLF/MQK9ey7S76SNQr7XZ3N0EB5UjBzN/pvzTkMVp9zuddY8V2bX8bBgE7z8qxV3IGFN/c/AYCtpev/YYnxweCqhWCXHYAR8QYjfMkG29cxcymnAkFkFu6Qt9n0DhzS/oznV1qN2Yhh2tQP/hMnmSsRD8FYNtUMa6S4oPhKd0wp3DewKAn+/R5gFSc1kV1hFAcxmFCm6almUDRdPyp60+Up73ZcOCUQoI9GQIO8wdsVvL/c1cH6cJzeONWjGzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iphE8HHigEN9f0WR0+i6ZBpGRgcKimbUCjELmRjiTmw=; b=FMg8HAk5rbdVbc5x3mYkvF4EhI/m649Afufi4rCmOAs7Nax5rpseqNubAhhJCWjv4P4DCh2bUDpRcYLKQlO9yxRw2ZrVastmXHip1XB9yg9B1EyBNPFIo5M0n3vv1H9yJcuMSYGvQEwfcOCQzStzndBkybUc/SjXgukq8WUIAoSNwaVmO0s7Dt5zEH35wPrjBjj44HmJ6OImejrnV2s2wuqGGQJnfen2jSDPOTSMINKWNrhAd9nSooCiwwLsF/Yf/RqhIV1JkJMvDTh+kz0+XwxP6HiUj+0etE73qfeEJyc/Yomr/xYBoTGP8Ex2/dNxtEUZR8urATpeyvZvosGbzQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iphE8HHigEN9f0WR0+i6ZBpGRgcKimbUCjELmRjiTmw=; b=SuPhoWknCDfC46SHub+DAsLy0pwRVqVJbKp+0KK+nOPYylIlvjWy0hvsTml/hUo0ZyCOu+mu3dAurmL+hq8csQUh61vWEfonqSiQD/HSPXPO+yxjWXOFuywXNJpUN7yB56xjpKvyREf3DRkG5thBdGftZpjwbz1KUZNxKrGIDOc= Received: from BYAPR10MB3366.namprd10.prod.outlook.com (2603:10b6:a03:14f::25) by CH3PR10MB7458.namprd10.prod.outlook.com (2603:10b6:610:15a::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8422.10; Fri, 7 Feb 2025 09:28:17 +0000 Received: from BYAPR10MB3366.namprd10.prod.outlook.com ([fe80::baf2:dff1:d471:1c9]) by BYAPR10MB3366.namprd10.prod.outlook.com ([fe80::baf2:dff1:d471:1c9%4]) with mapi id 15.20.8398.025; Fri, 7 Feb 2025 09:28:16 +0000 Date: Fri, 7 Feb 2025 09:28:10 +0000 From: Lorenzo Stoakes To: Liu Ye Cc: akpm@linux-foundation.org, Liam.Howlett@oracle.com, vbabka@suse.cz, jannh@google.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/mlock: Fix WARN_ON_ONCE condition. Message-ID: <57fa3641-4166-4a0d-8851-2bddb4a19f1c@lucifer.local> References: <20250207060448.146606-1-liuye@kylinos.cn> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250207060448.146606-1-liuye@kylinos.cn> X-ClientProxiedBy: LO4P123CA0176.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:18a::19) To BYAPR10MB3366.namprd10.prod.outlook.com (2603:10b6:a03:14f::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR10MB3366:EE_|CH3PR10MB7458:EE_ X-MS-Office365-Filtering-Correlation-Id: 137fb330-2e65-4641-f35a-08dd4759c041 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|366016|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?Db/hn3lOSC+8fAqgkdcspPzjxWw2iz+VkCwyYLFuHr9jinqlKkt6DhLmaBZE?= =?us-ascii?Q?PEuBf9orlesyuJSa4ca1wWqxH86zCrOef9aw3MYovBjMUPnoy6YBe+qKoLO5?= =?us-ascii?Q?GrcGv6LjbztHpZ7K+w9KdcMFLLh/lNZLeLKyXFF2njaa+3AdJX9ocmAXIunE?= =?us-ascii?Q?tkhRVL4bnI+vYtK224+zNmR7yWcrd/KqJVgmoXsDJK46R6Ff9+DjGvof75HG?= =?us-ascii?Q?JF/ryE0w2dqUz2ow+5yKYhq7xINnp/fdGxNnrt7oBBXVDJ2dr4gY8c24fxyL?= =?us-ascii?Q?quI7Gaz/ATkkQyH3s28LwRdWx40htbVkSlOFnm/59kbd1jwiTx0og7+q89Xb?= =?us-ascii?Q?AvmBkxWuZMgrA8qTsThfvmUJcZzttRRgqA2bIKJfDDDSuVzEneb63qk1bfUs?= =?us-ascii?Q?M87cn4BN4IcGwqQqjSMDBzBMo/zKGefvf2WcQPrFmsm/3HjvDGrKls52oMej?= =?us-ascii?Q?eDnpNU6RzYR0ok2EJdRXS5ZmsrBPD5OxomE3tk0jS0yQy4VjEV1wVIFFAqap?= =?us-ascii?Q?lLHXaa4lOR9CQi4q4wSSf/W4p8+XgqG/0MTszPsegI5yKUTnt7tHkF8a2LRD?= =?us-ascii?Q?ow46HYBNKvs4gDkHnMYfTfbp3JyuhTaafOL1/BOBekzDqcjPquS6UqwZMMcu?= =?us-ascii?Q?pNDS7FIg3ymtSBBPg9QjEwfDKGqWZrxk6ezFdycQDLIB/UPCCmNpNsbJMnPe?= =?us-ascii?Q?IH2eGspPnIeNZxmNMYAL0E+tR+5isMt1AaHHhLbGRw5U7tuk2AUGyqA5tUKE?= =?us-ascii?Q?SzKcZzzFrsyWpA55EFpyKBsk48bpY9mz8d0nUzeVYe+V19gSw329zPPc06dm?= =?us-ascii?Q?5vILsNETPzhAIc2HG5WJPXadFaIO+xLCPXgg5Cbv7BJZUvRVLneDwLW8YdE6?= =?us-ascii?Q?A2oqR6sHIemPkRIRnx9dbrt2pv0kYs1PMQIs3aZ9bt8XPfiVO0CyEUXcxx6q?= =?us-ascii?Q?gCH4OLmI0ZW9ZlbqNQjBfGq4b5UMtqqbGo62cqaTKKMEER0l8QbgYVV8ANjB?= =?us-ascii?Q?skmGO+VUHWWHmBcEHYnVRDDP5NSIg0gX5ZetOhySUpQPj7l7QhmWD23mnljt?= =?us-ascii?Q?Q8Ilif28DRMgXuqstBKtbiXN/MWGZWwa8lCbrAxDwe9eNy7WUEjCbjAb8y2+?= =?us-ascii?Q?lVaNwvSUp5AlDuzQe3VTnoDuIwGWXfkG4dexpYnRNiH7bTdu0/0Y3KOH/gPw?= =?us-ascii?Q?86M9IDsTMiYRkAkePmIFslrjbm1nMoamjw5yx/dcOhzCamrCkkM1V8Wvk0gh?= =?us-ascii?Q?2xp++9AZ03s5st5LF0tNlitKJn5/9ZOvfGJb7EKQhBLROdDtkL3lr+7lHpf/?= =?us-ascii?Q?ogeaDVLQIpD5r6Qjp9x3wduJI6yBYJI0TfcIzz4nVziVxpmqHvyEk9bcFya2?= =?us-ascii?Q?uMq5F6Ch/u+HmyQHdbFUfFcp0JlW?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR10MB3366.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(376014)(366016)(7053199007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?FIGnDZFjPu6kKnbq8ijTNPAtXv4CwRk1HJg4g2if4fe3f1tTpJOTIsr2AUn6?= =?us-ascii?Q?OaIljDwCyp4TUFMwYDcu2sDR6H5QJKxZ5EomnQs92yrV8ghTaMLXwDvjn6Du?= =?us-ascii?Q?kL/XYtK9FWkHHhA2wJ4KKzSKQRxCFiOOidtMB2YHOQZrUx6ZaOmfbjHNPIbv?= =?us-ascii?Q?Hkg6Y0ynB00zdOwBnT2Fl3V47+R6bpBuwuFlPo8Hf2PdEaG+x7zNXR+OhWE7?= =?us-ascii?Q?S9X7k3XW4V1k50/7vAVcM0dDSt/6SKCTKS9ayWP2tYYetbz/Hoe4G51g5+Jr?= =?us-ascii?Q?4t6m7QMMVkX6gdmjfjB2Pn7c+KomcA1i7ioFc1n4fpSxQ1i43VQFlPdq97Q1?= =?us-ascii?Q?vzQwH6pgZvscls89em4PyVu1ulqyBcaw1Glxa3xSIBnaXPJj7QofwsApBrQf?= =?us-ascii?Q?9BWxrevmR2qG4SxXQYSpJwkkp9viHdtOUEV7Oaw1ZP8+Oz+w9CA4to/Oicn2?= =?us-ascii?Q?0G4chyku7eRlw3CNSSrgph1rjZf10RkhnRIHRWFq2U9Jx5qas01jWahyrjwp?= =?us-ascii?Q?60/A0xoCkNblzicGNjT2B56BaWCSmH/3+VC7E6Zs7h91baX4BWRvrU+2OiIs?= =?us-ascii?Q?dRWMwZqjhiJQzMC2156552Iw63h/hJ0kyVQTWryLxaRDaCtla4cpZleE6y7v?= =?us-ascii?Q?liKbybP+V3mX4pkacCq5fyVMXvUpjGpxjlaDDr19Bb8apPTlav0qPhgItnu/?= =?us-ascii?Q?2S2BDqLFqOt96qbGAeoDSoQkWubWwUjTAvZlNIza47G8pR8KxYwv8pdcGfTK?= =?us-ascii?Q?hGRPt17G3DHd2QhIXOoZBDaS7pyAPGIP8B2k6Uc33YA/LybHXytIY1Cu1H5N?= =?us-ascii?Q?6/J+h58p4spQDPbg1tW5grZge6evTis94+K6kaYmYmESJuw0uZJgtaP1GzEH?= =?us-ascii?Q?s2FNYBiNW8C4Y4xgqIAZ9MQr8/dAa5EPDJrfvNhqSVM+oVpMYq7lA86yln86?= =?us-ascii?Q?+/XxFulALtTjdM6uADTxp8Th0ZUnxyZCJzLEfqCDpIG+zb92nbzTaLHPCyO6?= =?us-ascii?Q?PPM0FnzTD/Y8ZBUluBnlZIGIaYLjppNtXkGQb97iYn2/y6/WieeukL2CjHxD?= =?us-ascii?Q?fwup8ztMG1gDcdFX0DsMDdNI7i7KojDwSmE1tZ0ZjmsGLAbUshHwelxoWiQf?= =?us-ascii?Q?caZb7JmnZwjobCvnoisP6xwEBM0XV8ndTbLqZVSUOvaEijrZRhipN0TxaVR3?= =?us-ascii?Q?V/Knqv3xcqPCVVHeuD8wcBVmLiX/Ckloocmv/PN1ERxRmdhal4yvzobjp1cW?= =?us-ascii?Q?YIiBgTjPEqAPFM7Or36TT1WEFOoCYPIAxbotCdf7KANQRr6IQ3cwnhyoJABk?= =?us-ascii?Q?DrbeDQcZ/3blTnKH87grhM5apRK9/u8eQphK3RPOJglxBDmeBEIrZWJ73Bpx?= =?us-ascii?Q?RVD+ZQb7dIgGaaFCNNMfOaXsVxJJSEpdx226ahyV2d7+YqAWEr/we/X/9nq8?= =?us-ascii?Q?SMKl9ruIR7jwFarlUblsIKTijULT6q26EfNM6EDTgklmqKi0vxs6DLwMz+R+?= =?us-ascii?Q?+32CrzAqDqqIWj4bhU6n0goVrm4RaEMuzTUlOABVdxB+t4PLBRJXqihhxBMx?= =?us-ascii?Q?5sCE0OAAGXljYvNRfIZm29N7FDL2fbVwnsE8hMyZ6zlA0mqEoEK1WcMQ1iVe?= =?us-ascii?Q?5g=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: H5CBS2ikXPE41WoqiTd6Hx/dz1AKufX4F/aFQWYKaXfbwup0Of9vYTlhx7gVB18bANOtJoZImjy/RSXF8fsicyF4c7PhqHO1D7CbX/1sX0XOBb1d01JMj1UBT7Uf+lSLMaqNRO5ft3K31NlbbleXTRAmB/0J4tQYtRegMSlMoOVY24iqKBJMWY2j/aKm3BlMhlUEdt3QvVgotWDmkWvHYI+MPiL8obyg0lbLBoXrdiKnr0sWNwISV7a1WD402LhGID7+1C9b31wWCFvv4Dm/aAfdZt9dNOpa/DdP89dvlmuQdWnbdaS5tUecpgS+fcvgfzFPModG9TlMwyGTSXs68GAA0d0CQsjNgNiVuNtrzfE+oz3hqeAlMn3PQaoJXjwMOCl2KrNOsx7gBzLwkYRDUd4s71VIsYzPOWeiPPojjxCGAjOA4NbPryjcjNdGUSiGd8dIguxe6zR5xHzdSRCjJkziOkGKqIwcWWvpnD42NHT9pHAqh8zMyc1iBUTGG3UJKr8nAzsR+Xp2GcMG0uqigtoUC9FeKegWARPjoVKuOXiBtIEankWDfaX0jlY8hfv3x4vTTb7BqSsc0xNlWyKBfsQTO6ICEx8DNyVpcxn9lfM= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 137fb330-2e65-4641-f35a-08dd4759c041 X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB3366.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Feb 2025 09:28:16.1030 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: QRl3VUdBtEPhV9qbxsFlzqwo28MTNE73EcwFX58HTAHdx46rZXZmB71PD2n8einq1fzTrOEIlYIYoCkEAHJO+qZDnAfADCP9vxsPPELhkNU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR10MB7458 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1057,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-02-07_04,2025-02-07_01,2024-11-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 malwarescore=0 phishscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 suspectscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2501170000 definitions=main-2502070072 X-Proofpoint-ORIG-GUID: 43hSwf2jDbQ3Zh5pJsHA6jSZbY4fomhD X-Proofpoint-GUID: 43hSwf2jDbQ3Zh5pJsHA6jSZbY4fomhD X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 4BC8D40006 X-Stat-Signature: xbdizt5ej9rtdud313n1kwbxe6ghwxzy X-HE-Tag: 1738920504-567538 X-HE-Meta: U2FsdGVkX19Ma2S9oWTKaVhV5d4E+UKV9wmBJTHn7CnywGE0DXTU1TjHlOgqC4Z9zIwfDE07UmJsyW0VZzIm3GTU2WvBXOROCuBPMGSGQWxIDeKRdiHLV01IUdg1oT+xs4/KLNUOSxk4UgPNdPC79Hh+BqegyJWoGQhSC+EnIWvsKdWQDzcgTIkY7yCrKRosUU6nqvCkbIfBGCOo0Vu9LEAVn1tNzGxzuFJ0g5sX5yzOinGmKiTth6WcrABlfwrhBkuqYx18drNiLfv+ztPXHgyzaaYATWsDuo0PHI/GWOCyBoWDgAvEiWNgTvCiYoEcV9L1KOH/WEZTSdcPR5AfeDcSuAHZ3pcX3usYmkYYwnVrWniQm0aRUyAo9ZiovuM9vpcSurTiyoUR3Pd7Lan+DL5GrkKLVY/spZ4HLhyUsC2gXPFiIs48fd7oJs0DYspp7Y8sTWqttQgWQjUSmzuJS5CkhBsTMpTQRzDj7Bpy/QJy7bFmjwpFBH1uyR0fTeZsc4IwGaJ2LPn6Y9L9YMZ+YJQiHiiMXcRPGAlQEhuvLijV/FFrX4Pk2800WfbzvlaYoGEDT+S3qoSB4YRpaOwwtvebjWLfiAgvaZv59Tvv9Ey049+DsoiHmiPJ9RDAieCTdWdChbtTwWx5HdFdYiBkzuPyOT8+yrY3u/SFNx9/baA/s0fVd7XE2WsctOSiCxdNysOVXI81S8fHRQXbWxNY/cx2e673iWbSORmAry7JZp+56CJWwmKIPfzKuoeKGOc200Ah34h0wh/Gq+fgcUEVEj04bxKt+F5SuFPioSg0CFfdrbShlL8YTe1pOZSgQ3vK9F5GwDiltl9dKah1NjZZruZ+0uJPsuy1TAJ5La4UwUi1zVnmfjldgzv0UeYVbSAneipGm2StMpQTLbb7ebwrAgvY4Kq4nwueYlUzi3VlprMKG1TzAshCVjKnUA3FGLWGmRBZCa5Ebb3h35n/4iy rK1HF7tF hOJkLWeHIIcbRf9lQ9puPxdTCvp6Xv3t6kfZ5l7zFxQCI3QcGG+LUPshotkeUM6w2dIKCcylyl0C1NsEdG8cU4RFwjHlNjFZ49+Nq1R6dsOdDZt/m5vSSdLd+qP8fZZXwBSU7vS/KX9+Lk0jBEVyFh6W3Q69l3bvyg30pQOpMxPq4hognXmvgSNrI7gkYKcch/jVcvc1n6/xQ8VzmnDNqfwW5cBQRWjQEIlJNZvyBYen4S8XJnu+66zoVasHp1FmcN7WdDZkYX3Wwgc7PohixjMT/Y9IeF1XXFdTI1jClDBQeX1XWrhWqyI1rzfZ3DjQA82WzeYrKn/Qz4kYTOJ0UxTPPKuE7q22+phzyOtaHlbMsXaRYyqwIuWnROp9ou1cOhUgKiBZ9PMkiEAUNzi92Hx1yApdyElIUb6TnLB3lUk956cjuiugb+y+WvLKM7f7lhZgtXMkWx6QVyGoErhJ8U+nzgmKZ0Uz9hJb/gN/OeS3bueodGq0wfrtJLY74c9VCJ5bw2olksj3nFYI/NhAt8SywllHjpQ1jv4a+1pEy67YtwsaVt6j7BTr8OSuT45VNMIIS96YB1nEQa0/9deHbDwwaHg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000015, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Feb 07, 2025 at 02:04:48PM +0800, Liu Ye wrote: > The condition in WARN_ON_ONCE(cpu_online(cpu)) should be !cpu_online(cpu) > to ensure the warning is triggered when the CPU is offline. > > Signed-off-by: Liu Ye NACK. This is a really odd patch to send, if you were right we'd be seeing constant warnings on this no? And as per Dev, this seems completely wrong? You also MUST provide more justification if you're going to do something as crazy as this. An 'it's wrong because I say it is' isn't acceptable on any level whatsoever. > --- > mm/mlock.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/mlock.c b/mm/mlock.c > index cde076fa7d5e..40acf7897917 100644 > --- a/mm/mlock.c > +++ b/mm/mlock.c > @@ -224,7 +224,7 @@ void mlock_drain_remote(int cpu) > { > struct folio_batch *fbatch; > > - WARN_ON_ONCE(cpu_online(cpu)); > + WARN_ON_ONCE(!cpu_online(cpu)); > fbatch = &per_cpu(mlock_fbatch.fbatch, cpu); > if (folio_batch_count(fbatch)) > mlock_folio_batch(fbatch); > -- > 2.25.1 >