From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26356C10F1A for ; Thu, 9 May 2024 18:20:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9CD1F6B0092; Thu, 9 May 2024 14:20:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 97CFB6B009B; Thu, 9 May 2024 14:20:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 81D0D6B009C; Thu, 9 May 2024 14:20:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 6357A6B0092 for ; Thu, 9 May 2024 14:20:21 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 019FAC1569 for ; Thu, 9 May 2024 18:20:20 +0000 (UTC) X-FDA: 82099672242.04.9A642B0 Received: from madrid.collaboradmins.com (madrid.collaboradmins.com [46.235.227.194]) by imf22.hostedemail.com (Postfix) with ESMTP id 1E715C000D for ; Thu, 9 May 2024 18:20:17 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=collabora.com header.s=mail header.b=Y0vwhbgp; dmarc=pass (policy=quarantine) header.from=collabora.com; spf=pass (imf22.hostedemail.com: domain of usama.anjum@collabora.com designates 46.235.227.194 as permitted sender) smtp.mailfrom=usama.anjum@collabora.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715278818; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3WxD2vUVxTbhr4aewNpRf5wpftmhmSVdH5fPburQYnI=; b=w7rr5sPUHjVB4EzFJ0fk7fEYofsbVIAZ89JwmqUsHkmCoBFFNxp+WDsDpl68cHJe/0D5KC 5SL8yuf3UuPBd1hY2tUlOU3n/gjae8JsyLXvzxER4zGgEGAKPt/WN7QrgyCQaylcGQQIEf Xwbye6bUBDZnwmuvEV6aBc3+Vxn2T+I= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=collabora.com header.s=mail header.b=Y0vwhbgp; dmarc=pass (policy=quarantine) header.from=collabora.com; spf=pass (imf22.hostedemail.com: domain of usama.anjum@collabora.com designates 46.235.227.194 as permitted sender) smtp.mailfrom=usama.anjum@collabora.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715278818; a=rsa-sha256; cv=none; b=RWVySQuh2CqfdZH5Q0IGBFuCIcoje27GMSJ462kdjA/j6VBkeVW1DOg2jhChpqUWTPDW7Y ZRgpAgbKeB+bHcRfcAM5kpOIkJ/QfxbkRQiveCyb9rTKPJUwBL04twD/6rd1EaIAEhearQ BXaFcFYZXqvLhHiofP9oGyh8adjMQ+c= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1715278815; bh=JCJaK6QpOrmmUJdi/1h2/P/m5VnuJoQJ8ijlBJBZs2E=; h=Date:Cc:Subject:To:References:From:In-Reply-To:From; b=Y0vwhbgpxSGiErJBlZANaCoV14K1sUaA4F/ooMPA8bO48t72Fpno5DrnfALIMJiFY oMSvCEfOkwdTnfzldtNTgWgnNeYnX0lnmSBwYV+uUcXI50biIzPUgTSdbJDAk9h9/N bVUTOACTMW2U5cMSjfFt9b0R/BiIAN1Kzg0OIMCCtoqr8O1bj2D1Led/rtVGtGTVC8 kz3S35qqjR2mswHsIzoVynyPqK+vGV6uTv4IAVR+VARRqE/hZwUo8M6kQ1/zzNJO7N IQqLkWeZKdjhwuxngilpfTAlT58QqNdElQbuZGDixBXFgx76yRt8hchoMtP4P0BWps 4uG5Wxt7oOVIg== Received: from [100.113.15.66] (ec2-34-240-57-77.eu-west-1.compute.amazonaws.com [34.240.57.77]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: usama.anjum) by madrid.collaboradmins.com (Postfix) with ESMTPSA id 3ED82378214F; Thu, 9 May 2024 18:19:55 +0000 (UTC) Message-ID: <57f47bc1-972c-45b5-81ef-d8269dcadebb@collabora.com> Date: Thu, 9 May 2024 23:20:19 +0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: Muhammad Usama Anjum , shuah@kernel.org, Mark Brown , Jaroslav Kysela , Takashi Iwai , Catalin Marinas , Will Deacon , Nhat Pham , Johannes Weiner , Christian Brauner , Eric Biederman , Kees Cook , OGAWA Hirofumi , Thomas Gleixner , Ingo Molnar , Peter Zijlstra , Darren Hart , Davidlohr Bueso , =?UTF-8?Q?Andr=C3=A9_Almeida?= , Jiri Kosina , Benjamin Tissoires , Jason Gunthorpe , Kevin Tian , Andy Lutomirski , Will Drewry , Marc Zyngier , Oliver Upton , James Morse , Suzuki K Poulose , Zenghui Yu , Paolo Bonzini , Sean Christopherson , Anup Patel , Atish Patra , Paul Walmsley , Palmer Dabbelt , Albert Ou , Christian Borntraeger , Janosch Frank , Claudio Imbrenda , David Hildenbrand , =?UTF-8?Q?Micka=C3=ABl_Sala=C3=BCn?= , Paul Moore , James Morris , "Serge E. Hallyn" , Andrew Morton , Seth Forshee , Bongsu Jeon , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Steffen Klassert , Herbert Xu , =?UTF-8?Q?Andreas_F=C3=A4rber?= , Manivannan Sadhasivam , Matthieu Baerts , Mat Martineau , Geliang Tang , Willem de Bruijn , Fenghua Yu , Reinette Chatre , Mathieu Desnoyers , "Paul E. McKenney" , Boqun Feng , Alexandre Belloni , Jarkko Sakkinen , Dave Hansen , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, kernel-team@android.com, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, linux-input@vger.kernel.org, iommu@lists.linux.dev, kvmarm@lists.linux.dev, kvm@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-security-module@vger.kernel.org, linux-fsdevel@vger.kernel.org, netdev@vger.kernel.org, linux-actions@lists.infradead.org, mptcp@lists.linux.dev, linux-rtc@vger.kernel.org, linux-sgx@vger.kernel.org, bpf@vger.kernel.org Subject: Re: [PATCH v2 0/5] Define _GNU_SOURCE for sources using To: Edward Liaw , Shuah Khan References: <20240507214254.2787305-1-edliaw@google.com> <946ae22f-a4af-448a-92e1-60afb6ed9261@linuxfoundation.org> Content-Language: en-US From: Muhammad Usama Anjum In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 1E715C000D X-Stat-Signature: 1njfxz8rqkhtn7erncicnqi7js7bdtwq X-HE-Tag: 1715278817-648728 X-HE-Meta: U2FsdGVkX187s0kL2902BGekGbKJu+tNr6NripeivG90blibkZPtnPOTd6sy8ir+cRacBUFe42eyN0ll+M8k6AQtYdXiaCJHUeRkCNmDQE6yUQShZEwk8083SKfEtwStFCwwwuwY+TLz/4i4YIPeBx1Nx6VM7w4/g6GkeUsnYo5CNjM+9y3I2N9tNYZ5akI2CUqtXXXQsfZuw51WWqu3jP73lXjOf7XcATi0PWN0XCzx+ENgpu9x17JS4z4idWlZcDJLsQZ7hL35kjYlbYVnTeVgVG6ffysFigOX99kuxFfJpxteNkO98Waqg5rnHVC89iiZw4jrPS353scmsK6LnVFzdmOCREFEmcTj/Sz9g6tah3MIFdwibTqLXfo7qYBN52DWdpK4mhiPPsTPRPN7zzs2xtlHwH3ICY8f0yXl7JsaNw/1ygFP3d/C9ao6xCfsorryQM5V1l9OBb7/X8Nr5X3jfPHl4LfPiS2FdBRTygjPgPn9TMoS3NyTFVqzV89kujK5/esbeelSAVuboQ6lU/SFlHOGaY5AnU4WE3gvU8hcRc0Q7fMTGf+9k25d32RTsBU1VhNy6bzwnL6CzjJCwSvyYAGd/hnywCr/2WTD5t1I9t/enlRMjjvtysPM+UNpRTIYlqeQXgaGyHes9j39ZBHubKUS59QtppqtdIugaXZqUK+UjhlRv0CIEUtabrjuoJ6LdlI3IrrHU8GARv06MVm6Z7CO9xNHySPFqmFhGnBE2kSCxlFRqrmmoxf5hJIX016nR5n4rifdwWwyENQ0uRCCCfR/Ej55pkoprB01Zmn9N8LMqW0t37XrM8OskUfNA3lGEqcqzCtFTlN/SFiKsKdEzXGc+AddsYBhOtr80Qe7WT5rKqm4cbNamMNeHke+CNC13tw+xRCY982hT0mFv0JrE3DrfnJtD7aoav39Eryrpr36Bwv7rZkVLazKlEoojr2+g8nR/7tdd/+oO6K uq/sPDgM MhLCGnXxO+8FRjL9iiFrc5NGsJmNO9NXfDeX6wwCa7Fiw5Qkfavsb5YDTz0Xsso0Ocg0p+ZytYXN2l32T9fgdTawxohImSftA/2RpZ4jrAcPjzGwrcFP5o7AV9ZzQNtkYxvUvxSKlITeApfNVYtyTsA2EET/Gz2qe9v8ONSFbKPpwvwD9gSYNnHFks5Nhh7/XbrF5USQP3NEGgp8PQGKVfmNrGr41eWZwd/AS8hU7wl2Z9PFs+2y7t+HeF01UfA5W3dQybDklguR/BJ87UUAncoDi7/UGw1WLujeWaXXgPELDzEDgKGkiKV8AoHqr6Sg3W+OY+VwVnr4rlqr0Cihjlz2E+J2eZS8Tyv1eDa91GEEiWvtFZM5UxVLO4fuz8qTVbJszdWbhGs0nqPn2s51WS/SoYP23j/02GcEU3pXnOr7AMC18vRhBxNS2Zv+wuDmY5r7yU1wcwuSfqX3LTEvh+WWpHmHnadztfOxi0J/PO3T5KPB7L/peF9g/bnfA6uHw8X6B0oipF4mivPWGAqeURZZxLb6LTKHgK+No8RAIoYtWyy+kvAxvpUuKq56w2Dqk3SsXJm6Oq4mrFY/0HKajsMd/TF7F6WolBYx9Kr8pyQopvVI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 5/9/24 10:45 PM, Edward Liaw wrote: > On Thu, May 9, 2024 at 7:37 AM Shuah Khan wrote: >> >> On 5/9/24 00:13, Edward Liaw wrote: >>> On Wed, May 8, 2024 at 4:10 PM Shuah Khan wrote: >>>> >>>> On 5/7/24 15:38, Edward Liaw wrote: >>>>> 809216233555 ("selftests/harness: remove use of LINE_MAX") introduced >>>>> asprintf into kselftest_harness.h, which is a GNU extension and needs >>>>> _GNU_SOURCE to either be defined prior to including headers or with the >>>>> -D_GNU_SOURCE flag passed to the compiler. >>>>> >>>>> v1: https://lore.kernel.org/linux-kselftest/20240430235057.1351993-1-edliaw@google.com/ >>>>> v2: add -D_GNU_SOURCE to KHDR_INCLUDES so that it is in a single >>>>> location. Remove #define _GNU_SOURCE from source code to resolve >>>>> redefinition warnings. >>>>> >>>>> Edward Liaw (5): >>>>> selftests: Compile kselftest headers with -D_GNU_SOURCE >>>>> selftests/sgx: Include KHDR_INCLUDES in Makefile >>>> >>>> I appled patches 1/5 and 2.5 - The rest need to be split up. >>>> >>>>> selftests: Include KHDR_INCLUDES in Makefile >>>>> selftests: Drop define _GNU_SOURCE >>>>> selftests: Drop duplicate -D_GNU_SOURCE >>>>> >>>> >>>> Please split these patches pwe test directory. Otherwise it will >>>> cause merge conflicts which can be hard to resolve. >>> >>> Hi Shuah, >>> Sean asked that I rebase the patches on linux-next, and I will need to >>> remove additional _GNU_SOURCE defines. Should I send an unsplit v3 to >>> be reviewed, then split it afterwards? I'm concerned that it will be >>> difficult to review with ~70 patches once split. >> >> Please send them split - it will be easier to review and apply. You >> might as well wait until the merge window is done. I don't think >> anybody would have time to review now since merge window starts >> next week. > > Sorry, I have them split already; is it ok if I send them now? I will > be on leave soon and may not be able to get back to it in a while. Feel free to send the patches. There is no restriction on that. > > Thanks, > Edward > >> >> >> thanks, >> -- Shuah > -- BR, Muhammad Usama Anjum