From: David Hildenbrand <david@redhat.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: "Jason A. Donenfeld" <Jason@zx2c4.com>,
linux-kernel@vger.kernel.org, patches@lists.linux.dev,
tglx@linutronix.de, linux-crypto@vger.kernel.org,
linux-api@vger.kernel.org, x86@kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Adhemerval Zanella Netto <adhemerval.zanella@linaro.org>,
Carlos O'Donell <carlos@redhat.com>,
Florian Weimer <fweimer@redhat.com>,
Arnd Bergmann <arnd@arndb.de>, Jann Horn <jannh@google.com>,
Christian Brauner <brauner@kernel.org>,
David Hildenbrand <dhildenb@redhat.com>,
linux-mm@kvack.org
Subject: Re: [PATCH v22 1/4] mm: add MAP_DROPPABLE for designating always lazily freeable mappings
Date: Thu, 11 Jul 2024 21:22:00 +0200 [thread overview]
Message-ID: <57efaa1f-e9b6-41e8-96d5-aea5bc102bb4@redhat.com> (raw)
In-Reply-To: <CAHk-=wjVc6cpSCJwAqrhPvwBbcQEOL2TEnCELfadhA=n1GN4Ww@mail.gmail.com>
On 11.07.24 21:17, Linus Torvalds wrote:
> On Thu, 11 Jul 2024 at 12:08, David Hildenbrand <david@redhat.com> wrote:
>>
>> We also have these folio_mark_dirty() calls, for example in
>> unpin_user_pages_dirty_lock(). Hm ... so preventing the folio from
>> getting dirtied is likely shaky.
>
> I do wonder if we should just disallow page pinning for these pages
> entirely. When the page can get replaced by zeroes at any time,
> pinning it doesn't make much sense.
>
> Except we do have that whole "fast" case that intentionally doesn't
> take locks and doesn't have a vma. Darn.
Yeah, and I think it should all be simpler; we shouldn't have to
special-case these cases everywhere.
Maybe we can just find a way to not do *folio_set_swapbacked() without a
VMA.
--
Cheers,
David / dhildenb
next prev parent reply other threads:[~2024-07-11 19:22 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240709130513.98102-1-Jason@zx2c4.com>
2024-07-09 13:05 ` Jason A. Donenfeld
2024-07-10 3:27 ` David Hildenbrand
2024-07-10 4:05 ` David Hildenbrand
2024-07-11 0:44 ` Jason A. Donenfeld
2024-07-11 4:32 ` Jason A. Donenfeld
2024-07-11 4:46 ` David Hildenbrand
2024-07-11 5:07 ` Linus Torvalds
2024-07-11 17:09 ` Jason A. Donenfeld
2024-07-11 17:17 ` Jason A. Donenfeld
2024-07-11 17:24 ` David Hildenbrand
2024-07-11 17:27 ` David Hildenbrand
2024-07-11 17:54 ` Jason A. Donenfeld
2024-07-11 17:56 ` Jason A. Donenfeld
2024-07-11 18:08 ` Jason A. Donenfeld
2024-07-11 18:24 ` David Hildenbrand
2024-07-11 18:54 ` Jason A. Donenfeld
2024-07-11 18:56 ` David Hildenbrand
2024-07-11 19:18 ` David Hildenbrand
2024-07-11 19:20 ` David Hildenbrand
2024-07-11 19:49 ` Yu Zhao
2024-07-11 19:52 ` Yu Zhao
2024-07-11 19:53 ` David Hildenbrand
2024-07-11 19:58 ` Yu Zhao
2024-07-11 20:59 ` David Hildenbrand
2024-07-11 20:20 ` Jason A. Donenfeld
2024-07-11 20:59 ` David Hildenbrand
2024-07-11 17:49 ` Jason A. Donenfeld
2024-07-11 17:57 ` Linus Torvalds
2024-07-11 19:07 ` David Hildenbrand
2024-07-11 19:17 ` Linus Torvalds
2024-07-11 19:22 ` David Hildenbrand [this message]
2024-07-11 20:07 ` Jason A. Donenfeld
2024-07-11 20:17 ` Jason A. Donenfeld
2024-07-11 22:29 ` David Hildenbrand
2024-07-12 1:21 ` Jason A. Donenfeld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57efaa1f-e9b6-41e8-96d5-aea5bc102bb4@redhat.com \
--to=david@redhat.com \
--cc=Jason@zx2c4.com \
--cc=adhemerval.zanella@linaro.org \
--cc=arnd@arndb.de \
--cc=brauner@kernel.org \
--cc=carlos@redhat.com \
--cc=dhildenb@redhat.com \
--cc=fweimer@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=jannh@google.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=patches@lists.linux.dev \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox